subject:"D17154\: Go back to SCSS"

D17154: Go back to SCSS

2019-01-14 Thread Christophe Giboudeaux

cgiboudeaux added a comment.


  In D17154#392806 , @davidedmundson 
wrote:
  
  > > Are there any strong reasons?
  >
  > It's not installed, so a user can't use it.
  >
  > That means it's only a build tool. As it's a build tool it's very important 
to not get stuff from the host system as it makes things less reproducible.
  
  
  at the very least, it should use XDG_DATA_HOME by default and 
${HOME}/.local/share as a fallback 
(https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-14 Thread David Edmundson

davidedmundson added a comment.


  > Are there any strong reasons?
  
  It's not installed, so a user can't use it.
  
  That means it's only a build tool. As it's a build tool it's very important 
to not get stuff from the host system as it makes things less reproducible.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-14 Thread Luca Beltrame

lbeltrame added a comment.


  In D17154#391812 , @gepardo wrote:
  
  > Are there any strong reasons?
  
  
  Not everyone has their XDG paths set in ~/.local, even more so when doing 
development.
  
  In addition, I had a look at the script. While I do stuff in Python for a 
living (and for many years) I could not figure out what was the purpose of the 
classes, the functions, and the last part of the generation of the theme is a 
bunch of calls without much context. In short, this needs to be documented, and 
clearly, otherwise it'll be treated as a magic black box and the moment 
something breaks, no one will know how to fix it.
  
  Yes, I'm to blame because I didn't look at it sooner.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-12 Thread Alexander Kernozhitsky

gepardo added a comment.


  > I would also scrap all the stuff about ~/.local
  
  Are there any strong reasons?
  
  Reasons for not removing `~/.local` are the following. KDE still doesn't have 
custom color schemes support for Breeze-GTK. But `build-theme.sh` allows to 
rebuild the theme with custom color scheme and by default install it into 
`~/.local/share/themes`. As you can see, it can read the colors from kdeglobals 
and color schemes (local and system-wide). (BTW that's how I'm using the theme: 
I just run `build_theme.sh` when changing color scheme)
  
  I do agree that's a temporary hack there should be a user-friendly way to 
change the colors. But I think there no reason to remove this stuff now.
  
  Maybe this way to rebuild the theme can be mentioned in README also.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-12 Thread David Edmundson

davidedmundson added inline comments.

INLINE COMMENTS

> build_theme.sh:89-98
> +COLOR_SCHEME="/usr/share/color-schemes/Breeze.colors"
> +  fi
> +else
> +  THEME_NAME="${COLOR_SCHEME}"
> +  if [ -f "/usr/share/color-schemes/${COLOR_SCHEME}.colors" ]; then
> +COLOR_SCHEME="/usr/share/color-schemes/${COLOR_SCHEME}.colors"
> +  elif [ -f "${HOME}/.local/share/color-schemes/${COLOR_SCHEME}.colors" ]; 
> then

We can't assume '/usr/share'/
Nor can we use the install prefix for where this is installed as that breaks 
distro packaging.

Breeze needs to export this location in it's installed .cmake file, then we 
should reference that.

I would also scrap all the stuff about ~/.local.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-11 Thread Luca Beltrame

lbeltrame added a comment.


  
https://invent.kde.org/sysadmin/ci-tooling/commit/d3443ccf5b0233f4fd0b19c93d8332046b616f58
 adds the PyCairo dependency to the CI, although the build system must still 
check for it (as it doesn't now).

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-11 Thread Luca Beltrame

lbeltrame added a comment.


  In D17154#391718 , @lbeltrame 
wrote:
  
  >
  
  
  
  
  > - It requires the Breeze style to be installed to load the color schemes 
but the dependency isn't checked anywhere
  
  This should be hopefully fixed by 
https://commits.kde.org/breeze-gtk/92978bb2a243fdca5f58fa231b425bbe1802b231

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-11 Thread Luca Beltrame

lbeltrame added a comment.


  In D17154#391718 , @lbeltrame 
wrote:
  
  >
  
  
  
  
  > - There are decoding errors in the Python script because it doesn't take 
into account translations
  
  Fixed in 
https://commits.kde.org/breeze-gtk/cf5f675799a35687dd1fd4a13a4b80a860b71935.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-11 Thread Luca Beltrame

lbeltrame added a comment.


  There are several issues with this patch, which cause build failures:
  
  - It requires PyCairo (python3-cairo in openSUSE) but the dependency isn't 
checked anywhere
  - It requires the Breeze style to be installed to load the color schemes but 
the dependency isn't checked anywhere
  - There are decoding errors in the Python script because it doesn't take into 
account translations
  
  As shown by the falures in the CI.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-11 Thread David Edmundson

davidedmundson closed this revision.
davidedmundson added a comment.


  Merged.
  
  This didn't close because we had to disable the commit hooks.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-08 Thread Nathaniel Graham

ngraham added a comment.


  Awesome, thanks a lot David!

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-08 Thread David Edmundson

davidedmundson added a comment.


  I've git filter-branch'd Alex's github branch so the root commit's now match 
ours.
  
  Then merged that into master.
  History graph still looks like quite a  mess, but then that's a reflection of 
reality :)
  
  -
  
  I'll wait a day for some other git people to comment, then will push it.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-08 Thread Nathaniel Graham

ngraham added a comment.


  Hmm, so what's our path forward here? What's the best way to merge this while 
preserving some semblance of history and state?

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-08 Thread David Edmundson

davidedmundson accepted this revision.
davidedmundson added a comment.


  We should try to see how we can merge this properly
  
  Effectively it's a revert - and there's relevant tracking in the github 
history here. I'd rather not just have a massive patch that changes everything.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-08 Thread Nathaniel Graham

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This has been working fine in my testing. I haven't noticed any overt 
regressions. Technically it looks fine to me too now. It would be nice to get 
some more testing from others before shipping it though--especially people who 
use a lot of GTK apps.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-01 Thread Nathaniel Graham

ngraham added a comment.


  Thanks, much better now! Will resume testing the actual user interface now.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2019-01-01 Thread Alexander Kernozhitsky

gepardo updated this revision to Diff 48474.
gepardo added a comment.


  Prevent the theme from rebuilding each time

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48462=48474

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/CMakeLists.txt
  Breeze-dark-gtk/assets/arrow-down-active.png
  Breeze-dark-gtk/assets/arrow-down-hover.png
  Breeze-dark-gtk/assets/arrow-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-down.png
  Breeze-dark-gtk/assets/arrow-left-active.png
  Breeze-dark-gtk/assets/arrow-left-hover.png
  Breeze-dark-gtk/assets/arrow-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-left.png
  Breeze-dark-gtk/assets/arrow-right-active.png
  Breeze-dark-gtk/assets/arrow-right-hover.png
  Breeze-dark-gtk/assets/arrow-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-right.png
  Breeze-dark-gtk/assets/arrow-small-down-active.png
  Breeze-dark-gtk/assets/arrow-small-down-hover.png
  Breeze-dark-gtk/assets/arrow-small-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-down.png
  Breeze-dark-gtk/assets/arrow-small-left-active.png
  Breeze-dark-gtk/assets/arrow-small-left-hover.png
  Breeze-dark-gtk/assets/arrow-small-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-left.png
  Breeze-dark-gtk/assets/arrow-small-right-active.png
  Breeze-dark-gtk/assets/arrow-small-right-hover.png
  Breeze-dark-gtk/assets/arrow-small-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-right.png
  Breeze-dark-gtk/assets/arrow-small-up-active.png
  Breeze-dark-gtk/assets/arrow-small-up-hover.png
  Breeze-dark-gtk/assets/arrow-small-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-up.png
  Breeze-dark-gtk/assets/arrow-up-active.png
  Breeze-dark-gtk/assets/arrow-up-hover.png
  Breeze-dark-gtk/assets/arrow-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-up.png
  Breeze-dark-gtk/assets/button-active.png
  Breeze-dark-gtk/assets/button-hover.png
  Breeze-dark-gtk/assets/button-insensitive.png
  Breeze-dark-gtk/assets/button.png
  Breeze-dark-gtk/assets/check-checked-active.png
  Breeze-dark-gtk/assets/check-checked-act...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop.png
  Breeze-dark-gtk/assets/check-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-checked-hover.png
  Breeze-dark-gtk/assets/check-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-checked-insensitive.png
  Breeze-dark-gtk/assets/check-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-active.png
  Breeze-dark-gtk/assets/check-mixed-act...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop.png
  Breeze-dark-gtk/assets/check-mixed-backd...@2.png
  Breeze-dark-gtk/assets/check-mixed-hover.png
  Breeze-dark-gtk/assets/check-mixed-ho...@2.png
  Breeze-dark-gtk/assets/check-mixed-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  
Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked.png
  Breeze-dark-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-dark-gtk/assets/check-unchecked-active.png
  Breeze-dark-gtk/assets/check-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-unchecked-backdrop-insensit...@2.png

D17154: Go back to SCSS

2018-12-31 Thread Bhushan Shah

bshah edited subscribers, added: bshah; removed: Sysadmin.
bshah added a comment.


  (removing sysadmin from subscribers)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, #sysadmin

D17154: Go back to SCSS

2018-12-31 Thread Nathaniel Graham

ngraham added a comment.


  No worries! CMake can be a bit challenging. :)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-31 Thread Alexander Kernozhitsky

gepardo added a comment.


  In D17154#384519 , @ngraham wrote:
  
  > The `install` target is installing to `./Breeze` and `./Breeze-Dark` in 
addition to the `CMAKE_INSTALL_PREFIX` location, which messes up the 
permissions in your source checkout if you do an in-source build and run `sudo 
make install`.
  
  
  Got it. The issue is more compilcated, though. `Breeze` and `Breeze-Dark` 
directories are created during the build. They are not real targets currently, 
so are build each time (even during the install). So, when installed as root, 
they are modified. I will think of how to fix this issue.
  
  Sorry for these issues with the building process, I'm not familar with it 
much. But at least I hope there're no such issues with the theme itself.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-31 Thread Nathaniel Graham

ngraham added a comment.


  The `install` target is installing to `./Breeze` and `./Breeze-Dark` in 
addition to the `CMAKE_INSTALL_PREFIX` location, which messes up the 
permissions in your source checkout if you do an in-source build and run `sudo 
make install`.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-31 Thread Alexander Kernozhitsky

gepardo updated this revision to Diff 48462.
gepardo added a comment.


  CMake fixes:
  
  - Compatibility with older versions
  - Add docs and copyright into FindSass.cmake

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48224=48462

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/CMakeLists.txt
  Breeze-dark-gtk/assets/arrow-down-active.png
  Breeze-dark-gtk/assets/arrow-down-hover.png
  Breeze-dark-gtk/assets/arrow-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-down.png
  Breeze-dark-gtk/assets/arrow-left-active.png
  Breeze-dark-gtk/assets/arrow-left-hover.png
  Breeze-dark-gtk/assets/arrow-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-left.png
  Breeze-dark-gtk/assets/arrow-right-active.png
  Breeze-dark-gtk/assets/arrow-right-hover.png
  Breeze-dark-gtk/assets/arrow-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-right.png
  Breeze-dark-gtk/assets/arrow-small-down-active.png
  Breeze-dark-gtk/assets/arrow-small-down-hover.png
  Breeze-dark-gtk/assets/arrow-small-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-down.png
  Breeze-dark-gtk/assets/arrow-small-left-active.png
  Breeze-dark-gtk/assets/arrow-small-left-hover.png
  Breeze-dark-gtk/assets/arrow-small-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-left.png
  Breeze-dark-gtk/assets/arrow-small-right-active.png
  Breeze-dark-gtk/assets/arrow-small-right-hover.png
  Breeze-dark-gtk/assets/arrow-small-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-right.png
  Breeze-dark-gtk/assets/arrow-small-up-active.png
  Breeze-dark-gtk/assets/arrow-small-up-hover.png
  Breeze-dark-gtk/assets/arrow-small-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-up.png
  Breeze-dark-gtk/assets/arrow-up-active.png
  Breeze-dark-gtk/assets/arrow-up-hover.png
  Breeze-dark-gtk/assets/arrow-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-up.png
  Breeze-dark-gtk/assets/button-active.png
  Breeze-dark-gtk/assets/button-hover.png
  Breeze-dark-gtk/assets/button-insensitive.png
  Breeze-dark-gtk/assets/button.png
  Breeze-dark-gtk/assets/check-checked-active.png
  Breeze-dark-gtk/assets/check-checked-act...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop.png
  Breeze-dark-gtk/assets/check-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-checked-hover.png
  Breeze-dark-gtk/assets/check-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-checked-insensitive.png
  Breeze-dark-gtk/assets/check-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-active.png
  Breeze-dark-gtk/assets/check-mixed-act...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop.png
  Breeze-dark-gtk/assets/check-mixed-backd...@2.png
  Breeze-dark-gtk/assets/check-mixed-hover.png
  Breeze-dark-gtk/assets/check-mixed-ho...@2.png
  Breeze-dark-gtk/assets/check-mixed-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  
Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked.png
  Breeze-dark-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-dark-gtk/assets/check-unchecked-active.png
  Breeze-dark-gtk/assets/check-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-unchecked-backdrop-insensitive.png

D17154: Go back to SCSS

2018-12-31 Thread Alexander Kernozhitsky

gepardo added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in FindSass.cmake:1
> Missing doc & license

Which one should I choose? Is BSD 3-clause, that is used by //Extra CMake 
modules//, OK?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-31 Thread Christophe Giboudeaux

cgiboudeaux added inline comments.

INLINE COMMENTS

> CMakeLists.txt:14
>  
> -include(KDEInstallDirs)
> +if(${CMAKE_VERSION} GREATER_EQUAL 3.12.0)
> +find_package(Python3 COMPONENTS Interpreter REQUIRED)

This doesn't exist in CMake 2.8.12. Use

  if(NOT CMAKE_VERSION VERSION_LESS 3.12.0)

or invert the if/else to avoid the 'NOT'

> FindSass.cmake:1
> +set_package_properties(Sass PROPERTIES
> +  DESCRIPTION "SASS compiler"

Missing doc & license

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-29 Thread Nathaniel Graham

ngraham added a comment.


  FWIW I've applied this and have been using it in my day-to-day, and so far I 
haven't found any problems.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: davidedmundson, bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D17154: Go back to SCSS

2018-12-29 Thread David Edmundson

davidedmundson added a comment.


  > As a base, I used this repository: https://github.com/dirruk1/gnome-breeze
  
  Dirruk is also the author who moved this repo from SCSS to having all the 
assets, especially annoyingly that commit has no description on why.  Would be 
good if we hear from him. Generated CSS certainly seems sensible.
  
  > Hello, is there any progress on the review?
  
  There's a lot to review, practically every commit since June 2016 :/
  I went through 6 at random and they all seemed correct which is very 
encouraging.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: davidedmundson, bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D17154: Go back to SCSS

2018-12-28 Thread Nathaniel Graham

ngraham added a comment.


  It's on my to-do list, but please have some patience. :) Most people are 
probably still out for their winter holiday vacations.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-28 Thread Alexander Kernozhitsky

gepardo added a comment.


  Hello, is there any progress on the review?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-26 Thread Nathaniel Graham

ngraham added a comment.


  There we go, much better! Thanks for all the work on this. Now we can move on 
to the next part of the review. :)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-26 Thread Alexander Kernozhitsky

gepardo updated this revision to Diff 48224.
gepardo added a comment.


  Remove compiled themes from the sources; now the building process doesn't 
modify the sources at all

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48223=48224

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/CMakeLists.txt
  Breeze-dark-gtk/assets/arrow-down-active.png
  Breeze-dark-gtk/assets/arrow-down-hover.png
  Breeze-dark-gtk/assets/arrow-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-down.png
  Breeze-dark-gtk/assets/arrow-left-active.png
  Breeze-dark-gtk/assets/arrow-left-hover.png
  Breeze-dark-gtk/assets/arrow-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-left.png
  Breeze-dark-gtk/assets/arrow-right-active.png
  Breeze-dark-gtk/assets/arrow-right-hover.png
  Breeze-dark-gtk/assets/arrow-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-right.png
  Breeze-dark-gtk/assets/arrow-small-down-active.png
  Breeze-dark-gtk/assets/arrow-small-down-hover.png
  Breeze-dark-gtk/assets/arrow-small-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-down.png
  Breeze-dark-gtk/assets/arrow-small-left-active.png
  Breeze-dark-gtk/assets/arrow-small-left-hover.png
  Breeze-dark-gtk/assets/arrow-small-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-left.png
  Breeze-dark-gtk/assets/arrow-small-right-active.png
  Breeze-dark-gtk/assets/arrow-small-right-hover.png
  Breeze-dark-gtk/assets/arrow-small-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-right.png
  Breeze-dark-gtk/assets/arrow-small-up-active.png
  Breeze-dark-gtk/assets/arrow-small-up-hover.png
  Breeze-dark-gtk/assets/arrow-small-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-up.png
  Breeze-dark-gtk/assets/arrow-up-active.png
  Breeze-dark-gtk/assets/arrow-up-hover.png
  Breeze-dark-gtk/assets/arrow-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-up.png
  Breeze-dark-gtk/assets/button-active.png
  Breeze-dark-gtk/assets/button-hover.png
  Breeze-dark-gtk/assets/button-insensitive.png
  Breeze-dark-gtk/assets/button.png
  Breeze-dark-gtk/assets/check-checked-active.png
  Breeze-dark-gtk/assets/check-checked-act...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop.png
  Breeze-dark-gtk/assets/check-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-checked-hover.png
  Breeze-dark-gtk/assets/check-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-checked-insensitive.png
  Breeze-dark-gtk/assets/check-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-active.png
  Breeze-dark-gtk/assets/check-mixed-act...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop.png
  Breeze-dark-gtk/assets/check-mixed-backd...@2.png
  Breeze-dark-gtk/assets/check-mixed-hover.png
  Breeze-dark-gtk/assets/check-mixed-ho...@2.png
  Breeze-dark-gtk/assets/check-mixed-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  
Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked.png
  Breeze-dark-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-dark-gtk/assets/check-unchecked-active.png
  Breeze-dark-gtk/assets/check-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-unchecked-backdrop-insensitive.png

D17154: Go back to SCSS

2018-12-26 Thread Alexander Kernozhitsky

gepardo added a comment.


  > But files in the source repo are still overwritten during the build process 
if you do an in-source build.
  
  `Breeze-gtk` and `Breeze-dark-gtk` are ovewritten regardless of whether an 
in-source build in used or not. I'm going to fix it now by removing compiled 
files from the repo (located in `Breeze-gtk` and `Breeze-dark-gtk`)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-26 Thread Nathaniel Graham

ngraham added a comment.


  Thanks, I can verify that the race condition is fixed so parallel building 
now works! But files in the source repo are still overwritten during the build 
process if you do an in-source build. If this is not easily resolvable, you 
could just disallow in-source builds in the CMake file (see Kirigami repo for 
an example of how).

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-26 Thread Alexander Kernozhitsky

gepardo updated this revision to Diff 48223.
gepardo added a comment.


  Summary of changes done:
  
  - Fix race condition during the build
  - Prevent the build process from writing into the source directory
  - Style fixes in build_theme.sh
  - Improve parameter parsing in build_theme.sh
  - Remove gtkrc, at it is autogenerated anyway
  - Pycodestyle fixes

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48156=48223

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png

D17154: Go back to SCSS

2018-12-26 Thread Alexander Kernozhitsky

gepardo added a comment.

  In D17154#382450 , @ngraham wrote:

  > Also, overwriting sources is a no-no. :/
  >
  > If this is a pre-existing bug, perhaps we should fix it in another patch 
though.

  What does it mean? Should I create a new Phabricator revision or so?

  This bug did exist in the repo I took as a base 
(https://github.com/dirruk1/gnome-breeze). The scripts from there overwrote the 
sources.

  Now I am almost ready with fixing this issue. This involves changing Python 
script a liitle to make it write `gtk2rc` and `global.scss` into custom 
locations.

  > Also, overwriting sources is a no-no. :/

  So, I think, it's even better to remove `Breeze-gtk` and `Breeze-dark-gtk` 
directories from the sources (because they are regenerated each time). Is it OK?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-26 Thread Nathaniel Graham

ngraham added a comment.


  Also, overwriting sources is a no-no. :/
  
  If this is a pre-existing bug, perhaps we should fix it in another patch 
though.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-26 Thread Alexander Kernozhitsky

gepardo added a comment.


  It seems to be the issue with parallel Make. The original scripts often 
overwrite sources, so they can't be built in parallel. I'll try to fix it to 
resolve the race conditions.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-26 Thread Nathaniel Graham

ngraham added a comment.


  Hmm, now `make` fails:
  
~/repos/breeze-gtk$  (arcpatch-D17154) make -j2
Scanning dependencies of target gtkbreeze5.5
[ 50%] Building CXX object 
kconf_update/CMakeFiles/gtkbreeze5.5.dir/main.cpp.o
/usr/lib/ruby/vendor_ruby/sass/util.rb:1109: warning: constant ::Fixnum is 
deprecated
[100%] Linking CXX executable gtkbreeze5.5
[100%] Built target gtkbreeze5.5
/usr/lib/ruby/vendor_ruby/sass/util.rb:1109: warning: constant ::Fixnum is 
deprecated
/usr/lib/ruby/vendor_ruby/sass/util.rb:1109: warning: constant ::Fixnum is 
deprecated
[100%] Built target Breeze-gtk
/usr/lib/ruby/vendor_ruby/sass/util.rb:1109: warning: constant ::Fixnum is 
deprecated
mv: cannot stat 'assets': No such file or directory
src/CMakeFiles/Breeze-dark-gtk.dir/build.make:57: recipe for target 
'src/CMakeFiles/Breeze-dark-gtk' failed
make[2]: *** [src/CMakeFiles/Breeze-dark-gtk] Error 1
CMakeFiles/Makefile2:215: recipe for target 
'src/CMakeFiles/Breeze-dark-gtk.dir/all' failed
make[1]: *** [src/CMakeFiles/Breeze-dark-gtk.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-24 Thread Ben Cooksley

bcooksley added a comment.


  Thanks @ngraham. I've now scheduled the addition of `scss` into the images 
with 63d16727883e9c9f9d09bdd2bc7163fb386c0a57 


REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-24 Thread Alexander Kernozhitsky

gepardo updated this revision to Diff 48156.
gepardo added a comment.


  Add gtk-dark.css support for Breeze

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48153=48156

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop.png
  Breeze-gtk/assets/radio-unchecked-backd...@2.png
  Breeze-gtk/assets/radio-unchecked-insensitive.png
  Breeze-gtk/assets/radio-unchecked-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked.png
  Breeze-gtk/assets/radio-unchec...@2.png

D17154: Go back to SCSS

2018-12-24 Thread Alexander Kernozhitsky

gepardo updated this revision to Diff 48153.
gepardo added a comment.


  Fix GTK+ 3.18 theme installation

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48148=48153

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop.png
  Breeze-gtk/assets/radio-unchecked-backd...@2.png
  Breeze-gtk/assets/radio-unchecked-insensitive.png
  Breeze-gtk/assets/radio-unchecked-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked.png
  Breeze-gtk/assets/radio-unchec...@2.png

D17154: Go back to SCSS

2018-12-24 Thread Alexander Kernozhitsky

gepardo added a comment.


  Oops, sorry, I forgot to check the installation.
  
  GTK+ 3.18 did built, but it was built into `gtk-3.0` directory (the build 
scripts in the old repo seem to do so). But `CMakeLists.txt` remained unchanged.
  
  I noticed that recent versions install `gtk-3.18` and `gtk-3.20` dirs, so 
I'll change the build scripts to have `gtk-3.18` as a target directory.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-24 Thread Nathaniel Graham

ngraham added a subscriber: Sysadmin.
ngraham added a comment.


  Thanks much better. Now it can find Python 3 with CMake version < 3.12, and 
Sass is a required dependency. I believe #sysadmin 
 has asked to be notified of all new 
required dependendies, so adding I'm subscribing them.
  
  Now we're close, but the install target doesn't complete successfully:
  
dev@dev-pc:~/repos/breeze-gtk$  (arcpatch-D17154) sudo make install
[100%] Built target gtkbreeze5.5
/usr/lib/ruby/vendor_ruby/sass/util.rb:1109: warning: constant ::Fixnum is 
deprecated

[...]

-- Installing: 
/usr/share/themes/Breeze-Dark/assets/check-selectionmode-checked-backdrop-insensit...@2.png
-- Installing: /usr/share/themes/Breeze-Dark/assets/check-mixed-ho...@2.png
-- Installing: /usr/share/themes/Breeze-Dark/assets/togglebutton-hover.png
CMake Error at Breeze-dark-gtk/cmake_install.cmake:73 (file):
  file INSTALL cannot find
  "/home/dev/repos/breeze-gtk/Breeze-dark-gtk/gtk-3.18".
Call Stack (most recent call first):
  cmake_install.cmake:42 (include)


Makefile:73: recipe for target 'install' failed
make: *** [install] Error 1
  
  Here's the contents of that folder:
  
dev@dev-pc:~/repos/breeze-gtk$  (arcpatch-D17154) ls 
/home/dev/repos/breeze-gtk/Breeze-dark-gtk/
assets  cmake_install.cmake  gtk-2.0  gtk-3.20
CMakeFiles  CMakeLists.txt   gtk-3.0  Makefile
  
  Looks like GTK 3.18 didn't get built?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-24 Thread Alexander Kernozhitsky

gepardo updated this revision to Diff 48148.
gepardo marked an inline comment as done.
gepardo added a comment.


  Fix finding Python package for CMake <3.12

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48145=48148

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.0/gtk.css
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop.png
  Breeze-gtk/assets/radio-unchecked-backd...@2.png
  Breeze-gtk/assets/radio-unchecked-insensitive.png
  Breeze-gtk/assets/radio-unchecked-insensit...@2.png

D17154: Go back to SCSS

2018-12-24 Thread Alexander Kernozhitsky

gepardo marked 2 inline comments as done.
gepardo added inline comments.

INLINE COMMENTS

> ngraham wrote in CMakeLists.txt:13
> This doesn't seem like the correct way to require Python 3:
> 
>   dev@dev-pc:~/repos/breeze-gtk$  (arcpatch-D17154) cmake 
> -DCMAKE_INSTALL_PREFIX=/usr
>   -- Could NOT find Sass (missing: Sass_EXECUTABLE) 
>   CMake Error at CMakeLists.txt:13 (find_package):
> By not providing "FindPython3.cmake" in CMAKE_MODULE_PATH this project has
> asked CMake to find a package configuration file provided by "Python3", 
> but
> CMake did not find one.
>   
> Could not find a package configuration file provided by "Python3" with any
> of the following names:
>   
>   Python3Config.cmake
>   python3-config.cmake
>   
> Add the installation prefix of "Python3" to CMAKE_PREFIX_PATH or set
> "Python3_DIR" to a directory containing one of the above files.  If
> "Python3" provides a separate development package or SDK, be sure it has
> been installed.
>   
>   
>   -- Configuring incomplete, errors occurred!
>   See also "/home/dev/repos/breeze-gtk/CMakeFiles/CMakeOutput.log".

Using find_package(Python3) worked for me. But I understood the reason why it 
may fail.

It seems that find_package(Python3) appeared only in CMake 3.12, while 
find_package(PythonInterp) was used earlier (now it's deprecated). So, I'll add 
a conditional for older and current CMake.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-24 Thread Alexander Kernozhitsky

gepardo updated this revision to Diff 48145.
gepardo added a comment.


  Make Sass a required dependency

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48031=48145

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.0/gtk.css
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop.png
  Breeze-gtk/assets/radio-unchecked-backd...@2.png
  Breeze-gtk/assets/radio-unchecked-insensitive.png
  Breeze-gtk/assets/radio-unchecked-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked.png

D17154: Go back to SCSS

2018-12-24 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> CMakeLists.txt:12
>  find_package(GTKEngine)
> +find_package(Sass)
> +find_package(Python3 REQUIRED)

Shouldn't this be required since you can't build the theme without it?

> CMakeLists.txt:13
> +find_package(Sass)
> +find_package(Python3 REQUIRED)
>  

This doesn't seem like the correct way to require Python 3:

  dev@dev-pc:~/repos/breeze-gtk$  (arcpatch-D17154) cmake 
-DCMAKE_INSTALL_PREFIX=/usr
  -- Could NOT find Sass (missing: Sass_EXECUTABLE) 
  CMake Error at CMakeLists.txt:13 (find_package):
By not providing "FindPython3.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "Python3", but
CMake did not find one.
  
Could not find a package configuration file provided by "Python3" with any
of the following names:
  
  Python3Config.cmake
  python3-config.cmake
  
Add the installation prefix of "Python3" to CMAKE_PREFIX_PATH or set
"Python3_DIR" to a directory containing one of the above files.  If
"Python3" provides a separate development package or SDK, be sure it has
been installed.
  
  
  -- Configuring incomplete, errors occurred!
  See also "/home/dev/repos/breeze-gtk/CMakeFiles/CMakeOutput.log".

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-22 Thread Alexander Kernozhitsky

gepardo updated this revision to Diff 48031.
gepardo added a comment.


  More imrovements:
  
  - remove gtk-3.18 as it's not rebuilt. The theme is still usable under GTK+ 
3.18 (files are actually located in gtk-3.0)
  - add python as a dependency in CMakeLists.txt

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48030=48031

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.0/gtk.css
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop.png

D17154: Go back to SCSS

2018-12-22 Thread Alexander Kernozhitsky

gepardo updated this revision to Diff 48030.
gepardo added a comment.


  Use CMake for building themes
  
  The following changes are made:
  
  - cmake/FindSass.cmake is now used to detect SASS compiler presence
  - build scripts are invoked from cmake, so everythings builds using simple 
cmake && make

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=46195=48030

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.0/gtk.css
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop.png
  Breeze-gtk/assets/check-unchecked-backd...@2.png
  Breeze-gtk/assets/check-unchecked-insensitive.png
  Breeze-gtk/assets/check-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-unchecked.png
  Breeze-gtk/assets/check-unchec...@2.png
  Breeze-gtk/assets/combo-entry-button-insensitive.png
  Breeze-gtk/assets/combo-entry-button.png
  Breeze-gtk/assets/combo-entry-insensitive.png
  Breeze-gtk/assets/combo-entry.png
  Breeze-gtk/assets/entry-insensitive.png
  Breeze-gtk/assets/entry.png
  Breeze-gtk/assets/frame-gap-end.png
  Breeze-gtk/assets/frame-gap-start.png
  Breeze-gtk/assets/frame.png
  Breeze-gtk/assets/line-h.png
  Breeze-gtk/assets/line-v.png
  Breeze-gtk/assets/menu-arrow-insensitive.png
  Breeze-gtk/assets/menu-arrow-selected.png
  Breeze-gtk/assets/menu-arrow.png
  Breeze-gtk/assets/notebook-frame-bottom.png
  Breeze-gtk/assets/notebook-frame-right.png
  Breeze-gtk/assets/notebook-frame-top.png
  Breeze-gtk/assets/progressbar-trough.png
  Breeze-gtk/assets/radio-checked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-checked-backdrop.png
  Breeze-gtk/assets/radio-checked-backd...@2.png
  Breeze-gtk/assets/radio-checked-insensitive.png
  Breeze-gtk/assets/radio-checked-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/radio-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-mixed-backdrop.png
  Breeze-gtk/assets/radio-mixed-backd...@2.png
  Breeze-gtk/assets/radio-mixed-insensitive.png
  Breeze-gtk/assets/radio-mixed-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/radio-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/radio-unchecked-backdrop.png

D17154: Go back to SCSS

2018-12-22 Thread Alexander Kernozhitsky

gepardo added a comment.


  In D17154#380574 , @ngraham wrote:
  
  > On that subject, rebuilding the theme should be done as a part of the 
default build target when running `make` rather than requiring the use of a 
script. It's a requirement that all the work gets done simply by running 
`make`. This will require a few CMake adjustment too.
  
  
  I had an even better idea: to run these lines directly from CMakeLists.txt, 
so it will be integrated with building process as good as possible.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-21 Thread Nathaniel Graham

ngraham added a reviewer: VDG.
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  @gepardo I'm very sorry that you haven't gotten any real feedback on this 
yet. :( The maintainer seems to have vanished. I will CC come more people and 
have a go at reviewing it myself.
  
  One thing that's definitely going to need to change is that if since you've 
added build dependencies, this needs to be reflected in `CMakeLists.txt`, 
because right now, running your `rebuild_theme.sh` simply doesn't work without 
the new dependency:
  
$  (arcpatch-D17154) ./rebuild-theme.sh
./build_theme.sh: 18: ./build_theme.sh: sass: not found
./build_theme.sh: 18: ./build_theme.sh: sass: not found
./build_theme.sh: 18: ./build_theme.sh: sass: not found
./build_theme.sh: 18: ./build_theme.sh: sass: not found
  
  On that subject, rebuilding the theme should be done as a part of the default 
build target when running `make` rather than requiring the use of a script. 
It's a requirement that all the work gets done simply by running `make`. This 
will require a few CMake adjustment too.
  
  Can you make these changes?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-09 Thread Alexander Kernozhitsky

gepardo added a comment.


  This patch is not reviewed for two weeks. How soon can I get some feedback on 
it?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze
Cc: ngraham, jackg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-11-25 Thread Nathaniel Graham

ngraham added subscribers: jackg, ngraham.
ngraham added reviewers: Plasma, jackg, Breeze.
ngraham added a comment.


  @jackg, if you're around, I'd really appreciate your perspective on this 
patch. I'm not sure about the history regarding why we moved away from this 
approach, whether or not it's proved to be a mistake, and if this is the right 
way to move back.
  
  More generally, if anyone else knows the history here, please speak up.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze
Cc: ngraham, jackg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-11-25 Thread Alexander Kernozhitsky

gepardo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gepardo requested review of this revision.

REVISION SUMMARY
  As it was explained in https://phabricator.kde.org/D16365,
  
  > Further potential steps in the same direction of saving code would be going 
back to SASS
  
  This patch tries to go back to SCSS sources with backporting all the fixes 
made in Breeze-gtk recently. As a base, I used this repository: 
https://github.com/dirruk1/gnome-breeze. But it's outdated, so I walked through 
the commit history of breeze-gtk and ported all the changes here. The script 
for building the theme was ported to Python3, and shell scripts now use POSIX 
sh instead of bash. Also I fixed some inconsistences between Qt and GTK Breeze 
themes. For example, Breeze-Qt colorscheme was updated a little (in Plasma 
5.12, as far as I remember), but the GTK theme was updated only partially; now 
the colors are synchronized. Both GTK-3.18 and GTK-3.20 versions work fine for 
me; many things were also fixed for GTK 3.18.
  
  For building the theme, ruby-sass (or more lightweght sassc) is required. 
Also the theme can be patched to allow changing the colorscheme in System 
Settings (though, rebuilding the theme with sassc is required for this). The 
original repository (https://github.com/dirruk1/gnome-breeze) had also 
named-colors branch that allowed using named colors and changing the 
colorscheme without rebuilding; but I couldn't get this working.
  
  Because both Breeze-gtk and Breese-dark-gtk are now built from sources, there 
will be no more inconsistences between them. Rebuilding these themes can be 
done using rebuild-theme.sh.

TEST PLAN
  I do not know how to test this automatically. But I am using this version of 
Breeze-GTK for several months (I am not using many GTK+ applications, though). 
Also checked it on gtk3-widget-factory; it seems to work fine.
  
  GTK2 version was tested on Gimp, but it is mostly unchanged.
  
  For differences between https://github.com/dirruk1/gnome-breeze and this 
version, you can see my GitHub repo where I worked on this patch: 
https://github.com/alex65536/gnome-breeze/tree/breeze-gtk-merge.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/default
  Breeze-dark-gtk/gtk-2.0/widgets/scrollbar
  Breeze-dark-gtk/gtk-3.0/gtk.css
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/assets/arrow-down-insensitive.png
  Breeze-gtk/assets/arrow-down.png
  Breeze-gtk/assets/arrow-left-insensitive.png
  Breeze-gtk/assets/arrow-left.png
  Breeze-gtk/assets/arrow-right-insensitive.png
  Breeze-gtk/assets/arrow-right.png
  Breeze-gtk/assets/arrow-small-down-insensitive.png
  Breeze-gtk/assets/arrow-small-down.png
  Breeze-gtk/assets/arrow-small-left-insensitive.png
  Breeze-gtk/assets/arrow-small-left.png
  Breeze-gtk/assets/arrow-small-right-insensitive.png
  Breeze-gtk/assets/arrow-small-right.png
  Breeze-gtk/assets/arrow-small-up-insensitive.png
  Breeze-gtk/assets/arrow-small-up.png
  Breeze-gtk/assets/arrow-up-insensitive.png
  Breeze-gtk/assets/arrow-up.png
  Breeze-gtk/assets/button-insensitive.png
  Breeze-gtk/assets/button.png
  Breeze-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-checked-backdrop.png
  Breeze-gtk/assets/check-checked-backd...@2.png
  Breeze-gtk/assets/check-checked-insensitive.png
  Breeze-gtk/assets/check-checked-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-mixed-backdrop.png
  Breeze-gtk/assets/check-mixed-backd...@2.png
  Breeze-gtk/assets/check-mixed-insensitive.png
  Breeze-gtk/assets/check-mixed-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-gtk/assets/check-selectionmode-unchecked.png
  Breeze-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-gtk/assets/check-unchecked-backdrop-insensitive.png

53 matches

Mail list logo