D23378: Check if sddm user exists

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:85055a98133e: Check if sddm user exists (authored by 
filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23378?vs=66544=67326

REVISION DETAIL
  https://phabricator.kde.org/D23378

AFFECTED FILES
  sddmauthhelper.cpp
  src/advancedconfig.cpp

To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf added a comment.


  Gonna land this in 24hrs if there are no objections.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf added a comment.


  @davidedmundson is this okay now?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf updated this revision to Diff 66544.
filipf added a comment.


  Address David's comment, remove one entry from the map

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23378?vs=65000=66544

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

AFFECTED FILES
  sddmauthhelper.cpp
  src/advancedconfig.cpp

To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  On second look, given that each one does actually do slightly different 
things, I rescind my request. Since this contains no new translated strings, 
let's land it on the 5.17 branch.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf added a comment.


  In D23378#517611 , @ngraham wrote:
  
  > How about refactoring this "does SDDM user exist?" check into a function so 
we don't have to write virtually the same code three times?
  
  
  I would need help with this. If someone can speed things up feel free to 
commandeer the revision.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf updated this revision to Diff 65000.
filipf added a comment.


  Rebase on master

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23378?vs=64429=65000

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

AFFECTED FILES
  sddmauthhelper.cpp
  src/advancedconfig.cpp

To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> sddmauthhelper.cpp:80
>  // create SDDM config directory if it does not exist
>  QDir 
> sddmConfigLocation(args[QStringLiteral("sddmUserConfig")].toString());
>  if (!sddmConfigLocation.exists()) {

can we use sddmHomeDirPath + "whatever"

instead now

and get rid of this sddmUserConfig map entry

> sddmauthhelper.cpp:172
> +
>  QDir 
> sddmConfigLocation(args[QStringLiteral("sddmUserConfig")].toString());
>  QDir fontconfigDir(args[QStringLiteral("sddmUserConfig")].toString() + 
> QStringLiteral("/fontconfig"));

and here

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Nathaniel Graham]

ngraham added a comment.


  How about refactoring this "does SDDM user exist?" check into a function so 
we don't have to write virtually the same code three times?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf updated this revision to Diff 64429.
filipf added a comment.


  add qDebug info in auth helper

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23378?vs=64428=64429

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

AFFECTED FILES
  sddmauthhelper.cpp
  src/advanceconfig.cpp

To: filipf, #plasma, davidedmundson, ngraham, #vdg
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf updated this revision to Diff 64428.
filipf edited the summary of this revision.
filipf added a comment.


  also apply the check for the auth helper

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23378?vs=64425=64428

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

AFFECTED FILES
  sddmauthhelper.cpp
  src/advanceconfig.cpp

To: filipf, #plasma, davidedmundson, ngraham, #vdg
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[David Edmundson]

davidedmundson added a comment.


  Whilst client checks are nice, for the reason you're changing it this should 
(also?) be in the authhelper.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Sddm-kcm should depend on sddm.
  Sddm sets up an sddm user which is used to run the greeter.
  Therefore it should not be possible to run sddm-kcm without an sddm user 
existing.
  
  But if it should happen that's the case, this patch adds a check for the sddm 
user.
  If the user is not present, everything will be aborted and an error message 
will pop-up.
  
  openSUSE BUG: https://bugzilla.opensuse.org/show_bug.cgi?id=1146817, 
https://bugzilla.opensuse.org/show_bug.cgi?id=1146831

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

AFFECTED FILES
  src/advanceconfig.cpp

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart