D25281: [GTK3] Improve legibility of Firefox CSD colours

[Nathaniel Graham]

ngraham added a comment.


  In D25281#561861 , @broulik wrote:
  
  > >   However Once we implement the Breeze color scheme changes
  >
  > How is that related? If i keep using a dark title bar I will still have 
that issue. Merely changing the colorscheme doesn't fix the underlying bug?
  
  
  No, but it makes it less severe with the default color scheme. In fact, it 
makes Firefox the Thunderbird look quite good imo. :)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D25281

To: cblack, #vdg, #breeze
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25281: [GTK3] Improve legibility of Firefox CSD colours

[Kai Uwe Broulik]

broulik added a comment.


  >   However Once we implement the Breeze color scheme changes
  
  How is that related? If i keep using a dark title bar I will still have that 
issue. Merely changing the colorscheme doesn't fix the underlying bug?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D25281

To: cblack, #vdg, #breeze
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25281: [GTK3] Improve legibility of Firefox CSD colours

[Nathaniel Graham]

ngraham added a comment.


  This suffers from the same problem as the earlier version in that the SSD 
versions of the apps look like this: F7759573: Screenshot_20191112_153033.png 

  
  This is a problem with the current state of the Breeze color scheme because 
of heavy the titlebar color looks when applied to the rest of the tools area 
underneath it. However Once we implement the Breeze color scheme changes to 
support  T10201 , these apps will in fact 
automatically look like how we want!
  
  So I won't formally object, but I think we should delay landing the changes 
until T10201  is done for other apps.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D25281

To: cblack, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25281: [GTK3] Improve legibility of Firefox CSD colours

[Carson Black]

cblack created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This fixes the CSD colors of Firefox to be more legible, but not without some 
caveats due to upstream issues.
  
  - The inactive titlebar foreground color is used regardless of window state.
  - #MozillaGtkWidget does not have any visible way to discriminate between CSD 
on and CSD off unlike normal GTK windows, so any style changes apply to both.
  
  BUG: 407639

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  firefox-csd-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25281

AFFECTED FILES
  src/gtk3/applications/_firefox.scss

To: cblack
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart