D26001: Fix rubberband selection outline position

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:80650e0e873d: Fix rubberband selection outline position 
(authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26001?vs=71547=71548

REVISION DETAIL
  https://phabricator.kde.org/D26001

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D26001: Fix rubberband selection outline position

[Noah Davis]

ndavis updated this revision to Diff 71547.
ndavis added a comment.


  fix code style

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26001?vs=71546=71547

BRANCH
  fix-rubberband (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26001

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D26001: Fix rubberband selection outline position

[Noah Davis]

ndavis updated this revision to Diff 71546.
ndavis edited the test plan for this revision.
ndavis added a comment.


  Remove opacity change

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26001?vs=71545=71546

BRANCH
  fix-rubberband (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26001

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D26001: Fix rubberband selection outline position

[Noah Davis]

ndavis added a comment.


  In D26001#577830 , 
@hpereiradacosta wrote:
  
  > I would avoid changing the alpha of the color though because: it makes no 
difference, and it is unrelated to the issue. Should be a different commit 
(which you can do without review if you really think it is important)
  
  
  It's not important, it's just nice if I can move it slightly up to an easy to 
express percentage (19.60784313725490% vs 20%)

REPOSITORY
  R31 Breeze

BRANCH
  fix-rubberband (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26001

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D26001: Fix rubberband selection outline position

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Fix is legit. Thanks ! 
  I would avoid changing the alpha of the color though because: it makes no 
difference, and it is unrelated to the issue. Should be a different commit 
(which you can do without review if you really think it is important)
  
  Fix it then ship it !

REPOSITORY
  R31 Breeze

BRANCH
  fix-rubberband (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26001

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D26001: Fix rubberband selection outline position

[Noah Davis]

ndavis added a reviewer: broulik.
ndavis added a comment.


  @broulik Does this fix the problem for you?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26001

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D26001: Fix rubberband selection outline position

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze, Plasma, hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Before this patch, the outline of the rubberband selection control was down 
and to the right half a pixel too far.
  This wasn't visible at 1x scaling because of the lack of antialiasing, but 
resulted in the top/left being too thin and bottom/right being too thick on 
high DPI displays.
  To fix the issue, I enabled antialiasing and moved all sides inwards by half 
a pixel so that the outline would be pixel perfect.
  I also added a function to get a QRectF with the correct size and position 
for rectangles with pen strokes.

TEST PLAN
  - Open dolphin and make a selection with the mouse
  - Go to a Folder View Plasma widget and make a selection with the mouse

REPOSITORY
  R31 Breeze

BRANCH
  fix-rubberband (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26001

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart