D26238: Improve context menu

2019-12-27 Thread Tranter Madi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R878:fe5dbf9f2b96: Improve context menu (authored by trmdi).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72253=72255

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/layouts/manager.h
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  app/shortcuts/globalshortcuts.cpp
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  plasmoid/package/contents/ui/ContextMenu.qml

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Michail Vourlakos 
mvourlakos added a comment.


  In D26238#583563 , @trmdi wrote:
  
  > In D26238#583556 , @mvourlakos 
wrote:
  >
  > > In D26238#583555 , @trmdi 
wrote:
  > >
  > > > In D26238#583551 , 
@mvourlakos wrote:
  > > >
  > > > > @trmdi I used Cuttlefish app, it points to **"edit"**
  > > >
  > > >
  > > > Maybe it's `document-edit`.
  > > >  (See this: 
https://api.kde.org/frameworks/plasma-framework/html/containment_8cpp_source.html#l00127)
  > >
  > >
  > > Correct
  >
  >
  > Could I land it now?
  
  
  Of course

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Tranter Madi 
trmdi added a comment.


  In D26238#583556 , @mvourlakos 
wrote:
  
  > In D26238#583555 , @trmdi wrote:
  >
  > > In D26238#583551 , @mvourlakos 
wrote:
  > >
  > > > @trmdi I used Cuttlefish app, it points to **"edit"**
  > >
  > >
  > > Maybe it's `document-edit`.
  > >  (See this: 
https://api.kde.org/frameworks/plasma-framework/html/containment_8cpp_source.html#l00127)
  >
  >
  > Correct
  
  
  Could I land it now?

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Tranter Madi 
trmdi updated this revision to Diff 72253.
trmdi added a comment.


  - Change icon of the configure action

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72246=72253

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/layouts/manager.h
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  app/shortcuts/globalshortcuts.cpp
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  plasmoid/package/contents/ui/ContextMenu.qml

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Michail Vourlakos 
mvourlakos added a comment.


  In D26238#583555 , @trmdi wrote:
  
  > In D26238#583551 , @mvourlakos 
wrote:
  >
  > > @trmdi I used Cuttlefish app, it points to **"edit"**
  >
  >
  > Maybe it's `document-edit`.
  >  (See this: 
https://api.kde.org/frameworks/plasma-framework/html/containment_8cpp_source.html#l00127)
  
  
  Correct

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Tranter Madi 
trmdi added a comment.


  In D26238#583551 , @mvourlakos 
wrote:
  
  > @trmdi I used Cuttlefish app, it points to **"edit"**
  
  
  Maybe it's `document-edit`.
  (See this: 
https://api.kde.org/frameworks/plasma-framework/html/containment_8cpp_source.html#l00127)

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Michail Vourlakos 
mvourlakos added a comment.


  @trmdi I used Cuttlefish app, it points to **"edit"**

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Michail Vourlakos 
mvourlakos added a subscriber: ngraham.
mvourlakos added a comment.


  In D26238#583529 , @trmdi wrote:
  
  > In D26238#583386 , @ndavis wrote:
  >
  > > This seems inconsistent with the Plasma panel context menu: F7844566: 
Screenshot_20191227_000605.png 
  >
  >
  > Do you know what icon is used for the "Edit Panel" item in this screenshot?
  
  
  @ngraham do you know which icon this is it?

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Tranter Madi 
trmdi added a comment.


  In D26238#583386 , @ndavis wrote:
  
  > This seems inconsistent with the Plasma panel context menu: F7844566: 
Screenshot_20191227_000605.png 
  
  
  Do you know what icon is used for the "Edit Panel" item in this screenshot?

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Michail Vourlakos 
mvourlakos accepted this revision.
mvourlakos added a comment.
This revision is now accepted and ready to land.


  looks ok...
  
  I am not that fond of the second line separator but we can discuss this again 
in the future.

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Tranter Madi 
trmdi added a comment.


  In D26238#583520 , @mvourlakos 
wrote:
  
  > look ok! Can you please provide also the three screenshots mentioned 
earlier for reference?
  
  
  Done.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Michail Vourlakos 
mvourlakos added a comment.


  look ok! Can you please provide also the three screenshots mentioned earlier 
for reference?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Tranter Madi 
trmdi updated this revision to Diff 72246.
trmdi added a comment.


  - Typo

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72244=72246

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/layouts/manager.h
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  app/shortcuts/globalshortcuts.cpp
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  plasmoid/package/contents/ui/ContextMenu.qml

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Michail Vourlakos 
mvourlakos added inline comments.

INLINE COMMENTS

> manager.h:114
>  void hideLatteSettingsDialog();
> -Q_INVOKABLE void showLatteSettingsDialog(int page = 
> Latte::Types::LayoutPage);
> +Q_INVOKABLE void showLatteSettingsDialog(int firstPage = 
> Latte::Types::LayoutPage, bool toogleCurrentPage = false);
>  

please fix type "**toggleCurrentPage**"

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Tranter Madi 
trmdi updated this revision to Diff 72244.
trmdi added a comment.


  - Call toggleCurrentPage() only when using the shortcut

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72238=72244

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/layouts/manager.h
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  app/shortcuts/globalshortcuts.cpp
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  plasmoid/package/contents/ui/ContextMenu.qml

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Michail Vourlakos 
mvourlakos added a comment.


  @trmdi based on your last commit:
  
  1. you have made all showLatteSettingsDialog callers as togglers, meaning 
that : IF Latte Layouts manager is already shown and the user tries 
Layouts->Manage Layouts then the settings tab will switch to Latte Preferences 
window, is that the behavior you want?
  
  If I understood correctly then I think we want the following:
  
a. menu -> Layouts->Manage Layouts = ALWAYS shows the Layouts tab
b. menu -> Configure Latte... = ALWAYS shows there Preferences tab
c. clicking the Latte trademark in Dock config window = ALWAYS shows there 
Preferences tab
d. using [Meta+W]  = Toggles between Layouts and Preferences tab
  
  2. Please provide also three screenshots from this commit changes: a. context 
menu of applets b. context menu of a task that has one window shown c. context 
menu of Latte Tasks plasmoid when used on the desktop

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Tranter Madi 
trmdi updated this revision to Diff 72238.
trmdi added a comment.


  - Address comments

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72228=72238

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/layouts/manager.h
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  plasmoid/package/contents/ui/ContextMenu.qml

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-27 Thread Michail Vourlakos 
mvourlakos added inline comments.

INLINE COMMENTS

> manager.cpp:419
>  
>  void Manager::showLatteSettingsDialog(int page)
>  {

We could try to rename the function to:

  void Manager::showLatteSettingsDialog(int firstPage, bool cycleBetweenPages = 
false)

when cycleBetweenPages = true then the current behavior is applied, in any 
other case the specified firstPage is shown

> settingsdialog.cpp:365
>  
> -void SettingsDialog::toggleCurrentPage()
> +void SettingsDialog::toggleCurrentPage(int page)
>  {

leave this function untouched and introduce a new function called,

  setCurrentPage(int page)

> settingsdialog.h:58
>  
> -void toggleCurrentPage();
> +void toggleCurrentPage(int page);
>  

leave this function untouched and introduce a new function called,

setCurrentPage(int page)

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-26 Thread Michail Vourlakos 
mvourlakos added a comment.


  In D26238#583413 , @trmdi wrote:
  
  > 1. It still works for other cases.
  
  
  Do you cycle in settings tabs with Meta+W, between Layouts and Preferences ?
  
  > 3. "Configure Application" sounds a bit unclearly.  And it can confuse 
users with "Configure Application Dashboard". "Configure Latte Global 
Settings..." is too long?
  
  it is too long... I can accept suggestions for [Verb+Noun] cases
  
  In D26238#583414 , @trmdi wrote:
  
  > 4. I want to separate between **View's items** (Add widget, Edit View) and 
**Latte's items** (Layouts, Configure Latte) because they are two different 
groups (one is the global setting, one is the view setting) (See the After 
screenshot)
  
  
  I wont object for now, but I will conclude if I will keep the second 
separator after using the program with the changes for some days. The order of 
the actions must be the one referenced though.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-26 Thread Tranter Madi 
trmdi added a comment.


  4. I want to separate between **View's items** (Add widget, Edit View) and 
**Latte's items** (Layouts, Configure Latte) because they are two different 
groups.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-26 Thread Tranter Madi 
trmdi added a comment.


  1. It still works for other cases.
  
  3. "Configure Application" sounds a bit unclearly.  And it can confuse users 
with "Configure Application Dashboard".
  
  "Configure Latte Global Settings..." is too long?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-26 Thread Michail Vourlakos 
mvourlakos added a comment.


  the [Verb+Noun] sounds logical, updated names in my last comment

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-26 Thread Michail Vourlakos 
mvourlakos added a comment.


  This commit needs to be split in different commits.
  Based on the approach I wil describe the issues of the commit and in what 
changes I can approve or not.
  
  SPLITTED COMMITS
  
  1. The showLatteSettingsDialog() is used from more places and you have 
changed its behavior. The page that
  
  this function takes is used as the first page to show when the window is 
created, after that it toggles between
  tabs. This is used ALSO from [Meta+W] global shortcut and Latte trademark 
icon in Dock Settings in order to show
  the Latte Global Preferences. From my understanding you need to create a new 
function that is not a toggler but
  rather sets specific settings tab all the time
  
  2. The context menu changes MUST be the same in TWO different places, because 
otherwise showing context menu will be different between tasks and applets.
  
  
  
a. containmentactions/contextmenu/menu.cpp
b. plasmoid/package/contents/ui/ContextMenu.qml
  
  3. Renames
  
  
  
a. Layouts->Configure TO Layouts->Manage...
b. Dock Settings -> Edit Dock... 
c. Latte Global Settings... -> Application Settings
  
  4. Order:
  
  
  
a.  -separator-
b. Layouts->
c. Application Settings...
d. Add Widgets...
e. Edit Dock...
f.  -separator- [only for Tasks plasmoid]
g.  Close... [only for Tasks plasmoid]

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-26 Thread Tranter Madi 
trmdi updated this revision to Diff 72228.
trmdi added a comment.


  - Add a new separator and change addWidget's icon

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72227=72228

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-26 Thread Noah Davis 
ndavis added a comment.


  In D26238#583390 , @trmdi wrote:
  
  > In D26238#583389 , @ndavis wrote:
  >
  > > In the plasma panel context menu, add widgets and edit panel are below 
the separator
  >
  >
  > Maybe I need to create a new separator at the line 126 instead of reusing 
it. Is it ok if there are 2 separators in a context menu?
  
  
  Sounds reasonable, although I'm not sure they're unrelated enough that they 
need a separator. I'll leave it up to your judgement.
  
  > What about the other changes?
  
  They look fine.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-26 Thread Tranter Madi 
trmdi added a comment.


  In D26238#583389 , @ndavis wrote:
  
  > In the plasma panel context menu, add widgets and edit panel are below the 
separator
  
  
  Maybe I need to create a new separator at the line 126 instead of reusing it.
  What about the other changes?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-26 Thread Noah Davis 
ndavis added a comment.


  In the plasma panel context menu, add widgets and edit panel are below the 
separator

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-26 Thread Noah Davis 
ndavis added a comment.


  This seems inconsistent with the Plasma panel context menu: F7844566: 
Screenshot_20191227_000605.png 

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

2019-12-26 Thread Tranter Madi 
trmdi created this revision.
trmdi added reviewers: Latte Dock, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Merge branch 'master' of https://anongit.kde.org/latte-dock

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h

To: trmdi, #latte_dock, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart