D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo added a comment.


  before
  F8106544: Screenshot_20200216_100603.png 

  after
  F8106545: Screenshot_20200216_102852.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a35d2b9adf40: [Applet/Task Manager] Move audio indicator 
to the corner (authored by gvgeo, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26861?vs=74298=75571

REVISION DETAIL
  https://phabricator.kde.org/D26861

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Nathaniel Graham]

ngraham added a comment.


  Landing on master to be safe, but if Plasma people take a look later and like 
what they see, we can backport this to the stable branch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  pos2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Nathaniel Graham]

ngraham added a comment.


  No response, assuming that means it's good. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  pos2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Filip Fila]

filipf added a comment.


  Well I tested this with several themes and it looks just fine on all of them 
except Sweet. A #plasma  person should 
have a look at the code, but visually and usability-wise this is pretty good.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  pos2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Yeah, it won't be perfect for everything, but I think it's better than what 
we have right now and fixes the bug.
  
  Is everyone okay with this?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  pos2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo added a comment.


  Never going to be correct. Sometimes the highlight touches the edges, other 
times have big margins. The aim was to avoid getting out of the svg frame.
  
  These changes focus even more on the breeze theme. 
   Sweet theme has some issues.
   F7927628: Screenshot_20200124_112438.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  pos2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo updated this revision to Diff 74298.
gvgeo added a comment.


  Change line order.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26861?vs=74297=74298

BRANCH
  pos2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo updated this revision to Diff 74297.
gvgeo added a comment.
This revision is now accepted and ready to land.


  Increase right margins by 1.2 when need, to avoid highlight area been drawn 
out of the frame.
  Various little changes.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26861?vs=74194=74297

BRANCH
  pos2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Nathaniel Graham]

ngraham added a comment.


  In D26861#599957 , @Fuchs wrote:
  
  > - Icon wise, given that it can still overlap with the app icon, I would 
prefer something that has a contrasting border, so e.g. a dark audio indicator 
is still visible on a dark app icon. But that can probably be addressed in a 
separate task, especially as it also affects other icons we have
  
  
  Yeah that's planned for 5.19.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Christian]

Fuchs added a comment.


  Looks good to me, thank you very much for the work :-)
  
  Sidesnotes that I mentioned in the group, just so they are documented here:
  
  - I think for a clickable action it can become too small, so it takes too 
much aiming. However, it doesn't get in the way, and people annoyed by it can 
just disable it completely, so that's probably fine
  
  - Icon wise, given that it can still overlap with the app icon, I would 
prefer something that has a contrasting border, so e.g. a dark audio indicator 
is still visible on a dark app icon. But that can probably be addressed in a 
separate task, especially as it also affects other icons we have

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo planned changes to this revision.
gvgeo added a comment.


  In D26880#599939 , @filipf wrote:
  
  > I also just noticed a pre-existing bug - that the hover effect filling the 
mouse area doesn't work well when the icon is smaller:
  >
  > F7923931: Screenshot_20200123_190024.png 

  >
  > The icon overflows the hover effect. I'm going to have the effect fill the 
icon instead:
  >
  > F7923933: Screenshot_20200123_185958.png 

  
  
  I will rebase on this patch and make icon aware of the orientation.
  Otherwise highlight area will overlap with the blue-bar on top when 
horizontal.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Filip Fila]

filipf added a comment.


  I don't use IOTM, but this looks quite alright to me.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  audioshrink (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added subscribers: cblack, filipf, ndavis, Fuchs, broulik.
ngraham added a comment.
This revision is now accepted and ready to land.


  I was working on a patch to improve things here and it was almost identical 
to this one. I think this is a good fix. Tested on an IOTM as well as a regular 
task manager on all four screen edges with various panel thicknesses and I did 
not find any regressions, and it did seem better to me.
  
  Let's make sure we hear from some of the other people who I recall had voiced 
concerns about the indicator getting in the way: @fuchs, @broulik, @cblack, 
@filipf @ndavis

REPOSITORY
  R119 Plasma Desktop

BRANCH
  audioshrink (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo added a comment.


  Could not pin point a specific size to disable mute function. If it is still 
a problem with this patch, maybe need to disable it for 5.18, and add a config 
option in the next release.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: VDG, Plasma, hein, ngraham.
gvgeo added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  When vertical or Icon-only task manager, shrink click area 10% and
  indicator 30%.
  This allows moving it closer to the corner, away from the center,
  to avoid accidental audio muting.
  
  BUG: 416553
  FIXED-IN: 5.18.1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  audioshrink (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart