Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

[Ben Cooksley]

On Sun, Mar 25, 2018 at 6:59 AM, Martin Flöser  wrote:
> Hi Ben,

Hi Martin,

>
> I pushed a possible fix. No guarnatees as this code obviously compiled on my
> system.

Thanks. That has fixed the issue.

>
> Could the compiler settings please be adjusted so that we have warnings be
> warnings on all ci systems and not fail on randomly? This was rather
> unexpected for me and makes it quite difficult to properly test before hand.
> The firefighting afterwards is something I don't like as mails with "fix
> this as soon as possible" are difficult if you don't have much time.

It appears that this is a FreeBSD or Clang specific issue as it didn't
fail on the Linux or Windows builds.

I've no idea where those settings could be coming from - however I
don't think it's a good idea for us to alter any settings specified by
the distributor, at least not at the CI system level, as that then
makes the CI system different from normal systems (and having it
compile on the CI system when it breaks on user systems is non-ideal).

Changing it in ECM or elsewhere in our CMake code would be the
preferable fix here if the compiler settings need changing.

>
> Cheers
> Martin

Thanks,
Ben

>
> Am 2018-03-24 11:25, schrieb Ben Cooksley:
>>
>> Hi Martin,
>>
>> Please see below. Could you please fix this as soon as possible?
>>
>> This is blocking all FreeBSD Dependency builds meaning any change to
>> the binary compatibility state of the FreeBSD platform will break the
>> whole CI system on FreeBSD.
>>
>> Cheers,
>> Ben
>>
>> On Wed, Mar 21, 2018 at 6:51 PM, CI System  wrote:
>>
>>> BUILD FAILURE
>>>
>>> Build URL
>>>
>>
>> https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/15/
>>>
>>> [1]
>>>
>>>
>>> Project:
>>> Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9
>>>
>>> Date of build:
>>> Wed, 21 Mar 2018 05:50:19 +
>>>
>>> Build duration:
>>> 1 min 31 sec and counting
>>>
>>> CONSOLE OUTPUT
>>>
>>> [...truncated 92.62 KB...]
>>>
>>> [ 10%] Building CXX object
>>>
>> src/CMakeFiles/KF5WindowSystem.dir/ECMQmLoader-kwindowsystem5_qt.cpp.o
>>>
>>>
>>> [ 11%] Building CXX object
>>>
>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionowner.cpp.o
>>>
>>>
>>> [ 12%] Building CXX object
>>>
>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionwatcher.cpp.o
>>>
>>>
>>> [ 12%] Building CXX object
>>>
>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxerrorhandler.cpp.o
>>>
>>>
>>> [ 13%] Building CXX object
>>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxutils.cpp.o
>>>
>>> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
>>> FreeBSDQt5.9/src/platforms/xcb/kxerrorhandler.cpp:145:10: warning:
>>> unused variable 'num' [-Wunused-variable]
>>>
>>> char num[ 256 ];
>>>
>>> ^
>>>
>>> 1 warning generated.
>>>
>>> [ 14%] Building CXX object
>>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kkeyserver.cpp.o
>>>
>>> [ 15%] Building CXX object
>>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxmessages.cpp.o
>>>
>>> [ 16%] Building CXX object
>>> src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/netwm.cpp.o
>>>
>>> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
>>> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:524:27: warning:
>>> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
>>>
>>> keySymX = XKeycodeToKeysym(QX11Info::display(),
>>> xmk->modifiermap[xmk->max_keypermod * i + j], k);
>>>
>>> ^
>>>
>>> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
>>> has been explicitly marked deprecated here
>>>
>>> extern KeySym XKeycodeToKeysym(
>>>
>>> ^
>>>
>>> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
>>> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:719:20: warning:
>>> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
>>>
>>> if (sym == XKeycodeToKeysym(QX11Info::display(), code, 0))
>>>
>>> ^
>>>
>>> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
>>> has been explicitly marked deprecated here
>>>
>>> extern KeySym XKeycodeToKeysym(
>>>
>>> ^
>>>
>>> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
>>> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:721:25: warning:
>>> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
>>>
>>> else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 1)) {
>>>
>>> ^
>>>
>>> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
>>> has been explicitly marked deprecated here
>>>
>>> extern KeySym XKeycodeToKeysym(
>>>
>>> ^
>>>
>>> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
>>> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:723:27: warning:
>>> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
>>>
>>> } else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 2))
>>> {
>>>
>>> ^
>>>
>>> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
>>> has been explicitly marked deprecated here
>>>
>>> extern KeySym XKeycodeToKeysym(
>>>
>>> ^
>>>
>>> 

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

[Martin Flöser]

Hi Ben,

I pushed a possible fix. No guarnatees as this code obviously compiled 
on my system.


Could the compiler settings please be adjusted so that we have warnings 
be warnings on all ci systems and not fail on randomly? This was rather 
unexpected for me and makes it quite difficult to properly test before 
hand. The firefighting afterwards is something I don't like as mails 
with "fix this as soon as possible" are difficult if you don't have much 
time.


Cheers
Martin

Am 2018-03-24 11:25, schrieb Ben Cooksley:

Hi Martin,

Please see below. Could you please fix this as soon as possible?

This is blocking all FreeBSD Dependency builds meaning any change to
the binary compatibility state of the FreeBSD platform will break the
whole CI system on FreeBSD.

Cheers,
Ben

On Wed, Mar 21, 2018 at 6:51 PM, CI System  wrote:


BUILD FAILURE

Build URL


https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/15/

[1]

Project:
Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9

Date of build:
Wed, 21 Mar 2018 05:50:19 +

Build duration:
1 min 31 sec and counting

CONSOLE OUTPUT

[...truncated 92.62 KB...]

[ 10%] Building CXX object


src/CMakeFiles/KF5WindowSystem.dir/ECMQmLoader-kwindowsystem5_qt.cpp.o


[ 11%] Building CXX object


src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionowner.cpp.o


[ 12%] Building CXX object


src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kselectionwatcher.cpp.o


[ 12%] Building CXX object


src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxerrorhandler.cpp.o


[ 13%] Building CXX object
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxutils.cpp.o

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kxerrorhandler.cpp:145:10: warning:
unused variable 'num' [-Wunused-variable]

char num[ 256 ];

^

1 warning generated.

[ 14%] Building CXX object
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kkeyserver.cpp.o

[ 15%] Building CXX object
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/kxmessages.cpp.o

[ 16%] Building CXX object
src/CMakeFiles/KF5WindowSystem.dir/platforms/xcb/netwm.cpp.o

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:524:27: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

keySymX = XKeycodeToKeysym(QX11Info::display(),
xmk->modifiermap[xmk->max_keypermod * i + j], k);

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:719:20: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

if (sym == XKeycodeToKeysym(QX11Info::display(), code, 0))

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:721:25: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 1)) {

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:723:27: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

} else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 2))
{

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:725:27: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

} else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 3))
{

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:917:20: warning:
'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]

uint sym = XKeycodeToKeysym(QX11Info::display(), keyCodeX, 0);

^

/usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym'
has been explicitly marked deprecated here

extern KeySym XKeycodeToKeysym(

^

[ 16%] Building CXX object


src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_autogen/mocs_compilation.cpp.o


6 warnings generated.

/usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2762:25: warning: cast from
'unsigned char *' to 'uint32_t *' (aka 'unsigned int *') increases
required alignment from 1 to 4 [-Wcast-align]

uint32_t *d32 = (uint32_t *) 

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

[Ben Cooksley]

Hi Martin,

Please see below. Could you please fix this as soon as possible?

This is blocking all FreeBSD Dependency builds meaning any change to the
binary compatibility state of the FreeBSD platform will break the whole CI
system on FreeBSD.

Cheers,
Ben

On Wed, Mar 21, 2018 at 6:51 PM, CI System  wrote:

> *BUILD FAILURE*
> Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%
> 20kf5-qt5%20FreeBSDQt5.9/15/
> Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9
> Date of build: Wed, 21 Mar 2018 05:50:19 +
> Build duration: 1 min 31 sec and counting
> * CONSOLE OUTPUT *
> [...truncated 92.62 KB...]
> [ 10%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/
> ECMQmLoader-kwindowsystem5_qt.cpp.o
> [ 11%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/kselectionowner.cpp.o
> [ 12%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/kselectionwatcher.cpp.o
> [ 12%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/kxerrorhandler.cpp.o
> [ 13%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/kxutils.cpp.o
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kxerrorhandler.cpp:145:10: warning: unused
> variable 'num' [-Wunused-variable]
> char num[ 256 ];
> ^
> 1 warning generated.
> [ 14%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/kkeyserver.cpp.o
> [ 15%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/kxmessages.cpp.o
> [ 16%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/
> xcb/netwm.cpp.o
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:524:27: warning:
> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
> keySymX = XKeycodeToKeysym(QX11Info::display(), 
> xmk->modifiermap[xmk->max_keypermod
> * i + j], k);
> ^
> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been
> explicitly marked deprecated here
> extern KeySym XKeycodeToKeysym(
> ^
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:719:20: warning:
> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
> if (sym == XKeycodeToKeysym(QX11Info::display(), code, 0))
> ^
> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been
> explicitly marked deprecated here
> extern KeySym XKeycodeToKeysym(
> ^
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:721:25: warning:
> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
> else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 1)) {
> ^
> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been
> explicitly marked deprecated here
> extern KeySym XKeycodeToKeysym(
> ^
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:723:27: warning:
> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
> } else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 2)) {
> ^
> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been
> explicitly marked deprecated here
> extern KeySym XKeycodeToKeysym(
> ^
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:725:27: warning:
> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
> } else if (sym == XKeycodeToKeysym(QX11Info::display(), code, 3)) {
> ^
> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been
> explicitly marked deprecated here
> extern KeySym XKeycodeToKeysym(
> ^
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/kkeyserver.cpp:917:20: warning:
> 'XKeycodeToKeysym' is deprecated [-Wdeprecated-declarations]
> uint sym = XKeycodeToKeysym(QX11Info::display(), keyCodeX, 0);
> ^
> /usr/local/include/X11/Xlib.h:1687:15: note: 'XKeycodeToKeysym' has been
> explicitly marked deprecated here
> extern KeySym XKeycodeToKeysym(
> ^
> [ 16%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/
> KF5WindowSystem_autogen/mocs_compilation.cpp.o
> 6 warnings generated.
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2762:25: warning: cast from
> 'unsigned char *' to 'uint32_t *' (aka 'unsigned int *') increases required
> alignment from 1 to 4 [-Wcast-align]
> uint32_t *d32 = (uint32_t *) icons[i].data;
> ^~
> /usr/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5
> FreeBSDQt5.9/src/platforms/xcb/netwm.cpp:2846:13: error:
> non-constant-expression cannot be narrowed from type 'int' to 'uint32_t'
> (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
> topology.top, topology.bottom, topology.left, topology.right, 1
> ^~~~
>