Re: Monday meeting minutes for 2019-02-04 (week 6)
On Mon, Feb 4, 2019 at 2:25 PM Eike Hein wrote: > > > Of special note: We decided on doing another 5.14.x release to round up > Folder View and Discover fixes, to aid Debian Stable which will ship > 5.14.x. This will happen pending th completion of some Discover work for > the branch. on my side: * continued the custom toolbar work, turns out very not trivial D18619 * continued work on c++ pagerow partial rewrite * this week at the plasma mobile sprint -- Marco Martin
Monday meeting minutes for 2019-02-04 (week 6)
Of special note: We decided on doing another 5.14.x release to round up Folder View and Discover fixes, to aid Debian Stable which will ship 5.14.x. This will happen pending th completion of some Discover work for the branch. kbroulik - Merged new Color KCM \o/ - Desktop Theme KCM can now install from remote locations (via KIO) - Dolphin now defaults to sort and group by date in Downloads folder - Investigated why fonts:/ KCM doesn't show thumbnails, found cause, no real fix yet (WIP D18654) - Fixed unreadable tooltip text colors in GTK2 settings written by kde-gtk-settings - Looked into icon support in ComboBox -- difficult because of QIcon vs QQuickIcon -- Fixed crash in Breeze style when you do that from QQC - Minor optimizations in Plasma Work todo: - Follow-up patch for Color KCM to add search field and filter: D18646 - Now on Qt 5.12, working nicely so far, tooltip text size is glitched out but supposedly fixed in Qt 5.12.1 already - Please review: D18487 D18700 D18701 D18718 bshah = - PlaMo sprint starting from today - Worked on Qt 5.12 upto last week - Worked with d_ed yesterday on scaling fix for PlaM still work in progress ^^ and FOSDEM :) romangg === Gonna merge this week Xwl DND (now for real, waited for latest frameworks release in light of KWayland patches). Thinking of joining the PlaMo sprint. But would be only the last few days. zzag * Splited out the Desktop Effects KCM * Did some code tidying in KWin * Rebased my window rules patches on David's changes Sho === * Finished and merged patch for the "icons sometimes scrambled at boot" issue * Finished and merged fix for the "new items sometimes get duplicated" issue * Helped merge a patch for a DND position validation issue leinir == In short: We need two patches, one which simply reverts a commit, and one which causes certain backends to be disabled after a timeout (which will render some things less functional on very slow connections, but will at least make Discover not entirely broken for those users) Right, will get that under way momentarily - i don't expect the second patch to be a huge amount of work, and of course the former is a revert (which incidentally has been tested by three users with the bug, who report it as worked-around with that commit reverted) Cheers, Eike [11:59:51] hi, who's here for the meeting? [11:59:56] me [11:59:59] cool [12:00:09] me too [12:00:43] romangg Riddell d_ed bshah notmart fvogt zzag pingeling [12:00:55] ngraham too [12:00:56] yo [12:00:57] pingelingeling, pingelingeling, here comes the eggman [12:01:01] Oh, time for lunch :P [12:01:02] d_ed on roadtrip [12:01:03] apol next to me [12:01:12] notmart on train ride [12:01:16] * kbroulik boring @home [12:01:20] romangg also train ride [12:01:26] aye [12:01:37] let's start with kbroulik then [12:02:02] also I am working like Sho_ for first time :P (in coffee place) [12:02:20] nice :) [12:02:53] alright [12:02:59] (since I've been on vacation last week, includes stuff from the previous meeting I missed) Work done: - Merged new Color KCM \o/ - Desktop Theme KCM can now install from remote locations (via KIO) - Dolphin now defaults to sort and group by date in Downloads folder - Investigated why fonts:/ KCM doesn't show thumbnails, found cause, no real fix yet (WIP D18654) Diff 18654 "[fonts:/ KIO] Implement stat() call" [Changes Planned] https://phabricator.kde.org/D18654 - Fixed unreadable tooltip text colors in GTK2 settings written by kde-gtk-settings - Looked into icon support in ComboBox -- difficult because of QIcon vs QQuickIcon -- Fixed crash in Breeze style when you do that from QQC - Minor optimizations in Plasma Work todo: - Follow-up patch for Color KCM to add search field and filter: D18646 Diff 18646 "[Colors KCM] Add search and filter" [Needs Review] https://phabricator.kde.org/D18646 - Now on Qt 5.12, working nicely so far, tooltip text size is glitched out but supposedly fixed in Qt 5.12.1 already - Please review: D18487 D18700 D18701 D18718 Diff 18487 "Reparse background contrast settings when colors changed" [Needs Review] https://phabricator.kde.org/D18487 Diff 18700 "[Color Picker] Allow dragging color button to drag color" [Needs Review] https://phabricator.kde.org/D18700 Diff 18701 "[Icon Applet] Show busy indicator when launching app" [Needs Review] https://phabricator.kde.org/D18701 Diff 18718 "Support icon on ComboBox" [Needs Review] https://phabricator.kde.org/D18718 Not sure how reliable the DB internet is, but I'm here. questions || next oh, nice on the contrast fix next up is bshah - PlaMo sprint starting from today - Worked on Qt 5.12 upto last week - Worked with d_ed yesterday on scaling fix for PlaM still work in progress ^^ and FOSDEM :) questions? or next romangg is next guess DB internet doesn't work :P Gonna merge this week Xwl DND (now for real, waited for latest frameworks release in light of KWayland
Monday meeting minutes for 2019-01-28 (week 5)
d_ed I did a few little bug fixes, mostly in the cursors KCM In bigger changes, my patch supporting shadows in KWindowSystem is nearly done That reminds me. I had a tiny compositor written in kwayland that used to recreate the firefox issue Firefox now works there ! ...but still fails in kwin so it seems something in FF has been fixed accidentally - but we now still need to revisit everything on the kwin side notmart === Kirigami * Fixed a bug in PageRow whenre replacing the first page didn't work and just gave an empty window * Merged Collapsible drawer items branch * started a partial reimplementation of PageRow in C++ (to optimize memory consumption and fix some bugs that are tricky with qml-only, as well as features * fixed paddings in SwipeListItem KWin * continued patches for wayland virtual desktops rows, accepted and landed romangg === Decided to move pushing my Xwl DND patches to next week to wait for after Frameworks release. Have patches for improved Wayland backend on phab: D18465 Diff 18465 "[platforms/wayland] Multi output support" [Needs Review] https://phabricator.kde.org/D18465 Patch for Xwl Multi DPI: D18486 Diff 18486 "[RFC] XWayland Multi DPI support" [Needs Review] https://phabricator.kde.org/D18486 some other patches are on review which I will push in the coming two weeks. Currently looking into xdg-output support to Weston. which might come in handy for testing multi dpi. bshah = - Preparing qt5.12 in neon, landing tomorrow at best - Preparing for PlaMo sprint - Rebased dmabuf patches to recent master for testing by community member on Librem 5 devkit Sho === I cleaned up the libtm code on master to use the new rows API in the PVD Wayland protocol and dropped the D-Bus codepath again I'm looking into some Folder View model bugs now, hoping I find the time to get fixes in before 5.15 is tagged My new laptop has a decent nVidia DGPU. I tried testing nVidia's eglstreams backend patch (D18570) just before the meeting, but kwin is crashing during the splash screen. I'll debug Next meeting todos: Schedule 5.16 kickoff; put dmabuf patches into 5.16 task list Cheers, Eike â[20:07] â<âSho_â>â I'll do notes â[20:07] â<âSho_â>â d_ed: gogogo â[20:08] â<âd_edâ>â I did a few little bug fixes, mostly in the cursors KCM â[20:08] â<âd_edâ>â In bigger changes, my patch supporting shadows in KWindowSystem is nearly done â[20:08] â<âSho_â>â supporting shadows in kws? â[20:09] â<âSho_â>â sounds interesting, what does it entail :) â[20:09] â<âd_edâ>â effectively moving the code from Plasma::DialogShadows and Breeze::ShadowHelper / Oxygen::ShadowHelper into KWS â[20:09] â<âSho_â>â neat â[20:09] â<âd_edâ>â main reason is that it's plugin based which is a pre-requisite for some changes Martin is doing in kwin with the internal windows â[20:09] â<ânotmartâ>â KWS? â[20:10] â<âd_edâ>â KWindowSystem â[20:10] â<ânotmartâ>â ah, kwindowsystem â[20:10] â<ânotmartâ>â neat :) â[20:10] â<âSho_â>â d_ed: did the Fedora-defaulting-to-Firefox-Wayland news stir up anything, e.g. Firefox fixing anything or someone reaching out to you? â[20:10] â* âbshahââ around â[20:10] â<âd_edâ>â Sho_: That reminds me. I had a tiny compositor written in kwayland that used to recreate the firefox issue â[20:10] â<âd_edâ>â Firefox now works there ! â[20:10] â<âd_edâ>â ...but still fails in kwin â[20:11] â<âSho_â>â Interesting â[20:11] â<ânotmartâ>â duh â[20:11] â<âd_edâ>â so it seems something in FF has been fixed accidentally - but we now still need to revisit everything on the kwin side â[20:11] â<âSho_â>â :) at least it looks like it's something under our control then â[20:12] â<âSho_â>â getting a wayland-native browser will be great ... â[20:12] â<âd_edâ>â yeah definitely â[20:12] â<âSho_â>â got anything else, or should we move on to notmart? â[20:12] â<âd_edâ>â lets move on â[20:12] â<ânotmartâ>â ok â[20:12] â<âSho_â>â notmart: gogogo â[20:12] â<âSho_â>â this meeting directive not sponsored by Google Go â[20:13] â<ânotmartâ>â Kirigami â[20:13] â<ânotmartâ>â * Fixed a bug in PageRow whenre replacing the first page didn't work and just gave an empty window â[20:13] â<ânotmartâ>â * Merged Collapsible drawer items branch â[20:13] â<ânotmartâ>â * started a partial reimplementation of PageRow in C++ (to optimize memory consumption and fix some bugs that are tricky with qml-only, as well as features â[20:13] â<ânotmartâ>â * fixed paddings in SwipeListItem â[20:13] â<ânotmartâ>â KWin â[20:13] â<ânotmartâ>â * continued patches for wayland virtual desktops rows, accepted and landed â[20:15] â<âSho_â>â romangg would
Monday meeting minutes for 2019-01-21 (week 4)
Hi all, this week's meeting minutes for Plasma: notmart === * fixed loading of default iconset&window deco from lnf package * (5.16) systemsettings sidebar icons are now 32 px with less margin, as agreed with VDG d_ed * fixed a kscreen-kwin crash * Back on some wayland work: * added support for the keep on top "pin" that we see in system tray / calendar * along with the usual bugfixes * going to try and spend today investigating Bug 353983 (Turning off compositing breaks Plasma panel rendering) romangg === * Will push my Xwl DND patch series this week to master. * Working on an idea to fix Xwl Multi DPI. ** For example: Bug 389191 (xwayland auto-upscaling causes pixelation and should be optional) ** The Xwl Multi DPI is code in KWin and Xwl * Working on a rewrite of the Wayland platform plugin in terms of AbstractOutput kbroulik Work done: * Some overall optimizations: ** Some connect syntax porting ** Plasma::Theme instances are shared between (often-created) ColorScope objects *** Plasma::Svg also creates its own instance of default theme but there it's more complicated as: *** can be either default theme or custom theme, not sure about proper use of refcounting/QShared stuff there * Lock screen doesn't break (lock out user) if HOME ends up unwritable (config file locked) Work todo: * Continue on notifications rewrite * Overall 5.15 Beta bug fixing Other: * Plasma-browser-integration for Chrome has hit 40,000 users \o/ Cheers Kai Uwe [12:02:24] meeting? [12:03:05] notmart: d_ed Sho_ romangg fvogt jgrulich [12:04:54] here [12:05:31] here [12:06:00] alright, notmart go [12:06:58] really few things in plasma this week [12:07:01] * fixed loading of default iconset&window deco from lnf package [12:07:02] * (5.16) systemsettings sidebar icons are now 32 px with less margin, as agreed with VDG [12:07:24] that's pretty much it :( [12:07:24] ah, that explains why they're gigantic now [12:07:34] hi [12:07:49] kbroulik: yeah, vdg really wanted them like that very much [12:07:52] :/ [12:07:55] (until next time i guess :p) [12:08:04] alright, d_ed next [12:08:33] Back on some wayland work [12:08:58] fixed a kscreen-kwin crash [12:09:15] added support for the keep on top "pin" that we see in system tray / calendar [12:09:26] along with the usual bugfixes [12:10:03] ok, romangg [12:10:09] going to try and spend today investigating 353983 [12:10:19] as I have some new hardware and a possible idea [12:10:29] (sorry, done now, I had to pause to look up the number) [12:10:33] cool! [12:10:49] * Will push my Xwl DND patch series this week to master. [12:10:59] * Working on an idea to fix Xwl Multi DPI. [12:11:12] (for example: https://bugs.kde.org/show_bug.cgi?id=389191) [12:11:12] KDE bug 389191 in kwin (wayland-generic) "xwayland auto-upscaling causes pixelation and should be optional" [wishlist,WONTFIX] https://bugs.kde.org/show_bug.cgi?id=389191 [12:11:33] * Working on a rewrite of the Wayland platform plugin in terms of AbstractOutput [12:11:50] The Xwl Multi DPI is code in KWin and Xwl [12:12:08] questions? [12:12:22] cool [12:12:26] anyone else wants to chime in? [12:12:51] alright I'll wrap up then, this was a quick one [12:12:56] Work done: [12:12:56] - Some overall optimizations: [12:12:56] -- Some connect syntax porting [12:12:56] -- Plasma::Theme instances are shared between (often-created) ColorScope objects [12:12:56] --- Plasma::Svg also creates its own instance of default theme but there it's more complicated as: [12:12:56] --- can be either default theme or custom theme, not sure about proper use of refcounting/QShared stuff there [12:13:01] - Lock screen doesn't break (lock out user) if HOME ends up unwritable (config file locked) [12:13:01] -- Candidate for 5.12? D18291 [12:13:05] - Plasma-browser-integration for Chrome has hit 40,000 users \o/ [12:13:07] Diff 18291 "[Greeter] Ignore unwritable configuration files" [Closed] https://phabricator.kde.org/D18291 [12:13:08] Work todo: [12:13:08] - Continue on notifications rewrite [12:13:08] - Overall 5.15 Beta bug fixing [12:14:29] alright, done, thanks everyone
Monday meeting minutes for 1/10/2018
Eike: what i did: * [Wayland] Virtual desktops KCM: Implemented delayed-apply, handle all cases of state-desync between KCM and server nicely for the user, UI cleanup * [Wayland] Fixed a crash in one of the containment action ports * [Kickoff] Rewrote mouse handling to fix highlight sticking to mouse pointer during search; also saves many MouseAreas * [FV] Fixed initial focus for arrow key nav when opening panel applet by hotkey * what i will do next: no idea! but it will probably be super cool and maybe involve virtual desktops Kai Uwe: Work done: Plasma: - Released 0.3.1 of plasma-browser-integration -- Improved heuristic for ignoring short sounds (to avoid controlling chat notifications) -- Chrome has 25,000 users now, Firefox 9,500 - Plasma-pa now shows "muted" icon when using Dummy Output - Had to revert removal of XRandrBrightness u_u because Nvidia apparently relies on it -.- - Company stuff Misc: - Various Dolphin fixes for tab/window titles - Various crash fixes in thumbnailers now that they have KCrash support and we actually see them (PDF/Ghostscript and FFmpegthumbs being the worst offenders afaics) Work todo: - Company stuff - Support for Seek() in plasma-browser-integration: D15863 -- Fixes seeking tracks via KDE Connect Diff 15863 "[MPris Plugin] Support Seek()" [Needs Review] https://phabricator.kde.org/D15863 David: Qt 5.12 has 2 interesting wayland problems with dialog 1) QWindow::position returns 0,0 after QWindow::setPosition because it knows it hasn't moved it which is on one hand very sensible, but our plasma shell code relies on it I have a Qt patch that puts it back, but I'm 50/50 on whether it'll get in I also have a plasma popup 2) the other breakage we have is that with plasma popups show/hide/show doesn't work I have a plasma workaround but I don't have a proper fix https://bugreports.qt.io/browse/QTBUG-70845 I know the chain of events that goes wrong, I don't fully understand how it's meant to work * I'll give porting to xdg popup a go once I've settled this. * outside of wayland, I'm stripping down ksmserver still Marco: Kirigami: * fixed last annoyances with monochrome icons heuristics * possibility for CardsGridView to have an arbitrary number of columns, introduced concept of minimumcolumnwidth * same feature and api in CardsLayout as well Next week: * this week i hope to get some time into the virtual desktop wayland stuff * and, to finally finish the multilevel kcm stuff, another thing abandoned since ages * 2 reviews are ship it, 2 still to go ** Diff 15098 "make push/pop part of ConfigModule API" [Needs Review] https://phabricator.kde.org/D15098 ** Diff 14580 "support for multi pages kcms" [Needs Review] https://phabricator.kde.org/D14580
Monday meeting minutes
Kai Uwe: * Bugfixing in Folder View * Fixed System Settings section headings font (Qt bug with font.bold vs font.weight priority) * Added "aboutToShow" signal for ToolTipArea, allows to defer heavy lifting to when the tooltip is actually shown (vs containsMouse) * Profiling in Dolphin * Tried to fix undo move to trash in desktop not working caused by (once again..) URL rewriting, D11987 but that's still not enough to fix it * Fix for blur background filling caused by Image wallpaper rewrite: D11981 * Performance improvement for file dialog: D11948 * Will add QtQuickSettings to System Settings since it has a lot of QML stuff nowadays * Made a patch for QtDBus to allow interactive authorization https://codereview.qt-project.org/#/c/225143/ ** needed for new logind and other calls, such as "reboot to firmware setup" I've also been working on ** will try to get the Qt patch cleaned up this week Riddell: * spoken with Mirko about the sprint, needs somebody keeping the office key * finding details of kde office warmup party to coordinate with who is still at the sprint then Roman: Working on T4465. Thinking about the right library structure. Current progress here: https://cgit.kde.org/clones/plasma-workspace/romangilg/plasma-workspace.git/log/?h=colorCorrectIndividualOutputs David: * Mostly Qt stuff this week: * Had some fallout from my Qt nvidia patch - hopefully now all fixed. Mostly all merged now. * Finally had that Qt memory leak patch merged (visible on slideshow wallpaper) * wrote a QtDbus patch allowing for wildcards in QDBusService (waiting on Kai to review before tagging proper people) * this morning fixed a very boring crash in plasma framework https://bugs.kde.org/show_bug.cgi?id=391642#c6 Eike: * Short week due to holiday on Monday and taking another day off for personal stuff * [SysSe] Finished Language KCM port, need to re-read and Phab ** We don't have a drag-reorderable list in Kirigami yet, so I did without it for now (Up/Down buttons) * Leaving for Berlin on the 12th, vacation until 17th, some more vacay after the board meeting (28th+29th) in Berlin, then back in Seoul and at work on the 3rd Marco: * finished up a new api for libplasma to make containments and activities bookkeeping easier on shellcorona, will push this week as frameworks has been released * ksplash themes standalone and ghns ui on systemsettings splash module: they are still shared with lnf, but lnf module won't list themes with just a splash * Kirigami: DesktopIcon now used on all styles (except plasma svg theme where the identical IconItem is used) * Working with VDG on a new lockscreen look D11928
