RFC: move krunnermodel in org.kde.plasma.core
Hi all, for some reason the krunner model ended up into its own import, that doesn't make much sense and causes that tad ov overhead of having one more so. its real place would be org.kde.plasma.core together the other libplasma bindings. if this is moved today would cause some annoyances but not much, basically is madder of deleting import org.kde.runnermodel from the qml files that are using it (and make sure they have import org.kde.plasma.core that is 99% likely they have already) the api of the class wouldn't change it's probably just a couple of places where is used and wasn't really documented yet (more on documentation issue later) so change would be fairly pailess opinions? ideas? Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: RFC: move krunnermodel in org.kde.plasma.core
On Wednesday 03 October 2012 13:20:43 Marco Martin wrote: it's probably just a couple of places where is used and wasn't really documented yet (more on documentation issue later) so change would be fairly pailess opinions? ideas? the krunnermodel has been part of a release, right? Given that we should not break the API, so I would suggest to go ahead with what you suggested, but in addition keep the old import around. That way maybe existing 3rd party users don't get broken. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: RFC: move krunnermodel in org.kde.plasma.core
Le mercredi 3 octobre 2012 13:20:43 Marco Martin a écrit : Hi all, for some reason the krunner model ended up into its own import, that doesn't make much sense and causes that tad ov overhead of having one more so. its real place would be org.kde.plasma.core together the other libplasma bindings. if this is moved today would cause some annoyances but not much, basically is madder of deleting import org.kde.runnermodel from the qml files that are using it (and make sure they have import org.kde.plasma.core that is 99% likely they have already) the api of the class wouldn't change Makes sense to me. You may want to take advantage of this small breakage to replace the name of the model roles from label to display and icon to decoration. This would make RunnerModel follow the same conventions used by Qt when exposing C++ models. Aurélien ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: RFC: move krunnermodel in org.kde.plasma.core
On Wednesday 03 October 2012, Aurélien Gâteau wrote: the api of the class wouldn't change Makes sense to me. You may want to take advantage of this small breakage to replace the name of the model roles from label to display and icon to decoration. This would make RunnerModel follow the same conventions used by Qt when exposing C++ models. i thnk the roles should map exactly QueryMatch, but adding *also* decoration and display for consistency is a good idea Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: RFC: move krunnermodel in org.kde.plasma.core
On Wednesday 03 October 2012, Martin Gräßlin wrote: On Wednesday 03 October 2012 13:20:43 Marco Martin wrote: it's probably just a couple of places where is used and wasn't really documented yet (more on documentation issue later) so change would be fairly pailess opinions? ideas? the krunnermodel has been part of a release, right? Given that we should not break the API, so I would suggest to go ahead with what you suggested, but in addition keep the old import around. That way maybe existing 3rd party users don't get broken. yeah, it got into 4.9 :/ anyways is easy to use the same code and still have the old import (with a big comment in the code about removing it for plasma2) that thing also won't be mentioned in the documentation anywhere, while mentioned only the one in core Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
