Re: Review Request 129091: Add icons for Fcitx
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/ --- (Updated 十月 6, 2016, 6:03 p.m.) Review request for Plasma. Repository: plasma-framework Description --- This patch adds icons for Fcitx system tray icon. Fcitx is the default input method framework in most Chinese GNU/Linux desktop system. These icons will make Fcitx looks better in system tray. ime.svgz - ime-fullwidth - ime-halfwidth - ime-punctuation-fullwidth - ime-punctuation-halfwidth - ime-chinese-simplified - ime-chinese-traditional - ime-remind-on - ime-remind-off - ime-handwriting-on - ime-handwriting-off - ime-erbi - ime-googlepinyin - ime-libpinyin-pinyin - ime-libpinyin-quanpin - ime-libpinyin-shuangpin - ime-pinyin - ime-quanpin - ime-shuangpin - ime-sunpinyin - ime-wubi - ime-wubipinyin - ime-ziranma - ime-bopomofo - ime-cangjie - ime-chewing - ime-libpinyin-bopomofo - ime-libpinyin-chewing - ime-rime - ime-anthy - ime-libkkc - ime-libskk - ime-hangul - ime-unikey - ime-emoji fcitx.svgz - fcitx - fcitx-kbd - fcitx-vk-active - fcitx-vk-inactive - fcitx-remind-active - fcitx-remind-inactive - fcitx-chntran-active - fcitx-chntran-inactive - fcitx-fullwidth-active - fcitx-fullwidth-inactive - fcitx-punc-active - fcitx-punc-inactive - fcitx-pinyin - fcitx-shuangpin - fcitx-wubi - fcitx-pinyin-libpinyin - fcitx-shuangpin-libpinyin - fcitx-bopomofo - fcitx-sunpinyin - fcitx-googlepinyin - fcitx-emoji - ... Diffs - src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION src/desktoptheme/breeze/icons/ime.svgz PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129091/diff/ Testing --- File Attachments (updated) Spectacle.Et8101.png https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png Spectacle.AD8101.png https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png Screenshot_20161006_201118.png https://git.reviewboard.kde.org/media/uploaded/files/2016/10/06/9b51635d-7461-40b4-9c59-27d07407a475__Screenshot_20161006_201118.png Thanks, Yunhe Guo
Re: Review Request 129091: Add icons for Fcitx
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/ --- (Updated 十月 6, 2016, 6:02 p.m.) Review request for Plasma. Changes --- Add generic icons ime.svgz and Fcitx icons fcitx.svgz Repository: plasma-framework Description (updated) --- This patch adds icons for Fcitx system tray icon. Fcitx is the default input method framework in most Chinese GNU/Linux desktop system. These icons will make Fcitx looks better in system tray. ime.svgz - ime-fullwidth - ime-halfwidth - ime-punctuation-fullwidth - ime-punctuation-halfwidth - ime-chinese-simplified - ime-chinese-traditional - ime-remind-on - ime-remind-off - ime-handwriting-on - ime-handwriting-off - ime-erbi - ime-googlepinyin - ime-libpinyin-pinyin - ime-libpinyin-quanpin - ime-libpinyin-shuangpin - ime-pinyin - ime-quanpin - ime-shuangpin - ime-sunpinyin - ime-wubi - ime-wubipinyin - ime-ziranma - ime-bopomofo - ime-cangjie - ime-chewing - ime-libpinyin-bopomofo - ime-libpinyin-chewing - ime-rime - ime-anthy - ime-libkkc - ime-libskk - ime-hangul - ime-unikey - ime-emoji fcitx.svgz - fcitx - fcitx-kbd - fcitx-vk-active - fcitx-vk-inactive - fcitx-remind-active - fcitx-remind-inactive - fcitx-chntran-active - fcitx-chntran-inactive - fcitx-fullwidth-active - fcitx-fullwidth-inactive - fcitx-punc-active - fcitx-punc-inactive - fcitx-pinyin - fcitx-shuangpin - fcitx-wubi - fcitx-pinyin-libpinyin - fcitx-shuangpin-libpinyin - fcitx-bopomofo - fcitx-sunpinyin - fcitx-googlepinyin - fcitx-emoji - ... Diffs (updated) - src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION src/desktoptheme/breeze/icons/ime.svgz PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129091/diff/ Testing --- File Attachments Spectacle.Et8101.png https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png Spectacle.AD8101.png https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png Thanks, Yunhe Guo
Re: Review Request 129091: Add icons for Fcitx
> On 十月 4, 2016, 3:56 p.m., Eike Hein wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > > language code so they can also be used by kimpanel (which in turn can use > > fcitx or ibus or scim)? Do you really need different icons for each IME > > engine instead of just per language? > > > > Having icons for specific fcitx plugins upstream seems like bad layering. > > Yunhe Guo wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > language code so they can also be used by kimpanel (which in turn can use > fcitx or ibus or scim)? > > Having icons for specific fcitx plugins upstream seems like bad > layering. > > I just use the same icon name in original Fcitx icons. These icons were > tested with Fcitx classic UI, not Kimpanel. But as far as I know, **kimpanel > is just a part of Fcitx project**. So here is no "fcitx plugin" problem. What > icons that Fcitx uses is always what kimpanel uses. So these icons will > provide same support to ibus and scim if they use kimpanel as UI (by default, > not). > > > Do you really need different icons for each IME engine instead of just > per language? > > Those Chinese IMEs are totally different. It is impossible to use only > one icon for all without confusing users. > > Xuetian Weng wrote: > Can you separate the request into two different ones? input-keyboard > addition is quite generic. while the im icon is input method specific. > > Yunhe Guo wrote: > Now input-keyboard in another patch > https://git.reviewboard.kde.org/r/129098/ > > Eike Hein wrote: > The situation is this: > * fcitx has its own UI frontend > * ibus has its own UI frontend > * plasma-desktop contains kimpanel, which can act as UI frontend for > either fcitx or ibus > > From the Plasma, POV we care most about kimpanel. kimpanel currently > shows the icons provided/requested by the IME. So if fcitx is used as > backend, it will show your icons. But it won't when using the ibus backend, > since ibus uses different icon names. > > My goal is to raise the visual quality level of the entire ecosystem - > many distros currently default to ibus, and when Plasma is started in a > locale that needs one, it will automatically add impanel to the panel as IME > frontend. Due to the lack of icons, that means CJK is currently > ugly-by-default for many users. > > So my proposed way to fix this would be: > * Agree on generic icon names (e.g. ime-zh-sunpinyin) > * Ask fcitx and ibus to switch to using the generic icon names > * For a transitional period, also provide the icons under legacy > fcitx/ibus names > > Eike Hein wrote: > Sorry, RB fucked up my bullet lists. Fixed: > > The situation is this: > * fcitx has its own UI frontend > * ibus has its own UI frontend > * plasma-desktop contains kimpanel, which can act as UI frontend for > either fcitx or ibus > > From the Plasma, POV we care most about kimpanel. kimpanel currently > shows the icons provided/requested by the IME. So if fcitx is used as > backend, it will show your icons. But it won't when using the ibus backend, > since ibus uses different icon names. > > My goal is to raise the visual quality level of the entire ecosystem - > many distros currently default to ibus, and when Plasma is started in a > locale that needs one, it will automatically add impanel to the panel as IME > frontend. Due to the lack of icons, that means CJK is currently > ugly-by-default for many users. > > So my proposed way to fix this would be: > * Agree on generic icon names (e.g. ime-zh-sunpinyin) > * Ask fcitx and ibus to switch to using the generic icon names > * For a transitional period, also provide the icons under legacy > fcitx/ibus names > > Yunhe Guo wrote: > Back to the purpose of this patch... It provide support for Fcitx. If you > need ibus or scim, then that will be provided by other patches. That is > beyond the topic here... > > 1. If this patch is acceptable, I will provide patches for ibus and scim > later, based on this patch. Generic icon patch will be provided after they > make a agreement on names. (Need quiet a long time) > 2. If this patch is not acceptable, I need to improve it. > > Generic icon names is a long time task. It is better to support something > than nothing. It cannot be a good reason to reject this patch. Final solution: 1. Create ime.svgz for generic icon names. Names are drafted at https://gist.github.com/guoyunhe/9e0ade5d612feaf9d8534abf56715dd2 2. Draw all necessary icons for generic IME usage. 3. Create fcitx.svgz for current Fcitx support. Copy icons from ime.svgz. 4. Create ibus.svgz for current IBus support. Copy icons from ime.svgz. 5. Create scim.svgz for current SCIM support. Copy icons from ime.svgz. Fcitx, IBus and SCIM project
Re: Review Request 129091: Add icons for Fcitx
> On 十月 4, 2016, 3:56 p.m., Eike Hein wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > > language code so they can also be used by kimpanel (which in turn can use > > fcitx or ibus or scim)? Do you really need different icons for each IME > > engine instead of just per language? > > > > Having icons for specific fcitx plugins upstream seems like bad layering. > > Yunhe Guo wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > language code so they can also be used by kimpanel (which in turn can use > fcitx or ibus or scim)? > > Having icons for specific fcitx plugins upstream seems like bad > layering. > > I just use the same icon name in original Fcitx icons. These icons were > tested with Fcitx classic UI, not Kimpanel. But as far as I know, **kimpanel > is just a part of Fcitx project**. So here is no "fcitx plugin" problem. What > icons that Fcitx uses is always what kimpanel uses. So these icons will > provide same support to ibus and scim if they use kimpanel as UI (by default, > not). > > > Do you really need different icons for each IME engine instead of just > per language? > > Those Chinese IMEs are totally different. It is impossible to use only > one icon for all without confusing users. > > Xuetian Weng wrote: > Can you separate the request into two different ones? input-keyboard > addition is quite generic. while the im icon is input method specific. > > Yunhe Guo wrote: > Now input-keyboard in another patch > https://git.reviewboard.kde.org/r/129098/ > > Eike Hein wrote: > The situation is this: > * fcitx has its own UI frontend > * ibus has its own UI frontend > * plasma-desktop contains kimpanel, which can act as UI frontend for > either fcitx or ibus > > From the Plasma, POV we care most about kimpanel. kimpanel currently > shows the icons provided/requested by the IME. So if fcitx is used as > backend, it will show your icons. But it won't when using the ibus backend, > since ibus uses different icon names. > > My goal is to raise the visual quality level of the entire ecosystem - > many distros currently default to ibus, and when Plasma is started in a > locale that needs one, it will automatically add impanel to the panel as IME > frontend. Due to the lack of icons, that means CJK is currently > ugly-by-default for many users. > > So my proposed way to fix this would be: > * Agree on generic icon names (e.g. ime-zh-sunpinyin) > * Ask fcitx and ibus to switch to using the generic icon names > * For a transitional period, also provide the icons under legacy > fcitx/ibus names > > Eike Hein wrote: > Sorry, RB fucked up my bullet lists. Fixed: > > The situation is this: > * fcitx has its own UI frontend > * ibus has its own UI frontend > * plasma-desktop contains kimpanel, which can act as UI frontend for > either fcitx or ibus > > From the Plasma, POV we care most about kimpanel. kimpanel currently > shows the icons provided/requested by the IME. So if fcitx is used as > backend, it will show your icons. But it won't when using the ibus backend, > since ibus uses different icon names. > > My goal is to raise the visual quality level of the entire ecosystem - > many distros currently default to ibus, and when Plasma is started in a > locale that needs one, it will automatically add impanel to the panel as IME > frontend. Due to the lack of icons, that means CJK is currently > ugly-by-default for many users. > > So my proposed way to fix this would be: > * Agree on generic icon names (e.g. ime-zh-sunpinyin) > * Ask fcitx and ibus to switch to using the generic icon names > * For a transitional period, also provide the icons under legacy > fcitx/ibus names Back to the purpose of this patch... It provide support for Fcitx. If you need ibus or scim, then that will be provided by other patches. That is beyond the topic here... 1. If this patch is acceptable, I will provide patches for ibus and scim later, based on this patch. Generic icon patch will be provided after they make a agreement on names. (Need quiet a long time) 2. If this patch is not acceptable, I need to improve it. Generic icon names is a long time task. It is better to support something than nothing. It cannot be a good reason to reject this patch. - Yunhe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review99774 --- On 十月 4, 2016, 4:38 p.m., Yunhe Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129091/ >
Re: Review Request 129091: Add icons for Fcitx
> On 十月 4, 2016, 3:56 p.m., Eike Hein wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > > language code so they can also be used by kimpanel (which in turn can use > > fcitx or ibus or scim)? Do you really need different icons for each IME > > engine instead of just per language? > > > > Having icons for specific fcitx plugins upstream seems like bad layering. > > Yunhe Guo wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > language code so they can also be used by kimpanel (which in turn can use > fcitx or ibus or scim)? > > Having icons for specific fcitx plugins upstream seems like bad > layering. > > I just use the same icon name in original Fcitx icons. These icons were > tested with Fcitx classic UI, not Kimpanel. But as far as I know, **kimpanel > is just a part of Fcitx project**. So here is no "fcitx plugin" problem. What > icons that Fcitx uses is always what kimpanel uses. So these icons will > provide same support to ibus and scim if they use kimpanel as UI (by default, > not). > > > Do you really need different icons for each IME engine instead of just > per language? > > Those Chinese IMEs are totally different. It is impossible to use only > one icon for all without confusing users. > > Xuetian Weng wrote: > Can you separate the request into two different ones? input-keyboard > addition is quite generic. while the im icon is input method specific. Now input-keyboard in another patch https://git.reviewboard.kde.org/r/129098/ - Yunhe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review99774 --- On 十月 4, 2016, 4:38 p.m., Yunhe Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129091/ > --- > > (Updated 十月 4, 2016, 4:38 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > This patch adds icons for Fcitx system tray icon. Fcitx is the default input > method framework in most Chinese GNU/Linux desktop system. These icons will > make Fcitx looks better in system tray. > > Icons included: > > input.svgz > > - input-keyboard > > fcitx.svgz > > - fcitx > - fcitx-kbd > - fcitx-pinyin > - fcitx-shuangpin > - fcitx-wubi > - fcitx-pinyin-libpinyin > - fcitx-shuangpin-libpinyin > - fcitx-bopomofo > - fcitx-sunpinyin > - fcitx-googlepinyin > - fcitx-emoji > > > Diffs > - > > src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129091/diff/ > > > Testing > --- > > > File Attachments > > > Spectacle.Et8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png > Spectacle.AD8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png > > > Thanks, > > Yunhe Guo > >
Re: Review Request 129091: Add icons for Fcitx
> On Oct. 4, 2016, 3:56 p.m., Eike Hein wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > > language code so they can also be used by kimpanel (which in turn can use > > fcitx or ibus or scim)? Do you really need different icons for each IME > > engine instead of just per language? > > > > Having icons for specific fcitx plugins upstream seems like bad layering. > > Yunhe Guo wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > language code so they can also be used by kimpanel (which in turn can use > fcitx or ibus or scim)? > > Having icons for specific fcitx plugins upstream seems like bad > layering. > > I just use the same icon name in original Fcitx icons. These icons were > tested with Fcitx classic UI, not Kimpanel. But as far as I know, **kimpanel > is just a part of Fcitx project**. So here is no "fcitx plugin" problem. What > icons that Fcitx uses is always what kimpanel uses. So these icons will > provide same support to ibus and scim if they use kimpanel as UI (by default, > not). > > > Do you really need different icons for each IME engine instead of just > per language? > > Those Chinese IMEs are totally different. It is impossible to use only > one icon for all without confusing users. > > Xuetian Weng wrote: > Can you separate the request into two different ones? input-keyboard > addition is quite generic. while the im icon is input method specific. > > Yunhe Guo wrote: > Now input-keyboard in another patch > https://git.reviewboard.kde.org/r/129098/ > > Eike Hein wrote: > The situation is this: > * fcitx has its own UI frontend > * ibus has its own UI frontend > * plasma-desktop contains kimpanel, which can act as UI frontend for > either fcitx or ibus > > From the Plasma, POV we care most about kimpanel. kimpanel currently > shows the icons provided/requested by the IME. So if fcitx is used as > backend, it will show your icons. But it won't when using the ibus backend, > since ibus uses different icon names. > > My goal is to raise the visual quality level of the entire ecosystem - > many distros currently default to ibus, and when Plasma is started in a > locale that needs one, it will automatically add impanel to the panel as IME > frontend. Due to the lack of icons, that means CJK is currently > ugly-by-default for many users. > > So my proposed way to fix this would be: > * Agree on generic icon names (e.g. ime-zh-sunpinyin) > * Ask fcitx and ibus to switch to using the generic icon names > * For a transitional period, also provide the icons under legacy > fcitx/ibus names Sorry, RB fucked up my bullet lists. Fixed: The situation is this: * fcitx has its own UI frontend * ibus has its own UI frontend * plasma-desktop contains kimpanel, which can act as UI frontend for either fcitx or ibus >From the Plasma, POV we care most about kimpanel. kimpanel currently shows the >icons provided/requested by the IME. So if fcitx is used as backend, it will >show your icons. But it won't when using the ibus backend, since ibus uses >different icon names. My goal is to raise the visual quality level of the entire ecosystem - many distros currently default to ibus, and when Plasma is started in a locale that needs one, it will automatically add impanel to the panel as IME frontend. Due to the lack of icons, that means CJK is currently ugly-by-default for many users. So my proposed way to fix this would be: * Agree on generic icon names (e.g. ime-zh-sunpinyin) * Ask fcitx and ibus to switch to using the generic icon names * For a transitional period, also provide the icons under legacy fcitx/ibus names - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review99774 --- On Oct. 4, 2016, 4:38 p.m., Yunhe Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129091/ > --- > > (Updated Oct. 4, 2016, 4:38 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > This patch adds icons for Fcitx system tray icon. Fcitx is the default input > method framework in most Chinese GNU/Linux desktop system. These icons will > make Fcitx looks better in system tray. > > Icons included: > > input.svgz > > - input-keyboard > > fcitx.svgz > > - fcitx > - fcitx-kbd > - fcitx-pinyin > - fcitx-shuangpin > - fcitx-wubi > - fcitx-pinyin-libpinyin > - fcitx-shuangpin-libpinyin > - fcitx-bopomofo > - fcitx-sunpinyin > - fcitx-googlepinyin > - fcitx-emoji > > > Diffs > - > >
Re: Review Request 129091: Add icons for Fcitx
> On Oct. 4, 2016, 3:56 p.m., Eike Hein wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > > language code so they can also be used by kimpanel (which in turn can use > > fcitx or ibus or scim)? Do you really need different icons for each IME > > engine instead of just per language? > > > > Having icons for specific fcitx plugins upstream seems like bad layering. > > Yunhe Guo wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > language code so they can also be used by kimpanel (which in turn can use > fcitx or ibus or scim)? > > Having icons for specific fcitx plugins upstream seems like bad > layering. > > I just use the same icon name in original Fcitx icons. These icons were > tested with Fcitx classic UI, not Kimpanel. But as far as I know, **kimpanel > is just a part of Fcitx project**. So here is no "fcitx plugin" problem. What > icons that Fcitx uses is always what kimpanel uses. So these icons will > provide same support to ibus and scim if they use kimpanel as UI (by default, > not). > > > Do you really need different icons for each IME engine instead of just > per language? > > Those Chinese IMEs are totally different. It is impossible to use only > one icon for all without confusing users. > > Xuetian Weng wrote: > Can you separate the request into two different ones? input-keyboard > addition is quite generic. while the im icon is input method specific. > > Yunhe Guo wrote: > Now input-keyboard in another patch > https://git.reviewboard.kde.org/r/129098/ The situation is this: * fcitx has its own UI frontend * ibus has its own UI frontend * plasma-desktop contains kimpanel, which can act as UI frontend for either fcitx or ibus >From the Plasma, POV we care most about kimpanel. kimpanel currently shows the >icons provided/requested by the IME. So if fcitx is used as backend, it will >show your icons. But it won't when using the ibus backend, since ibus uses >different icon names. My goal is to raise the visual quality level of the entire ecosystem - many distros currently default to ibus, and when Plasma is started in a locale that needs one, it will automatically add impanel to the panel as IME frontend. Due to the lack of icons, that means CJK is currently ugly-by-default for many users. So my proposed way to fix this would be: * Agree on generic icon names (e.g. ime-zh-sunpinyin) * Ask fcitx and ibus to switch to using the generic icon names * For a transitional period, also provide the icons under legacy fcitx/ibus names - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review99774 --- On Oct. 4, 2016, 4:38 p.m., Yunhe Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129091/ > --- > > (Updated Oct. 4, 2016, 4:38 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > This patch adds icons for Fcitx system tray icon. Fcitx is the default input > method framework in most Chinese GNU/Linux desktop system. These icons will > make Fcitx looks better in system tray. > > Icons included: > > input.svgz > > - input-keyboard > > fcitx.svgz > > - fcitx > - fcitx-kbd > - fcitx-pinyin > - fcitx-shuangpin > - fcitx-wubi > - fcitx-pinyin-libpinyin > - fcitx-shuangpin-libpinyin > - fcitx-bopomofo > - fcitx-sunpinyin > - fcitx-googlepinyin > - fcitx-emoji > > > Diffs > - > > src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129091/diff/ > > > Testing > --- > > > File Attachments > > > Spectacle.Et8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png > Spectacle.AD8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png > > > Thanks, > > Yunhe Guo > >
Re: Review Request 129091: Add icons for Fcitx
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/ --- (Updated 十月 4, 2016, 4:38 p.m.) Review request for Plasma. Changes --- Update only Fcitx icons in this patch Repository: plasma-framework Description --- This patch adds icons for Fcitx system tray icon. Fcitx is the default input method framework in most Chinese GNU/Linux desktop system. These icons will make Fcitx looks better in system tray. Icons included: input.svgz - input-keyboard fcitx.svgz - fcitx - fcitx-kbd - fcitx-pinyin - fcitx-shuangpin - fcitx-wubi - fcitx-pinyin-libpinyin - fcitx-shuangpin-libpinyin - fcitx-bopomofo - fcitx-sunpinyin - fcitx-googlepinyin - fcitx-emoji Diffs (updated) - src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129091/diff/ Testing --- File Attachments Spectacle.Et8101.png https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png Spectacle.AD8101.png https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png Thanks, Yunhe Guo
Re: Review Request 129091: Add icons for Fcitx
> On Oct. 4, 2016, 3:56 p.m., Eike Hein wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > > language code so they can also be used by kimpanel (which in turn can use > > fcitx or ibus or scim)? Do you really need different icons for each IME > > engine instead of just per language? > > > > Having icons for specific fcitx plugins upstream seems like bad layering. > > Yunhe Guo wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > language code so they can also be used by kimpanel (which in turn can use > fcitx or ibus or scim)? > > Having icons for specific fcitx plugins upstream seems like bad > layering. > > I just use the same icon name in original Fcitx icons. These icons were > tested with Fcitx classic UI, not Kimpanel. But as far as I know, **kimpanel > is just a part of Fcitx project**. So here is no "fcitx plugin" problem. What > icons that Fcitx uses is always what kimpanel uses. So these icons will > provide same support to ibus and scim if they use kimpanel as UI (by default, > not). > > > Do you really need different icons for each IME engine instead of just > per language? > > Those Chinese IMEs are totally different. It is impossible to use only > one icon for all without confusing users. Can you separate the request into two different ones? input-keyboard addition is quite generic. while the im icon is input method specific. - Xuetian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review99774 --- On Oct. 3, 2016, 6:18 p.m., Yunhe Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129091/ > --- > > (Updated Oct. 3, 2016, 6:18 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > This patch adds icons for Fcitx system tray icon. Fcitx is the default input > method framework in most Chinese GNU/Linux desktop system. These icons will > make Fcitx looks better in system tray. > > Icons included: > > input.svgz > > - input-keyboard > > fcitx.svgz > > - fcitx > - fcitx-kbd > - fcitx-pinyin > - fcitx-shuangpin > - fcitx-wubi > - fcitx-pinyin-libpinyin > - fcitx-shuangpin-libpinyin > - fcitx-bopomofo > - fcitx-sunpinyin > - fcitx-googlepinyin > - fcitx-emoji > > > Diffs > - > > src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION > src/desktoptheme/breeze/icons/input.svgz > ef7ba12c12427d2171ad31ebe5886c9665e4cdf0 > > Diff: https://git.reviewboard.kde.org/r/129091/diff/ > > > Testing > --- > > > File Attachments > > > Spectacle.Et8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png > Spectacle.AD8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png > > > Thanks, > > Yunhe Guo > >
Re: Review Request 129091: Add icons for Fcitx
> On 十月 4, 2016, 3:56 p.m., Eike Hein wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > > language code so they can also be used by kimpanel (which in turn can use > > fcitx or ibus or scim)? Do you really need different icons for each IME > > engine instead of just per language? > > > > Having icons for specific fcitx plugins upstream seems like bad layering. > Instead of using fcitx-, would it be possible to make generic icons per > language code so they can also be used by kimpanel (which in turn can use > fcitx or ibus or scim)? > Having icons for specific fcitx plugins upstream seems like bad layering. I just use the same icon name in original Fcitx icons. These icons were tested with Fcitx classic UI, not Kimpanel. But as far as I know, **kimpanel is just a part of Fcitx project**. So here is no "fcitx plugin" problem. What icons that Fcitx uses is always what kimpanel uses. So these icons will provide same support to ibus and scim if they use kimpanel as UI (by default, not). > Do you really need different icons for each IME engine instead of just per > language? Those Chinese IMEs are totally different. It is impossible to use only one icon for all without confusing users. - Yunhe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review99774 --- On 十月 3, 2016, 6:18 p.m., Yunhe Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129091/ > --- > > (Updated 十月 3, 2016, 6:18 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > This patch adds icons for Fcitx system tray icon. Fcitx is the default input > method framework in most Chinese GNU/Linux desktop system. These icons will > make Fcitx looks better in system tray. > > Icons included: > > input.svgz > > - input-keyboard > > fcitx.svgz > > - fcitx > - fcitx-kbd > - fcitx-pinyin > - fcitx-shuangpin > - fcitx-wubi > - fcitx-pinyin-libpinyin > - fcitx-shuangpin-libpinyin > - fcitx-bopomofo > - fcitx-sunpinyin > - fcitx-googlepinyin > - fcitx-emoji > > > Diffs > - > > src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION > src/desktoptheme/breeze/icons/input.svgz > ef7ba12c12427d2171ad31ebe5886c9665e4cdf0 > > Diff: https://git.reviewboard.kde.org/r/129091/diff/ > > > Testing > --- > > > File Attachments > > > Spectacle.Et8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png > Spectacle.AD8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png > > > Thanks, > > Yunhe Guo > >
Re: Review Request 129091: Add icons for Fcitx
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review99774 --- Instead of using fcitx-, would it be possible to make generic icons per language code so they can also be used by kimpanel (which in turn can use fcitx or ibus or scim)? Do you really need different icons for each IME engine instead of just per language? Having icons for specific fcitx plugins upstream seems like bad layering. - Eike Hein On Oct. 3, 2016, 6:18 p.m., Yunhe Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129091/ > --- > > (Updated Oct. 3, 2016, 6:18 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > This patch adds icons for Fcitx system tray icon. Fcitx is the default input > method framework in most Chinese GNU/Linux desktop system. These icons will > make Fcitx looks better in system tray. > > Icons included: > > input.svgz > > - input-keyboard > > fcitx.svgz > > - fcitx > - fcitx-kbd > - fcitx-pinyin > - fcitx-shuangpin > - fcitx-wubi > - fcitx-pinyin-libpinyin > - fcitx-shuangpin-libpinyin > - fcitx-bopomofo > - fcitx-sunpinyin > - fcitx-googlepinyin > - fcitx-emoji > > > Diffs > - > > src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION > src/desktoptheme/breeze/icons/input.svgz > ef7ba12c12427d2171ad31ebe5886c9665e4cdf0 > > Diff: https://git.reviewboard.kde.org/r/129091/diff/ > > > Testing > --- > > > File Attachments > > > Spectacle.Et8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png > Spectacle.AD8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png > > > Thanks, > > Yunhe Guo > >
