Re: Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/
---

(Updated Oct. 17, 2016, 3:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit f82d76eb2b915d5097f41a22a9f218e0bb23bb03 by David 
Edmundson on behalf of Alberto Curro to branch master.


Repository: plasma-framework


Description
---

Being a newbie, following build instruction from the wiki, I could not build 
plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).

Two of the changes are coding issues.

The change in CMakeLists.txt comes from a wrong required version, also stated 
here: https://git.reviewboard.kde.org/r/128763/. 

For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.


Diffs
-

  src/declarativeimports/core/windowthumbnail.cpp 0453c09 

Diff: https://git.reviewboard.kde.org/r/129203/diff/


Testing
---

Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial


Thanks,

Alberto Curro

Re: Review Request 129203: Fixes for building plasma-framework

[Marco Martin]

> On Oct. 17, 2016, 10:20 a.m., David Edmundson wrote:
> > Do you have commit access?
> 
> Alberto Curro wrote:
> I don't think so, it's my first patch and I'm newbie to the KDE 
> development team :)

you a re welcome to get one
https://community.kde.org/Infrastructure/Get_a_Developer_Account


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100077
---


On Oct. 17, 2016, 2:53 p.m., Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Oct. 17, 2016, 2:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

Re: Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

> On Oct. 17, 2016, 10:20 a.m., David Edmundson wrote:
> > Do you have commit access?

I don't think so, it's my first patch and I'm newbie to the KDE development 
team :)


- Alberto


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100077
---


On Oct. 17, 2016, 2:53 p.m., Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Oct. 17, 2016, 2:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

Re: Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/
---

(Updated Oct. 17, 2016, 2:53 p.m.)


Review request for Plasma.


Changes
---

Updated the selection of right RenderStage depending on version of Qt available.


Repository: plasma-framework


Description
---

Being a newbie, following build instruction from the wiki, I could not build 
plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).

Two of the changes are coding issues.

The change in CMakeLists.txt comes from a wrong required version, also stated 
here: https://git.reviewboard.kde.org/r/128763/. 

For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.


Diffs (updated)
-

  src/declarativeimports/core/windowthumbnail.cpp 0453c09 

Diff: https://git.reviewboard.kde.org/r/129203/diff/


Testing
---

Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial


Thanks,

Alberto Curro

Re: Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

> On Oct. 17, 2016, 8:37 a.m., David Edmundson wrote:
> > src/declarativeimports/core/windowthumbnail.cpp, line 231
> > 
> >
> > FWIW: https://git.reviewboard.kde.org/r/129065/

I've changed the code, given a comment in your own review, to choose the right 
RenderStage based on the version of Qt available. Please check the updated 
patch.


- Alberto


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100069
---


On Oct. 17, 2016, 7:35 a.m., Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Oct. 17, 2016, 7:35 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
>   src/plasmaquick/dialog.cpp eac9ee5 
>   src/plasmaquick/dialogshadows.cpp eb67926 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

Re: Review Request 129203: Fixes for building plasma-framework

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100077
---


Ship it!




Do you have commit access?

- David Edmundson


On Oct. 17, 2016, 7:35 a.m., Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Oct. 17, 2016, 7:35 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
>   src/plasmaquick/dialog.cpp eac9ee5 
>   src/plasmaquick/dialogshadows.cpp eb67926 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

Re: Review Request 129203: Fixes for building plasma-framework

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100069
---




src/declarativeimports/core/windowthumbnail.cpp (line 231)


FWIW: https://git.reviewboard.kde.org/r/129065/


- David Edmundson


On Oct. 17, 2016, 7:35 a.m., Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Oct. 17, 2016, 7:35 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
>   src/plasmaquick/dialog.cpp eac9ee5 
>   src/plasmaquick/dialogshadows.cpp eb67926 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

Re: Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

> On Oct. 17, 2016, 4:51 a.m., Anthony Fieroni wrote:
> > CMakeLists.txt, line 47
> > 
> >
> > You can't increase minimum deps only for this framework. It's done 
> > automatically for all and when it's needed. Just try this patch 
> > https://git.reviewboard.kde.org/r/129065/ give 'ship it' if works correctly

I see, the original patch was not enough, there are 2 usings of 
QQuickWindow::NoStage, so I've updated the patch.


- Alberto


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100058
---


On Oct. 17, 2016, 1:37 a.m., Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Oct. 17, 2016, 1:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3c0eaee 
>   src/plasmaquick/dialog.cpp eac9ee5 
>   src/plasmaquick/dialogshadows.cpp eb67926 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

Re: Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/
---

(Updated Oct. 17, 2016, 7:35 a.m.)


Review request for Plasma.


Changes
---

Drop changing the Qt Requirement for the framework, applied an extended patch 
based on another review


Repository: plasma-framework


Description
---

Being a newbie, following build instruction from the wiki, I could not build 
plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).

Two of the changes are coding issues.

The change in CMakeLists.txt comes from a wrong required version, also stated 
here: https://git.reviewboard.kde.org/r/128763/. 

For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.


Diffs (updated)
-

  src/declarativeimports/core/windowthumbnail.cpp 0453c09 
  src/plasmaquick/dialog.cpp eac9ee5 
  src/plasmaquick/dialogshadows.cpp eb67926 

Diff: https://git.reviewboard.kde.org/r/129203/diff/


Testing
---

Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial


Thanks,

Alberto Curro

Re: Review Request 129203: Fixes for building plasma-framework

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100058
---




CMakeLists.txt (line 47)


You can't increase minimum deps only for this framework. It's done 
automatically for all and when it's needed. Just try this patch 
https://git.reviewboard.kde.org/r/129065/ give 'ship it' if works correctly


- Anthony Fieroni


On Окт. 17, 2016, 4:37 преди обяд, Alberto Curro wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> ---
> 
> (Updated Окт. 17, 2016, 4:37 преди обяд)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Being a newbie, following build instruction from the wiki, I could not build 
> plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated 
> here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** 
> defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3c0eaee 
>   src/plasmaquick/dialog.cpp eac9ee5 
>   src/plasmaquick/dialogshadows.cpp eb67926 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> ---
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: 
> https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>