Re: Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
I understand and I agree with you. So I leave this work to someone more skilled by me. I'm still a newbie kde programmer. I'll close the review request. Cheers 2011/12/28 Sebastian Kügler : > On Tuesday, December 27, 2011 20:00:12 Simone Gaiarin wrote: >> Summarizing: >> 1)No redundant configuration interface should be added. >> 2)Only cycle through active activity is fine, but the dbus interface > > I still don't like this behaviour, as, even with a tooltip, it's still kind of > hidden. A more explicit behaviour would be nicer. > >> should provide a method to get the list of active activity to simplify >> the work, or it will be necessary to make a dbus call for every >> activity to check if it is active. But what is the sense of active or >> unactive activity? >> 3)The tooltip popup of the widget now says: "Click to show the >> activity manager". We can add a description like: "Scroll to switch >> activity." >> With this two changes who do not use activities can't do any mista >> since the widget does not do anything even if he scroll over it. >> Instead the activity aware user can know how the widget work from the >> tooltip. >> 4)Later, as a final improvement an osd with the activity name can be added. > > This is really what should be done, maybe like a kwin VD switching effect? > >> What do you think? > > I'm not a great fan of pushing in the wheel-switches-activity, this should be > improved in the correct way right away. We're so far away from feature freeze > (4.9) that we don't really need a quick thing in. > > Cheers, > -- > sebas > > http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
On Tuesday, December 27, 2011 20:00:12 Simone Gaiarin wrote: > Summarizing: > 1)No redundant configuration interface should be added. > 2)Only cycle through active activity is fine, but the dbus interface I still don't like this behaviour, as, even with a tooltip, it's still kind of hidden. A more explicit behaviour would be nicer. > should provide a method to get the list of active activity to simplify > the work, or it will be necessary to make a dbus call for every > activity to check if it is active. But what is the sense of active or > unactive activity? > 3)The tooltip popup of the widget now says: "Click to show the > activity manager". We can add a description like: "Scroll to switch > activity." > With this two changes who do not use activities can't do any mista > since the widget does not do anything even if he scroll over it. > Instead the activity aware user can know how the widget work from the > tooltip. > 4)Later, as a final improvement an osd with the activity name can be added. This is really what should be done, maybe like a kwin VD switching effect? > What do you think? I'm not a great fan of pushing in the wheel-switches-activity, this should be improved in the correct way right away. We're so far away from feature freeze (4.9) that we don't really need a quick thing in. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Re: Re: Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
Le mardi 27 décembre 2011 22:09:33 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= a écrit : > On Tuesday 27 December 2011 21:49:24 Guillaume DE BURE wrote: > > I use the keyboard shortcut (meta + tab) quite often. However I remember > > once someone (maybe, marco ?) proposed an "exposé like" effect, with > > activities as rows, and desktop as columns. That could be extremely useful, > > especially for dragging windows between desktop / activities. Does that > > still sound like a good idea ? Would it be difficult to do ? > There is one problem with that: when an activity is closed we do not know > which windows are there. If an activity is suspended we most likely due not > have a pixmap for this window as the driver discarded it for the long time > unmapped window. So unless someone has a genious idea how to get thumbnails of > non existing windows, it will be difficult to implement :-) Thought this was just relevant for running activities... But maybe you could start activities from there also ? No sure you would need preview for non running activities, that might just confuse the user, no ? > > (The genious idea might be as simple as storing screenshots from the window > when it got closed, activity switched, whatever. 4.9 will hopefully see nice > QML bindings in KWin, so that might be implementable. Help welcome) > > Cheers > Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Re: Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
On Tuesday 27 December 2011 21:49:24 Guillaume DE BURE wrote: > I use the keyboard shortcut (meta + tab) quite often. However I remember > once someone (maybe, marco ?) proposed an "exposé like" effect, with > activities as rows, and desktop as columns. That could be extremely useful, > especially for dragging windows between desktop / activities. Does that > still sound like a good idea ? Would it be difficult to do ? There is one problem with that: when an activity is closed we do not know which windows are there. If an activity is suspended we most likely due not have a pixmap for this window as the driver discarded it for the long time unmapped window. So unless someone has a genious idea how to get thumbnails of non existing windows, it will be difficult to implement :-) (The genious idea might be as simple as storing screenshots from the window when it got closed, activity switched, whatever. 4.9 will hopefully see nice QML bindings in KWin, so that might be implementable. Help welcome) Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
Le mardi 27 décembre 2011 15:58:31 Sebastian =?ISO-8859-1?Q?K=FCgler?= a écrit : > On Tuesday, December 27, 2011 14:11:34 Marco Martin wrote: > > On Tuesday 27 December 2011, Simone Gaiarin wrote: > > > To fix the two problem it is just necessary to add a configuration > > > dialog to the plasmoid in a such way that the user must intentionally > > > enable this feature before use it. What do you think about this > > > solution? I'll work on it. > > > > no, adding a configuration option for every potentially problematic feature > > is a too easy shortcut that has been done too much in the past, and is a > > thing we are finally manage to get out of. > > > > as i said, a solution can be a combination of: > > a) make the activity switching way more intuitive, with animations, an osd > > that says the activity name for an instant, in any case something obvious > > b) only cycle troucg runnung activities (and by default there is only one > > running activity) so if someone never seen them/doesn't use them, doesn't > > get anything with the mouse wheel > > > > this may or may not be intuitive enough, but is important to avoid the > > shortcut of "just throwing another configuration option in" > > One could also make it a hover interface, a bit like opening a QMenu while the > mouse is over that button (but not directly underneath it, as that makes > interaction harder). Or maybe fold the button out to a list of activities when > clicked (a bit like the devicenotifier does it). > > One of the problems I see is that the Activity Switcher still feels a bit too > modal, the switcher is also in my normal usage often at least half a screen > away from my mouse, and in the case of the toolbox, even across the entire > screen. The activity switcher in the panel has a much better position. I use the keyboard shortcut (meta + tab) quite often. However I remember once someone (maybe, marco ?) proposed an "exposé like" effect, with activities as rows, and desktop as columns. That could be extremely useful, especially for dragging windows between desktop / activities. Does that still sound like a good idea ? Would it be difficult to do ? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
Summarizing: 1)No redundant configuration interface should be added. 2)Only cycle through active activity is fine, but the dbus interface should provide a method to get the list of active activity to simplify the work, or it will be necessary to make a dbus call for every activity to check if it is active. But what is the sense of active or unactive activity? 3)The tooltip popup of the widget now says: "Click to show the activity manager". We can add a description like: "Scroll to switch activity." With this two changes who do not use activities can't do any mista since the widget does not do anything even if he scroll over it. Instead the activity aware user can know how the widget work from the tooltip. 4)Later, as a final improvement an osd with the activity name can be added. What do you think? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
On Tuesday, December 27, 2011 14:11:34 Marco Martin wrote: > On Tuesday 27 December 2011, Simone Gaiarin wrote: > > To fix the two problem it is just necessary to add a configuration > > dialog to the plasmoid in a such way that the user must intentionally > > enable this feature before use it. What do you think about this > > solution? I'll work on it. > > no, adding a configuration option for every potentially problematic feature > is a too easy shortcut that has been done too much in the past, and is a > thing we are finally manage to get out of. > > as i said, a solution can be a combination of: > a) make the activity switching way more intuitive, with animations, an osd > that says the activity name for an instant, in any case something obvious > b) only cycle troucg runnung activities (and by default there is only one > running activity) so if someone never seen them/doesn't use them, doesn't > get anything with the mouse wheel > > this may or may not be intuitive enough, but is important to avoid the > shortcut of "just throwing another configuration option in" One could also make it a hover interface, a bit like opening a QMenu while the mouse is over that button (but not directly underneath it, as that makes interaction harder). Or maybe fold the button out to a list of activities when clicked (a bit like the devicenotifier does it). One of the problems I see is that the Activity Switcher still feels a bit too modal, the switcher is also in my normal usage often at least half a screen away from my mouse, and in the case of the toolbox, even across the entire screen. The activity switcher in the panel has a much better position. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
On Tuesday 27 December 2011, Simone Gaiarin wrote: > To fix the two problem it is just necessary to add a configuration > dialog to the plasmoid in a such way that the user must intentionally > enable this feature before use it. What do you think about this > solution? I'll work on it. no, adding a configuration option for every potentially problematic feature is a too easy shortcut that has been done too much in the past, and is a thing we are finally manage to get out of. as i said, a solution can be a combination of: a) make the activity switching way more intuitive, with animations, an osd that says the activity name for an instant, in any case something obvious b) only cycle troucg runnung activities (and by default there is only one running activity) so if someone never seen them/doesn't use them, doesn't get anything with the mouse wheel this may or may not be intuitive enough, but is important to avoid the shortcut of "just throwing another configuration option in" Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
To fix the two problem it is just necessary to add a configuration dialog to the plasmoid in a such way that the user must intentionally enable this feature before use it. What do you think about this solution? I'll work on it. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
On Tuesday 27 December 2011, Sebastian Kügler wrote: > I think that this change is problematic from an interaction point of view, > it seems very easy to accidentally trigger, and in that case all windows > are gone, the desktop changes completely, and users who triggered this > feature unaware of it will likely be very confused and think they've just > broken their system. It's also not discoverable, making it hard to find > even for those that would understand it. > > Not sure how to address those, maybe you have an idea? looks like we really need a cute activity switching kwin effect :p -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
Hi Simone, Thanks for your patch to the activity switcher. Making pieces of the UI easier to use is always welcome. I thought a bit about your patch, though, and I see two problems with it as it is right now. On Monday, December 26, 2011 23:45:58 Simone Gaiarin wrote: > Rolling the mouse wheel over the showActivityManager change the current > activity. In this way it's not necessary to open the activities menu, > select the activity and close the menu and the activity change is faster. I think that this change is problematic from an interaction point of view, it seems very easy to accidentally trigger, and in that case all windows are gone, the desktop changes completely, and users who triggered this feature unaware of it will likely be very confused and think they've just broken their system. It's also not discoverable, making it hard to find even for those that would understand it. Not sure how to address those, maybe you have an idea? Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103548/ --- (Updated Dec. 26, 2011, 10:46 p.m.) Review request for Plasma and Aaron J. Seigo. Description --- Rolling the mouse wheel over the showActivityManager change the current activity. In this way it's not necessary to open the activities menu, select the activity and close the menu and the activity change is faster. Diffs - plasma/desktop/applets/showActivityManager/showActivityManager.h f58fbb71a633f7f2ee3185650a9a7cbb083ec955 plasma/desktop/applets/showActivityManager/showActivityManager.cpp e77df0d82c64562390fc922105cd3aea9af138a2 Diff: http://git.reviewboard.kde.org/r/103548/diff/diff Testing --- The plasmoid works fine after the patch. Thanks, Simone Gaiarin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Change activity by rolling the mouse wheel over the showActivityManager widget.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103548/ --- Review request for Plasma and Aaron J. Seigo. Description --- Rolling the mouse wheel over the showActivityManager change the current activity. In this way it's not necessary to open the activities menu, select the activity and close the menu and the activity change is faster. Diffs - plasma/desktop/applets/showActivityManager/showActivityManager.h f58fbb71a633f7f2ee3185650a9a7cbb083ec955 plasma/desktop/applets/showActivityManager/showActivityManager.cpp e77df0d82c64562390fc922105cd3aea9af138a2 Diff: http://git.reviewboard.kde.org/r/103548/diff/diff Testing --- The plasmoid works fine after the patch. Thanks, Simone Gaiarin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
