Re: Review Request 119794: Add button to change keyboard layout in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/#review65281 --- Ship it! Close 338518 when you submit this. - David Edmundson On Aug. 25, 2014, 1:43 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 25, 2014, 1:43 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs - ksmserver/screenlocker/greeter/CMakeLists.txt 4837017 ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119794: Add button to change keyboard layout in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 26, 2014, 2:44 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs - ksmserver/screenlocker/greeter/CMakeLists.txt 4837017 ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119794: Add button to change keyboard layout in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 25, 2014, 3:43 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs (updated) - ksmserver/screenlocker/greeter/CMakeLists.txt 4837017 ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119794: Add button to change keyboard layout in the lockscreen
On Aug. 16, 2014, 1:58 p.m., Emmanuel Pescosta wrote: lookandfeel/contents/components/KeyboardLayout.qml, line 28 https://git.reviewboard.kde.org/r/119794/diff/2/?file=305631#file305631line28 really?! ;) Ooops, copy paste :) On Aug. 16, 2014, 1:58 p.m., Emmanuel Pescosta wrote: lookandfeel/contents/components/KeyboardLayout.qml, line 47 https://git.reviewboard.kde.org/r/119794/diff/2/?file=305631#file305631line47 Maybe a simple modulo operation instead of this check? This seems a bit easier to understand and a is I'd say more common solution for is this the last item in the list check - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/#review64630 --- On Aug. 14, 2014, 11:40 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 14, 2014, 11:40 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs - ksmserver/screenlocker/greeter/CMakeLists.txt 7ac1846 ksmserver/screenlocker/greeter/greeterapp.cpp 3af10ef ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119794: Add button to change keyboard layout in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/#review64630 --- lookandfeel/contents/components/KeyboardLayout.qml https://git.reviewboard.kde.org/r/119794/#comment45199 really?! ;) lookandfeel/contents/components/KeyboardLayout.qml https://git.reviewboard.kde.org/r/119794/#comment45200 Maybe a simple modulo operation instead of this check? - Emmanuel Pescosta On Aug. 14, 2014, 11:40 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 14, 2014, 11:40 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs - ksmserver/screenlocker/greeter/CMakeLists.txt 7ac1846 ksmserver/screenlocker/greeter/greeterapp.cpp 3af10ef ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119794: Add button to change keyboard layout in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs - ksmserver/screenlocker/greeter/CMakeLists.txt 7ac1846 ksmserver/screenlocker/greeter/greeterapp.cpp 3af10ef ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119794: Add button to change keyboard layout in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/#review64575 --- We probably don't want to show this if there is only one layout. Maybe check available list 1 before setting valid to true. ksmserver/screenlocker/greeter/keyboardlayout.h https://git.reviewboard.kde.org/r/119794/#comment45127 why is this mutable? ksmserver/screenlocker/greeter/keyboardlayout.cpp https://git.reviewboard.kde.org/r/119794/#comment45121 this is blocking :( ksmserver/screenlocker/greeter/keyboardlayout.cpp https://git.reviewboard.kde.org/r/119794/#comment45124 Needs a category so we know what has no such layout ksmserver/screenlocker/greeter/keyboardlayout.cpp https://git.reviewboard.kde.org/r/119794/#comment45125 I'd do this only when get the signal that the layout has actually changed. (i.e don't re-use one function for setting from QML and when it's been set externally) ksmserver/screenlocker/greeter/keyboardlayout.cpp https://git.reviewboard.kde.org/r/119794/#comment45123 blocking. ksmserver/screenlocker/greeter/keyboardlayout.cpp https://git.reviewboard.kde.org/r/119794/#comment45122 This is blocking lookandfeel/contents/lockscreen/LockScreen.qml https://git.reviewboard.kde.org/r/119794/#comment45126 anchors inside a RowLayout isn't needed. - David Edmundson On Aug. 14, 2014, 8:50 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 14, 2014, 8:50 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs - ksmserver/screenlocker/greeter/CMakeLists.txt 7ac1846 ksmserver/screenlocker/greeter/greeterapp.cpp 3af10ef ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119794: Add button to change keyboard layout in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 14, 2014, 11:40 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This adds a button that allows toggling keyboard layout from the lockscreen. It talks and listens directly to the KDED's keyboard module. Diffs (updated) - ksmserver/screenlocker/greeter/CMakeLists.txt 7ac1846 ksmserver/screenlocker/greeter/greeterapp.cpp 3af10ef ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments (updated) https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
