Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-12-28 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Dec. 28, 2015, 2:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Changes
---

Submitted with commit cf570eb71014e517c91f718c02a48b7afaa96418 by Aditya Dev 
Sharma to branch master.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList.

After the image is fetched, gotImage emits the signal imageFetched (from 
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.


Diffs
-

  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/CMakeLists.txt 5a13449 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/CMakeLists.txt a7171b7 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Builds 100%.
Works as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-12-23 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Dec. 23, 2015, 9:20 a.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Changes
---

Minor changes in renaming stuff


Repository: plasma-mediacenter


Description (updated)
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList.

After the image is fetched, gotImage emits the signal imageFetched (from 
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.


Diffs (updated)
-

  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/CMakeLists.txt 5a13449 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/CMakeLists.txt a7171b7 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Builds 100%.
Works as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-12-22 Thread Ashish Bansal 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review89948
---

Ship it!



libs/mediacenter/lastfmimagefetcher.cpp (line 172)


Use QTimer:singleShot(0, your_slot) instead for better response and remove 
runSignal.



libs/mediacenter/lastfmimagefetcher.cpp (line 176)


May be LastFmImageFetcher::setupImageFetcher ?



libs/mediacenter/medialibrary.h (line 59)


mediaUpdated still sounds wrong, although I am not sure what it should be 
named. Anyway replace it with more logically correct name.


- Ashish Bansal


On Dec. 21, 2015, 2:51 p.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> ---
> 
> (Updated Dec. 21, 2015, 2:51 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented it like the other datasources.
> 
> Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
> handleLastFmNewMedia then calls fetchImage for each newMedia in the 
> newMediaList.
> 
> After the image is fetched, gotImage emits the signal mediaUpdated (from 
> mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/medialibrary.h 45744c1 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> ---
> 
> Builds 100%.
> Works as expected.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-12-21 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Dec. 21, 2015, 2:51 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Changes
---

Everything works fine.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList.

After the image is fetched, gotImage emits the signal mediaUpdated (from 
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing (updated)
---

Builds 100%.
Works as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-12-21 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Dec. 21, 2015, 8:39 a.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList.

After the image is fetched, gotImage emits the signal mediaUpdated (from 
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.


Diffs (updated)
-

  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/CMakeLists.txt 5a13449 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/CMakeLists.txt a7171b7 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/CMakeLists.txt 04ba1c3 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing (updated)
---

Builds 100%.
The Audio Scrobbler API works as expected. Images are fetched.
Problem: The fetched images are not displayed on the app UI however.
NOTE: This is just for testing purposes. Hence kept the comments and debugs.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-26 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 27, 2015, 7:05 a.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList.

After the image is fetched, gotImage emits the signal mediaUpdated (from 
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.


Diffs (updated)
-

  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing (updated)
---

Builds 100%.
Audio Scrobbler doesn't seem to work which I'll fix.
Am working on fixing those thumbnails and ~/.cache 
Fixed the QThread LastfmImageFetcher Warning.
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-25 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 25, 2015, 4:31 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList.

After the image is fetched, gotImage emits the signal mediaUpdated (from 
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.


Diffs
-

  datasources/CMakeLists.txt a7171b7 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing (updated)
---

Builds 100%.
Am working on fixing those thumbnails and ~/.cache 
Fixed the QThread LastfmImageFetcher Warning.
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-25 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 25, 2015, 4:30 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList.

After the image is fetched, gotImage emits the signal mediaUpdated (from 
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.


Diffs (updated)
-

  datasources/CMakeLists.txt a7171b7 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Builds 100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this. 
Fixed the QThread LastfmImageFetcher Warning.
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 23, 2015, 8:05 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Changes
---

Changes made as per Review.


Repository: plasma-mediacenter


Description (updated)
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList.

After the image is fetched, gotImage emits the signal mediaUpdated (from 
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing (updated)
---

Builds 100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this. 
Fixed the QThread LastfmImageFetcher Warning.
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review88715
---


Do the tests not work anymore? Just curious why were they removed.


libs/mediacenter/lastfmimagefetcher.cpp (line 155)


remove the extra whitespace


- Shantanu Tushar


On Nov. 22, 2015, 2:23 p.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> ---
> 
> (Updated Nov. 22, 2015, 2:23 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented it like the other datasources.
> 
> Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
> handleLastFmNewMedia then calls fetchImage for each newMedia in the 
> newMediaList. Created a QList for storing the new media.
> 
> After the image is fetched, gotImage emits the signal imageFetched (from 
> mediaLibrary) with the QList we created earlier. This signal is absorbed by 
> handleNewMedia in PmcMetaDataModel which does the rest.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/medialibrary.h 45744c1 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> ---
> 
> Builds 100%.
> However the audio scrobbler api doesn't seem to work which I'll fix after 
> this. 
> Also, I get the following Output : http://ix.io/mps
> Apart from it, all the datasources are loaded and media plays as expected.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 23, 2015, 1:50 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList. Created a QList for storing the new media.

After the image is fetched, gotImage emits the signal imageFetched (from 
mediaLibrary) with the QList we created earlier. This signal is absorbed by 
handleNewMedia in PmcMetaDataModel which does the rest.


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Builds 100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this. 
Also, I get the following Output : http://ix.io/mps
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Ashish Bansal 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review88730
---



libs/mediacenter/lastfmimagefetcher.cpp (line 152)


Remove trailing white spaces.



libs/mediacenter/lastfmimagefetcher.cpp (line 155)


newMediaList ? 
Haven't we got image for only one media file yet ?



libs/mediacenter/medialibrary.h (line 58)


Change it to :
void mediaUpdated(QSharedPointer);



libs/mediacenter/pmcmetadatamodel.cpp (line 85)


Isn't this gonna duplicate the media in the view ? Check 
PmcMetadataModel::signalUpdate



libs/mediacenter/pmcmetadatamodel.cpp (line 87)


Remove White space error.


- Ashish Bansal


On Nov. 23, 2015, 1:50 p.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> ---
> 
> (Updated Nov. 23, 2015, 1:50 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented it like the other datasources.
> 
> Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
> handleLastFmNewMedia then calls fetchImage for each newMedia in the 
> newMediaList. Created a QList for storing the new media.
> 
> After the image is fetched, gotImage emits the signal imageFetched (from 
> mediaLibrary) with the QList we created earlier. This signal is absorbed by 
> handleNewMedia in PmcMetaDataModel which does the rest.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/medialibrary.h 45744c1 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> ---
> 
> Builds 100%.
> However the audio scrobbler api doesn't seem to work which I'll fix after 
> this. 
> Also, I get the following Output : http://ix.io/mps
> Apart from it, all the datasources are loaded and media plays as expected.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-22 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 22, 2015, 2:19 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Changes
---

Minor changes in coding style


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList. Created a QList for storing the new media.

After the image is fetched, gotImage emits the signal imageFetched (from 
mediaLibrary) with the QList we created earlier. This signal is absorbed by 
handleNewMedia in PmcMetaDataModel which does the rest.


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Builds 100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this. 
Also, I get the following Output : http://ix.io/mps
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-22 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 22, 2015, 2:23 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList. Created a QList for storing the new media.

After the image is fetched, gotImage emits the signal imageFetched (from 
mediaLibrary) with the QList we created earlier. This signal is absorbed by 
handleNewMedia in PmcMetaDataModel which does the rest.


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Builds 100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this. 
Also, I get the following Output : http://ix.io/mps
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-22 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 22, 2015, 2:14 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Changes
---

Changed to the form : LastFmImageFetcher -> MediaLibrary -> PmcMetaDataModel


Repository: plasma-mediacenter


Description (updated)
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList. Created a QList for storing the new media.

After the image is fetched, gotImage emits the signal imageFetched (from 
mediaLibrary) with the QList we created earlier. This signal is absorbed by 
handleNewMedia in PmcMetaDataModel which does the rest.


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing (updated)
---

Builds 100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this. 
Also, I get the following Output : http://ix.io/mps
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-13 Thread Ashish Bansal 


> On Nov. 13, 2015, 9:23 a.m., Ashish Bansal wrote:
> > libs/mediacenter/lastfmimagefetcher.cpp, line 158
> > 
> >
> > As imageFetcher is a signal, append "emit" word in the beginning. 
> > Although it is an empty macro, but it helps in understanding code better.

Sorry, I wanted to say imageFetched, not imageFetcher.


- Ashish


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review88315
---


On Nov. 12, 2015, 7:21 p.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> ---
> 
> (Updated Nov. 12, 2015, 7:21 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented it like the other datasources.
> 
> Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
> handleLastFmNewMedia then calls fetchImage for each newMedia in the 
> newMediaList
> 
> Removed redundant imageFetched from LastFmImageFetcher
> gotImage calls the signal imageFetched in PmcImageCache which is again 
> connected to signalUpdate in PmcMetaDataModel
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/pmcimagecache.h 6399461 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> ---
> 
> Built and Tested.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-13 Thread Ashish Bansal 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review88315
---



libs/mediacenter/lastfmimagefetcher.cpp (line 156)


As imageFetcher is a signal, append "emit" word in the beginning. Although 
it is an empty macro, but it helps in understanding code better.


- Ashish Bansal


On Nov. 12, 2015, 7:21 p.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> ---
> 
> (Updated Nov. 12, 2015, 7:21 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented it like the other datasources.
> 
> Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
> handleLastFmNewMedia then calls fetchImage for each newMedia in the 
> newMediaList
> 
> Removed redundant imageFetched from LastFmImageFetcher
> gotImage calls the signal imageFetched in PmcImageCache which is again 
> connected to signalUpdate in PmcMetaDataModel
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/pmcimagecache.h 6399461 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> ---
> 
> Built and Tested.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-13 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 13, 2015, 9:27 a.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Changes
---

Minor changes in syntax


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList

Removed redundant imageFetched from LastFmImageFetcher
gotImage calls the signal imageFetched in PmcImageCache which is again 
connected to signalUpdate in PmcMetaDataModel


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/pmcimagecache.h 6399461 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Built and Tested.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-12 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 12, 2015, 7:21 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description (updated)
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList

Removed redundant imageFetched from LastFmImageFetcher
gotImage calls the signal imageFetched in PmcImageCache which is again 
connected to signalUpdate in PmcMetaDataModel


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/pmcimagecache.h 6399461 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Built and Tested.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-12 Thread Ashish Bansal 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review88301
---



libs/mediacenter/lastfmimagefetcher.cpp (line 46)


Use latest Qt5 Signal/Slot signal syntax.



libs/mediacenter/lastfmimagefetcher.cpp (line 47)


This statement seems to be redundant. If no one outside this class listens 
to this signal, then just remove it, or modify it and make PmcImageCache listen 
to it.



libs/mediacenter/pmcimagecache.cpp (line 100)


As this slot is just emitting another signal, you should remove it and emit 
signal directly in connect function.


- Ashish Bansal


On Nov. 12, 2015, 4:23 p.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> ---
> 
> (Updated Nov. 12, 2015, 4:23 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented it like the other datasources.
> 
> Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
> handleLastFmNewMedia then calls fetchImage for each newMedia in the 
> newMediaList
> 
> To update this info, the signal imageFetched is absorbed by 
> imageFetchedFromLastFm in PmcImageCache.
> Inside this imageFetchedFromLastFm, another signalImageFetchedFromLastFm is 
> emitted which is then absorbed by signalUpdate in PmcMetaDataModel
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/pmcimagecache.h 6399461 
>   libs/mediacenter/pmcimagecache.cpp fcfe2a8 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> ---
> 
> Built and Tested.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-12 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 12, 2015, 4:36 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description (updated)
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList

To update this info, the signal imageFetched is absorbed by 
imageFetchedFromLastFm in PmcImageCache.
Inside this imageFetchedFromLastFm, another signalImageFetchedFromLastFm is 
emitted which is then absorbed by signalUpdate in PmcMetaDataModel


Diffs
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/pmcimagecache.h 6399461 
  libs/mediacenter/pmcimagecache.cpp fcfe2a8 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Built and Tested.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-12 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 12, 2015, 4:23 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/pmcimagecache.h 6399461 
  libs/mediacenter/pmcimagecache.cpp fcfe2a8 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Built and Tested.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-08 Thread Bhushan Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review88159
---



datasources/lastfm/CMakeLists.txt (line 2)


You sure this builds? there is no datasources/lastfm/lastfmimagefetcher.cpp 
?


- Bhushan Shah


On Nov. 8, 2015, 6:02 p.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> ---
> 
> (Updated Nov. 8, 2015, 6:02 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented it like the other datasources.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> ---
> 
> Built and Tested.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-08 Thread Bhushan Shah 


> On Nov. 8, 2015, 6:11 p.m., Bhushan Shah wrote:
> > datasources/lastfm/CMakeLists.txt, line 2
> > 
> >
> > You sure this builds? there is no 
> > datasources/lastfm/lastfmimagefetcher.cpp ?

Sorry, I somehow mis-read diff..


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review88159
---


On Nov. 8, 2015, 6:02 p.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> ---
> 
> (Updated Nov. 8, 2015, 6:02 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented it like the other datasources.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> ---
> 
> Built and Tested.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-08 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.


Diffs
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Built and Tested.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel