Re: Review Request 127024: Don't filter names if we have mimetypes

2016-02-15 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127024/
---

(Updated Feb. 15, 2016, 12:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 415ad2ed48356c3065c937813888fa1bd2742789 by Aleix Pol to 
branch master.


Repository: frameworkintegration


Description
---

setMimeTypeFilters will call setNameFilter anyway, so we're not missing any 
entries, on the other hand setMimeFilter will do some nice things using the 
extra knowledge.


Diffs
-

  src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 

Diff: https://git.reviewboard.kde.org/r/127024/diff/


Testing
---

Tested it while porting okular.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127024: Don't filter names if we have mimetypes

2016-02-15 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127024/#review92384
---


Ship it!




Ship It!

- David Faure


On Feb. 14, 2016, 11:31 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127024/
> ---
> 
> (Updated Feb. 14, 2016, 11:31 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> setMimeTypeFilters will call setNameFilter anyway, so we're not missing any 
> entries, on the other hand setMimeFilter will do some nice things using the 
> extra knowledge.
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 
> 
> Diff: https://git.reviewboard.kde.org/r/127024/diff/
> 
> 
> Testing
> ---
> 
> Tested it while porting okular.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127024: Don't filter names if we have mimetypes

2016-02-14 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127024/
---

(Updated Feb. 15, 2016, 12:31 a.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Address issue as pointed by David.


Repository: frameworkintegration


Description
---

setMimeTypeFilters will call setNameFilter anyway, so we're not missing any 
entries, on the other hand setMimeFilter will do some nice things using the 
extra knowledge.


Diffs (updated)
-

  src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 

Diff: https://git.reviewboard.kde.org/r/127024/diff/


Testing
---

Tested it while porting okular.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127024: Don't filter names if we have mimetypes

2016-02-13 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127024/#review92310
---



Indeed, mime filters supersede name filters.


src/platformtheme/kdeplatformfiledialoghelper.cpp (line 268)


these 3 lines are duplicated in both branches -> move them out of the 
if/else?


- David Faure


On Feb. 11, 2016, 4:41 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127024/
> ---
> 
> (Updated Feb. 11, 2016, 4:41 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> setMimeTypeFilters will call setNameFilter anyway, so we're not missing any 
> entries, on the other hand setMimeFilter will do some nice things using the 
> extra knowledge.
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 
> 
> Diff: https://git.reviewboard.kde.org/r/127024/diff/
> 
> 
> Testing
> ---
> 
> Tested it while porting okular.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127024: Don't filter names if we have mimetypes

2016-02-11 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127024/
---

(Updated Feb. 11, 2016, 5:41 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: frameworkintegration


Description
---

setMimeTypeFilters will call setNameFilter anyway, so we're not missing any 
entries, on the other hand setMimeFilter will do some nice things using the 
extra knowledge.


Diffs
-

  src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 

Diff: https://git.reviewboard.kde.org/r/127024/diff/


Testing
---

Tested it while porting okular.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel