Re: Review Request 120306: Exclude X11 when building for Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/#review67169 --- I do not understand why this should be mutual exclusive. One of the nice new things in Qt 5 is that we can support multiple platforms in one library. We do not want Distros to have to ship everything twice: once for Wayland and once for X11. - Martin Gräßlin On Sept. 21, 2014, 4:50 p.m., Pier Luigi Fiorini wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/ --- (Updated Sept. 21, 2014, 4:50 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Exclude X11 when building for Wayland Diffs - CMakeLists.txt d9c78cf4ccc0ba8a37a2b43840a6867a9092d646 src/plasma/config-plasma.h.cmake ed14e7aa28835599f3a40ea1aff32d347f33a16c Diff: https://git.reviewboard.kde.org/r/120306/diff/ Testing --- Thanks, Pier Luigi Fiorini ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Announcing KWayland library
On Saturday 20 September 2014 23:08:43 šumski wrote: On Friday 19 of September 2014 11:06:56 Martin Gräßlin wrote: Hi plasma-devs, as discussed on Monday's hangout I split out KWin's Wayland handling code into a dedicated repository and library: git clone kde:kwayland The repository provides two libraries: * Client * Server At the moment Server doesn't get installed, but is used for the auto-tests of the Client library. Reporting now here, as there doesn't seem to be a bugzilla product yet. exists now. Seems the Server library uses Wayland API (wl_shm_buffer_begin_access and wl_shm_buffer_end_access) added after 1.3 release, but minimal version per CMakeLists is officially 1.2. Just raised it to 1.3. Thanks for noticing (note: it's rather difficult to notice which Wayland version introduces which API functionality). Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120279: Port to KWayland client library
On Sept. 20, 2014, 11:27 p.m., Pier Luigi Fiorini wrote: Modules/base/info_wayland.cpp, line 210 https://git.reviewboard.kde.org/r/120279/diff/2/?file=313412#file313412line210 Why we need a new connection? QPA already has one. there is no QPA in this case. It's for reporting information for everything available even if Qt doesn't support it. Likewise the X11 info module opens an own connection. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/#review67091 --- On Sept. 19, 2014, 12:49 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/ --- (Updated Sept. 19, 2014, 12:49 p.m.) Review request for Plasma. Repository: kinfocenter Description --- By using the KWayland library we don't need to interact with the low level C-library. Diffs - CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 Diff: https://git.reviewboard.kde.org/r/120279/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System tray icon sizes
On Sunday 21 September 2014, Andrew Lake wrote: On Sun, Sep 21, 2014 at 2:06 AM, Marco Martin wrote: Btw, since we are refining systray icons, do they work also on a size of 22x22(if not I'll fix the code)? I would love to get rid of the old hack of 24x24, that is just a remnant of the xembed legacy icons I changed the padding rect on klipper and the battery icons to 22x22 with the same 16x16 icon size in both. The result is here: http://wstaw.org/m/2014/09/21/5.1_scaling_bug_C.png ok, it seems fine, the battery needs ficing but we knew that The klipper icon seems to render fine. The battery icon scales up. With the fixes in-place or expected to be in-place, is it ok if I target a 22x22 padding rect for all icons? yes -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System tray icon sizes
On Sunday 21 September 2014, Kai Uwe Broulik wrote: Btw, since we are refining systray icons, do they work also on a size of 22x22(if not I'll fix the code)? I would love to get rid of the old hack of 24x24, that is just a remnant of the xembed legacy icons Is that the reason why even if I use units.roundToIconSize on the batterymonitor the icon still resizes at different thresholds? yes, probably. IconItem has a case for both 22x22 and 24x24, as a workaround on the fact most icons used to be 24. i can either add it to units as well, or just remove it (should probably use the same function to round as well) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KPackage framework in playground
Hi Marco, is kpackage successfully building on Linux already? I tried this on my OSX/CI system and got an error… Are you interested in me reporting about build issues on OSX already, or is this still too early? Greets, Marko ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KPackage framework in playground
On Friday 19 September 2014, Marko Käning wrote: Hi Marco, is kpackage successfully building on Linux already? I tried this on my OSX/CI system and got an error… Are you interested in me reporting about build issues on OSX already, or is this still too early? yes, here builds fine. what's the build error on OSX? -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Minutes Monday Plasma Hangout
Minutes Plasma Hangout, 22-9-2014 Present: Jens, Marco, Martin K., Martin G., Kai Uwe, Sebas, Vishesh, Jonathan For updates on TODO/status, see also Kanban board at: https://todo.kde.org/?controller=boardaction=showproject_id=13 Kai Uwe: - doing reviews - nagging mck182 about notifications and digiclock's timezones Martin G: - Split out KWayland (client and server abstraction for wayland) - in kde:kwayland, not framework-ready yet, but will be needed for Plasma Next - will go to XDC: if there are open wayland-related questions, pass them to Martin Marco: - continued refactoring dialog class with Vishesh - has been testing gerrit for patch reviews - standalone framework for Plasma::Package is in playground (git clone kde:kpackage) Martin K: - Fixed various things in clock and notifications - timezones support in digiclock is almost ready (RR coming up) Jens: - started Made for Plasma - discussing how to balance out messages this fits a Plasma workspace really well, yet application runs on *any* desktop, not just Plasma -- ideas welcome - Worked on design of Calamaris installer Jonathan: - has to push tags - tarballing on Thursday planned Vishesh: - Work on Dialog w/ Marco - Working on Baloo parser and KIO folder - Splitting out baloo-related code for Akonadi into akonadi-search repo - API adjustments for Baloo sebas: - pluginloader: dataengines don't need ksycoca anymore (in my branch) - indexed reading for a single servicetype is 3.5 - 8 times faster than ksycoca - still bit undecided where the caching and reading from cache should go, perhaps kservice - to work more on pluginloader and libkscreen wayland backend -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Minutes Monday Plasma Hangout
On Monday 22 September 2014, Sebastian Kügler wrote: Marco: - continued refactoring dialog class with Vishesh - has been testing gerrit for patch reviews - standalone framework for Plasma::Package is in playground (git clone kde:kpackage) - standalone application mode for plasmashell, intended for plasma mediacenter: 2 parallel approaches: in plasmawindowed and in plasmashell, still undecided what's better -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 12:56 p.m.) Review request for Plasma. Changes --- Add screenshots Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments (updated) Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 1:05 p.m.) Review request for Plasma. Changes --- Remove commented-out stuff, add some comments Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs (updated) - applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c applets/digital-clock/package/contents/config/config.qml f897c9a Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67181 --- Thanks for your work! :) applets/digital-clock/package/contents/ui/DigitalClock.qml https://git.reviewboard.kde.org/r/120314/#comment46877 I think this should be i18n'd just time - return time time + timezone - return i18nc(explain, %1 (%2), time, timezone) time + date - return time + br + date time + timezone + date - return time + br + i18nc(explain, %1 (%2), date, timezone) applets/digital-clock/package/contents/ui/DigitalClock.qml https://git.reviewboard.kde.org/r/120314/#comment46876 delta 0 applets/digital-clock/package/contents/ui/DigitalClock.qml https://git.reviewboard.kde.org/r/120314/#comment46878 Remove applets/digital-clock/package/contents/ui/configTimeZones.qml https://git.reviewboard.kde.org/r/120314/#comment46879 Whitespace applets/digital-clock/plugin/CMakeLists.txt https://git.reviewboard.kde.org/r/120314/#comment46881 Still needed after your changes? - Kai Uwe Broulik On Sept. 22, 2014, 11:05 vorm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 11:05 vorm.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c applets/digital-clock/package/contents/config/config.qml f897c9a Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 2:55 p.m.) Review request for Plasma. Changes --- Fix issues pointed by Kai Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs (updated) - applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 5.0.2 candidate tars
On Thu, Sep 18, 2014 at 02:07:16PM +0200, David Edmundson wrote: We seem to be missing tagsA a**for 5.0.1 and 5.02 in the plasma-workspace repo (not checked others) tags pushed, sorry for the delay Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120279: Port to KWayland client library
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/ --- (Updated Sept. 22, 2014, 3:46 p.m.) Review request for Plasma. Changes --- fixed the two reported styling issues. Repository: kinfocenter Description --- By using the KWayland library we don't need to interact with the low level C-library. Diffs (updated) - CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 Diff: https://git.reviewboard.kde.org/r/120279/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120279: Port to KWayland client library
On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote: Modules/base/info_wayland.cpp, line 289 https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line289 Why make this a function and use it once? It seems rather pointless. Martin Gräßlin wrote: simple: I didn't want to have a temporary variable I have to use. a function pointer is a temproary variable. If we're gonna make static methods, we may as well make a static method. On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote: Modules/base/info_wayland.cpp, line 236 https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236 This will add a row when the keyboard is added, but won't delete it when you remove it. When you add a keyboard again you'll now have two. Martin Gräßlin wrote: no, this is not how the seat works, unplugging the keyboard will not remove the capability keyboard from the seat, neither will adding one at the capability. One would have to reconfigure the system (in a way which I do not know how to do). Given that I think it's a very unlikely scenario that it would change while the KCM is open. David Edmundson wrote: then why are we using a connect? Or is it more like we're going from from unknown - might have keyboard as we load the data? Martin Gräßlin wrote: what I should add: I also don't want the KCM to update to changes. That's why the Output gets deleted once the change signal is recieved. Unfortunately wl_seat doesn't provide a mechanismn like wl_output to get a callback once all data is submitted. Martin Gräßlin wrote: Or is it more like we're going from from unknown - might have keyboard as we load the data? yes exactly. The information is pushed from wayland in an async way. I don't know about Wayland, but on DBus having a client library that hides the difference between false and just not loaded tends to be a headache later on. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/#review66922 --- On Sept. 22, 2014, 1:46 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/ --- (Updated Sept. 22, 2014, 1:46 p.m.) Review request for Plasma. Repository: kinfocenter Description --- By using the KWayland library we don't need to interact with the low level C-library. Diffs - CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 Diff: https://git.reviewboard.kde.org/r/120279/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120279: Port to KWayland client library
On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote: Modules/base/info_wayland.cpp, line 236 https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236 This will add a row when the keyboard is added, but won't delete it when you remove it. When you add a keyboard again you'll now have two. Martin Gräßlin wrote: no, this is not how the seat works, unplugging the keyboard will not remove the capability keyboard from the seat, neither will adding one at the capability. One would have to reconfigure the system (in a way which I do not know how to do). Given that I think it's a very unlikely scenario that it would change while the KCM is open. David Edmundson wrote: then why are we using a connect? Or is it more like we're going from from unknown - might have keyboard as we load the data? Martin Gräßlin wrote: what I should add: I also don't want the KCM to update to changes. That's why the Output gets deleted once the change signal is recieved. Unfortunately wl_seat doesn't provide a mechanismn like wl_output to get a callback once all data is submitted. Martin Gräßlin wrote: Or is it more like we're going from from unknown - might have keyboard as we load the data? yes exactly. The information is pushed from wayland in an async way. David Edmundson wrote: I don't know about Wayland, but on DBus having a client library that hides the difference between false and just not loaded tends to be a headache later on. Thanks for the suggestion. This might be added to KWayland::Client::Seat. Unfortunately the Wayland interface is not really useful here. As I wrote above: wl_output has a mechanism to announce when all information is set, wl_seat doesn't. This should be fixed in the wl_seat interface and then we could expose it in a useful way in the library. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/#review66922 --- On Sept. 22, 2014, 3:46 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/ --- (Updated Sept. 22, 2014, 3:46 p.m.) Review request for Plasma. Repository: kinfocenter Description --- By using the KWayland library we don't need to interact with the low level C-library. Diffs - CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 Diff: https://git.reviewboard.kde.org/r/120279/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120316: standalone application mode for plasmashell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- Review request for Plasma. Repository: plasma-workspace Description --- This is as alternative to https://git.reviewboard.kde.org/r/120270/ with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated. It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday). One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated) Diffs - shell/desktopview.h 6aeeeb6 shell/desktopview.cpp 08c1c32 shell/main.cpp e737007 shell/shellcorona.cpp eeb01af shell/shellmanager.h eef25aa shell/shellmanager.cpp f6472cb Diff: https://git.reviewboard.kde.org/r/120316/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120279: Port to KWayland client library
On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote: Modules/base/info_wayland.cpp, line 236 https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236 This will add a row when the keyboard is added, but won't delete it when you remove it. When you add a keyboard again you'll now have two. Martin Gräßlin wrote: no, this is not how the seat works, unplugging the keyboard will not remove the capability keyboard from the seat, neither will adding one at the capability. One would have to reconfigure the system (in a way which I do not know how to do). Given that I think it's a very unlikely scenario that it would change while the KCM is open. David Edmundson wrote: then why are we using a connect? Or is it more like we're going from from unknown - might have keyboard as we load the data? Martin Gräßlin wrote: what I should add: I also don't want the KCM to update to changes. That's why the Output gets deleted once the change signal is recieved. Unfortunately wl_seat doesn't provide a mechanismn like wl_output to get a callback once all data is submitted. Martin Gräßlin wrote: Or is it more like we're going from from unknown - might have keyboard as we load the data? yes exactly. The information is pushed from wayland in an async way. David Edmundson wrote: I don't know about Wayland, but on DBus having a client library that hides the difference between false and just not loaded tends to be a headache later on. Martin Gräßlin wrote: Thanks for the suggestion. This might be added to KWayland::Client::Seat. Unfortunately the Wayland interface is not really useful here. As I wrote above: wl_output has a mechanism to announce when all information is set, wl_seat doesn't. This should be fixed in the wl_seat interface and then we could expose it in a useful way in the library. and it doesn't always do the capabilitiesCallback/nameCallback on connection? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/#review66922 --- On Sept. 22, 2014, 1:46 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/ --- (Updated Sept. 22, 2014, 1:46 p.m.) Review request for Plasma. Repository: kinfocenter Description --- By using the KWayland library we don't need to interact with the low level C-library. Diffs - CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 Diff: https://git.reviewboard.kde.org/r/120279/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 4:33 p.m.) Review request for Plasma. Changes --- Change showTimezone property to showLocalTimezone to better reflect what it actually does Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs (updated) - applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120279: Port to KWayland client library
On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote: Modules/base/info_wayland.cpp, line 236 https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236 This will add a row when the keyboard is added, but won't delete it when you remove it. When you add a keyboard again you'll now have two. Martin Gräßlin wrote: no, this is not how the seat works, unplugging the keyboard will not remove the capability keyboard from the seat, neither will adding one at the capability. One would have to reconfigure the system (in a way which I do not know how to do). Given that I think it's a very unlikely scenario that it would change while the KCM is open. David Edmundson wrote: then why are we using a connect? Or is it more like we're going from from unknown - might have keyboard as we load the data? Martin Gräßlin wrote: what I should add: I also don't want the KCM to update to changes. That's why the Output gets deleted once the change signal is recieved. Unfortunately wl_seat doesn't provide a mechanismn like wl_output to get a callback once all data is submitted. Martin Gräßlin wrote: Or is it more like we're going from from unknown - might have keyboard as we load the data? yes exactly. The information is pushed from wayland in an async way. David Edmundson wrote: I don't know about Wayland, but on DBus having a client library that hides the difference between false and just not loaded tends to be a headache later on. Martin Gräßlin wrote: Thanks for the suggestion. This might be added to KWayland::Client::Seat. Unfortunately the Wayland interface is not really useful here. As I wrote above: wl_output has a mechanism to announce when all information is set, wl_seat doesn't. This should be fixed in the wl_seat interface and then we could expose it in a useful way in the library. David Edmundson wrote: and it doesn't always do the capabilitiesCallback/nameCallback on connection? no, that depends on the version. If the version is less than 2, the nameCallback will not be invoked. Also it's not specified in the documentation that the callbacks have to be invoked when connecting (which is explicitly stated for other interfaces). I don't know whether that is a documentation oversight or whether the capabilities don't have to be announced. For other interfaces (e.g. the _wl_fullscreen_shell) the capabilities are not announced if there are none. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/#review66922 --- On Sept. 22, 2014, 3:46 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/ --- (Updated Sept. 22, 2014, 3:46 p.m.) Review request for Plasma. Repository: kinfocenter Description --- By using the KWayland library we don't need to interact with the low level C-library. Diffs - CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 Diff: https://git.reviewboard.kde.org/r/120279/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67205 --- The following steps lead to unexpected behavior for me: a) Add Digital Clock to panel. b) Set display to Timezone city. c) Disable Local. d) Enable Manila. e) Set default to Manila. f) Click OK. Expected result: A Digital Clock showing Manila. Actual result: No changes. Opening the config again, Manila is disabled and default is Berlin. All changes seem to have been lost. Seems to be related to disabling Local. - Eike Hein On Sept. 22, 2014, 2:33 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 2:33 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120318: PoC: Package Manager integration for the AppsModel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future. It adds an entry on the menu that is called Remove 'packagename' that opens a software center. I set it to muon-discover for now, but this should be iterated over. To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best. Diffs - CMakeLists.txt 7b794ff applets/kicker/CMakeLists.txt 0688732 applets/kicker/plugin/appsmodel.cpp b88d711 Diff: https://git.reviewboard.kde.org/r/120318/diff/ Testing --- I uninstalled openarena, selfcompiled software cannot removed. The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120318: PoC: Package Manager integration for the AppsModel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/#review67207 --- Hmm, overall approach seems fine I think :). Using the executable as search key might not always find the right package, but then using the desktop file name isn't any more reliable, and the user can use muon-discover to check the result anyway. There's a laundry list of minor things to do: - Separate files for PackageKitJob - Coding style fixes - Action needs ... and should probably use the muon icon I'm happy to do all that stuff though. More important is making it build-time optional :). You have way more CMake fu than I do, mind doing that? - Eike Hein On Sept. 22, 2014, 2:54 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 2:54 p.m.) Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future. It adds an entry on the menu that is called Remove 'packagename' that opens a software center. I set it to muon-discover for now, but this should be iterated over. To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best. Diffs - CMakeLists.txt 7b794ff applets/kicker/CMakeLists.txt 0688732 applets/kicker/plugin/appsmodel.cpp b88d711 Diff: https://git.reviewboard.kde.org/r/120318/diff/ Testing --- I uninstalled openarena, selfcompiled software cannot removed. The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120318: PoC: Package Manager integration for the AppsModel
On Sept. 22, 2014, 3:05 p.m., Eike Hein wrote: Hmm, overall approach seems fine I think :). Using the executable as search key might not always find the right package, but then using the desktop file name isn't any more reliable, and the user can use muon-discover to check the result anyway. There's a laundry list of minor things to do: - Separate files for PackageKitJob - Coding style fixes - Action needs ... and should probably use the muon icon I'm happy to do all that stuff though. More important is making it build-time optional :). You have way more CMake fu than I do, mind doing that? Will do, it's related to moving it into a separate file anyway. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/#review67207 --- On Sept. 22, 2014, 2:54 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 2:54 p.m.) Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future. It adds an entry on the menu that is called Remove 'packagename' that opens a software center. I set it to muon-discover for now, but this should be iterated over. To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best. Diffs - CMakeLists.txt 7b794ff applets/kicker/CMakeLists.txt 0688732 applets/kicker/plugin/appsmodel.cpp b88d711 Diff: https://git.reviewboard.kde.org/r/120318/diff/ Testing --- I uninstalled openarena, selfcompiled software cannot removed. The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120318: PoC: Package Manager integration for the AppsModel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 3:34 p.m.) Review request for Plasma and Eike Hein. Changes --- Separate FindPackageNameJob into a separate class. Made the dependency optional. Repository: plasma-desktop Description --- I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future. It adds an entry on the menu that is called Remove 'packagename' that opens a software center. I set it to muon-discover for now, but this should be iterated over. To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best. Diffs (updated) - CMakeLists.txt 7b794ff applets/kicker/CMakeLists.txt 0688732 applets/kicker/plugin/appsmodel.cpp b88d711 applets/kicker/plugin/findpackagenamejob.h PRE-CREATION applets/kicker/plugin/findpackagenamejob.cpp PRE-CREATION config-workspace.h.cmake 58a11d4 Diff: https://git.reviewboard.kde.org/r/120318/diff/ Testing --- I uninstalled openarena, selfcompiled software cannot removed. The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120318: PoC: Package Manager integration for the AppsModel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/#review67209 --- I like the idea! Suggestion for the which package manager to use part: add a package manager selection to the defaults application KCM and use the one which is configured there. Distros should be able to easily configure the one they are using then. - Martin Gräßlin On Sept. 22, 2014, 5:34 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 5:34 p.m.) Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future. It adds an entry on the menu that is called Remove 'packagename' that opens a software center. I set it to muon-discover for now, but this should be iterated over. To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best. Diffs - CMakeLists.txt 7b794ff applets/kicker/CMakeLists.txt 0688732 applets/kicker/plugin/appsmodel.cpp b88d711 applets/kicker/plugin/findpackagenamejob.h PRE-CREATION applets/kicker/plugin/findpackagenamejob.cpp PRE-CREATION config-workspace.h.cmake 58a11d4 Diff: https://git.reviewboard.kde.org/r/120318/diff/ Testing --- I uninstalled openarena, selfcompiled software cannot removed. The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120318: PoC: Package Manager integration for the AppsModel
On Sept. 22, 2014, 3:38 p.m., Martin Gräßlin wrote: I like the idea! Suggestion for the which package manager to use part: add a package manager selection to the defaults application KCM and use the one which is configured there. Distros should be able to easily configure the one they are using then. Why would distros need a GUI for configuring it? - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/#review67209 --- On Sept. 22, 2014, 3:34 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 3:34 p.m.) Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future. It adds an entry on the menu that is called Remove 'packagename' that opens a software center. I set it to muon-discover for now, but this should be iterated over. To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best. Diffs - CMakeLists.txt 7b794ff applets/kicker/CMakeLists.txt 0688732 applets/kicker/plugin/appsmodel.cpp b88d711 applets/kicker/plugin/findpackagenamejob.h PRE-CREATION applets/kicker/plugin/findpackagenamejob.cpp PRE-CREATION config-workspace.h.cmake 58a11d4 Diff: https://git.reviewboard.kde.org/r/120318/diff/ Testing --- I uninstalled openarena, selfcompiled software cannot removed. The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120318: PoC: Package Manager integration for the AppsModel
On Sept. 22, 2014, 5:38 p.m., Martin Gräßlin wrote: I like the idea! Suggestion for the which package manager to use part: add a package manager selection to the defaults application KCM and use the one which is configured there. Distros should be able to easily configure the one they are using then. Aleix Pol Gonzalez wrote: Why would distros need a GUI for configuring it? distros don't need the GUI, but the kconfig key. Some distros provide multiple tools, though and then the user might want to be able to configure it. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/#review67209 --- On Sept. 22, 2014, 5:34 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 5:34 p.m.) Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future. It adds an entry on the menu that is called Remove 'packagename' that opens a software center. I set it to muon-discover for now, but this should be iterated over. To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best. Diffs - CMakeLists.txt 7b794ff applets/kicker/CMakeLists.txt 0688732 applets/kicker/plugin/appsmodel.cpp b88d711 applets/kicker/plugin/findpackagenamejob.h PRE-CREATION applets/kicker/plugin/findpackagenamejob.cpp PRE-CREATION config-workspace.h.cmake 58a11d4 Diff: https://git.reviewboard.kde.org/r/120318/diff/ Testing --- I uninstalled openarena, selfcompiled software cannot removed. The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120318: PoC: Package Manager integration for the AppsModel
On Sept. 22, 2014, 3:38 p.m., Martin Gräßlin wrote: I like the idea! Suggestion for the which package manager to use part: add a package manager selection to the defaults application KCM and use the one which is configured there. Distros should be able to easily configure the one they are using then. Aleix Pol Gonzalez wrote: Why would distros need a GUI for configuring it? Martin Gräßlin wrote: distros don't need the GUI, but the kconfig key. Some distros provide multiple tools, though and then the user might want to be able to configure it. I was planning to add a config key to Kicker for now, but I agree a more canonical workspace-level key and an API in KToolInvocation would be cool. Next Frameworks release maybe? - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/#review67209 --- On Sept. 22, 2014, 3:34 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 3:34 p.m.) Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future. It adds an entry on the menu that is called Remove 'packagename' that opens a software center. I set it to muon-discover for now, but this should be iterated over. To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best. Diffs - CMakeLists.txt 7b794ff applets/kicker/CMakeLists.txt 0688732 applets/kicker/plugin/appsmodel.cpp b88d711 applets/kicker/plugin/findpackagenamejob.h PRE-CREATION applets/kicker/plugin/findpackagenamejob.cpp PRE-CREATION config-workspace.h.cmake 58a11d4 Diff: https://git.reviewboard.kde.org/r/120318/diff/ Testing --- I uninstalled openarena, selfcompiled software cannot removed. The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120318: PoC: Package Manager integration for the AppsModel
On Sept. 22, 2014, 3:38 nachm., Martin Gräßlin wrote: I like the idea! Suggestion for the which package manager to use part: add a package manager selection to the defaults application KCM and use the one which is configured there. Distros should be able to easily configure the one they are using then. Aleix Pol Gonzalez wrote: Why would distros need a GUI for configuring it? Martin Gräßlin wrote: distros don't need the GUI, but the kconfig key. Some distros provide multiple tools, though and then the user might want to be able to configure it. Eike Hein wrote: I was planning to add a config key to Kicker for now, but I agree a more canonical workspace-level key and an API in KToolInvocation would be cool. Next Frameworks release maybe? In theory, a call on the PackageKit interface should trigger whatever implements the PackageKit session DBus interface (on KDE that's only Apper at time) to display any GUI dialogs. But probably showing the application prior to removing it in a software center is a good idea anyway :) Would it make sense to send the application-name to the software center, and have it figure out the package name, instead of doing that prior to calling the SC? Might be a bit nicer... As a sidenote: Using LibAppstreamQt could be a future option for resolving application-names to packages - depending on the distribution's package-manager, calls to SearchFiles() could be a bit slow. Drawback of using that lib is that distros need to ship with AppStream metadata, which currently only OpenSUSE and Fedora do - Debian will support is soon, and Ubuntu maybe as well (both distros currently have partial support via AppInstall data). That feature looks great, I hope it doesn't conflict with http://dantti.wordpress.com/2010/11/25/yup-laziness-is-a-virtue/ , although honestly I need to check if that Apper feature actually still works... - Matthias --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/#review67209 --- On Sept. 22, 2014, 3:34 nachm., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 3:34 nachm.) Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future. It adds an entry on the menu that is called Remove 'packagename' that opens a software center. I set it to muon-discover for now, but this should be iterated over. To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best. Diffs - CMakeLists.txt 7b794ff applets/kicker/CMakeLists.txt 0688732 applets/kicker/plugin/appsmodel.cpp b88d711 applets/kicker/plugin/findpackagenamejob.h PRE-CREATION applets/kicker/plugin/findpackagenamejob.cpp PRE-CREATION config-workspace.h.cmake 58a11d4 Diff: https://git.reviewboard.kde.org/r/120318/diff/ Testing --- I uninstalled openarena, selfcompiled software cannot removed. The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120318: PoC: Package Manager integration for the AppsModel
On Sept. 22, 2014, 3:38 p.m., Martin Gräßlin wrote: I like the idea! Suggestion for the which package manager to use part: add a package manager selection to the defaults application KCM and use the one which is configured there. Distros should be able to easily configure the one they are using then. Aleix Pol Gonzalez wrote: Why would distros need a GUI for configuring it? Martin Gräßlin wrote: distros don't need the GUI, but the kconfig key. Some distros provide multiple tools, though and then the user might want to be able to configure it. Eike Hein wrote: I was planning to add a config key to Kicker for now, but I agree a more canonical workspace-level key and an API in KToolInvocation would be cool. Next Frameworks release maybe? Matthias Klumpp wrote: In theory, a call on the PackageKit interface should trigger whatever implements the PackageKit session DBus interface (on KDE that's only Apper at time) to display any GUI dialogs. But probably showing the application prior to removing it in a software center is a good idea anyway :) Would it make sense to send the application-name to the software center, and have it figure out the package name, instead of doing that prior to calling the SC? Might be a bit nicer... As a sidenote: Using LibAppstreamQt could be a future option for resolving application-names to packages - depending on the distribution's package-manager, calls to SearchFiles() could be a bit slow. Drawback of using that lib is that distros need to ship with AppStream metadata, which currently only OpenSUSE and Fedora do - Debian will support is soon, and Ubuntu maybe as well (both distros currently have partial support via AppInstall data). That feature looks great, I hope it doesn't conflict with http://dantti.wordpress.com/2010/11/25/yup-laziness-is-a-virtue/ , although honestly I need to check if that Apper feature actually still works... @Klumpp: Well, we still want to do the lookup on the kicker side, because we don't want to show the option in case its not removable. Otherwise we would be rising the user's hopes for little reason. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/#review67209 --- On Sept. 22, 2014, 3:34 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 3:34 p.m.) Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future. It adds an entry on the menu that is called Remove 'packagename' that opens a software center. I set it to muon-discover for now, but this should be iterated over. To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best. Diffs - CMakeLists.txt 7b794ff applets/kicker/CMakeLists.txt 0688732 applets/kicker/plugin/appsmodel.cpp b88d711 applets/kicker/plugin/findpackagenamejob.h PRE-CREATION applets/kicker/plugin/findpackagenamejob.cpp PRE-CREATION config-workspace.h.cmake 58a11d4 Diff: https://git.reviewboard.kde.org/r/120318/diff/ Testing --- I uninstalled openarena, selfcompiled software cannot removed. The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[muon/frameworks] discover: Port Muon Discover away from PlasmaComponents
Git commit 5a331be3e90abb3e2fa942deb11347d33986c187 by Aleix Pol.
Committed on 22/09/2014 at 16:57.
Pushed by apol into branch 'frameworks'.
Port Muon Discover away from PlasmaComponents
Depending on org.kde.plasma.* components is problematic at the moment as
plasma-framework is not coinstallable (or kactivities for that matter) and
it has stopped a couple of people who were trying to contribute to the
project.
Furthermore, it was not a good idea to depend on it anyway. It wouldn't
integrate with the application look and feel settings and we had to juggle
to make it look acceptable.
Counter-side is that most of our components are provided in plasma
framework, so development will be needed to get all needed components in
shape either in Qt or KDeclarative.
REVIEW: 120265
CCMAIL: plasma-devel@kde.org
M +0-2discover/MuonDiscoverMainWindow.cpp
M +6-8discover/qml/ApplicationDescription.qml
M +2-4discover/qml/ApplicationOverview.qml
M +0-1discover/qml/ApplicationPage.qml
M +0-1discover/qml/ApplicationsGridDelegate.qml
M +5-5discover/qml/ApplicationsList.qml
M +3-3discover/qml/ApplicationsTop.qml
M +2-3discover/qml/CategoryHeader.qml
M +3-3discover/qml/CategoryPage.qml
M +2-3discover/qml/DefaultBanner.qml
M +8-9discover/qml/FeaturedBanner.qml
M +0-34 discover/qml/GridItem.qml
M +1-2discover/qml/Main.qml
M +3-3discover/qml/MuonToolButton.qml
M +4-4discover/qml/ProgressView.qml
M +0-1discover/qml/Rating.qml
M +0-1discover/qml/ReviewsPage.qml
M +0-1discover/qml/UpdatesPage.qml
http://commits.kde.org/muon/5a331be3e90abb3e2fa942deb11347d33986c187
diff --git a/discover/MuonDiscoverMainWindow.cpp
b/discover/MuonDiscoverMainWindow.cpp
index 96bdfa0..6c7e93c 100644
--- a/discover/MuonDiscoverMainWindow.cpp
+++ b/discover/MuonDiscoverMainWindow.cpp
@@ -71,8 +71,6 @@ MuonDiscoverMainWindow::MuonDiscoverMainWindow()
// m_view-setBackgroundRole(QPalette::AlternateBase);
// qreal bgGrayness = m_view-backgroundBrush().color().blackF();
-// Plasma::Theme::defaultTheme()-setUseGlobalSettings(false); //don't
change every plasma theme!
-// Plasma::Theme::defaultTheme()-setThemeName(bgGrayness0.5 ?
muon-contenttheme : oxygen);
m_view = new QQuickWidget(this);
m_view-setResizeMode(QQuickWidget::SizeRootObjectToView);
QQmlEngine* engine = m_view-engine();
diff --git a/discover/qml/ApplicationDescription.qml
b/discover/qml/ApplicationDescription.qml
index f2ea22c..c54cae8 100644
--- a/discover/qml/ApplicationDescription.qml
+++ b/discover/qml/ApplicationDescription.qml
@@ -19,8 +19,6 @@
import QtQuick 2.1
import QtQuick.Controls 1.1
-import org.kde.plasma.core 2.0
-import org.kde.plasma.extras 2.0
import org.kde.muon 1.0
import org.kde.muon.discover 1.0 as Discover
import navigation.js as Navigation
@@ -35,7 +33,7 @@ Column {
margins: 10
}
height: icon.height
-IconItem {
+Image {
id: icon
anchors {
top: header.top
@@ -44,7 +42,7 @@ Column {
height: 64
width: height
-source: application.icon
+source: image://icon/+application.icon
clip: true
}
@@ -58,7 +56,7 @@ Column {
leftMargin: 5
}
-Heading {
+Label {
id: heading
text: application.name
width: parent.width
@@ -81,7 +79,7 @@ Column {
}
}
Item {width: 10; height: 20}
-Heading { text: i18n(Description) }
+Label { text: i18n(Description) }
Label {
id: info
anchors {
@@ -95,7 +93,7 @@ Column {
}
Item {width: 10; height: 20}
-Heading {
+Label {
text: i18n(Addons)
visible: addonsView.visible
}
@@ -107,7 +105,7 @@ Column {
}
Item {width: 10; height: 20}
-Heading {
+Label {
text: i18n(Comments)
visible: reviewsView.visible
}
diff --git a/discover/qml/ApplicationOverview.qml
b/discover/qml/ApplicationOverview.qml
index e3dd9fe..7493a17 100644
--- a/discover/qml/ApplicationOverview.qml
+++ b/discover/qml/ApplicationOverview.qml
@@ -20,9 +20,6 @@
import QtQuick 2.1
import QtQuick.Controls 1.1
import QtQuick.Controls 1.1
-import org.kde.plasma.core 2.0
-import org.kde.plasma.extras 2.0
-import org.kde.kquickcontrols 2.0
import org.kde.muon.discover 1.0 as Discover
import org.kde.muon 1.0
@@ -80,7 +77,8 @@ Item {
anchors.fill: parent
onClicked: Qt.openUrlExternally(application.homepage);
}
-color: theme.linkColor
+SystemPalette { id: palette }
+color: palette.highlight
font.underline: true
width: parent.width/2
elide:
Re: Review Request 120316: standalone application mode for plasmashell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- (Updated Sept. 22, 2014, 6 p.m.) Review request for Plasma. Changes --- use a different corona for the standalone mode, doesn't overcomplicate it. scriptengine becomes slightly uglier tough Repository: plasma-workspace Description --- This is as alternative to https://git.reviewboard.kde.org/r/120270/ with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated. It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday). One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated) Diffs (updated) - shell/shellmanager.cpp f6472cb shell/standaloneappcorona.h PRE-CREATION shell/standaloneappcorona.cpp PRE-CREATION shell/scripting/scriptengine.cpp 5b035ea shell/shellcorona.cpp eeb01af shell/shellmanager.h eef25aa shell/main.cpp e737007 shell/scripting/scriptengine.h 6ce8b51 shell/CMakeLists.txt e835bf8 shell/desktopview.h 6aeeeb6 shell/desktopview.cpp 08c1c32 Diff: https://git.reviewboard.kde.org/r/120316/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120318: PoC: Package Manager integration for the AppsModel
On Sept. 22, 2014, 3:38 nachm., Martin Gräßlin wrote: I like the idea! Suggestion for the which package manager to use part: add a package manager selection to the defaults application KCM and use the one which is configured there. Distros should be able to easily configure the one they are using then. Aleix Pol Gonzalez wrote: Why would distros need a GUI for configuring it? Martin Gräßlin wrote: distros don't need the GUI, but the kconfig key. Some distros provide multiple tools, though and then the user might want to be able to configure it. Eike Hein wrote: I was planning to add a config key to Kicker for now, but I agree a more canonical workspace-level key and an API in KToolInvocation would be cool. Next Frameworks release maybe? Matthias Klumpp wrote: In theory, a call on the PackageKit interface should trigger whatever implements the PackageKit session DBus interface (on KDE that's only Apper at time) to display any GUI dialogs. But probably showing the application prior to removing it in a software center is a good idea anyway :) Would it make sense to send the application-name to the software center, and have it figure out the package name, instead of doing that prior to calling the SC? Might be a bit nicer... As a sidenote: Using LibAppstreamQt could be a future option for resolving application-names to packages - depending on the distribution's package-manager, calls to SearchFiles() could be a bit slow. Drawback of using that lib is that distros need to ship with AppStream metadata, which currently only OpenSUSE and Fedora do - Debian will support is soon, and Ubuntu maybe as well (both distros currently have partial support via AppInstall data). That feature looks great, I hope it doesn't conflict with http://dantti.wordpress.com/2010/11/25/yup-laziness-is-a-virtue/ , although honestly I need to check if that Apper feature actually still works... Aleix Pol Gonzalez wrote: @Klumpp: Well, we still want to do the lookup on the kicker side, because we don't want to show the option in case its not removable. Otherwise we would be rising the user's hopes for little reason. Ah, right - didn't think about that possibility. - Matthias --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/#review67209 --- On Sept. 22, 2014, 3:34 nachm., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 3:34 nachm.) Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future. It adds an entry on the menu that is called Remove 'packagename' that opens a software center. I set it to muon-discover for now, but this should be iterated over. To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best. Diffs - CMakeLists.txt 7b794ff applets/kicker/CMakeLists.txt 0688732 applets/kicker/plugin/appsmodel.cpp b88d711 applets/kicker/plugin/findpackagenamejob.h PRE-CREATION applets/kicker/plugin/findpackagenamejob.cpp PRE-CREATION config-workspace.h.cmake 58a11d4 Diff: https://git.reviewboard.kde.org/r/120318/diff/ Testing --- I uninstalled openarena, selfcompiled software cannot removed. The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120316: standalone application mode for plasmashell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- (Updated Sept. 22, 2014, 6:27 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This is as alternative to https://git.reviewboard.kde.org/r/120270/ with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated. It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday). One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated) Diffs (updated) - shell/main.cpp e737007 shell/CMakeLists.txt e835bf8 shell/desktopview.h 6aeeeb6 shell/desktopview.cpp 08c1c32 shell/scripting/scriptengine.h 6ce8b51 shell/scripting/scriptengine.cpp 5b035ea shell/shellcorona.cpp eeb01af shell/shellmanager.h eef25aa shell/shellmanager.cpp f6472cb shell/standaloneappcorona.h PRE-CREATION shell/standaloneappcorona.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120316/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67225 --- I think scaling could use a little more love:  Specifically, notice how the time part isn't of uniform size. I guess it gets scaled to fit in with the city text size, which is scaled to fit horizontally. But in an arrangement like this, it would look nicer if the time size was uniform. - Eike Hein On Sept. 22, 2014, 2:33 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 2:33 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote: I think scaling could use a little more love:  Specifically, notice how the time part isn't of uniform size. I guess it gets scaled to fit in with the city text size, which is scaled to fit horizontally. But in an arrangement like this, it would look nicer if the time size was uniform. Sorry, botched the image embed:  - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67225 --- On Sept. 22, 2014, 2:33 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 2:33 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120318: PoC: Package Manager integration for the AppsModel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120318/ --- (Updated Sept. 22, 2014, 7:09 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Eike Hein. Repository: plasma-desktop Description --- I've been discussing with Eike having something like that for a while, I finally managed to put something together that we could use in a future. It adds an entry on the menu that is called Remove 'packagename' that opens a software center. I set it to muon-discover for now, but this should be iterated over. To do the lookup, it uses PackageKitQt. It probably should be an optional dependency, but I want Eike to look into it first and decide how to do it best. Diffs - CMakeLists.txt 7b794ff applets/kicker/CMakeLists.txt 0688732 applets/kicker/plugin/appsmodel.cpp b88d711 applets/kicker/plugin/findpackagenamejob.h PRE-CREATION applets/kicker/plugin/findpackagenamejob.cpp PRE-CREATION config-workspace.h.cmake 58a11d4 Diff: https://git.reviewboard.kde.org/r/120318/diff/ Testing --- I uninstalled openarena, selfcompiled software cannot removed. The locking is not really noticeable on my system. We still probably want to improve that but I don't think it would be terrible like this, only bad. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_master_qt5 #637
See http://build.kde.org/job/plasma-desktop_master_qt5/637/changes Changes: [hein] Add a context menu action to remove applications. -- [...truncated 2662 lines...] http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp:125:48: warning: ‘QExplicitlySharedDataPointerKSharedConfig KGlobal::config()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:382) [-Wdeprecated-declarations] KSharedConfig::Ptr _config = KGlobal::config(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp: In member function ‘void KAccessApp::xkbBellNotify(XkbBellNotifyEvent*)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp:438:71: warning: ‘NETWinInfo::NETWinInfo(xcb_connection_t*, xcb_window_t, xcb_window_t, NET::Properties, NET::Role)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/netwm.h:988) [-Wdeprecated-declarations] NETWinInfo net(QX11Info::connection(), id, desktop()-winId(), 0); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp:481:53: warning: ‘Phonon::MediaSource::MediaSource(const QString)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kdesupport/phonon/phonon/inst/include/phonon4qt5/phonon/mediasource.h:144) [-Wdeprecated-declarations] _player-setCurrentSource(_currentPlayerSource); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp: In member function ‘void KAccessApp::createDialogContents()’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp:585:20: warning: ‘KDialog’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kdialog.h:128) [-Wdeprecated-declarations] dialog = new KDialog( 0 ); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp:595:14: warning: ‘KVBox’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kvbox.h:36) [-Wdeprecated-declarations] KVBox *topcontents = new KVBox (dialog); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp:595:32: warning: ‘KVBox’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kvbox.h:36) [-Wdeprecated-declarations] KVBox *topcontents = new KVBox (dialog); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp: In member function ‘void KAccessApp::applyChanges()’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp:825:33: warning: ‘QExplicitlySharedDataPointerKSharedConfig KGlobal::config()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:382) [-Wdeprecated-declarations] KConfigGroup config(KGlobal::config(), Keyboard); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp:825:40: warning: ‘QExplicitlySharedDataPointerKSharedConfig KGlobal::config()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:382) [-Wdeprecated-declarations] KConfigGroup config(KGlobal::config(), Keyboard); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp:842:35: warning: ‘QExplicitlySharedDataPointerKSharedConfig KGlobal::config()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:382) [-Wdeprecated-declarations] KConfigGroup mousegrp(KGlobal::config(),Mouse); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp:842:42: warning: ‘QExplicitlySharedDataPointerKSharedConfig KGlobal::config()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:382) [-Wdeprecated-declarations] KConfigGroup mousegrp(KGlobal::config(),Mouse); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/access/kaccess.cpp: In member function ‘void KAccessApp::yesClicked()’:
Jenkins build is back to normal : plasma-desktop_master_qt5 #638
See http://build.kde.org/job/plasma-desktop_master_qt5/638/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
On Sept. 22, 2014, 9:03 p.m., Eike Hein wrote: I think scaling could use a little more love:  Specifically, notice how the time part isn't of uniform size. I guess it gets scaled to fit in with the city text size, which is scaled to fit horizontally. But in an arrangement like this, it would look nicer if the time size was uniform. Eike Hein wrote: Sorry, botched the image embed:  Ah yeah, that is because just one label is used for the whole thing, so when it needs to scale the font down to fit Manila, it also scales down the clock font :S At this point I'd like to leave this as is for now as fixing it would require splitting this into two standalone labels and given this change would not be trivial, I'd leave it for after this gets merged. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67225 --- On Sept. 22, 2014, 4:33 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 4:33 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote: I think scaling could use a little more love:  Specifically, notice how the time part isn't of uniform size. I guess it gets scaled to fit in with the city text size, which is scaled to fit horizontally. But in an arrangement like this, it would look nicer if the time size was uniform. Eike Hein wrote: Sorry, botched the image embed:  Martin Klapetek wrote: Ah yeah, that is because just one label is used for the whole thing, so when it needs to scale the font down to fit Manila, it also scales down the clock font :S At this point I'd like to leave this as is for now as fixing it would require splitting this into two standalone labels and given this change would not be trivial, I'd leave it for after this gets merged. Yeah I think that's fine, it's an edge case. - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67225 --- On Sept. 22, 2014, 2:33 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 2:33 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 11:59 p.m.) Review request for Plasma. Changes --- \* Removed the combobox for the default timezone \* The last displayed timezone is used instead \* More robust remembering the last used timezone \* Don't force Local to be always selected \* Cannot reproduce Eike's issue with not remembering config, can anyone else confirm? Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs (updated) - applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67238 --- Patch doesn't apply cleanly to master: The next patch would delete the file a/applets/digital-clock/plugin/processrunnerplugin.h, which does not exist! Assume -R? [n] - Eike Hein On Sept. 22, 2014, 9:59 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 9:59 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
On Sept. 22, 2014, 10:18 p.m., Eike Hein wrote: Patch doesn't apply cleanly to master: The next patch would delete the file a/applets/digital-clock/plugin/processrunnerplugin.h, which does not exist! Assume -R? [n] Uh never mind - fat-fingered the patch level. It's late ... - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67238 --- On Sept. 22, 2014, 9:59 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 9:59 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67240 --- I can no longer reproduce my problem from earlier, but note it's possible to deselect all timezones in the config and then you get: plasmashell(28432)/default unknown: file:///home/sho/devel/install/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/DigitalClock.qml:84: TypeError: Cannot read property 'DateTime' of undefined - Eike Hein On Sept. 22, 2014, 9:59 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 9:59 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67241 --- Place names with multiple names use _ as word separator, and don't get scaled down enough nor elided to fit a narrow vertical panel:  - Eike Hein On Sept. 22, 2014, 9:59 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 9:59 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120314: Add timezones support into clock applet
On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote: I think scaling could use a little more love:  Specifically, notice how the time part isn't of uniform size. I guess it gets scaled to fit in with the city text size, which is scaled to fit horizontally. But in an arrangement like this, it would look nicer if the time size was uniform. Eike Hein wrote: Sorry, botched the image embed:  Martin Klapetek wrote: Ah yeah, that is because just one label is used for the whole thing, so when it needs to scale the font down to fit Manila, it also scales down the clock font :S At this point I'd like to leave this as is for now as fixing it would require splitting this into two standalone labels and given this change would not be trivial, I'd leave it for after this gets merged. Eike Hein wrote: Yeah I think that's fine, it's an edge case. That said, it also means the time size changes a lot while mouse-wheeling to change zones, which is a little less edge case-y and pretty ugly. - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67225 --- On Sept. 22, 2014, 9:59 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 22, 2014, 9:59 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- I've picked up Kai's branch where he started the timezone support and finished it. New features: * timezones tab in the config * changing timezones by scrolling a wheel on the clock * that's optional, defaults to off * displaying non-local timezones as either city or abbreviation * Show time zone config option is now changed to Show local time zone as foreign zones are always displayed by default What's still missing: * selecting default timezone in the config (should be fairly easy; currently the last used is restored on login * timezones in the popup, this would require either large changes to the applet (moving functions around) or displaying the time in non-locale way Diffs - applets/digital-clock/plugin/processrunnerplugin.h 2b6317b applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 applets/digital-clock/plugin/qmldir 3d57bbb applets/digital-clock/plugin/timezonedata.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.h PRE-CREATION applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION dataengines/time/timesource.cpp b79fd7c applets/digital-clock/package/contents/config/config.qml f897c9a applets/digital-clock/package/contents/config/main.xml cbeb02f applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION applets/digital-clock/package/contents/ui/main.qml e78f1f3 applets/digital-clock/plugin/CMakeLists.txt 0590e6e applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120314/diff/ Testing --- I've been using it for couple days, all those features from above work nicely here, with all sorts of config configurations (eg. if date is displayed, it also changes properly with timezone change). File Attachments Timezone date displayed https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png Timezone without date https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/ --- Review request for Plasma. Repository: kdeplasma-addons Description --- port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start I'd like somebody to have a look at it to tell me, if I'm on the right way or if I'm completely wrong Diffs - applets/binary-clock/binaryclock.h 5ae83dfff9c473bd484b99d49330093b6e091975 applets/binary-clock/Messages.sh 40a3686fffcb2036d5baef6e3ab2ba58ff57a8f4 applets/CMakeLists.txt 38751705f0b712ee8ce6861a7d437402be480873 applets/binary-clock/CMakeLists.txt b42a6e76752af3cc800ad5455ba0678a18a0ce45 applets/binary-clock/package/contents/ui/BinaryClock.qml PRE-CREATION applets/binary-clock/package/contents/ui/Dot.qml PRE-CREATION applets/binary-clock/package/contents/ui/DotColumn.qml PRE-CREATION applets/binary-clock/package/contents/ui/configGeneral.qml PRE-CREATION applets/binary-clock/package/contents/ui/main.qml PRE-CREATION applets/binary-clock/plasma-applet-binaryclock.desktop 10bd99b0518873f819ae89c9e9b9e09d9eb3490e applets/binary-clock/clockConfig.ui 0c2cec7925dd9e1ff92d7cd9d99005dca20497b0 applets/binary-clock/package/contents/config/config.qml PRE-CREATION applets/binary-clock/package/contents/config/main.xml PRE-CREATION applets/binary-clock/binaryclock.cpp 75c4548588ff15e2316dd1c2e888ad8c07f7f78b Diff: https://git.reviewboard.kde.org/r/120325/diff/ Testing --- It works on the desktop, but the dots are too small in the panel Thanks, Joseph Wenninger ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120222: When the button is being pressed draw background like it has focus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120222/#review67247 --- bump. - David Edmundson On Sept. 15, 2014, 6:29 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120222/ --- (Updated Sept. 15, 2014, 6:29 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- When the button is being pressed draw like it has focus PushButtons typically turn blue because they gain focus, whereas tool buttons don't. This means buttons look inconsistent. Also it fixes QtQuickControls push buttons which do change focus when pressed BUG: 339099 Diffs - kstyle/breezestyle.cpp b0a3fc9 Diff: https://git.reviewboard.kde.org/r/120222/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120222: When the button is being pressed draw background like it has focus
On Sept. 22, 2014, 11:06 p.m., David Edmundson wrote: bump. In case it matters, I have no objection to this change. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120222/#review67247 --- On Sept. 15, 2014, 6:29 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120222/ --- (Updated Sept. 15, 2014, 6:29 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze Description --- When the button is being pressed draw like it has focus PushButtons typically turn blue because they gain focus, whereas tool buttons don't. This means buttons look inconsistent. Also it fixes QtQuickControls push buttons which do change focus when pressed BUG: 339099 Diffs - kstyle/breezestyle.cpp b0a3fc9 Diff: https://git.reviewboard.kde.org/r/120222/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120327: Fix crash in ImageWallpaper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120327/ --- Review request for Plasma. Repository: plasma-workspace Description --- Fix crash in ImageWallpaper When not in a package (i.e a lone image) the metadata file cannot be loaded. This returns an invalid metadata (KPluginInfo) with isValid() set to false but an invalid d pointer. Diffs - wallpapers/image/backgroundlistmodel.cpp a667c10 Diff: https://git.reviewboard.kde.org/r/120327/diff/ Testing --- In config to change the wallpaper click the remove button of one of your own images, it didn't crash. It fixes it, but I'm not convinced it's the correct fix, we're still spewing warnings about the package being broken. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Bugs
We've all slacked off on the bug triage a lot. It is far far easier if we deal with things as they come in, not let things pile up. What I found quite frustrating when cleaning up today is people commenting and then leaving bugs as unconfirmed. Bugs are either: - not going to be implemented (resolved) - waiting for more data (needsinfo) - confirmed Please don't leave things in unconfirmed it means I end up triaging something which someone else has already looked at. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120329/ --- (Updated Sept. 23, 2014, 7:39 a.m.) Review request for Plasma and Martin Gräßlin. Changes --- added plasma review group Repository: kwayland Description --- PlasmaShell and PlasmaSurface interfaces Diffs - autotests/client/test_wayland_registry.cpp 54aa9a560153d00924d4e73c75f029ed1d1ad788 src/client/CMakeLists.txt e00f4573ad22efc9b5776b5ef900854c04f8afd6 src/client/plasma_shell.h PRE-CREATION src/client/plasma_shell.cpp PRE-CREATION src/client/plasma_surface.h PRE-CREATION src/client/plasma_surface.cpp PRE-CREATION src/client/registry.h 103be0aec9cae6d76c62fd32481eaaafa5a161f0 src/client/registry.cpp 17d738415e395fb638751ac6429d1fc0e3ededd9 Diff: https://git.reviewboard.kde.org/r/120329/diff/ Testing --- Work in progress Plasma port to Wayland. Thanks, Pier Luigi Fiorini ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120329/#review67255
---
src/client/CMakeLists.txt
https://git.reviewboard.kde.org/r/120329/#comment46931
there is no need to add private include dirs. This should be done by adding
the appropriate target_link_libraries
src/client/CMakeLists.txt
https://git.reviewboard.kde.org/r/120329/#comment46932
what's the state of getting this into ECM?
src/client/plasma_shell.h
https://git.reviewboard.kde.org/r/120329/#comment46945
why the QtCore/ prefix?
src/client/plasma_shell.h
https://git.reviewboard.kde.org/r/120329/#comment46933
trailing whitespace
src/client/plasma_shell.h
https://git.reviewboard.kde.org/r/120329/#comment46937
why is this in PlasmaShell? Shouldn't it be in the PlasmaSurface?
src/client/plasma_shell.h
https://git.reviewboard.kde.org/r/120329/#comment46936
trailing whitespace
src/client/plasma_shell.h
https://git.reviewboard.kde.org/r/120329/#comment46935
trailing whitespace
src/client/plasma_shell.h
https://git.reviewboard.kde.org/r/120329/#comment46934
why are these wl_surface and not PlasmaShellSurface/
src/client/plasma_shell.h
https://git.reviewboard.kde.org/r/120329/#comment46944
const QListwl_surface*
src/client/plasma_shell.h
https://git.reviewboard.kde.org/r/120329/#comment46943
const QListSurface*
src/client/plasma_shell.cpp
https://git.reviewboard.kde.org/r/120329/#comment46942
note: this causes the QList to detach. You want to pass in the surfaces as
const
src/client/plasma_shell.cpp
https://git.reviewboard.kde.org/r/120329/#comment46941
KDE coding style requires {} for single conditions. This is a difference to
the qt style
src/client/plasma_surface.h
https://git.reviewboard.kde.org/r/120329/#comment46940
why wrapped in QT_BEGIN_NAMESPACE? I have never seen that in KDE code
src/client/plasma_surface.h
https://git.reviewboard.kde.org/r/120329/#comment46939
I'm not sure whether we need this. Plasma is using kscreen and not QScreen.
src/client/plasma_surface.cpp
https://git.reviewboard.kde.org/r/120329/#comment46938
we normally do not use Q_EMIT but emit
- Martin Gräßlin
On Sept. 23, 2014, 7:39 a.m., Pier Luigi Fiorini wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120329/
---
(Updated Sept. 23, 2014, 7:39 a.m.)
Review request for Plasma and Martin Gräßlin.
Repository: kwayland
Description
---
PlasmaShell and PlasmaSurface interfaces
Diffs
-
autotests/client/test_wayland_registry.cpp
54aa9a560153d00924d4e73c75f029ed1d1ad788
src/client/CMakeLists.txt e00f4573ad22efc9b5776b5ef900854c04f8afd6
src/client/plasma_shell.h PRE-CREATION
src/client/plasma_shell.cpp PRE-CREATION
src/client/plasma_surface.h PRE-CREATION
src/client/plasma_surface.cpp PRE-CREATION
src/client/registry.h 103be0aec9cae6d76c62fd32481eaaafa5a161f0
src/client/registry.cpp 17d738415e395fb638751ac6429d1fc0e3ededd9
Diff: https://git.reviewboard.kde.org/r/120329/diff/
Testing
---
Work in progress Plasma port to Wayland.
Thanks,
Pier Luigi Fiorini
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120329/#review67256 --- I also need to point out that I won't accept the code unless it has auto tests :-) - Martin Gräßlin On Sept. 23, 2014, 7:39 a.m., Pier Luigi Fiorini wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120329/ --- (Updated Sept. 23, 2014, 7:39 a.m.) Review request for Plasma and Martin Gräßlin. Repository: kwayland Description --- PlasmaShell and PlasmaSurface interfaces Diffs - autotests/client/test_wayland_registry.cpp 54aa9a560153d00924d4e73c75f029ed1d1ad788 src/client/CMakeLists.txt e00f4573ad22efc9b5776b5ef900854c04f8afd6 src/client/plasma_shell.h PRE-CREATION src/client/plasma_shell.cpp PRE-CREATION src/client/plasma_surface.h PRE-CREATION src/client/plasma_surface.cpp PRE-CREATION src/client/registry.h 103be0aec9cae6d76c62fd32481eaaafa5a161f0 src/client/registry.cpp 17d738415e395fb638751ac6429d1fc0e3ededd9 Diff: https://git.reviewboard.kde.org/r/120329/diff/ Testing --- Work in progress Plasma port to Wayland. Thanks, Pier Luigi Fiorini ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces
On Sept. 23, 2014, 5:39 a.m., Martin Gräßlin wrote: I am not comfortable with this going into the master branch yet. I do want master to get into the state where we can provide API and ABI stability. By adding development code it would become difficult to reach this state. What I find most problematic is the requirement of having to use the QPA connection. This means the code is currently unusable as it requires an unreleased Qt component (I don't accept QtWayland dependency neither direct or indirect till it's released and we depend on that Qt version). Also this makes the library difficult to use as some parts can and some parts cannot be used with the ConnectionThread. I would like us to find a solution for this problem before it goes into master branch. qtwayland should be released with Qt 5.4, but if it doesn't and there's no solution but use the QPA connection that means no Plasma on Wayland at all. :( As far as having to use the QPA connection: I don't like it either but you need the native interface to get wl_surface out of a QWindow anyway and using the ConnectionThread connection gives protocol errors as the wl_surface is not recognized. In the Qt 5 world I guess that's the way it is supposed to be: QPA exposes the native interface details. - Pier Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120329/#review67254 --- On Sept. 23, 2014, 5:39 a.m., Pier Luigi Fiorini wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120329/ --- (Updated Sept. 23, 2014, 5:39 a.m.) Review request for Plasma and Martin Gräßlin. Repository: kwayland Description --- PlasmaShell and PlasmaSurface interfaces Diffs - autotests/client/test_wayland_registry.cpp 54aa9a560153d00924d4e73c75f029ed1d1ad788 src/client/CMakeLists.txt e00f4573ad22efc9b5776b5ef900854c04f8afd6 src/client/plasma_shell.h PRE-CREATION src/client/plasma_shell.cpp PRE-CREATION src/client/plasma_surface.h PRE-CREATION src/client/plasma_surface.cpp PRE-CREATION src/client/registry.h 103be0aec9cae6d76c62fd32481eaaafa5a161f0 src/client/registry.cpp 17d738415e395fb638751ac6429d1fc0e3ededd9 Diff: https://git.reviewboard.kde.org/r/120329/diff/ Testing --- Work in progress Plasma port to Wayland. Thanks, Pier Luigi Fiorini ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
