D11909: Properly use kpackage_install_package

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:45ca8d95d543: Properly use kpackage_install_package 
(authored by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11909?vs=31238=40899

REVISION DETAIL
  https://phabricator.kde.org/D11909

AFFECTED FILES
  CMakeLists.txt

To: zzag, #breeze, davidedmundson
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D15093: Add WireGuard capability.

[Pino Toscano]

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  Much better now!
  
  General notes:
  
  - there are various checks on lengths of strings like `str.length() > 0` or 
`str.length() != 0`: if all you need is check whether a string is empty or not, 
just use `str.isEmpty()`
  - regarding the UI for all the pre/post scripts: since they are file paths, 
better use a KUrlRequester widget (limited to local existing files only, no 
URLs), so the users have a Browse button next to each line edit that can be 
used to open a file dialog

INLINE COMMENTS

> nm-wireguard-service.h:2
> +/* -*- Mode: C; tab-width: 4; indent-tabs-mode: t; c-basic-offset: 4 -*- */
> +/* nm-openvpn-service - openvpn integration with NetworkManager
> + *

this comment needs to be fixed

> wireguard.cpp:25
> +#include 
> +#include 
> +#include 

unused

> wireguard.cpp:29-30
> +#include 
> +#include 
> +#include 
> +#include 

both unused

> wireguard.cpp:41
> +
> +#include 
> +

unused

> wireguard.cpp:60
> +#define NMV_WG_TAG_FWMARK"FwMark"
> +#define NMV_WG_ASSIGN"="
> +

unused

> wireguard.cpp:151-153
> +KConfig importFile(fileName, KConfig::NoGlobals);
> +KConfigGroup interfaceGroup = importFile.group(NMV_WG_TAG_INTERFACE);
> +KConfigGroup peerGroup = importFile.group(NMV_WG_TAG_PEER);;

make all 3 as `const`, so it is clear they are read-only (and attempts to use 
writeEntry() will result in build failures)

> wireguard.cpp:153
> +KConfigGroup interfaceGroup = importFile.group(NMV_WG_TAG_INTERFACE);
> +KConfigGroup peerGroup = importFile.group(NMV_WG_TAG_PEER);;
> +

extra ';'

> wireguard.cpp:166-172
> +// The config file must have both [Interface] and [Peer] sections
> +if (!importFile.groupList().contains("Interface")
> +|| !importFile.groupList().contains("Peer")) {
> +mError = VpnUiPlugin::Error;
> +mErrorMessage = i18n("Could not open file");
> +return result;
> +}

These checks can be moved right after reading the config file and getting the 
KConfigGroup objects.

> wireguard.cpp:167-168
> +// The config file must have both [Interface] and [Peer] sections
> +if (!importFile.groupList().contains("Interface")
> +|| !importFile.groupList().contains("Peer")) {
> +mError = VpnUiPlugin::Error;

You do not need to get the list of groups in the config file (twice): earlier 
you get the KConfigGroup objects for the groups, so checking eg 
`interfaceGroup.exists()` should do the job.

> wireguard.cpp:175-178
> +value = interfaceGroup.readEntry(NMV_WG_TAG_ADDRESS);
> +{
> +QStringList addressList;
> +addressList << value.split(QRegExp("\\s*,\\s*"));

KConfig already supports comma-separated lists -- just pass QStringList() as 
`default` value to readEntry(), so KConfigGroup knows the value is a list.

> wireguard.cpp:195
> +// Listen Port
> +value = interfaceGroup.readEntry(NMV_WG_TAG_LISTEN_PORT);
> +if (value.length() > 0) {

If you specify `0` as default parameter, KConfigGroup will try to decode the 
value as integer automatically. If `0` is a valid value for the port, then use 
`-1`.
After doing that, you do not need a validator anymore, just a manual range 
check will do the job.

> wireguard.cpp:209
> +QRegExp validatorRegex(*regexStrings.keySpec);
> +QRegExpValidator validator(validatorRegex);
> +int pos = 0;

this validator is not needed, just use `validatorRegex` directly

> wireguard.cpp:231
> +// MTU
> +value = interfaceGroup.readEntry(NMV_WG_TAG_MTU);
> +if (value.length() > 0) {

same as for the listen port: please read the value directly as integer.

> wireguard.cpp:271
> +QRegExp validatorRegex(*regexStrings.keySpec);
> +QRegExpValidator validator(validatorRegex);
> +int pos = 0;

as above, no need for a validator, just use the QRegExp directly

> wireguard.cpp:288
> + + ", *)*" + *regexStrings.ip4Orip6Address);
> +QRegExpValidator *validator = new QRegExpValidator(allowedIPsRegex, 
> this);
> +if (validator->validate(value, pos) != QValidator::State::Invalid) {

as above, no need for a validator, just use the QRegExp directly

> wireguard.cpp:306
> +QRegExp validatorRegex(*regexStrings.keySpec);
> +QRegExpValidator validator(validatorRegex);
> +int pos = 0;

as above, no need for a validator, just use the QRegExp directly

> wireguard.cpp:350-353
> +value = dataMap[NM_WG_KEY_ADDR_IP4];
> +if (dataMap.contains(QLatin1String(NM_WG_KEY_ADDR_IP6))) {
> +value += "," + dataMap[NM_WG_KEY_ADDR_IP6];
> +}

as mentioned above: KConfigGroup supports lists

> wireguard.cpp:361-365
> +// Do Private Key
> +if (dataMap.contains(QLatin1String(NM_WG_KEY_PRIVATE_KEY)))
> +interfaceGroup.writeEntry(NMV_WG_TAG_PRIVATE_KEY, 
> 

D15093: Add WireGuard capability.

[Bruce Anderson]

andersonbruce added inline comments.

INLINE COMMENTS

> pino wrote in wireguard.cpp:175-178
> KConfig already supports comma-separated lists -- just pass QStringList() as 
> `default` value to readEntry(), so KConfigGroup knows the value is a list.

The problem with using the KConfig method is if a space slips into the config 
file before or after the comma then the spaces are left in one or the other of 
the QStrings and I have to process each entry in the list to remove the spaces. 
The files can come from elsewhere, e.g. I have some provided by my VPN which 
have spaces in comma separated lists. Using split allows both operations to be 
performed at the same time.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, anthonyfieroni, pino, lbeltrame, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D15233: Add a tooltip for the appentry in the kicker

[Ivan Razzhivin]

underwit created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
underwit requested review of this revision.

REVISION SUMMARY
  Hello!
  My improvement shows a tooltip for applications in ther kicker menu.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15233

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/plugin/abstractentry.cpp
  applets/kicker/plugin/abstractentry.h
  applets/kicker/plugin/abstractmodel.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appentry.h
  applets/kicker/plugin/appsmodel.cpp

To: underwit
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15226: Check against QRect whether pointer is inside DecorationButton

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  would adding
  
  bool DecorationButton::contains(QPoint) const
  
  make sense?

INLINE COMMENTS

> decoration.cpp:386
>  for (DecorationButton *button : d->buttons) {
>  if (button->geometry().contains(event->posF())) {
>  QCoreApplication::instance()->sendEvent(button, event);

Missed one

REPOSITORY
  R129 Window Decoration Library

BRANCH
  fix-hover-with-zero-spacing

REVISION DETAIL
  https://phabricator.kde.org/D15226

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15226: Check against QRect whether pointer is inside DecorationButton

[Vlad Zagorodniy]

zzag added a comment.


  In D15226#319409 , @davidedmundson 
wrote:
  
  > would adding
  >
  > bool DecorationButton::contains(QPoint) const
  >
  > make sense?
  
  
  Yes, it would. I'll add this method. :-)

REPOSITORY
  R129 Window Decoration Library

BRANCH
  fix-hover-with-zero-spacing

REVISION DETAIL
  https://phabricator.kde.org/D15226

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15093: Add WireGuard capability.

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> wireguard.cpp:71
> +{
> +regexStrings.ip4Range = new QString(
> +"(?:[0-1]?[0-9]?[0-9]|2[0-4][0-9]|25[0-5])");

You can use simpleipv[4,6]validator we have in plasma-nm instead of using 
everything below. Or maybe QHostAddress can validate it for you?

> wireguard.cpp:185
> +}
> +else if (addressIn.first.protocol() == 
> QAbstractSocket::NetworkLayerProtocol::IPv6Protocol) {
> +dataMap.insert(QLatin1String(NM_WG_KEY_ADDR_IP6), 
> addressList[i]);

Coding style.

> wireguard.cpp:215
> +}
> +else {
> +return result;

Coding style.

> wireguard.cpp:318
> +if (!haveAddress || !havePrivateKey || !havePublicKey || 
> !haveAllowedIps) {
> +
> +mError = VpnUiPlugin::Error;

Remove space.

> wireguard.h:34
> +public:
> +explicit WireGuardUiPlugin(QObject* parent = nullptr, const 
> QVariantList& = QVariantList());
> +~WireGuardUiPlugin() override;

Coding style. You mix funcName(Bar* foo) with funcName(Bar * foo) and 
funcName(Bar *foo), plese change it all to the last one. Same goes for 
functions below.

> wireguardadvancedwidget.h:55
> +
> +private Q_SLOTS:
> +

Can be removed if you don't have any private slot.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, anthonyfieroni, pino, lbeltrame, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D15093: Add WireGuard capability.

[Bruce Anderson]

andersonbruce added a comment.


  In D15093#319253 , @pino wrote:
  
  > Much better now!
  >
  > - regarding the UI for all the pre/post scripts: since they are file paths, 
better use a KUrlRequester widget (limited to local existing files only, no 
URLs), so the users have a Browse button next to each line edit that can be 
used to open a file dialog
  
  
  I debated with myself when I started this whether to include these at all. 
They are included in the base NetworkManager implementation which "inherited" 
them from the underlying wg-quick command but they duplicate functionality that 
NM provides directly and it seems to me that if someone is using NM then they 
can use those methods instead. Also, wg-quick specifies these as "script 
snippets" meaning actual direct commands that are executed by bash not 
necessarily a shell script. It also specifies that there can be multiple 
instances of each, a capability that the base NM implementation does not 
support. So my quandary is, do I implement this like the base NM does and 
possibly, as you suggest, force it to be a single shell script which sort of 
violates the spirit of the wg-quick command or do I delete it completely and 
not support something that base NM does, or do I leave it like it is?
  
  Personally I think that the base NM should get rid of these and force users 
to rely on the capability in NM to perform pre and post operations but given 
what exists, I don't think any of the alternatives are good and I'm not sure 
what the "least bad" solution is. If someone uses nm-connection-editor and 
enters something which is not a script and then opens the connection in a 
plasma-nm interface which only supports a file, I'm not sure what will happen. 
On the other hand if I delete the fields completely and open something created 
in nm-connection-editor with these fields, that's not good either.
  
  Since I initially was doing this only for my own use and was probably going 
to use NM for this, I admit that I took the easiest way out and duplicated what 
base NM has, which is a single string which can contain a shell script but also 
a snippet as the base WireGuard does and then said in the tool-tip that it was 
preferable to use NM capability instead.
  
  If you as a representative of the plasma-nm philosophy have a preference on 
which way to go or have a brilliant idea which solves all the problems, I will 
follow your lead.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, anthonyfieroni, pino, lbeltrame, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D15226: Check against QRect whether pointer is inside DecorationButton

[Vlad Zagorodniy]

zzag updated this revision to Diff 40900.
zzag added a comment.


  Add test

REPOSITORY
  R129 Window Decoration Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15226?vs=40876=40900

BRANCH
  fix-hover-with-zero-spacing

REVISION DETAIL
  https://phabricator.kde.org/D15226

AFFECTED FILES
  autotests/decorationbuttontest.cpp
  src/decoration.cpp
  src/decorationbutton.cpp

To: zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Monday meeting notes for 2018-09-03 (week 36)

[Roman Gilg]

Marco:

- DONE -
Kirigami:
* irc and matrix channels, all bridged together (done by Bhushan)
* start translations for kirigami gallery in its standalone repo
* bugfix: refine when icons get forced to monochrome and when not, should
fix mobile issues on some apps getting colored icons forced to black
* bugfix: FormLayout works better on small screen/mobile: fixed a
touchscreen issue and loads directly in single column mode on narrow screens
* bugfix: context drawer closes also when the action pushes a new page
* bugfix: remove hardcoded background rectangle from the whole app
* bugfix: fix holes in menus on Material style
* bugfix: fixed a couple of issues in the collapsible global drawer
* feature: ActionToolBar supports actions that are always hidden in the menu
* support disabled actions on the 3 main action buttons in mobile mode
* support for submenus on the 3 main action buttons in mobile mode
* mentoring a new guy (Dimitris) to some junor job in kirigami

Plasma Virtual Desktop:
* fix kwin to make old virtual desktop autotests work
* add a bunch of new autotests for the new vds

Multilevel KCMs:
* added an hack to keep old systemsettings work on a new framework

- PLAN -
Multilevel KCMs:
* difficulty/for this week: due to the fact we can't write on internal qml
contexts, the applicationwindow can't be used, multilevel api needs to be
in kcm, tough is fine as gives better abstraction

- Q -
(Kai Uwe) "support for submenus on the 3 main action buttons in mobile
mode" what'S that? so yoju can click one of those floating buttons and get
a menu?
(Marco) in mobile mode you have the big round button att he bottom. so
yeah, you can in theory get a menu


Kai Uwe:

- DONE -
* Investigated and fixed a ton of KIO/Gvfs/SMB-related issues
  * Now finds "gvfsd" mounts rather than just the /run/... parent directory
of those
  * Fixed "disk full" error when trying to copy files onto gvfs-mounted smb
share (e.g. LibreOffice)
  * Fixed "cannot change permission" warning when trying to copy files onto
gvfs-mounted smb share
  * Found that kioexecd only monitors for file changes to re-upload them,
misses delete-and-recreate cycle, leading to data loss in LibreOffice
  * KSambaShare accepts spaces in ACL host names now, fixes setting
permissions and guest access on "Share" tab
* Removed HTML thumbnailer
  * QtWebEngine cannot render to QPixmap and using WebKit or other
unmaintained lib is a security risk
* Fixed KWin using i18n before qApp construction (now asserts in ki18n)

- PLAN -
* More blockage/freeze fixes in KIO
  * Quite frustrating, just clicking a folder results in eight(!)
succeeding blocking calls (e.g. QFileInfo creation) in various libraries
and classes
* Folder View fixes

- Q -
(Roman) What's your overall impression working with the [KIO] code? Is it
in fine conditions or are there some big issues?
(Kai Uwe) when I enter a directory there's eight blocking file system calls
all over the place. many of the APIs are "innocently synchronous". they
look fine but break apart when that "local file" is some remote mounted
location
(Roman) so overall impression not so good?
(Kai Uwe) it's a bit overengineeded and convoluted, and ld :) and it's
all built around the assumption that local files are always fine and fast.
which is fine-ish in a KIO world where remote stuff is out of process using
Kio job but with fuse and the like it's horrible


Eike:

- DONE -
* Getting married

- PLAN -
* I expect to start responding to Phabricator things tomorrow
* And then just fix pressing bugs
* And then figure out what's next on the plate (maybe virtual desktop
stuff?)

- Q -
(Eike) you need to catch me up on the activities discussion you had at
Akademy or are notes on it up on the list now?
(Roman) Don't think there are notes. But basically it was more a feedback
round people saying how they use VDs and/or Activites. Bottom line: most
people use VDs only, but some people use Activities. And if they do they
also use VDs, which was somewhat to be expected.
(David) notes are my fault, I'll try and do it.


Roman:

- DONE -
* Refined my Dnd work, currently testing it.
* D15225: I have separated this one from my Dnd work, because I want to get
some feedback on why this innocently looking change wasn't done in the past
already. Is there a technical problem to it I overlook? (
https://phabricator.kde.org/D15225)
* Pushed D13084 as a temporary fix for unresponsive centered TabBox on
Wayland. (https://phabricator.kde.org/D13084)
* Just uploaded D15234, which will remove the annoying constrained pointer
messages in Wayland session. (https://phabricator.kde.org/D15234)

- PLAN -
* Testing my Dnd branch.
* Looking into the Touchpad/Mouse KCM bugs, which piled up since the
rewrite in 5.13.

- Q -
* I need some diffs getting reviewed. Some of them are pretty small:
D15072, D15074 (https://phabricator.kde.org/D15072,

D15245: Start looking for the context from the delegate itself

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Rather than the view, otherwise we don't get to access the view's
  properties, which may be useful.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15245

AFFECTED FILES
  src/delegaterecycler.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D15243: Remove some double look-ups

[Aleix Pol Gonzalez]

apol updated this revision to Diff 40919.
apol added a comment.


  Add missing part

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15243?vs=40915=40919

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15243

AFFECTED FILES
  src/delegaterecycler.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D15226: Check against QRect whether pointer is inside DecorationButton

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R129:c9cfd840137b: Check against QRect whether pointer is 
inside DecorationButton (authored by zzag).

REPOSITORY
  R129 Window Decoration Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15226?vs=40905=40909

REVISION DETAIL
  https://phabricator.kde.org/D15226

AFFECTED FILES
  autotests/decorationbuttontest.cpp
  src/decoration.cpp
  src/decorationbutton.cpp
  src/decorationbutton.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Plasma 5.14 Release Announcement

[Kai Uwe Broulik]

Hi all,

please fill in all the exciting stuff you've been working on this 
release cycle into the following etherpad:


https://notes.kde.org/p/plasma_5_14

For Plasma 5.14 I would suggest we let our awesome new promo folks come 
up with an announcement. What do you think?


Thanks
Kai Uwe

D15226: Check against QRect whether pointer is inside DecorationButton

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  thanks

REPOSITORY
  R129 Window Decoration Library

BRANCH
  fix-hover-with-zero-spacing

REVISION DETAIL
  https://phabricator.kde.org/D15226

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15226: Check against QRect whether pointer is inside DecorationButton

[Vlad Zagorodniy]

zzag updated this revision to Diff 40905.
zzag added a comment.


  Add `contais` method

REPOSITORY
  R129 Window Decoration Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15226?vs=40900=40905

BRANCH
  fix-hover-with-zero-spacing

REVISION DETAIL
  https://phabricator.kde.org/D15226

AFFECTED FILES
  autotests/decorationbuttontest.cpp
  src/decoration.cpp
  src/decorationbutton.cpp
  src/decorationbutton.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15243: Remove some double look-ups

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

TEST PLAN
  My apps still work

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15243

AFFECTED FILES
  src/delegaterecycler.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D15247: Show tooltips in krunner

[Nathaniel Graham]

ngraham added reviewers: Plasma, broulik.
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  The patch does not apply because of an extraneous `milou` in the path for 
your diff:
  
  `milou/lib/qml/ResultDelegate.qml`
  should be
  `lib/qml/ResultDelegate.qml`
  
  Consider setting up `arc`; it makes the patch submission process so much 
simpler and less error-prone. :)
  
  
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.11 - Build # 19 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.11/19/
 Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.11
 Date of build:
Mon, 03 Sep 2018 20:42:51 +
 Build duration:
3 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 1.23 MB...]Scanning dependencies of target launchertasksmodeltest_autogenScanning dependencies of target tasktoolstest_autogen[ 69%] Automatic MOC for target launchertasksmodeltest[ 69%] Automatic MOC for target tasktoolstest[ 69%] Built target launchertasksmodeltest_autogen[ 69%] Built target tasktoolstest_autogen[ 69%] Building CXX object gmenu-dbusmenu-proxy/CMakeFiles/gmenudbusmenuproxy.dir/utils.cpp.oScanning dependencies of target taskmanagerplugin_autogenScanning dependencies of target appmenu_autogen[ 70%] Generating appmenu.json[ 70%] Automatic MOC for target taskmanagerpluginAbout to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/kdedmodule.desktop"Found property definition "X-KDE-FactoryName" with type "QString"Found property definition "X-KDE-Kded-autoload" with type "bool"Found property definition "X-KDE-Kded-load-on-demand" with type "bool"Found property definition "X-KDE-Kded-phase" with type "int"Found property definition "X-KDE-OnlyShowOnQtPlatforms" with type "QStringList"Generated  "/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.11/build/appmenu/appmenu.json" [ 70%] Automatic MOC for target appmenu[ 70%] Built target taskmanagerplugin_autogenScanning dependencies of target testPlatformDetection_autogen[ 71%] Automatic MOC for target testPlatformDetection[ 71%] Built target appmenu_autogenScanning dependencies of target holidayeventshelperplugin[ 71%] Building CXX object plasmacalendarintegration/qmlhelper/CMakeFiles/holidayeventshelperplugin.dir/holidayeventshelperplugin.cpp.o[ 71%] Built target testPlatformDetection_autogen[ 71%] Building CXX object plasmacalendarintegration/qmlhelper/CMakeFiles/holidayeventshelperplugin.dir/holidayeventshelperplugin_autogen/mocs_compilation.cpp.o/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.11/gmenu-dbusmenu-proxy/menu.cpp: In lambda function:/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.11/gmenu-dbusmenu-proxy/menu.cpp:172:29: warning: comparison of integer expressions of different signedness: ���const uint��� {aka ���const unsigned int���} and ���const int��� [-Wsign-compare] return item.section == section;~^~/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.11/gmenu-dbusmenu-proxy/menu.cpp: In lambda function:/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.11/gmenu-dbusmenu-proxy/menu.cpp:229:43: warning: comparison of integer expressions of different signedness: ���const uint��� {aka ���const unsigned int���} and ���int��� [-Wsign-compare] if (change.itemsToRemoveCount == change.itemsToInsert.count()) { ~~^~~/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.11/gmenu-dbusmenu-proxy/menu.cpp:239:35: warning: comparison of integer expressions of different signedness: ���int��� and ���const uint��� {aka ���const unsigned int���} [-Wsign-compare] for (int i = 0; i < change.itemsToRemoveCount; ++i) { ~~^~~Scanning dependencies of target colorcorrectplugin_autogen[ 71%] Building CXX object gmenu-dbusmenu-proxy/CMakeFiles/gmenudbusmenuproxy.dir/debug.cpp.o[ 71%] Automatic MOC for target colorcorrectplugin[ 71%] Building CXX object gmenu-dbusmenu-proxy/CMakeFiles/gmenudbusmenuproxy.dir/dbusmenuadaptor.cpp.o[ 71%] Linking CXX shared module ../bin/soliduiserver.so[ 71%] Built target colorcorrectplugin_autogenScanning dependencies of target colorcorrectlocationupdater_autogen[ 71%] Generating colorcorrectlocationupdater.jsonAbout to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/kdedmodule.desktop"Found property definition "X-KDE-FactoryName" with type "QString"Found property definition "X-KDE-Kded-autoload" with type "bool"Found property definition "X-KDE-Kded-load-on-demand" with type "bool"Found property definition "X-KDE-Kded-phase" with type "int"Found property definition "X-KDE-OnlyShowOnQtPlatforms" with type "QStringList"Generated  "/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.11/build/libcolorcorrect/kded/colorcorrectlocationupdater.json" Scanning dependencies of target nightcolortest_autogen[ 71%] Automatic MOC for target colorcorrectlocationupdater[ 71%] Automatic MOC for target nightcolortest[ 71%] Built target colorcorrectlocationupdater_autogen[ 71%] Building CXX object gmenu-dbusmenu-proxy/CMakeFiles/gmenudbusmenuproxy.dir/gmenudbusmenuproxy_autogen/mocs_compilation.cpp.o[ 71%] Building CXX object 

D15254: Fix Firefox profile location lookup after location has changed

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  When the profile has initially been looked up, the location is saved to
  the global config. Afterwards, the location is never updated even if
  the profile has been replaced, due to an inverted exits() check.

TEST PLAN
  1. Check dbfile in kdeglobals is pointing to a valid profile
  
  2a. Change the dbfile setting - or -
  2b. Remove the existing profile and create a new one
  
  3. Restart krunner - it should fix the config entry/use the new profile

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15254

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: bruns, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15243: Remove some double look-ups

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> broulik wrote in delegaterecycler.cpp:73
> `m_refs.erase(itRef)`?

Thanks!

> broulik wrote in delegaterecycler.cpp:83
> Unrelated question: Where does this get removed from `items`?

They are unused items (delegate instances), they get deleted when it's 
destroyed.
The code looks good to me.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15243

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D15243: Remove some double look-ups

[Aleix Pol Gonzalez]

apol updated this revision to Diff 40947.
apol marked an inline comment as done.
apol added a comment.


  Remove another lookup, thanks Kai!

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15243?vs=40919=40947

BRANCH
  arcpatch-D15243

REVISION DETAIL
  https://phabricator.kde.org/D15243

AFFECTED FILES
  src/delegaterecycler.cpp

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D15243: Remove some double look-ups

[Kai Uwe Broulik]

broulik added a comment.


  +1

INLINE COMMENTS

> delegaterecycler.cpp:73
> +if (*itRef <= 0) {
>  m_refs.remove(component);
> +

`m_refs.erase(itRef)`?

> delegaterecycler.cpp:83
> +if (items.length() >= s_cacheSize) {
>  item->deleteLater();
>  return;

Unrelated question: Where does this get removed from `items`?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15243

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D14999: [PanelShadows] Use 0 offset for disabled borders on Wayland

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1cfe69b80d47: [PanelShadows] Use 0 offset for disabled 
borders on Wayland (authored by zzag).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14999?vs=40216=40928

REVISION DETAIL
  https://phabricator.kde.org/D14999

AFFECTED FILES
  shell/panelshadows.cpp

To: zzag, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15093: Add WireGuard capability.

[Pino Toscano]

pino added a comment.


  In D15093#319336 , @andersonbruce 
wrote:
  
  > If you as a representative of the plasma-nm philosophy have a preference on 
which way to go or have a brilliant idea which solves all the problems, I will 
follow your lead.
  
  
  I'm not a plasma-nm developer, @jgrulich is :)
  Your explanation makes sense, thanks for taking the time to explain it. One 
thing I (don't) see is the configuration of pre/post scripts in plasma-nm for 
other types of connections (I can only check for wired, wireless, and openvpn). 
Maybe a possible idea is to leave them out for the first version, and implement 
them later if a) deemed appropriate for plasma-nm users b) solved their 
configuration mess as you described it.

INLINE COMMENTS

> andersonbruce wrote in wireguard.cpp:175-178
> The problem with using the KConfig method is if a space slips into the config 
> file before or after the comma then the spaces are left in one or the other 
> of the QStrings and I have to process each entry in the list to remove the 
> spaces. The files can come from elsewhere, e.g. I have some provided by my 
> VPN which have spaces in comma separated lists. Using split allows both 
> operations to be performed at the same time.

This is what `QString::trimmed()` does already. Considering you are passing the 
string directly to QHostAddress, it is just easy to write

  const QPair addressIn = 
QHostAddress::parseSubnet(addressList[i].trimmed());

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, anthonyfieroni, pino, lbeltrame, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Oleg Solovyov]

McPain updated this revision to Diff 40923.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14895?vs=39934=40923

REVISION DETAIL
  https://phabricator.kde.org/D14895

AFFECTED FILES
  dataengines/soliddevice/CMakeLists.txt
  dataengines/soliddevice/soliddeviceengine.cpp
  dataengines/soliddevice/soliddeviceengine.h

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  In case of something long in krunner you can't read the whole string because 
of one line restriction and fixed krunner width.
  
  This patch enables tooltips where you can read anything krunner shows.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

AFFECTED FILES
  milou/lib/qml/ResultDelegate.qml

To: McPain
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11233: Ordered system tray

[Kristopher Ives]

kives added a comment.


  I think this is a useful feature to add to KDE. If others disagree with the 
way @wsdfhjxc implemented it I think they should provide a clear pathway to 
getting it accepted. As long as this can be implemented in a way that doesn't 
affect default sorting behavior, it doesn't make sense to refuse to allow 
people to have a custom sorting order. Reasons like the codebase being too 
fragile are implementation specific details that shouldn't deny a feature 
request.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11233

To: wsdfhjxc, #plasma_workspaces, #plasma, #vdg
Cc: kives, mart, broulik, ngraham, anthonyfieroni, Pitel, alexeymin, 
plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D15257: Set favicon DB path when when places DB path is retrieved from config

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  When the path of the places DB is fetched from the config, the path of
  the favicon DB is not initialized.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15257

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: bruns, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15256: [Mouse KCM] Avoid changes to touchpads in libinput backend

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Similar to evdev backend we need to ignore touchpad devices explicitly in the
  libinput backend because these are also pointer devices.
  
  XInput2 can do this in theory via input classes, but my touchpad did not set
  the class correctly. So just switch to using XInput like in the evdev backend
  to query all pointer devices and then use the XI_TOUCHPAD atom to filter out
  touchpads.
  
  BUG: 395401
  BUG: 395722
  BUG: 396269

TEST PLAN
  Manually

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixMouseResettingTouchpad

REVISION DETAIL
  https://phabricator.kde.org/D15256

AFFECTED FILES
  kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp

To: romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15254: Fix Firefox profile location lookup after location has changed

[Stefan Brüns]

bruns added a comment.


  The check for QFile::exists was initially added here:
  
https://github.com/KDE/kde-workspace/commit/5c6e27750605de3bba186c9dbd6a0509b68beb90#diff-57c8456496e7f0219f33e5b735f7e3f3

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15254

To: bruns, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15228: Export install location for DBUS interfaces via CMake

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:bfd3fe9cbe02: Export install location for DBUS interfaces 
via CMake (authored by bruns).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15228?vs=40880=40936

REVISION DETAIL
  https://phabricator.kde.org/D15228

AFFECTED FILES
  KScreenLockerConfig.cmake.in

To: bruns, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15229: Specify minimum version for KScreenlocker, use correct DBUS path

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:aab6b5c23ea5: Specify minimum version for KScreenlocker, 
use correct DBUS path (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15229?vs=40882=40938

REVISION DETAIL
  https://phabricator.kde.org/D15229

AFFECTED FILES
  CMakeLists.txt
  ksmserver/CMakeLists.txt

To: bruns, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.11 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.11/16/
 Project:
Plasma plasma-workspace kf5-qt5 FreeBSDQt5.11
 Date of build:
Mon, 03 Sep 2018 20:42:51 +
 Build duration:
5 min 0 sec and counting
   CONSOLE OUTPUT
  [...truncated 1.18 MB...]About to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/kdedmodule.desktop"Found property definition "X-KDE-FactoryName" with type "QString"Found property definition "X-KDE-Kded-autoload" with type "bool"Found property definition "X-KDE-Kded-load-on-demand" with type "bool"Found property definition "X-KDE-Kded-phase" with type "int"Found property definition "X-KDE-OnlyShowOnQtPlatforms" with type "QStringList"Generated  "/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.11/build/libcolorcorrect/kded/colorcorrectlocationupdater.json" [ 76%] Automatic MOC for target colorcorrectlocationupdater[ 76%] Built target colorcorrectplugin_autogenScanning dependencies of target nightcolortest_autogen[ 76%] Built target launchertasksmodeltest_autogen[ 76%] Automatic MOC for target nightcolortest[ 76%] Generating kscreensaversettings.h, kscreensaversettings.cpp[ 76%] Generating screensaver_interface.cpp, screensaver_interface.h[ 76%] Generating screensaver_interface.moc[ 76%] Built target colorcorrectlocationupdater_autogen[ 76%] Generating krunner_interface.cpp, krunner_interface.h[ 76%] Generating plasmashelladaptor.cpp, plasmashelladaptor.h[ 76%] Built target tasktoolstest_autogenScanning dependencies of target klipper_autogen[ 76%] Generating krunner_interface.moc[ 76%] Automatic MOC for target klipper[ 77%] Generating plasmashelladaptor.moc[ 77%] Built target klipper_autogen[ 77%] Generating appadaptor.cpp, appadaptor.h[ 77%] Generating appadaptor.mocScanning dependencies of target sessionsprivateplugin[ 78%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsmodel.cpp.o[ 78%] Built target nightcolortest_autogen[ 78%] Generating org.kde.KCMinit.xmlgmake[2]: *** No rule to make target '/org.kde.screensaver.xml', needed by 'ksmserver/kscreenlocker_interface.cpp'.  Stop.gmake[2]: *** Waiting for unfinished jobs[ 78%] Generating klauncher_interface.cpp, klauncher_interface.hgmake[1]: *** [CMakeFiles/Makefile2:3255: ksmserver/CMakeFiles/kdeinit_ksmserver.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 78%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsprivateplugin.cpp.oScanning dependencies of target krunner[ 78%] Building CXX object krunner/CMakeFiles/krunner.dir/main.cpp.oScanning dependencies of target plasmashell[ 78%] Building CXX object shell/CMakeFiles/plasmashell.dir/alternativeshelper.cpp.o[ 78%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/screensaver_interface.cpp.o/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.11/components/sessionsprivate/sessionsmodel.cpp:212:74: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]QObject::connect(watcher, ::finished, this, [this, cb](QDBusPendingCallWatcher *watcher) { ^[ 78%] Building CXX object krunner/CMakeFiles/krunner.dir/view.cpp.o1 warning generated.[ 78%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/kscreensaversettings.cpp.o[ 78%] Building CXX object shell/CMakeFiles/plasmashell.dir/main.cpp.o[ 78%] Building CXX object components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsprivateplugin_autogen/mocs_compilation.cpp.o[ 78%] Building CXX object shell/CMakeFiles/plasmashell.dir/containmentconfigview.cpp.o[ 78%] Linking CXX shared library ../../bin/libsessionsprivateplugin.so[ 78%] Building CXX object shell/CMakeFiles/plasmashell.dir/currentcontainmentactionsmodel.cpp.o[ 78%] Built target sessionsprivateplugin[ 78%] Building CXX object krunner/CMakeFiles/krunner.dir/appadaptor.cpp.o[ 78%] Building CXX object krunner/CMakeFiles/krunner.dir/krunner_autogen/mocs_compilation.cpp.o[ 78%] Building CXX object shell/CMakeFiles/plasmashell.dir/desktopview.cpp.o/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.11/shell/currentcontainmentactionsmodel.cpp:226:14: warning: lambda capture 'configDlg' is not used [-Wunused-lambda-capture][configDlg, pluginInstance] () { ^1 warning generated.[ 78%] Building CXX object shell/CMakeFiles/plasmashell.dir/panelview.cpp.o[ 79%] Building CXX object shell/CMakeFiles/plasmashell.dir/panelconfigview.cpp.o[ 80%] Linking CXX executable ../bin/krunner[ 80%] Built target krunner[ 80%] Building CXX object shell/CMakeFiles/plasmashell.dir/panelshadows.cpp.o[ 80%] Building CXX object shell/CMakeFiles/plasmashell.dir/shellcorona.cpp.o[ 80%] Building CXX object