D23261: Add option to discourage reporting bugs

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> sitter wrote in statusnotifier.cpp:144
> I care more about the context that this is a notification message than about 
> the brevity recommendation.

We never do that. Do we have a `@context` for that or should I just write 
`i18nc("Notification text", "...")`?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D23261

To: broulik, #plasma
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23261: Add option to discourage reporting bugs

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> broulik wrote in statusnotifier.cpp:144
> We never do that. Do we have a `@context` for that or should I just write 
> `i18nc("Notification text", "...")`?

We do not. I always check my handy cheat sheet 
http://people.ubuntu.com/~apachelogger/misc/i18nccheatsheet.png ;)

`i18nc("Notification text", "...")` lgtm

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D23261

To: broulik, #plasma
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23261: Add option to discourage reporting bugs

[Kai Uwe Broulik]

broulik updated this revision to Diff 64647.
broulik added a comment.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.


  - Add i18nc

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23261?vs=64038&id=64647

REVISION DETAIL
  https://phabricator.kde.org/D23261

AFFECTED FILES
  src/main.cpp
  src/statusnotifier.cpp
  src/statusnotifier.h

To: broulik, #plasma
Cc: kfm-devel, sitter, davidedmundson, plasma-devel, aprcela, vmarinescu, 
fprice, LeGast00n, The-Feren-OS-Dev, jraleigh, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, ragreen, Pitel, meven, spoorun, navarromorales, 
ZrenBot, firef, andrebarros, himcesjf, emmanuelp, lesliezhai, ali-mohamed, 
mikesomov, jensreuterberg, abetts, sebas, apol, mart

D23241: Show application window icon on AboutPage

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> caspermeijn wrote in settings.h:81
> I have no idea what the value would be for that and Kirigami doesn't have any 
> example.

https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions

tldr:

- add `REVISON 10` to property
- change krigiamiplugin.cpp to register that revision

I am not sure how that would work for a singletontype though, one always needs 
all properties since any revision may be used at any time.
@apol are you sure this makes sense for singletons?

REPOSITORY
  R169 Kirigami

BRANCH
  about_icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23241

To: caspermeijn, mart, apol, #kirigami, hein
Cc: sitter, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D23261: Add option to discourage reporting bugs

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> sitter wrote in main.cpp:225
> Surely it should also return right away if isShuttingDown down and 
> interaction isn't allowed, otherwise you create a dump needlessly on account 
> of the user not being meant to report it.

What about this?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23261

To: broulik, #plasma
Cc: kfm-devel, sitter, davidedmundson, plasma-devel, aprcela, vmarinescu, 
fprice, LeGast00n, The-Feren-OS-Dev, jraleigh, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, ragreen, Pitel, meven, spoorun, navarromorales, 
ZrenBot, firef, andrebarros, himcesjf, emmanuelp, lesliezhai, ali-mohamed, 
mikesomov, jensreuterberg, abetts, sebas, apol, mart

D23261: Add option to discourage reporting bugs

[Kai Uwe Broulik]

broulik updated this revision to Diff 64649.
broulik added a comment.


  - Do nothing when shutting down in non-interactive mode

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23261?vs=64647&id=64649

REVISION DETAIL
  https://phabricator.kde.org/D23261

AFFECTED FILES
  src/main.cpp
  src/statusnotifier.cpp
  src/statusnotifier.h

To: broulik, #plasma
Cc: kfm-devel, sitter, davidedmundson, plasma-devel, aprcela, vmarinescu, 
fprice, LeGast00n, The-Feren-OS-Dev, jraleigh, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, ragreen, Pitel, meven, spoorun, navarromorales, 
ZrenBot, firef, andrebarros, himcesjf, emmanuelp, lesliezhai, ali-mohamed, 
mikesomov, jensreuterberg, abetts, sebas, apol, mart

D23261: Add option to discourage reporting bugs

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D23261

To: broulik, #plasma, sitter
Cc: kfm-devel, sitter, davidedmundson, plasma-devel, aprcela, vmarinescu, 
fprice, LeGast00n, The-Feren-OS-Dev, jraleigh, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, ragreen, Pitel, meven, spoorun, navarromorales, 
ZrenBot, firef, andrebarros, himcesjf, emmanuelp, lesliezhai, ali-mohamed, 
mikesomov, jensreuterberg, abetts, sebas, apol, mart

D23448: Capacity degradation -> Battery health

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  That's much clearer.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  degradation-to-health (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23448

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, aspotashev, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  :/ good catch.

INLINE COMMENTS

> startuptasksmodel.cpp:178
> +// drop ".desktop" suffix
> +appId.chop(8);
>  

I quite like doing

appId.chop(strlen(".desktop"))

then it's self documenting - strlen is magical and evaluates at compile time.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixsuffixchopping

REVISION DETAIL
  https://phabricator.kde.org/D23417

To: kossebau, hein, broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23386: [Applet] Double-click on icon to make it the default

[David Edmundson]

davidedmundson added a comment.


  I don't like patches with secret features that rely on double click. We don't 
use double click in our UIs and we should be consistent.
  
  Also if we do have a UX problem where finding how to change the default is 
hard (which D23389  states) adding even 
more elusive ways doesn't resolve the problem.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23386

To: ngraham, drosca, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> fonts.cpp:607
> +};
> +kdedInterface.call("setFont", m_generalFont.toString());
> +}

Given this is a kded module and as such a regular qt application, you should be 
able to get all of this automatically.
Is the `QGuiApplication::fontChanged` emitted when you change font settings?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D23261: Add option to discourage reporting bugs

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:81c4e8f53148: Add option to discourage reporting bugs 
(authored by broulik).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23261?vs=64649&id=64650

REVISION DETAIL
  https://phabricator.kde.org/D23261

AFFECTED FILES
  src/main.cpp
  src/statusnotifier.cpp
  src/statusnotifier.h

To: broulik, #plasma, sitter
Cc: kfm-devel, sitter, davidedmundson, plasma-devel, aprcela, vmarinescu, 
fprice, LeGast00n, The-Feren-OS-Dev, jraleigh, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, ragreen, Pitel, meven, spoorun, navarromorales, 
ZrenBot, firef, andrebarros, himcesjf, emmanuelp, lesliezhai, ali-mohamed, 
mikesomov, jensreuterberg, abetts, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in fonts.cpp:607
> Given this is a kded module and as such a regular qt application, you should 
> be able to get all of this automatically.
> Is the `QGuiApplication::fontChanged` emitted when you change font settings?

There are two designs which are both sensible:

1. we have a daemon that runs all the time so that it can listen for changes. 
When that happens it syncs things

2. something that the fonts module explicitly calls (through whatever means) 
which then syncs things.

Both have an advantage, and a disadvantage.

This is both  running all the time *and* is being explicitly called,  which is 
the worst of both worlds.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/6/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 26 Aug 2019 09:59:36 +
 Build duration:
9 min 49 sec and counting
   CONSOLE OUTPUT
  [...truncated 403 lines...][2019-08-26T10:06:21.542Z] [  8%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest.cpp.obj[2019-08-26T10:06:21.542Z] [  8%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest_autogen/mocs_compilation.cpp.obj[2019-08-26T10:06:21.542Z] crashtest.cpp[2019-08-26T10:06:21.542Z] Scanning dependencies of target drkonqi_backtrace_parser[2019-08-26T10:06:21.542Z] mocs_compilation.cpp[2019-08-26T10:06:21.542Z] [ 10%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparser.cpp.obj[2019-08-26T10:06:21.542Z] [ 10%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsergdb.cpp.obj[2019-08-26T10:06:21.542Z] [ 11%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsernull.cpp.obj[2019-08-26T10:06:21.542Z] [ 11%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserkdbgwin.cpp.obj[2019-08-26T10:06:21.542Z] LINK Pass 1: command "C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\HostX64\x64\link.exe /nologo @CMakeFiles\lsb_release.dir\objects1.rsp /out:..\..\bin\lsb_release.exe /implib:..\..\lib\lsb_release.lib /pdb:C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\bin\lsb_release.pdb /version:0.0 /machine:x64 /NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd /debug /INCREMENTAL /subsystem:windows kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:CMakeFiles\lsb_release.dir/intermediate.manifest CMakeFiles\lsb_release.dir/manifest.res" failed (exit code 1120) with the following output:[2019-08-26T10:06:21.542Z] msvcrtd.lib(exe_winmain.obj) : error LNK2019: unresolved external symbol WinMain referenced in function "int __cdecl invoke_main(void)" (?invoke_main@@YAHXZ)[2019-08-26T10:06:21.542Z] ..\..\bin\lsb_release.exe : fatal error LNK1120: 1 unresolved externals[2019-08-26T10:06:21.542Z] jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\src\tests\CMakeFiles\lsb_release.dir\build.make [bin\lsb_release.exe] Error 2[2019-08-26T10:06:21.542Z] jom: C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.13\build\CMakeFiles\Makefile2 [src\tests\CMakeFiles\lsb_release.dir\all] Error 2[2019-08-26T10:06:21.542Z] backtraceparser.cpp[2019-08-26T10:06:21.542Z] Scanning dependencies of target kdbgwin[2019-08-26T10:06:21.542Z] [ 12%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserlldb.cpp.obj[2019-08-26T10:06:22.051Z] [ 13%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/main.cpp.obj[2019-08-26T10:06:22.051Z] main.cpp[2019-08-26T10:06:22.553Z] Scanning dependencies of target qbugzilla[2019-08-26T10:06:23.465Z] [ 13%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/apijob.cpp.obj[2019-08-26T10:06:23.465Z] apijob.cpp[2019-08-26T10:06:24.531Z] backtraceparsergdb.cpp[2019-08-26T10:06:25.036Z] backtraceparsernull.cpp[2019-08-26T10:06:25.036Z] [ 13%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/kdbgwin_process.cpp.obj[2019-08-26T10:06:25.036Z] backtraceparserlldb.cpp[2019-08-26T10:06:25.036Z] [ 14%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/bugzilla.cpp.obj[2019-08-26T10:06:25.540Z] backtraceparserkdbgwin.cpp[2019-08-26T10:06:25.540Z] [ 13%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsercdb.cpp.obj[2019-08-26T10:06:25.540Z] backtraceparsercdb.cpp[2019-08-26T10:06:25.540Z] [ 15%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_parser_debug.cpp.obj[2019-08-26T10:06:26.052Z] drkonqi_parser_debug.cpp[2019-08-26T10:06:26.052Z] [ 16%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/abstract_generator.cpp.obj[2019-08-26T10:06:26.559Z] [ 16%] Linking CXX executable ..\..\..\bin\crashtest.exe[2019-08-26T10:06:26.559Z] bugzilla.cpp[2019-08-26T10:06:27.087Z] [ 17%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/connection.cpp.obj[2019-08-26T10:06:27.607Z] [ 18%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_backtrace_parser_autogen/mocs_compilation.cpp.obj[2019-08-26T10:06:28.675Z] connection.cpp[2019-08-26T10:06:28.675Z] [ 19%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/callbacks.cpp.obj[2019-08-26T10:06:28.675Z] mocs_compilation.cpp[2019-08-26T10:06:29.182Z] [ 19%] Built target crashtest[2019-08-26T10:06:29.182Z] [ 19%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/exceptions.cpp.obj[2019-08-26T10:06:29.182Z] [ 19%] Building CX

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[David Edmundson]

davidedmundson added a comment.


  > Could you update the title and summary so they reflect what's in the patch 
now?
  
  This isn't done (or at least phabricator is being unhelpful and not showing 
it if you have)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[David Edmundson]

davidedmundson added a comment.


  Generally seems ok. Two minor comments.

INLINE COMMENTS

> main.qml:238
> +_iconName: "edit-redo"
> +_text: i18nd("libplasma5", "Redo")
> +onTriggered: contextMenu.retFocus(() => 
> mainTextArea.redo())

Where does this libplasma5 domain come from?

> documenthandler.cpp:94
>  
> +void DocumentHandler::paste()
> +{

This could  benefit from a name to explain the difference from the regular text 
edit paste.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Monday meeting notes for 26/8/2019

[Marco Martin]

Kai Uwe
plasma-browser-integration:
* Threshold for controlling short videos has been increased from 5s to 8s
* Failure error message has been removed in favor of a toolbar icon with popup
* Enhanced media controls are enabled by default now
* Minor improvements and reliability fixes for tabs runner
* Planning to do a new release by end of this week
Notifications:
* Quick reply won't make it for 5.17
* Please review D23293 (want in 5.16...), D22569
Diff 23293 "[Notifications] Implement JobViewV2" [Needs Review]
https://phabricator.kde.org/D23293
Diff 22569 "[Dialog] Apply window type after changing flags" [Needs
Review] https://phabricator.kde.org/D22569
Plasma:
* Added DrKonqi setting to discourage bug reporting
* For enterprises that cannot or don't want to report bugs upstream
* Ideally, there was another mechanism to forward those to IT
automatically but that needs a broader picture, with coredump and
whatever
* KRunner doesn't autostart when crashed anymore
* It's autostarted when invoking it nowadays
Other:
* Some improvements for Dolphin wrt slow network shares:
* D23295 D23458 D23459 D23460
Diff 23295 "[Tab Bar] Resolve tab icon only if visible" [Needs
Review] https://phabricator.kde.org/D23295
Diff 23458 "Don't store view properties on network shares" [Needs
Review] https://phabricator.kde.org/D23458
Diff 23459 "Reset progress bar text when directory loading starts"
[Needs Review] https://phabricator.kde.org/D23459
Diff 23460 "Always periodically dispatch pending items" [Needs
Review] https://phabricator.kde.org/D23460
* Please review D23145
Diff 23145 "[Exe Thumbnailer] Match 16 bit executables and don't
request icon types wrestool cannot handle" [Needs Review]
https://phabricator.kde.org/D23145



Nicolas:
* I worked a bit on print-manager
* In particular on an issue where it would just say 'Forbidden' when
you want to add a printer
* Made a patch for CUPS to allow members of 'wheel' to do privileged
operations without auth prompt
* For non-wheel users fixed the auth check in print-manager, it was
interpreting the return value from CUPS wrong
Diff 23403 "Fix authentication" [Needs Review]
https://phabricator.kde.org/D23403
Diff 23407 "Don't fetch server settings for preferences button"
[Needs Review] https://phabricator.kde.org/D23407
* Also made a mockup for a QML based print KCM



Leinir:
* my little bit of thing is that https://phabricator.kde.org/D21721 is
about ready for some actual feedback now :) Diff 21721 "[WIP] Bring
KNewStuffQuick to feature parity with KNewStuff(Widgets)" [Needs
Review]
* I need to rework the description and whatnot to be more than just a
pile of commit messages, and add a description of how to do the test
thing, but if anybody feels like taking it for a spin, it's an easy
thing to test by running this in the build dir (after installing it...
because framework and whatnot)
QT_LOGGING_RULES="org.kde.knewstuff*=true" ./bin/khotnewstuff-dialog
/usr/share/knsrcfiles/lookandfeel.knsrc



Arjen:
KSysGuard:
* We've been doing some work on ksysguard to make it a bit more flexible.
* d_ed posted D23287 which introduces a framework for plugins for ProcessCore.
* I posted D23342 which adds a plugin using that framework to add per
process network usage information.
* I also posted D23382 which adds a new type of memory column.
Eventually I hope to replace the main "memory" column with this one.
Diff 23287 "Create a plugin framework for processes" [Accepted]
https://phabricator.kde.org/D23287
Diff 23342 "Add a per-process network information plugin" [Needs
Review] https://phabricator.kde.org/D23342
Diff 23382 "Add vmPSS to Process and display it as "total memory"
column" [Accepted] https://phabricator.kde.org/D23382
Other:
* I've been working on a gpu-accelerated charts library that I hope
can eventually be used to replace the charts in the network applet and
other places. It's currently at
https://invent.kde.org/kde/kf5quickcharts .


Roman:
* I'm working on better screens clone functionality and noticed there
were some issues in other parts. Identified the bug and fixed with
D23435 (D23428 is cleanup). Hope this was the only breaking issue and
can continue work now on the clone project.
Diff 23435 "Emit mode-change on all relevant changes" [Accepted]
https://phabricator.kde.org/D23435
[12:30]  Diff 23428 "Remove change-set null check"
[Accepted] https://phabricator.kde.org/D23428
* Then there is also D23105 which I will split up soon into small
patches to be actually merged.
Diff 23105 "WIP: [platforms/x11] Cleanup GLX backend, revise
compositing" [Needs Review] https://phabricator.kde.org/D23105
* Feedback by testing or on the overall direction is still welcome.


Marco:
Plasma mobile
* this week dedicated mostly to the new homescreen/launcher for plamo
* dragging icons between the app grid, the favorites strip and the
"desktop" area managed by the new layout manager code now works
flawlwssly
* fixed some bug

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[Luca Carlon]

luc4 added a comment.


  In D22774#519403 , @davidedmundson 
wrote:
  
  > > Could you update the title and summary so they reflect what's in the 
patch now?
  >
  > This isn't done (or at least phabricator is being unhelpful and not showing 
it if you have)
  
  
  Not sure if I understand, sorry. I changed the title and I read an update 
message:
  
  > luc4 retitled this revision from Add a button to the notes applet to clear 
formatting to In the note applet, always paste without formatting by default. 
Add an action to paste preserving formatting in the contextual menu..
  
  Sorry, not very comfortable with phabricator yet.

INLINE COMMENTS

> davidedmundson wrote in main.qml:238
> Where does this libplasma5 domain come from?

I think I copied from here: https://git.reviewboard.kde.org/r/121698/diff/1/#. 
Is it outdated maybe?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22514: Show if KRunner is still searching for more things

[Aleix Pol Gonzalez]

apol updated this revision to Diff 64653.
apol added a comment.


  delay

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22514?vs=64265&id=64653

BRANCH
  arcpatch-D22514

REVISION DETAIL
  https://phabricator.kde.org/D22514

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: apol, #plasma, #vdg, broulik
Cc: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22514: Show if KRunner is still searching for more things

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> RunCommand.qml:105
> +
> +opacity: queryTimer.stillQuerying ? 1 : 0
> +running: visible

Easier would be `!queryTimer.running && results.querying`, then you don't need 
any of the custom state tracking

And then just `onQueryStringChanged: queryTimer.restart()`

Also, maybe longer than 200ms?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol, #plasma, #vdg, broulik
Cc: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21035: Remove disconnected network devices from Network Monitor.

[Jan Grulich]

jgrulich added a subscriber: mart.
jgrulich added a comment.


  Looks good to me, but I'm not the author of this code. I would rather let 
@mart to approve this review.

INLINE COMMENTS

> Applet.qml:71
> +function removeSource(source1, friendlyName1, source2, friendlyName2) {
> +var found = false;
> +for (var i = 0; i < sourcesModel.count; ++i) {

This variable doesn't seem to be used.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21035

To: bernhardu, #plasma, jgrulich
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23461: Remove 'magic' filtering of recent apps

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  The recent app wasn't displayed if it's recent *and* favorites.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  removeMagicFiltering

REVISION DETAIL
  https://phabricator.kde.org/D23461

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22514: Show if KRunner is still searching for more things

[Aleix Pol Gonzalez]

apol updated this revision to Diff 64655.
apol added a comment.


  simplify

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22514?vs=64653&id=64655

BRANCH
  arcpatch-D22514

REVISION DETAIL
  https://phabricator.kde.org/D22514

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: apol, #plasma, #vdg, broulik
Cc: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23386: [Applet] Double-click on icon to make it the default

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Yeah, I don't disagree. Let's focus on D23389 
.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23386

To: ngraham, drosca, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23448: Capacity degradation -> Battery health

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:441c3449dab6: Capacity degradation -> Battery health 
(authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23448?vs=64621&id=64656

REVISION DETAIL
  https://phabricator.kde.org/D23448

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, aspotashev, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23449: Capacity degradation -> Battery health

[Nathaniel Graham]

ngraham updated this revision to Diff 64658.
ngraham added a comment.


  Rebase

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23449?vs=64603&id=64658

BRANCH
  degradation-to-health (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23449

AFFECTED FILES
  Modules/energy/batterymodel.cpp
  Modules/energy/batterymodel.h
  Modules/energy/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23449: Capacity degradation -> Battery health

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:3795d42091a1: Capacity degradation -> Battery health 
(authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23449?vs=64658&id=64659#toc

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23449?vs=64658&id=64659

REVISION DETAIL
  https://phabricator.kde.org/D23449

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22514: Show if KRunner is still searching for more things

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  I still think it should be more than 200ms, more like 500ms.

INLINE COMMENTS

> RunCommand.qml:103
> +opacity: !queryTimer.running && results.querying ? 1 : 0
> +running: visible
> +}

The `BusyIndicator` is always `visible`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D22514

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol, #plasma, #vdg, broulik
Cc: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D22514: Show if KRunner is still searching for more things

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fae4515f23fc: Show if KRunner is still searching for more 
things (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22514?vs=64655&id=64661#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22514?vs=64655&id=64661

REVISION DETAIL
  https://phabricator.kde.org/D22514

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: apol, #plasma, #vdg, broulik
Cc: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23463: Fix PrivateActionToolButton with menu not clearing checked state properly

[Arjen Hiemstra]

ahiemstra created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  When closing the menu of a PrivateActionToolButton with a click on the
  button, the checked state of the button would not properly clear. So
  instead use the button's toggled signal to handle menu open/close.
  Combined with a close policy where the parent is explicitly excluded we
  can properly clear the checked state.

REPOSITORY
  R169 Kirigami

BRANCH
  fix_actiontoolbutton

REVISION DETAIL
  https://phabricator.kde.org/D23463

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: ahiemstra
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23463: Fix PrivateActionToolButton with menu not clearing checked state properly

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 64663.
ahiemstra edited the test plan for this revision.
ahiemstra added a comment.


  - Fix null object error

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23463?vs=64662&id=64663

BRANCH
  fix_actiontoolbutton

REVISION DETAIL
  https://phabricator.kde.org/D23463

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23463: Fix PrivateActionToolButton with menu not clearing checked state properly

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 64664.
ahiemstra added a comment.


  - Remove usage of no longer existing property

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23463?vs=64663&id=64664

BRANCH
  fix_actiontoolbutton

REVISION DETAIL
  https://phabricator.kde.org/D23463

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4f309328ee00: libtaskmanager: fix launch url for startup 
info with pathless desktop file (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23417?vs=64529&id=64665#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23417?vs=64529&id=64665

REVISION DETAIL
  https://phabricator.kde.org/D23417

AFFECTED FILES
  libtaskmanager/startuptasksmodel.cpp

To: kossebau, hein, broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> broulik wrote in fonts.cpp:607
> Given this is a kded module and as such a regular qt application, you should 
> be able to get all of this automatically.
> Is the `QGuiApplication::fontChanged` emitted when you change font settings?

@broulik I do not understand. `KDEDModule` (which is a parent of `GtkConfig`) 
is `QObject`, not a `QGuiApplication`. Maybe I am missing something? You want 
me to create a connection with that signal within a module, so I don't have to 
ask from KCM to change a font via DBus?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> gikari wrote in fonts.cpp:607
> @broulik I do not understand. `KDEDModule` (which is a parent of `GtkConfig`) 
> is `QObject`, not a `QGuiApplication`. Maybe I am missing something? You want 
> me to create a connection with that signal within a module, so I don't have 
> to ask from KCM to change a font via DBus?

kded (the application you're running in) is a `QApplication`, so from the 
constructor of your kdedmodule you could do

  #include 
  connect(qApp, &QGuiApplication::fontChanged, this, [this](this QFont &font) {
  // now check if you have the new fonts
  });

I can't guarantee this will work (accessing `font` from there will actually 
deadlock :D but I am curious whether that signal is emitted properly, so you 
dont have to listen to or ask the font kcm to tell you.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D23413: [System Tray] Unified data model for System Tray items

[Konrad Materka]

kmaterka updated this revision to Diff 64669.
kmaterka added a comment.


  Now the same model is used for:
  
  - rendering all items, both Plasmoids and StatusNotifications
  - "Entries" configuration page
  
  That should greatly simplify the https://phabricator.kde.org/D22176 (this is 
not my patch). It will also fix issue I mentioned in that review.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23413?vs=64521&id=64669

REVISION DETAIL
  https://phabricator.kde.org/D23413

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ConfigGeneral.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22176: Rework system tray settings

[Konrad Materka]

kmaterka added a comment.


  @nicolasfella I updated D23413 , now it 
can be used in configuration entries. Can you check if you can use this?
  
  I like the idea of removing "Categories", these are confusing and probably 
no-one uses them.
  **Important thing**, if we remove categories, then we need to remove:
  
  - check in AbstractItem.qml
  - "shownCategories" in main.qml
  - probably small cleanup in few other places.
  
  If not, user won't see items, as they won't be able to re-enable categories 
again.
  
  In D22176#489327 , @ngraham wrote:
  
  > Honestly I would support staying with the QQC1 TableView for now. Trying to 
move to QQC2 without a replacement for it just means we're rolling our own 
table view, which seems even hackier.
  
  
  In Qt 5.12 TableView is added to QtQuick module 
, in the similar way as 
ListView. There is no plan to add it to QQC2. I don't know how difficult 
migration is or how complete the implementation in Qt 5.12 is (missing header 
support?).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22176

To: nicolasfella, #plasma, #vdg
Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23461: Remove 'magic' filtering of recent apps

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> recentusagemodel.cpp:98
> -
> -return (service && (!favoritesModel || 
> !favoritesModel->isFavorite(service->storageId(;
> -}

This is doing two things.

1. It's removing any favourite in the history that returns a defunct service. 
i.e if dolphin is a favourite and you uninstall dolphin it will go away.

2. removing duplicates from the favourites model.

We definitely still want 1.

2 definitely makes sense to be optional, even off by default, but simply 
removing it will change kicker.

Is there a reason to change kicker? If not, it needs to be a property.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23461

To: tcanabrava, hein, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> luc4 wrote in main.qml:238
> I think I copied from here: 
> https://git.reviewboard.kde.org/r/121698/diff/1/#. Is it outdated maybe?

~ish.

To explain what it's doing.

i18n("hello")

will return a translated version of the word "hello" based on the currently 
loaded domain, which is done automatically for applets and applications, but 
there's some issues with library code.

i18nd("somePotFile", "hello") will explicitly load the pot file "somePotFile" 
then translate the word hello.

---

In this particular case, everything used is within the applet, so you can just 
use i18n

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22176: Rework system tray settings

[Nicolas Fella]

nicolasfella added a comment.


  In D22176#519573 , @kmaterka wrote:
  
  > @nicolasfella I updated D23413 , now it 
can be used in configuration entries. Can you check if you can use this?
  
  
  That makes sense, thanks
  
  > I like the idea of removing "Categories", these are confusing and probably 
no-one uses them.
  >  **Important thing**, if we remove categories, then we need to remove:
  > 
  > - check in AbstractItem.qml
  > - "shownCategories" in main.qml
  > - probably small cleanup in few other places. If not, user won't see items, 
as they won't be able to re-enable categories again.
  
  ack
  
  > In D22176#489327 , @ngraham 
wrote:
  > 
  >> Honestly I would support staying with the QQC1 TableView for now. Trying 
to move to QQC2 without a replacement for it just means we're rolling our own 
table view, which seems even hackier.
  > 
  > 
  > In Qt 5.12 TableView is added to QtQuick module 
, in the similar way as 
ListView. There is no plan to add it to QQC2. I don't know how difficult 
migration is or how complete the implementation in Qt 5.12 is (missing header 
support?).
  
  I think QQC1 TableView and the new TableView are quite different things. I 
had some issues with the QQC1 TableView and my new Model, so I decided to use 
something else, but I can revisit this

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22176

To: nicolasfella, #plasma, #vdg
Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

[Björn Feber]

GB_2 added a comment.


  Ping @hein

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23242

To: GB_2, #plasma, #vdg, hein, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

[Carl Schwan]

ognarb added a comment.


  Could it be possible to remove most of the code duplication between 
_window_decorations.scss and _chromium.scss?

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  window-button-symbolics (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23451

To: cblack, #breeze, #vdg, ngraham
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23469: Move the notifier logic into a separate process

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  At the moment, the bit that notifies about system updates was a plasmoid and 
it was working well. The problem was that as a plasmoid it did pull quite a lot 
of dependencies (flatpak, packagekit) that we kept alive and sometimes were 
found to de-stabilize the plasmashell process.
  This patch moves this into a SNI, the UX stays the same, if it crashes, only 
this will crash.

TEST PLAN
  Been using it, seems to work okay.

REPOSITORY
  R134 Discover Software Store

BRANCH
  notifier

REVISION DETAIL
  https://phabricator.kde.org/D23469

AFFECTED FILES
  discover/CMakeLists.txt
  notifier/CMakeLists.txt
  notifier/DiscoverNotifierDeclarativePlugin.cpp
  notifier/DiscoverNotifierDeclarativePlugin.h
  notifier/main.cpp
  notifier/org.kde.discover.notifier.desktop.cmake
  notifier/plasmoid/Messages.sh
  notifier/plasmoid/contents/ui/main.qml
  notifier/plasmoid/metadata.desktop
  notifier/qmldir

To: apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

[Björn Feber]

GB_2 updated this revision to Diff 64682.
GB_2 added a comment.


  Use a bool property setter and disable button when on intro page

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23274?vs=64071&id=64682

BRANCH
  add-show-intro-page-button-to-system-settings-sidebar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23274

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/CategoriesPage.qml

To: GB_2, #plasma, #vdg
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

[Björn Feber]

GB_2 marked 2 inline comments as done.
GB_2 added a comment.


  This is what happens when you set the current index to -1: F7282553: System 
Settings Sidebar Show Intro Page Button Bug.png 


REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23117: kcmlookandfeel - Correctly set the Splash Screen to what the Look & Feel intends for it to be set to

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Pong.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23117

To: The-Feren-OS-Dev, #plasma, davidedmundson, mart
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23174: Improve the look of the Activities KCM UI

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fbd0465c3b1c: Improve the look of the Activities KCM UI 
(authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23174?vs=63818&id=64686

REVISION DETAIL
  https://phabricator.kde.org/D23174

AFFECTED FILES
  kcms/activities/PrivacyTab.cpp
  kcms/activities/imports/dialog.cpp
  kcms/activities/imports/qml/activityDialog/GeneralTab.qml
  kcms/activities/imports/qml/activityDialog/OtherTab.qml
  kcms/activities/imports/qml/activityDialog/components/DialogButtons.qml
  kcms/activities/imports/qml/activityDialog/components/IconChooser.qml
  kcms/activities/imports/qml/activityDialog/components/LabeledTextField.qml
  kcms/activities/imports/qml/activityDialog/components/ShortcutChooser.qml
  kcms/activities/kcm_activities.desktop
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/activities/qml/privacyTab/BlacklistApplicationView.qml
  kcms/activities/ui/MainConfigurationWidgetBase.ui
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/ui/SwitchingTabBase.ui

To: GB_2, #plasma, #vdg, ivan, ngraham, #kactivities
Cc: #kactivities, ivan, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23049: Add Kirigami ListSectionHeader component

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg, mart, ngraham
Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, 
fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein

D23174: Improve the look of the Activities KCM UI

[Nathaniel Graham]

ngraham added a comment.


  Hooray!
  
  Next, do you think you could clean up the applications list so there aren't 
all those duplicates and they all get icons?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23174

To: GB_2, #plasma, #vdg, ivan, ngraham, #kactivities
Cc: #kactivities, ivan, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

[Noah Davis]

ndavis added a comment.


  Seems like people still complain about the patch, so I'll go ahead and land 
this.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-showdesktop-minimizall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22359

To: ndavis, #vdg, #plasma, davidedmundson
Cc: davidedmundson, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[Luca Carlon]

luc4 updated this revision to Diff 64689.
luc4 added a comment.


  Updated according to requests.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22774?vs=63248&id=64689

REVISION DETAIL
  https://phabricator.kde.org/D22774

AFFECTED FILES
  applets/notes/package/contents/ui/ShortcutMenuItem.qml
  applets/notes/package/contents/ui/main.qml
  applets/notes/plugin/documenthandler.cpp
  applets/notes/plugin/documenthandler.h

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9705414e3ec3: Revert "[showdesktop][minimizeall] 
Reduce the maximum panel icon size" (authored by ndavis).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22359?vs=61468&id=64690

REVISION DETAIL
  https://phabricator.kde.org/D22359

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml
  applets/showdesktop/package/contents/ui/main.qml

To: ndavis, #vdg, #plasma, davidedmundson
Cc: davidedmundson, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> broulik wrote in fonts.cpp:607
> kded (the application you're running in) is a `QApplication`, so from the 
> constructor of your kdedmodule you could do
> 
>   #include 
>   connect(qApp, &QGuiApplication::fontChanged, this, [this](this QFont &font) 
> {
>   // now check if you have the new fonts
>   });
> 
> I can't guarantee this will work (accessing `font` from there will actually 
> deadlock :D but I am curious whether that signal is emitted properly, so you 
> dont have to listen to or ask the font kcm to tell you.

So, I wrote this:

  GtkConfig::GtkConfig(QObject *parent, const QVariantList&) :
  KDEDModule(parent), configEditor {new ConfigEditor()}
  {
  qDebug() << "Parent: " << parent;
  QGuiApplication *qapp = static_cast(parent);
  qDebug() << "Qapp: " << qapp;
  connect(qapp, &QGuiApplication::fontChanged, this, [this](const QFont 
&font) {
  qDebug() << "Font recieved";
  qDebug() << font;
  });
  qDebug() << "GTK configuration module loaded";
  }

And when I save fonts via KCM nothing (Except the "parent", "qapp" and "GTK 
..." lines) was printed in konsole, where I run Kded5.  So, it means signal was 
not send?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

[Carson Black]

cblack updated this revision to Diff 64698.
cblack added a comment.


  DRY that code

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23451?vs=64606&id=64698

BRANCH
  window-button-symbolics (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23451

AFFECTED FILES
  src/assets/breeze-close-active-symbolic.svg
  src/assets/breeze-close-hover-symbolic.svg
  src/assets/breeze-close-symbolic.svg
  src/assets/breeze-maximize-active-symbolic.svg
  src/assets/breeze-maximize-hover-symbolic.svg
  src/assets/breeze-maximize-symbolic.svg
  src/assets/breeze-maximized-active-symbolic.svg
  src/assets/breeze-maximized-hover-symbolic.svg
  src/assets/breeze-maximized-symbolic.svg
  src/assets/breeze-minimize-active-symbolic.svg
  src/assets/breeze-minimize-hover-symbolic.svg
  src/assets/breeze-minimize-symbolic.svg
  src/build_theme.sh
  src/gtk3/applications/_chromium.scss
  src/gtk3/widgets/_window_decorations.scss

To: cblack, #breeze, #vdg, ngraham
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.


  Much better now thanks :)

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  window-button-symbolics (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23451

To: cblack, #breeze, #vdg, ngraham, ognarb
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:fa8e67c617f3: [GTK3] Recolor CSD titlebuttons according to 
user's color scheme (authored by cblack).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23451?vs=64698&id=64700

REVISION DETAIL
  https://phabricator.kde.org/D23451

AFFECTED FILES
  src/assets/breeze-close-active-symbolic.svg
  src/assets/breeze-close-hover-symbolic.svg
  src/assets/breeze-close-symbolic.svg
  src/assets/breeze-maximize-active-symbolic.svg
  src/assets/breeze-maximize-hover-symbolic.svg
  src/assets/breeze-maximize-symbolic.svg
  src/assets/breeze-maximized-active-symbolic.svg
  src/assets/breeze-maximized-hover-symbolic.svg
  src/assets/breeze-maximized-symbolic.svg
  src/assets/breeze-minimize-active-symbolic.svg
  src/assets/breeze-minimize-hover-symbolic.svg
  src/assets/breeze-minimize-symbolic.svg
  src/build_theme.sh
  src/gtk3/applications/_chromium.scss
  src/gtk3/widgets/_window_decorations.scss

To: cblack, #breeze, #vdg, ngraham, ognarb
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23469: Move the notifier logic into a separate process

[Aleix Pol Gonzalez]

apol updated this revision to Diff 64711.
apol added a comment.


  Fix build with gcc

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23469?vs=64680&id=64711

BRANCH
  notifier

REVISION DETAIL
  https://phabricator.kde.org/D23469

AFFECTED FILES
  discover/CMakeLists.txt
  notifier/CMakeLists.txt
  notifier/DiscoverNotifierDeclarativePlugin.cpp
  notifier/DiscoverNotifierDeclarativePlugin.h
  notifier/main.cpp
  notifier/org.kde.discover.notifier.desktop.cmake
  notifier/plasmoid/Messages.sh
  notifier/plasmoid/contents/ui/main.qml
  notifier/plasmoid/metadata.desktop
  notifier/qmldir

To: apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart