D25273: Enable selecting all installed color schemes in Cuttlefish

[David Redondo]

davidre added a comment.


  In D25273#561845 , @ngraham wrote:
  
  > Nice, it's good to get rid of so much boilerplate.
  >
  > However when I change the system's own color scheme from Breeze to anything 
else and start Cuttlefish, the app itself uses that color scheme as expected, 
but the combobox's text is blank: F7760159: Screenshot_20191112_221601.png 

  
  
  I see what's happening. I copied that code form Kate and it reads the current 
color scheme name from kdeglobals but there can be a difference between the 
stored name and the user visible name. Especially when it includes a space or 
hyphen. So it works correctly for Breeze or Oxygen but not Breeze Dark or 
Oxygen cold.
  
  In D25273#561847 , @ngraham wrote:
  
  > Also, the combobox's model appears to have duplicates for Breeze, Breeze 
Dark, and Breeze Light, which (correctly) don't show up in the colors KCM for 
me: F7760168: Screenshot_20191112_221936.png 

  
  
  Since this directly uses KColorSchemeManager, do you also see duplicated 
entries in Kate's color scheme menu?

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw added a comment.


  @ndavis Unless this needs a rebase, all I need is review/approval.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Translate software

[David Rebolo Magariños]

 Hello there,

I was wondering if Plasma Mobile has an official site for translators to
translate their ROM to our respective languages? If so, what is it call?




Thank you for answering my question,


David Rebolo Magariños

D25273: Enable selecting all installed color schemes in Cuttlefish

[David Redondo]

davidre updated this revision to Diff 69667.
davidre added a comment.


  Load initial color scheme name from the respective .colors file

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25273?vs=69639=69667

BRANCH
  colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25273

AFFECTED FILES
  CMakeLists.txt
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/colorschemes.cpp
  cuttlefish/src/colorschemes.h
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

[David Redondo]

davidre added a comment.


  In D25273#561847 , @ngraham wrote:
  
  > Also, the combobox's model appears to have duplicates for Breeze, Breeze 
Dark, and Breeze Light, which (correctly) don't show up in the colors KCM for 
me: F7760168: Screenshot_20191112_221936.png 

  
  
  I think I know what's happening. Do you have Breeze installed into the same 
prefix as cuttlefish in addition to system breeze? After doing so I also see 
the duplicate color. (The same happens in Kate)

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25198: KCM Colors : port color scheme state management to KConfigXT

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:199bbe20d72c: KCM Colors : port color scheme state 
management to KConfigXT (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25198?vs=69401=69668

REVISION DETAIL
  https://phabricator.kde.org/D25198

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/colorssettings.kcfg
  kcms/colors/colorssettings.kcfgc

To: crossi, #plasma, ervin, mart, bport
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25282: Ensure comments fetch for KNS starts on the right page

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  For a while, we've not had reviews/comments showing up for KNS content,
  and ensures we initiate fetching from the correct page. It does not,
  however, ensure that the number of reviews is quite correct, as
  we will need to add support for replies in some way (even if it's
  only done as an indication that they exist)

TEST PLAN
  Without patch: Notice no reviews show up, except on very-reviewed items
  With patch: Notice reviews show up on all content that says it has some

REPOSITORY
  R134 Discover Software Store

BRANCH
  start-fetching-kns-comments-from-the-right-page (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25282

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSReviews.cpp

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25281: [GTK3] Improve legibility of Firefox CSD colours

[Kai Uwe Broulik]

broulik added a comment.


  >   However Once we implement the Breeze color scheme changes
  
  How is that related? If i keep using a dark title bar I will still have that 
issue. Merely changing the colorscheme doesn't fix the underlying bug?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D25281

To: cblack, #vdg, #breeze
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

[Jan Grulich]

jgrulich added a comment.


  There is already a method to enable/disable BT, why don't you reuse it?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25279

To: ngraham, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[David Edmundson]

davidedmundson resigned from this revision.
davidedmundson added a comment.


  In theory it's all just a cache of data elsewhere.
  
  The downside of this patch is that if a user temporarily disables the 
indexer, when it's re-enabled we're triggering an entire first scan reset of 
everything.
  
  If we did this patch, does the config value "first run" need resetting to 
true?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma
Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari updated this revision to Diff 69689.
gikari marked 6 inline comments as done.
gikari edited the summary of this revision.
gikari added a comment.


  Fix the mistakes

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24743?vs=69259=69689

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/CMakeLists.txt.autosave
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/gtkconfig.json

To: gikari, #plasma, #vdg, broulik, cblack
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D25282: Ensure comments fetch for KNS starts on the right page

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:11bfabfcbee9: Ensure comments fetch for KNS starts on the 
right page (authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25282?vs=69669=69685

REVISION DETAIL
  https://phabricator.kde.org/D25282

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSReviews.cpp

To: leinir, #discover_software_store, #plasma, ngraham, apol, starbuck
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari updated this revision to Diff 69691.
gikari added a comment.


  Remember to save all files before blindly commiting

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24743?vs=69690=69691

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/gtkconfig.json

To: gikari, #plasma, #vdg, broulik, cblack
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw updated this revision to Diff 69693.
mthw added a comment.


  I think I made all the changes you wanted. Hopefully I didn't break anything. 
It works correctly on first glance.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=66959=69693

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25284: Make QmlComponentsPool one instance per engine

[David Edmundson]

davidedmundson updated this revision to Diff 69697.
davidedmundson added a comment.


  reduce lookup

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25284?vs=69671=69697

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25284

AFFECTED FILES
  src/columnview.cpp
  src/columnview_p.h

To: davidedmundson
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart, hein

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 27 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/27/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Wed, 13 Nov 2019 17:09:22 +
 Build duration:
8 min 56 sec and counting
   JUnit Tests
  Name: projectroot.src.bugzillaintegration.libbugzilla Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.src.bugzillaintegration.libbugzilla.autotests.connectiontestName: projectroot.src.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.13 - Build # 11 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.13/11/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Wed, 13 Nov 2019 17:09:23 +
 Build duration:
4 min 43 sec and counting
   JUnit Tests
  Name: projectroot.src.bugzillaintegration.libbugzilla Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.src.bugzillaintegration.libbugzilla.autotests.connectiontestName: projectroot.src.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari updated this revision to Diff 69690.
gikari added a comment.


  Remove the empty line in CMakeLists.txt

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24743?vs=69689=69690

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/CMakeLists.txt.autosave
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/gtkconfig.json

To: gikari, #plasma, #vdg, broulik, cblack
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D24743: Update GTK settings according to Plasma settings

[Nicolas Fella]

nicolasfella added a comment.


  Works really well, good job! Some minor nitpicks

INLINE COMMENTS

> CMakeLists.txt:69
>  add_subdirectory(tests)
> +add_subdirectory(kded-module)
>  

Nitpick, feel free to ignore since it was probably done by me:
usually we call the folder just 'kded'

> CMakeLists.txt:1
> +find_package(KF5DBusAddons)
> +

Move to top-level CMakeLists.txt (if needed at all)

> configeditor.cpp:176
> +{
> +QProcess pidof {};
> +pidof.start(QStringLiteral("pidof"), QStringList() << 
> QStringLiteral("-s") << QStringLiteral("xsettingsd"));

QProcess pidof;

> configvalueprovider.cpp:53
> +KIconTheme *newIconTheme = KIconLoader::global()->theme();
> +if (newIconTheme == nullptr) {
> +return QStringLiteral("breeze");

if (!newIconTheme)

> gtkconfig.cpp:24
> +#include 
> +#include 
> +#include 

#include 

> gtkconfig.json:4
> +"Description": "GTK config management",
> +"Icon": "preferences-system-power-management",
> +"Name": "Plasma GTKd",

I know it was me who did this, but maybe "gtkconfig" as icon?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg, broulik, cblack
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D25294: [applets/kicker] Set icon for all applications group

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Most group have icons, this one did not. A new icon just got created for
  all applications, it makes sense to be consistent.
  
  This has no effect in the kicker-dash as that does not show icons, nor
  kicker/kickoff as they don't show the all applications group.
  
  Only third party menus will be affected.

TEST PLAN
  Looked at my custom menu
  Looked at kicker-dash

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25294

AFFECTED FILES
  applets/kicker/plugin/rootmodel.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> handler.cpp:366-369
> +Handler::updatePreviousBluetoothStatus();
>  m_tmpWirelessEnabled = NetworkManager::isWirelessEnabled();
>  m_tmpWwanEnabled = NetworkManager::isWwanEnabled();
>  enableBluetooth(false);

You're asynchronously querying the bluetooth state with multiple calls.
Afterwards we send a call to disable bluetooth.

DBus will maintain order of individual calls, but N async things vs N async 
things is less determined

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25279

To: ngraham, #plasma, jgrulich
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

[Nathaniel Graham]

ngraham added a comment.


  In D25273#561852 , @davidre wrote:
  
  > Since this directly uses KColorSchemeManager, do you also see duplicated 
entries in Kate's color scheme menu?
  
  
  Yep.
  
  In D25273#561875 , @davidre wrote:
  
  > I think I know what's happening. Do you have Breeze installed into the same 
prefix as cuttlefish in addition to system breeze? After doing so I also see 
the duplicate color. (The same happens in Kate)
  
  
  That's right.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22684: [Klipper] Fix clipboard history management

[Nathaniel Graham]

ngraham added a comment.


  @pdabrowski can you rebase this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22684

To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25290: KCM launchfeedback : port to KConfig XT

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Simple KCM, all settings' states are automatically handled thanks to 
ManagedConfigModule.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25290

AFFECTED FILES
  kcms/launch/CMakeLists.txt
  kcms/launch/launchfeedback.cpp
  kcms/launch/launchfeedback.h
  kcms/launch/launchfeedbacksettings.kcfg
  kcms/launch/launchfeedbacksettings.kcfgc
  kcms/launch/package/contents/ui/main.qml

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25284: Make QmlComponentsPool one instance per engine

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> columnview.cpp:51
> +Q_ASSERT(engine);
> +if(privateQmlComponentsPoolSelf->m_instances.contains(engine)) {
> +return privateQmlComponentsPoolSelf->m_instances[engine];

Avoid double lookup:

  auto *componentPool = privateQmlComponentsPoolSelf->m_instances.value(engine);
  if (componentPool) {
  return componentPool;
  }
  
  componentPool = new QQmlComponentsPool(engine);
  ...
  return componentPool;

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25284

To: davidedmundson
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart, hein

D24070: Don't use toolTipMainText to show info, rather use the second line

[Kai Uwe Broulik]

broulik added a comment.


  There's also a lot of code duplication making the diff hard to read. Please 
group if statements together where it makes sense, e.g. avpod things like
  
if (foo) {
return plasmoid.title;
} else if (foo) {
return plasmoid.title;
  
  or
  
if (foo) {
if (bar) {
baz();
}
} else {
if (bar) {
baz();
}
}

INLINE COMMENTS

> batterymonitor.qml:85
> +if (powermanagementDisabled) {
> +return i18n("Power management is disabled")
> +}

When power management is disabled the subtext shows no useful information now.

Powermanagement disabled means disabled screen powermanagement (i.e. keep 
screen always on), has nothing to do with the battery percentage, which is 
still useful to have.

> batterymonitor.qml:95
>  if (remainingTime > 0) {
> -return i18nc("%1 is remaining time, %2 is percentage", "%1 
> Remaining (%2%)",
> - 
> KCoreAddons.Format.formatDuration(remainingTime, 
> KCoreAddons.FormatTypes.HideSeconds),
> - pmSource.data["Battery"]["Percent"])
> -} else {
> -return i18n("%1% Battery Remaining", 
> pmSource.data["Battery"]["Percent"]);
> +return i18n("%1 until fully charged", 
> KCoreAddons.Format.formatDuration(remainingTime, 
> KCoreAddons.FormatTypes.HideSeconds))
> +}

Keep the `i18nc` explaining that %1 is remaining time

> batterymonitor.qml:102
>  }
>  }
> +

What in the `else` case? Perhaps at least explicitly `return "";`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: KDE CI: Plasma » kscreenlocker » kf5-qt5 SUSEQt5.12 - Build # 58 - Failure!

[David Edmundson]

Just a framework sync issue, should be a non issue that will fix itself.

KDE CI: Plasma » kscreenlocker » kf5-qt5 SUSEQt5.12 - Build # 58 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kscreenlocker/job/kf5-qt5%20SUSEQt5.12/58/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 13 Nov 2019 14:36:51 +
 Build duration:
1 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 442 lines...][2019-11-13T14:37:49.573Z]  * KF5 (required version >= 5.62.0)[2019-11-13T14:37:49.573Z]  * X11, X11 libraries, [2019-11-13T14:37:49.573Z]Required for building the X11 based workspace[2019-11-13T14:37:49.573Z]  * XCB, X protocol C-language Binding, [2019-11-13T14:37:49.573Z]  * Qt5X11Extras[2019-11-13T14:37:49.573Z]  * Qt5 (required version >= 5.12.0)[2019-11-13T14:37:49.573Z]  * Qt5Gui (required version >= 5.11.0)[2019-11-13T14:37:49.573Z]  * KF5Wayland[2019-11-13T14:37:49.573Z]Required for building screenlocker[2019-11-13T14:37:49.573Z]  * Wayland (required version >= 1.3), C library implementation of the Wayland protocol: a protocol for a compositor to talk to its clients, [2019-11-13T14:37:49.573Z]Required for building screenlocker[2019-11-13T14:37:49.573Z]  * PAM, PAM Libraries, [2019-11-13T14:37:49.573Z]Required for screen unlocking and optionally used by the KDM log in manager[2019-11-13T14:37:49.573Z] [2019-11-13T14:37:49.573Z] -- The following features have been disabled:[2019-11-13T14:37:49.573Z] [2019-11-13T14:37:49.573Z]  * sys/event.h, Use the kevent() and sigwaitinfo() api for signalhandling[2019-11-13T14:37:49.573Z] [2019-11-13T14:37:49.573Z] -- The following OPTIONAL packages have not been found:[2019-11-13T14:37:49.573Z] [2019-11-13T14:37:49.573Z]  * Seccomp, The enhanced seccomp library., [2019-11-13T14:37:49.573Z]Used for putting the look'n'feel package in the greeter into a sandbox.[2019-11-13T14:37:49.573Z] [2019-11-13T14:37:49.573Z] -- Configuring done[2019-11-13T14:37:49.830Z] -- Generating done[2019-11-13T14:37:49.830Z] -- Build files have been written to: /home/jenkins/workspace/Plasma/kscreenlocker/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-11-13T14:37:51.556Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project kscreenlocker --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2019-11-13T14:37:51.814Z] Scanning dependencies of target KScreenLocker_autogen[2019-11-13T14:37:51.814Z] [  0%] Automatic MOC for target KScreenLocker[2019-11-13T14:37:52.379Z] [  0%] Built target KScreenLocker_autogen[2019-11-13T14:37:52.379Z] Scanning dependencies of target pointerGrabber_autogen[2019-11-13T14:37:52.379Z] [  0%] Automatic MOC for target pointerGrabber[2019-11-13T14:37:52.379Z] [  0%] Built target pointerGrabber_autogen[2019-11-13T14:37:52.379Z] Scanning dependencies of target keyboardGrabber_autogen[2019-11-13T14:37:52.379Z] [  1%] Automatic MOC for target keyboardGrabber[2019-11-13T14:37:52.379Z] [  1%] Built target keyboardGrabber_autogen[2019-11-13T14:37:52.379Z] Scanning dependencies of target logindTest_autogen[2019-11-13T14:37:52.379Z] [  2%] Automatic MOC for target logindTest[2019-11-13T14:37:52.640Z] [  2%] Built target logindTest_autogen[2019-11-13T14:37:52.640Z] Scanning dependencies of target kcheckpass_test_autogen[2019-11-13T14:37:52.640Z] [  2%] Automatic MOC for target kcheckpass_test[2019-11-13T14:37:52.900Z] [  2%] Built target kcheckpass_test_autogen[2019-11-13T14:37:52.900Z] Scanning dependencies of target powermanagment_test_autogen[2019-11-13T14:37:52.900Z] [  2%] Automatic MOC for target powermanagment_test[2019-11-13T14:37:52.900Z] [  2%] Built target powermanagment_test_autogen[2019-11-13T14:37:52.900Z] [  2%] Generating wayland-ksld-server-protocol.h[2019-11-13T14:37:52.900Z] /home/jenkins/workspace/Plasma/kscreenlocker/kf5-qt5 SUSEQt5.12/protocols/ksld.xml:9: warning: since version not increasing[2019-11-13T14:37:52.900Z] [2019-11-13T14:37:52.900Z] [  3%] Generating screensaveradaptor.cpp, screensaveradaptor.h[2019-11-13T14:37:52.900Z] [  4%] Generating kscreensaveradaptor.cpp, kscreensaveradaptor.h[2019-11-13T14:37:52.900Z] [  4%] Generating kscreensaversettingsbase.h, kscreensaversettingsbase.cpp[2019-11-13T14:37:53.157Z] [  5%] Generating powerdevilpolicyagent.cpp, powerdevilpolicyagent.h[2019-11-13T14:37:53.157Z] [  6%] Generating wayland-ksld-client-protocol.h[2019-11-13T14:37:53.157Z] /home/jenkins/workspace/Plasma/kscreenlocker/kf5-qt5 SUSEQt5.12/protocols/ksld.xml:9: warning: since version not increasing[2019-11-13T14:37:53.157Z] [2019-11-13T14:37:53.157Z] [  7%] Generating wayland-ksld-protocol.c[2019-11-13T14:37:53.157Z] /home/jenkins/workspace/Plasma/kscreenlocker/kf5-qt5 SUSEQt5.12/protocols/ksld.xml:9: warning: since version not increasing[2019-11-13T14:37:53.157Z] [2019-11-13T14:37:53.157Z] Using "code" is deprecated - use private-code or public-code.[2019-11-13T14:37:53.157Z] See the help page for details.[2019-11-13T14:37:53.157Z] [  7%] Generating 

KDE CI: Plasma » kscreenlocker » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kscreenlocker/job/kf5-qt5%20FreeBSDQt5.13/38/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 13 Nov 2019 14:36:51 +
 Build duration:
1 min 16 sec and counting
   CONSOLE OUTPUT
  [...truncated 741 lines...][2019-11-13T14:38:01.455Z] [ 72%] Building CXX object CMakeFiles/KScreenLocker.dir/globalaccel.cpp.o[2019-11-13T14:38:01.724Z] [ 73%] Linking CXX executable ../bin/kscreenlocker_greet[2019-11-13T14:38:01.724Z] [ 73%] Linking CXX executable ../bin/powermanagment_test[2019-11-13T14:38:01.995Z] [ 73%] Built target powermanagment_test[2019-11-13T14:38:01.995Z] [ 74%] Building CXX object CMakeFiles/KScreenLocker.dir/x11locker.cpp.o[2019-11-13T14:38:01.995Z] [ 74%] Built target kscreenlocker_greet[2019-11-13T14:38:01.995Z] [ 75%] Building CXX object CMakeFiles/KScreenLocker.dir/waylandlocker.cpp.o[2019-11-13T14:38:01.995Z] [ 76%] Linking CXX executable ../bin/logindTest[2019-11-13T14:38:02.280Z] [ 76%] Built target logindTest[2019-11-13T14:38:02.280Z] [ 77%] Building CXX object CMakeFiles/KScreenLocker.dir/logind.cpp.o[2019-11-13T14:38:03.293Z] [ 78%] Building CXX object CMakeFiles/KScreenLocker.dir/waylandserver.cpp.o[2019-11-13T14:38:03.556Z] /usr/home/jenkins/workspace/Plasma/kscreenlocker/kf5-qt5 FreeBSDQt5.13/x11locker.cpp:92:55: warning: 'resized' is deprecated: Use QScreen::geometryChanged() [-Wdeprecated-declarations][2019-11-13T14:38:03.556Z] connect(QApplication::desktop(), ::resized, this, ::updateGeo);[2019-11-13T14:38:03.556Z]   ^[2019-11-13T14:38:03.556Z] /usr/local/include/qt5/QtWidgets/qdesktopwidget.h:98:5: note: 'resized' has been explicitly marked deprecated here[2019-11-13T14:38:03.556Z] QT_DEPRECATED_X("Use QScreen::geometryChanged()") void resized(int);[2019-11-13T14:38:03.556Z] ^[2019-11-13T14:38:03.556Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2019-11-13T14:38:03.556Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2019-11-13T14:38:03.556Z] ^[2019-11-13T14:38:03.556Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2019-11-13T14:38:03.556Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2019-11-13T14:38:03.556Z]   ^[2019-11-13T14:38:03.556Z] /usr/home/jenkins/workspace/Plasma/kscreenlocker/kf5-qt5 FreeBSDQt5.13/x11locker.cpp:93:55: warning: 'screenCountChanged' is deprecated: Use QGuiApplication::screenAdded/Removed() [-Wdeprecated-declarations][2019-11-13T14:38:03.556Z] connect(QApplication::desktop(), ::screenCountChanged, this, ::updateGeo);[2019-11-13T14:38:03.556Z]   ^[2019-11-13T14:38:03.556Z] /usr/local/include/qt5/QtWidgets/qdesktopwidget.h:100:5: note: 'screenCountChanged' has been explicitly marked deprecated here[2019-11-13T14:38:03.556Z] QT_DEPRECATED_X("Use QGuiApplication::screenAdded/Removed()") void screenCountChanged(int);[2019-11-13T14:38:03.556Z] ^[2019-11-13T14:38:03.556Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2019-11-13T14:38:03.556Z] [ 78%] Building CXX object CMakeFiles/KScreenLocker.dir/powermanagement.cpp.o[2019-11-13T14:38:03.556Z] #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2019-11-13T14:38:03.556Z] ^[2019-11-13T14:38:03.556Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:649:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2019-11-13T14:38:03.556Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2019-11-13T14:38:03.556Z]   ^[2019-11-13T14:38:03.556Z] [ 79%] Building CXX object CMakeFiles/KScreenLocker.dir/powermanagement_inhibition.cpp.o[2019-11-13T14:38:03.556Z] /usr/home/jenkins/workspace/Plasma/kscreenlocker/kf5-qt5 FreeBSDQt5.13/x11locker.cpp:173:25: warning: cast from 'unsigned char *' to 'Window *' (aka 'unsigned long *') increases required alignment from 1 to 8 [-Wcast-align][2019-11-13T14:38:03.556Z] Window *dummy = (Window*)newRoot;[2019-11-13T14:38:03.556Z] ^~~~[2019-11-13T14:38:03.556Z] [ 80%] Linking CXX executable ../bin/x11LockerTest[2019-11-13T14:38:03.556Z] /usr/home/jenkins/workspace/Plasma/kscreenlocker/kf5-qt5 FreeBSDQt5.13/waylandlocker.cpp:78:46: warning: unused parameter 'window' [-Wunused-parameter][2019-11-13T14:38:03.556Z] void WaylandLocker::addAllowedWindow(quint32 window)[2019-11-13T14:38:03.556Z]  ^[2019-11-13T14:38:03.850Z] [ 80%] Built target x11LockerTest[2019-11-13T14:38:03.850Z] [ 81%] Building CXX object CMakeFiles/KScreenLocker.dir/kscreensaversettings.cpp.o[2019-11-13T14:38:04.141Z] 

D25212: Move the shortcut management in the settings object

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:68bdeb8cd7d9: Move the shortcut management in the 
settings object (authored by ervin).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25212?vs=69435=69675

REVISION DETAIL
  https://phabricator.kde.org/D25212

AFFECTED FILES
  CMakeLists.txt
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  kcfg/kscreensaversettings.kcfgc
  kcfg/kscreensaversettingsbase.kcfgc
  kcm/CMakeLists.txt
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm.ui
  kscreensaversettings.cpp
  kscreensaversettings.h
  ksldapp.cpp

To: ervin, #plasma, davidedmundson, bport, crossi, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

[Nathaniel Graham]

ngraham added a comment.


  In D25279#561853 , @jgrulich wrote:
  
  > There is already a method to enable/disable BT, why don't you reuse it?
  
  
  Nothing checks the previous BT status, so by the time we get to the function 
to enable BT, it can't know whether it was on before.
  
  ...Unless I'm misunderstanding you?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25279

To: ngraham, #plasma, jgrulich
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25284: Make QmlComponentsPool one instance per engine

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If we create 2 engines in an application the singleton is initialised to
  the first engine. If that first engine disappears the internal m_unit is
  dangling.
  
  A good example of this is systemsettings in the icon view if we enter
  two modules one after another. It's currently only kept alive because
  the sidebar created the first reference.
  
  BUG: 414003

TEST PLAN
  System settings in icon view
  opened global theme
  went back
  open fonts theme
  didn't crash

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25284

AFFECTED FILES
  src/columnview.cpp
  src/columnview_p.h

To: davidedmundson
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25281: [GTK3] Improve legibility of Firefox CSD colours

[Nathaniel Graham]

ngraham added a comment.


  In D25281#561861 , @broulik wrote:
  
  > >   However Once we implement the Breeze color scheme changes
  >
  > How is that related? If i keep using a dark title bar I will still have 
that issue. Merely changing the colorscheme doesn't fix the underlying bug?
  
  
  No, but it makes it less severe with the default color scheme. In fact, it 
makes Firefox the Thunderbird look quite good imo. :)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D25281

To: cblack, #vdg, #breeze
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25287: Integrate the lnf and wallpaper settings with the KCM logic

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, mart, davidedmundson, bport, crossi.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.

REVISION SUMMARY
  This was currently very much disconnected and broken in quite a few
  cases. The main changes here are:
  
  - disabling ConfigPropertyMap autosave behavior
  - having the QML integration write directly in the settings objects
  - use the settings objects to update the state of the KCM propertly
  
  Further improvement is needed to simplify the handling of the wallpaper
  plugin combo, it's still a bit over the place and fragile.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D25287

AFFECTED FILES
  greeter/lnf_integration.cpp
  greeter/lnf_integration.h
  greeter/wallpaper_integration.cpp
  greeter/wallpaper_integration.h
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/lnfconfig.qml
  kcm/wallpaperconfig.qml

To: ervin, #plasma, mart, davidedmundson, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24122: [GTK3] Generate Breeze Light assets

[Nathaniel Graham]

ngraham added a comment.


  I see.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24122

To: cblack, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22684: [Klipper] Fix clipboard history management

[Nathaniel Graham]

ngraham added a comment.


  @davidedmundson are you still good with this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22684

To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25290: KCM launchfeedback : port to KConfig XT

[Nathaniel Graham]

ngraham added a comment.


  So much red!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25290

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari updated this revision to Diff 69702.
gikari added a comment.


  Add DBusAddons component

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24743?vs=69691=69702

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/gtkconfig.json

To: gikari, #plasma, #vdg, broulik, cblack
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D24743: Update GTK settings according to Plasma settings

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> gikari wrote in configeditor.cpp:51
> You mean remove `gtk_init`?

Yes, my bad.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg, broulik, cblack
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D24798: Migrate QQC1 to QQC2

[Yunhe Guo]

guoyunhe updated this revision to Diff 69703.
guoyunhe added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24798?vs=69701=69703

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24798

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml
  applets/digital-clock/package/contents/ui/configTimeZones.qml
  applets/digital-clock/plugin/timezonesi18n.cpp
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/customwallpaper.qml

To: guoyunhe, #plasma, #plasma_workspaces, ngraham
Cc: broulik, kmaterka, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24798: Migrate QQC1 to QQC2

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks. Still needs fixes for the timezone list:
  
  - No frame around list
  - Scrolling using touchpad or mouse wheel does not work
  - Scrollview bounds are too large
  - Item highlight is weird and nonstandard
  - Keyboard navigation/selection does not work
  
  QQC2 really shouldn't make it this hard to build a halfway decent list view...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24798

To: guoyunhe, #plasma, #plasma_workspaces, ngraham
Cc: broulik, kmaterka, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24798: Migrate QQC1 to QQC2

[Yunhe Guo]

guoyunhe updated this revision to Diff 69701.
guoyunhe added a comment.


  Add QQC2 namespace

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24798?vs=68733=69701

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24798

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml
  applets/digital-clock/package/contents/ui/configTimeZones.qml
  applets/digital-clock/plugin/timezonesi18n.cpp
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/customwallpaper.qml

To: guoyunhe, #plasma, #plasma_workspaces, ngraham
Cc: broulik, kmaterka, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> cblack wrote in configeditor.cpp:51
> You should probably remove this call here, as you aren't using any GTK 
> functions.

You mean remove `gtk_init`?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg, broulik, cblack
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D24798: Migrate QQC1 to QQC2

[Nathaniel Graham]

ngraham added a comment.


  Needs a rebase, and Kai's comment still needs to be addressed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24798

To: guoyunhe, #plasma, #plasma_workspaces, ngraham
Cc: broulik, kmaterka, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24798: Migrate QQC1 to QQC2

[Yunhe Guo]

guoyunhe updated this revision to Diff 69705.
guoyunhe added a comment.


  Prefix QQC2

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24798?vs=69703=69705

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24798

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml
  applets/digital-clock/package/contents/ui/configTimeZones.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/customwallpaper.qml

To: guoyunhe, #plasma, #plasma_workspaces, ngraham
Cc: broulik, kmaterka, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Hmm
  
  F7761926: Screenshot_20191113_151950.png 

  
  Looks like the condition where `remainingTime` is 0 or undefined needs better 
handling.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24743: Update GTK settings according to Plasma settings

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> CMakeLists.txt:29
> +${GLIB2_LIBRARY}
> +${GTK3_LIBRARY}
> +${GOBJECT2_LIBRARY}

See below comments about GTK.

> configeditor.cpp:35
> +#include 
> +#include 
> +

You shouldn't need to import/use gtk for configuration, only gio which provides 
gsettings.

> configeditor.cpp:51
> +{
> +gtk_init(nullptr, nullptr);
> +g_autoptr(GSettings) gsettings = 
> g_settings_new("org.gnome.desktop.interface");

You should probably remove this call here, as you aren't using any GTK 
functions.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg, broulik, cblack
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari updated this revision to Diff 69704.
gikari marked 5 inline comments as done.
gikari added a comment.


  Remove unnecessary GTK lib usages

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24743?vs=69702=69704

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/gtkconfig.json

To: gikari, #plasma, #vdg, broulik, cblack
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D22176: Rework system tray settings

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22176

To: nicolasfella, #plasma, #vdg
Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

[Jan Grulich]

jgrulich added a comment.


  You are right, I didn't properly read what you do. I still think we should 
modify the already existing function to additionaly save the previous state, 
because most of the code is same. The only difference is "Set" vs "Get" method 
on DBus.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25279

To: ngraham, #plasma, jgrulich
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart