Kubuntu patches to plasma in kdelibs
Kubuntu has a couple of patches to plasma in kdelibs, here's a quick review in the interests of distro/upstream hugs. kubuntu_19_no_indent_kickoff_subtext.diff Removes the text intentation from kickoff and elsewhere, it was added on Celeste's advice. I'm pretty sure it's been discussed here before so no need to start a long thread :) http://bazaar.launchpad.net/%7Ekubuntu-members/kdelibs/ubuntu/annotate/head%3A/debian/patches/kubuntu_19_no_indent_kickoff_subtext.diff kubuntu_71_netbook_add_plasmawindoweffects.diff is backported from 4.4 http://bazaar.launchpad.net/%7Ekubuntu-members/kdelibs/ubuntu/annotate/head%3A/debian/patches/kubuntu_71_netbook_add_plasmawindoweffects.diff kubuntu_68_remove_applet_confirmation.diff I'm not sure where it came from but it allows the option to need a confirmation before removing a plasma widget. We don't turn this on by default and it includes the word hack written in capital letters so I'm not terribly keen on keeping it, but it seems like a not unreasonable idea in general if a UI was added. http://bazaar.launchpad.net/%7Ekubuntu-members/kdelibs/ubuntu/annotate/head%3A/debian/patches/kubuntu_68_remove_applet_confirmation.diff Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
kubuntu kdebase patches to plasma
The second in our series of periodical reviews of patches we include to Plasma. kubuntu_19_always_show_kickoff_subtext.diff, the subtexts in kickoff sometimes show always and sometimes on mouse over, this makes that consistent. It's been discussed here before. http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/annotate/head%3A/debian/patches/kubuntu_19_always_show_kickoff_subtext.diff kubuntu_71_default_plasma_layout.diff has our changes to the default layout. We used to do this with a config file override but that was unreliable. It adds the microblog applet to the desktop (social from the start, all the rage). It adds quickaccess, showdesktop, networkmanagement and our indicatordisplay applets to the panel. The clock shows the date by default, because I like to know what day it is. http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/annotate/head%3A/debian/patches/kubuntu_71_default_plasma_layout.diff kubuntu_91_plasma_autostart_condition.desktop is added so we can stop plasma-desktop being run for netbook edition. It would be good to find a better way to select between plasma-desktop and plasma-netbook, preferably as an X session at KDM. http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/annotate/head%3A/debian/patches/kubuntu_91_plasma_autostart_condition.desktop kubuntu_94_netbook_runner.diff comes from the netbook people, I believe it's in trunk. kubuntu_101_brightness_fn_keys_and_osd.diff adds a brightness on screen widget for brightness keys, it also needs patches to Qt and kdelibs to work http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/annotate/head%3A/debian/patches/kubuntu_101_brightness_fn_keys_and_osd.diff c'est tout Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
microblog kubuntu patch
For Kubuntu I add the microblog applet to the desktop by default. The intention is to integrate online services with KDE from first use (social from the start). Because forcing users to configure apps on first use it evil I patched it to default to a kubuntu feed by default, this turns out to be a more complex patch than I anticipated and I'm not entirely certain the quality of the patch is as it should be, but I still think it's a good idea to have it do something useful without configuration. http://bazaar.launchpad.net/%7Ekubuntu-members/kdeplasma-addons/ubuntu/annotate/head%3A/debian/patches/kubuntu_02_microblog_default_configuration.diff Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma Default Layout Scripting
Kubuntu currently has a patch to change the default layout of plasma in a couple of ways http://bazaar.launchpad.net/%7Ekubuntu-members/kdebase-workspace/ubuntu/annotate/head%3A/debian/patches/kubuntu_71_default_plasma_layout.diff As I understand it this should be replaced with a javascript script. Unfortunately there's not much in the way of examples to copy as far as I can find. So for our init script we want to recreate what loadDefaultLayout() does and the patch above. So far I have this var activity = new Activity(desktop); activity.addWidget(folderview); activity.addWidget(twitter); var panel = new Panel(panel); //TODO how to move to bottom? //panel.setLocation(SOMETHING); panel.addWidget(launcher); //TODO how to set launcher global shortcut? panel.addWidget(quickaccess); panel.addWidget(pager); panel.addWidget(tasks); panel.addWidget(showdesktop); systray = panel.addWidget(systemtray); //TODO how to do sysTray-action(add default applets) ? panel.addWidget(digital-clock); Can anyone fill in the gaps there? For upgrades I want to remove the batter and device notifier applets and have them in the sysTray. I think that's the same problem as the final TODO above. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Globally installed Python Plasmoids
With 4.4 I can't seem to get globally installed Python plasmoids to work in 4.4. In 4.3 plasma-widget-facebook would work with the files /usr/share/kde4/services/plasma-widget-facebook.desktop /usr/share/kde4/apps/plasma/plasmoids/facebook/metadata.desktop /usr/share/kde4/apps/plasma/plasmoids/facebook/contents/code/main.py (the first two files are the same) but in 4.4 I have to copy the last two files into ~/.kde/share/apps/plasma/plasmoids/facebook/ I get this error message plasma-desktop(18289)/libplasma Plasma::Package::isValid: Could not find required file mainscript , look in /home/jr/.kde/share/apps/plasma/plasmoids/facebook/contents/code/main Can globally installed Python plasmoids still work? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma Scripting IRC Session at 16:00 Tuesday
We'll have the Plasma Scripting IRC session at 16:00UTC on Tuesday (today) in #plasma on freenode. All welcome. Jonathan ___ Kde-packager mailing list kde-packa...@kde.org https://mail.kde.org/mailman/listinfo/kde-packager ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Scripting IRC Session at 16:00 Tuesday
On Tue, Apr 27, 2010 at 02:06:14AM +0100, Jonathan Riddell wrote: We'll have the Plasma Scripting IRC session at 16:00UTC on Tuesday (today) in #plasma on freenode. All welcome. 5 minutes reminder :) Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
KDE workspace users
With KDE Frameworks taking shape and sceenshots of Plasma 2 starting to appear it's worth looking at what else will need to be done to allow distros to ship it all. kde-runtime needs ported and there's a desire to move its various parts around https://community.kde.org/Frameworks/Epics/New_Runtime_Organization this page hasn't been touched for some time so I hope to make it more complete and discuss it more kde-workspace needs to be ported. much of this is under way in plasma 2 or the port of KWin but I'm not sure if it's all being tracked somewhere, should it be? Then there's various bits which use KDE Workspace and will stop working if you run Plasma 2. Various KControl Modules and plasma applets need ported to make a useable workspace. I've collected a list of the important ones here https://community.kde.org/Frameworks/Epics/KDE_workspace_users is this a useful list or is there already one somewhere? is there a better name for the list? it's bits which use the workspace rather than people who are users? is there a better place to put this wiki page? it's gatecrashing on the frameworks name now but maybe it shouldn't. does anything else need added to the list or are there other status updates I'm not aware of? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KDE workspace users
Looks like this duplicates some of http://community.kde.org/Plasma/PW2Todo I'll merge them together sometime Jonathan On Thu, Nov 14, 2013 at 06:50:35PM +, Jonathan Riddell wrote: With KDE Frameworks taking shape and sceenshots of Plasma 2 starting to appear it's worth looking at what else will need to be done to allow distros to ship it all. kde-runtime needs ported and there's a desire to move its various parts around https://community.kde.org/Frameworks/Epics/New_Runtime_Organization this page hasn't been touched for some time so I hope to make it more complete and discuss it more kde-workspace needs to be ported. much of this is under way in plasma 2 or the port of KWin but I'm not sure if it's all being tracked somewhere, should it be? Then there's various bits which use KDE Workspace and will stop working if you run Plasma 2. Various KControl Modules and plasma applets need ported to make a useable workspace. I've collected a list of the important ones here https://community.kde.org/Frameworks/Epics/KDE_workspace_users is this a useful list or is there already one somewhere? is there a better name for the list? it's bits which use the workspace rather than people who are users? is there a better place to put this wiki page? it's gatecrashing on the frameworks name now but maybe it shouldn't. does anything else need added to the list or are there other status updates I'm not aware of? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
New Runtime Organization
I've completed the wiki page for runtime organisation with a list of everything in kde-runtime. There's quite a few dusty corners here. https://community.kde.org/Frameworks/Epics/New_Runtime_Organization This page duplicates some of http://community.kde.org/Plasma/PW2Todo Please have a look over it and add comments where I've not been sure if something it used or if it's a runtime requirement or just a developer tool. Some parts can probably be removed (does anyone use kiofish any more?) and some moved into a framework. If I understand it right ASeigo's plan when making this page was to move most of it into the relevant framework but I'm not sure that's practical, e.g. the spellchecking kcm is marked to be moved into sonnet but that would create all sorts of extra circular dependencies on the sonnet framework. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KDE workspace users
I moved this to a new External Projects table on http://community.kde.org/Plasma/PW2Todo TODOkcm-akonadi TODOprint-manager TODOlibmm-qt TODOkde-config-gtk TODOkde wallet TODObluedevil TODOtelepathy kcm in system-settings TODOkamera TODOkscreen TODOabout-distro TODOlightdm/sddm TODOuser-manager Do update as relevant Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: No co-installability of plasma 1 and 2
I've been working on this assumption when making the coinstallability wiki page, I can't see any advantage is making the workspace co-installable. https://community.kde.org/Frameworks/Coinstallability Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Arrival in BCN
Incase you don't meet anyone it is super easy to get to the office, take the main airport bus service Aerobus http://www.aerobusbcn.com Get off at 2nd stop Gran Via/Urgell and walk to the office on Sepulveda. (south a block and west a block as I remember, barcelona is like an american city in block layout.) 10,20EUR return. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Oxygen as default font
On Wed, Mar 05, 2014 at 02:06:43PM +0100, Marco Martin wrote: On Wednesday 05 March 2014 13:36:33 Sebastian Kügler wrote: picked up by fontconfig, though. This means, installing it to a non-/usr prefix will likely mean the font is never going to be found for the user. There's a trick to fix this: fonts are picked up from XDG_DATA_HOME/fonts and ~/.fonts/ by default on most systems. So what I'm doing now is symlining the Oxygen font (conditionally) in one of those dirs (~/.fonts/ if XDG_DATA_HOME isn't set). so would symlink in the home if the prefix is not /usr? one thing that may be useful is to see how packagers expect fonts to be installed? we install oxygen to /usr/share/fonts/truetype/oxygen-fonts it may be easiest to just release oxygen font separately and have it as a build depends of kde-runtime, that way people who install kde-runtime into something other than /usr can just install the package. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116956: rename kglobalaccel to kglobalaccel5 for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116956/ --- Review request for KDE Runtime, Plasma and Martin Gräßlin. Repository: kde-runtime Description --- kde-runtime will soon get an alpha release. Because both KF5 and kdelibs4 applications should be able to be installed and run it should be co-installable with kde-runtime from KDE 4 times. Starting at the top of the cmake file I've renamed kglobalaccel to see if it's sane to do so. Diffs - kglobalaccel/org.kde.kglobalaccel.service.in d8576b0 kglobalaccel/CMakeLists.txt 8bc8bea kglobalaccel/kglobalaccel.desktop a61516e kglobalaccel/kglobalaccel.notifyrc 9e3ecd3 kglobalaccel/kglobalaccel5.desktop PRE-CREATION kglobalaccel/kglobalaccel5.notifyrc PRE-CREATION kglobalaccel/main.cpp d788b64 Diff: https://git.reviewboard.kde.org/r/116956/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
technology demonstration release 2
Good day Plasma There is a Technology demonstration release 2 due next week according to http://community.kde.org/Plasma/Next#Time_Based_Goals . Sebas is away and has asked that I help out with release management. Would that be welcomed? What needs released? Seems to be Comme Font (was Oxygen Font, annoyingly I can't get it to compile without FontForge segfaulting), kde-runtime and kde-workspace. Except kde-runtime and kde-workspace are being split up, is there any plan written down for what happening to them? Am I right in thinking that kde-runtime should be co-installable with the equivalent from kdelibs4 land? This probably needs quite a lot of bits renaming. (I've started on kglobalaccel https://git.reviewboard.kde.org/r/116956/). Am I right in thinking that kde-workspace doesn't need to be coinstallable with kdelibs4 equivalent? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116956: rename kglobalaccel to kglobalaccel5 for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116956/ --- (Updated March 25, 2014, 6:44 p.m.) Review request for KDE Runtime, Plasma and Martin Gräßlin. Changes --- rename to kglobalaccel5 to prevent file overlap with kdelibs 4 version don't move files in repository, just rename on install Repository: kde-runtime Description --- kde-runtime will soon get an alpha release. Because both KF5 and kdelibs4 applications should be able to be installed and run it should be co-installable with kde-runtime from KDE 4 times. Starting at the top of the cmake file I've renamed kglobalaccel to see if it's sane to do so. Diffs (updated) - kglobalaccel/CMakeLists.txt e0b739f kglobalaccel/kglobalaccel.desktop a61516e kglobalaccel/org.kde.kglobalaccel.service.in d8576b0 Diff: https://git.reviewboard.kde.org/r/116956/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: technology demonstration release 2
On Tue, Mar 25, 2014 at 07:58:21PM +0100, Aleix Pol wrote: Yes, kde-workspace should happen this week. kde-runtime I would say next but that's not part of the release I think. How can kde-runtime not be part of the release, it won't be very funcational without it surely? kde-runtime probably should be yes. I would suggest to do this work after the split. It will be more clear what goes where. Files will probably get installed in the same place so I don't think there's much to lose in starting now. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116956: rename kglobalaccel to kglobalaccel5 for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116956/ --- (Updated March 26, 2014, 11:55 a.m.) Status -- This change has been marked as submitted. Review request for KDE Runtime, Plasma and Martin Gräßlin. Repository: kde-runtime Description --- kde-runtime will soon get an alpha release. Because both KF5 and kdelibs4 applications should be able to be installed and run it should be co-installable with kde-runtime from KDE 4 times. Starting at the top of the cmake file I've renamed kglobalaccel to see if it's sane to do so. Diffs - kglobalaccel/CMakeLists.txt e0b739f kglobalaccel/kglobalaccel.desktop a61516e kglobalaccel/org.kde.kglobalaccel.service.in d8576b0 Diff: https://git.reviewboard.kde.org/r/116956/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma 2014.6 Alpha 1
Alpha 1 is due out on Tuesday but due to the splitting of kde-runtme and kde-workspace I'm going to try and get it tagged and tarred tomorrow. If you have any must have patched to get in time to do it toot sweet. I'll also tar up oxygen-fonts as Plasma now uses it by default. Then I'll send it around the packagers for mulling over and hopefully we can announce on Tuesday. Sebas and Jos are working on publicity. kde-runtime isn't currently co-installable so we'll have to highlight that it can't be installed alongside stuff using kdelibs4 yet. (But I'm working on patches, reviews needed https://git.reviewboard.kde.org/users/jriddell/ ) How does that sound? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma 2014.6 Alpha 1
Posted to release-team, plasma-devel and packagers. Let's keep the discussion on release-team for simplicity. I've uploaded initial tars of Plasma 2014.6 to depot. kde-runtime frameworks a37712565495939385f3e115bb41d7113b2ec76b 96e617a4afde01bd01cbe86810e8b1cea16bec2ee44732b1ee529425512d sources/kde-runtime-4.95.0.tar.xz kde-workspace master 5ac26da05523754ea2eab57ec58ad7f21c88bb21 229eddaf3dd3fb713124b7270e9dbd6998ec8496ce2023c39281e92dfe1b324c sources/kde-workspace-4.95.0.tar.xz oxygen-fonts release-0.4 556f299a8c562e4beaf72b60bd8e55e0647c8616 fd90a5198523c22749462c62705c77d84a6162205abeef306cfd3786cf34a18b sources/oxygen-fonts-3.95.0.tar.xz These should build with KF5 Beta 1 also just uploaded. I hope to release them on Tuesday. Oxygen Fonts uses fontforge to compile (generate is the term that seems to be used for fonts) and should work with the current release 20120731.b-5 of FontForge. Oxygen Fonts is the default font in Plasma Next. It is expected to get replaced with Comme Font, which is Oxygen Fonts renamed due to trademark issues https://github.com/vernnobile/commeFont but it has some spacing issues which mean we are going with Oxygen Fonts for now. Comme Font needs a version of FontForge from git http://fontforge.github.io/en-US/downloads/gnulinux/ but it must be a version from git in the last few weeks or it will segfault on generating the .ttf files. If anyone can get FontForge to compile you are doing better than me, please let me know how. kde-runtime is not co-installable with kde-runtime from kdelibs4 land so you will need to install to a different prefix or conflict your packages and warn users it'll remove up all kdelibs4 applications. I'm working on patches to fix this, any help appreciated (including reviews of my patches on reviewboard). kde-runtime is due to be split up after this release with much of it being put into Frameworks. kde-workspace contains what you've all been waiting for, the first alpha of Plasma Next which will become Plasma 2014.6 in June. Jenkins says it all compiles but I had an error in kwin oxygen theme I couldn't work out http://paste.kde.org/pfddkhxtw kde-workspace doesn't co-install with the kde-workspace from kdelibs4 land and nor is it expected to, it's a whole new version of Plasma. kde-workspace is due to be split up into separate sources after this release so don't spend too much time perfecting the packaging this time. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117372: replace kde4-config with kf5-config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117372/ --- Review request for Plasma and Àlex Fiestas. Repository: plasma-workspace Description --- startkde still uses kde4-config, this should be kf5-config in the kf5 world. Diffs - startkde/startkde.cmake e845603 Diff: https://git.reviewboard.kde.org/r/117372/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117372: replace kde4-config with kf5-config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117372/ --- (Updated April 10, 2014, 1:32 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Àlex Fiestas. Repository: plasma-workspace Description --- startkde still uses kde4-config, this should be kf5-config in the kf5 world. Diffs - startkde/startkde.cmake e845603 Diff: https://git.reviewboard.kde.org/r/117372/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Alpha 2
Alpha 2 is scheduled for a week today but as I understand it much of what was kde-runtime is now in KF5. So a new KF5 release will be needed which is not due until May 1st. Talking to KF5's Kevin he doesn't want a sudden new KF5 release and I doubt it's possible to give a load of patches with it. Should we cancel Alpha 2 and wait for Beta on May 6th? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Alpha 2
On Tue, Apr 15, 2014 at 05:57:56PM +0200, Aleix Pol wrote: With your distribution maintainer hat on, do you think an alpha 2 would reach users? Only if distros could package it and if it is co-installable. Since it requires a more recent version of KF5 it's not at all easy for distros to package it, and I suspect there's still plenty of bits that aren't co-installablle. I'm working on the ubuntu release this week so not able to confirm all this but will get to it after Thursday. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Alpha 2 Cancelled, Message freeze in 10 days time
I'm cancelling Alpha 2, due tomorrow, as I can't see any way to release it without a KDE Frameworks release. That makes our next deadline in 10 days time, the message freeze on Thusday 1st May followed by a beta the following Tuesday. We can discuss at the meeting tomorrow how realistic it is to have a message freeze now but I'd certainly be keen to keep the beta release on schedule. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117767: do not use minor library version for soversion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117767/ --- Review request for Plasma, Aleix Pol Gonzalez and John Tapsell. Repository: libksysguard Description --- set SOVERSION in CMakeLists.txt and use that for each library, minor version number is wrong to use Diffs - CMakeLists.txt 5aa86ab ksgrd/CMakeLists.txt 3daff17 lsofui/CMakeLists.txt d107611 processcore/CMakeLists.txt f2a84ae processui/CMakeLists.txt 599640f signalplotter/CMakeLists.txt 759aacf Diff: https://git.reviewboard.kde.org/r/117767/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117770: rename liboxygen libraries
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117770/ --- Review request for Plasma and Martin Gräßlin. Repository: oxygen Description --- liboxygen libraries used for the oxygen widget style should be renamed as they are runtime items which need to coinstall with equivalents from kdelibs4 land. However this does not compile, I'm confused by the target_include_directories() line for oxygenstyle, this change stops it including KMessageBox Diffs - liboxygen/CMakeLists.txt 4419809 Diff: https://git.reviewboard.kde.org/r/117770/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117772: rename oxygen-demo to oxygen-demo5 and oxygen-settings to oxygen-settings5 for co-installability with kde4 kde-runtime
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117772/ --- Review request for Plasma. Repository: oxygen Description --- rename oxygen-demo to oxygen-demo5 and oxygen-settings to oxygen-settings5 for co-installability with kde4 kde-runtime Diffs - kstyle/config/CMakeLists.txt 6e26eb89083b152031c426cb98aefd0e52fde2e0 kstyle/demo/CMakeLists.txt ba24b3e51c28347515f045df1781f86bc3fa8248 Diff: https://git.reviewboard.kde.org/r/117772/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117773: make kwin-decoration co-installable, remove unused kconfig_update script and rename oxygen-shadow-demo to oxygen-shadow-demo5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117773/ --- Review request for Plasma and Martin Gräßlin. Repository: oxygen Description --- make kwin-decoration co-installable with kdelibs4 equivalents, remove unused kconfig_update script and rename oxygen-shadow-demo to oxygen-shadow-demo5 kconfig upgrade script not used as KF5 apps will start with a fresh config Diffs - kwin-decoration/CMakeLists.txt ff99b256e94507b364965f3b8d4401dd07f55d9a kwin-decoration/data/CMakeLists.txt 7a4a2f7959b086d10dac313d02b49d97860fa057 kwin-decoration/data/oxygen.upd 2271c35e20f139625be419b2e9166aa35f9203a6 kwin-decoration/data/update_oxygen.pl da5c34e0a331ada6e0ef3be20838b3392a4ef051 kwin-decoration/demo/CMakeLists.txt 60c30180165a879ff3b3ab9980b47da186ce7ffc Diff: https://git.reviewboard.kde.org/r/117773/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117772: rename oxygen-demo to oxygen-demo5 and oxygen-settings to oxygen-settings5 for co-installability with kde4 kde-runtime
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117772/ --- (Updated April 25, 2014, 2:19 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: oxygen Description --- rename oxygen-demo to oxygen-demo5 and oxygen-settings to oxygen-settings5 for co-installability with kde4 kde-runtime Diffs - kstyle/config/CMakeLists.txt 6e26eb89083b152031c426cb98aefd0e52fde2e0 kstyle/demo/CMakeLists.txt ba24b3e51c28347515f045df1781f86bc3fa8248 Diff: https://git.reviewboard.kde.org/r/117772/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117773: make kwin-decoration co-installable, remove unused kconfig_update script and rename oxygen-shadow-demo to oxygen-shadow-demo5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117773/ --- (Updated April 25, 2014, 2:40 p.m.) Review request for Plasma, Martin Gräßlin and Hugo Pereira Da Costa. Changes --- add hugo Repository: oxygen Description --- make kwin-decoration co-installable with kdelibs4 equivalents, remove unused kconfig_update script and rename oxygen-shadow-demo to oxygen-shadow-demo5 kconfig upgrade script not used as KF5 apps will start with a fresh config Diffs - kwin-decoration/CMakeLists.txt ff99b256e94507b364965f3b8d4401dd07f55d9a kwin-decoration/data/CMakeLists.txt 7a4a2f7959b086d10dac313d02b49d97860fa057 kwin-decoration/data/oxygen.upd 2271c35e20f139625be419b2e9166aa35f9203a6 kwin-decoration/data/update_oxygen.pl da5c34e0a331ada6e0ef3be20838b3392a4ef051 kwin-decoration/demo/CMakeLists.txt 60c30180165a879ff3b3ab9980b47da186ce7ffc Diff: https://git.reviewboard.kde.org/r/117773/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117770: rename liboxygen libraries
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117770/ --- (Updated April 25, 2014, 4:39 p.m.) Review request for Plasma and Martin Gräßlin. Changes --- Rename library where it is used elsewhere, this fixes the compile Repository: oxygen Description --- liboxygen libraries used for the oxygen widget style should be renamed as they are runtime items which need to coinstall with equivalents from kdelibs4 land. However this does not compile, I'm confused by the target_include_directories() line for oxygenstyle, this change stops it including KMessageBox Diffs (updated) - kstyle/config/CMakeLists.txt 560c409 kwin-decoration/CMakeLists.txt ff99b25 kstyle/CMakeLists.txt 8c76de3 kwin-decoration/config/CMakeLists.txt c7e6d49 kwin-decoration/demo/CMakeLists.txt 60c3018 liboxygen/CMakeLists.txt 4419809 Diff: https://git.reviewboard.kde.org/r/117770/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117770: rename liboxygen libraries
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117770/ --- (Updated April 25, 2014, 4:40 p.m.) Review request for Plasma and Martin Gräßlin. Repository: oxygen Description (updated) --- liboxygen libraries used for the oxygen widget style should be renamed as they are runtime items which need to coinstall with equivalents from kdelibs4 land. Diffs - kstyle/config/CMakeLists.txt 560c409 kwin-decoration/CMakeLists.txt ff99b25 kstyle/CMakeLists.txt 8c76de3 kwin-decoration/config/CMakeLists.txt c7e6d49 kwin-decoration/demo/CMakeLists.txt 60c3018 liboxygen/CMakeLists.txt 4419809 Diff: https://git.reviewboard.kde.org/r/117770/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117775: rename oxygen sound files for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117775/ --- Review request for Plasma. Repository: oxygen Description --- Oxygen sound files were part of kde-runtime so need to be co-installable with kdelibs4 world. Use Oxygen name to give them a different name and correct identify the sound theme. There are various .notifyrc files that use these files which I'll submit patches for should this one be accepted. Diffs - sounds/KDE-Im-Cant-Connect.ogg sounds/KDE-Im-Connection-Lost.ogg sounds/KDE-Im-Contact-In.ogg sounds/KDE-Im-Contact-Out.ogg sounds/KDE-Im-Error-On-Connection.ogg sounds/KDE-Im-Highlight-Msg.ogg sounds/KDE-Im-Internal-Error.ogg sounds/KDE-Im-Irc-Event.ogg sounds/KDE-Im-Low-Priority-Message.ogg sounds/KDE-Im-Message-In.ogg sounds/KDE-Im-Message-Out.ogg sounds/KDE-Im-Network-Problems.ogg sounds/KDE-Im-New-Mail.ogg sounds/KDE-Im-Nudge.ogg sounds/KDE-Im-Phone-Ring.ogg sounds/KDE-Im-Sms.ogg sounds/KDE-Im-User-Auth.ogg sounds/KDE-K3B-Finish-Error.ogg sounds/KDE-K3B-Finish-Success.ogg sounds/KDE-K3B-Insert-Medium.ogg sounds/KDE-Sys-App-Error-Critical.ogg sounds/KDE-Sys-App-Error-Serious-Very.ogg sounds/KDE-Sys-App-Error-Serious.ogg sounds/KDE-Sys-App-Error.ogg sounds/KDE-Sys-App-Message.ogg sounds/KDE-Sys-App-Negative.ogg sounds/KDE-Sys-App-Positive.ogg sounds/KDE-Sys-Error-Printing.ogg sounds/KDE-Sys-File-Open-Foes.ogg sounds/KDE-Sys-List-End.ogg sounds/KDE-Sys-List-Match-Multiple.ogg sounds/KDE-Sys-List-Match-No.ogg sounds/KDE-Sys-Log-In-Long.ogg sounds/KDE-Sys-Log-In-Short.ogg sounds/KDE-Sys-Log-In.ogg sounds/KDE-Sys-Log-Out.ogg sounds/KDE-Sys-Question.ogg sounds/KDE-Sys-Special.ogg sounds/KDE-Sys-Trash-Emptied.ogg sounds/KDE-Sys-Warning.ogg sounds/KDE-Window-All-Desktops-Not.ogg sounds/KDE-Window-All-Desktops.ogg sounds/KDE-Window-Close.ogg sounds/KDE-Window-Maximize.ogg sounds/KDE-Window-Minimize.ogg sounds/KDE-Window-Move-Stop.ogg sounds/KDE-Window-Move.ogg sounds/KDE-Window-Shade-Down.ogg sounds/KDE-Window-Shade-Up.ogg Diff: https://git.reviewboard.kde.org/r/117775/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117773: make kwin-decoration co-installable, remove unused kconfig_update script and rename oxygen-shadow-demo to oxygen-shadow-demo5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117773/ --- (Updated April 29, 2014, 8:54 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Martin Gräßlin and Hugo Pereira Da Costa. Repository: oxygen Description --- make kwin-decoration co-installable with kdelibs4 equivalents, remove unused kconfig_update script and rename oxygen-shadow-demo to oxygen-shadow-demo5 kconfig upgrade script not used as KF5 apps will start with a fresh config Diffs - kwin-decoration/CMakeLists.txt ff99b256e94507b364965f3b8d4401dd07f55d9a kwin-decoration/data/CMakeLists.txt 7a4a2f7959b086d10dac313d02b49d97860fa057 kwin-decoration/data/oxygen.upd 2271c35e20f139625be419b2e9166aa35f9203a6 kwin-decoration/data/update_oxygen.pl da5c34e0a331ada6e0ef3be20838b3392a4ef051 kwin-decoration/demo/CMakeLists.txt 60c30180165a879ff3b3ab9980b47da186ce7ffc Diff: https://git.reviewboard.kde.org/r/117773/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117775: rename oxygen sound files for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117775/ --- (Updated April 29, 2014, 9:40 a.m.) Review request for Plasma and Jens Rutschmann. Changes --- Adding jens to review, if new theme sound effects are coming soon these old ones can be just not installed Repository: oxygen Description --- Oxygen sound files were part of kde-runtime so need to be co-installable with kdelibs4 world. Use Oxygen name to give them a different name and correct identify the sound theme. There are various .notifyrc files that use these files which I'll submit patches for should this one be accepted. Diffs - sounds/KDE-Im-Cant-Connect.ogg sounds/KDE-Im-Connection-Lost.ogg sounds/KDE-Im-Contact-In.ogg sounds/KDE-Im-Contact-Out.ogg sounds/KDE-Im-Error-On-Connection.ogg sounds/KDE-Im-Highlight-Msg.ogg sounds/KDE-Im-Internal-Error.ogg sounds/KDE-Im-Irc-Event.ogg sounds/KDE-Im-Low-Priority-Message.ogg sounds/KDE-Im-Message-In.ogg sounds/KDE-Im-Message-Out.ogg sounds/KDE-Im-Network-Problems.ogg sounds/KDE-Im-New-Mail.ogg sounds/KDE-Im-Nudge.ogg sounds/KDE-Im-Phone-Ring.ogg sounds/KDE-Im-Sms.ogg sounds/KDE-Im-User-Auth.ogg sounds/KDE-K3B-Finish-Error.ogg sounds/KDE-K3B-Finish-Success.ogg sounds/KDE-K3B-Insert-Medium.ogg sounds/KDE-Sys-App-Error-Critical.ogg sounds/KDE-Sys-App-Error-Serious-Very.ogg sounds/KDE-Sys-App-Error-Serious.ogg sounds/KDE-Sys-App-Error.ogg sounds/KDE-Sys-App-Message.ogg sounds/KDE-Sys-App-Negative.ogg sounds/KDE-Sys-App-Positive.ogg sounds/KDE-Sys-Error-Printing.ogg sounds/KDE-Sys-File-Open-Foes.ogg sounds/KDE-Sys-List-End.ogg sounds/KDE-Sys-List-Match-Multiple.ogg sounds/KDE-Sys-List-Match-No.ogg sounds/KDE-Sys-Log-In-Long.ogg sounds/KDE-Sys-Log-In-Short.ogg sounds/KDE-Sys-Log-In.ogg sounds/KDE-Sys-Log-Out.ogg sounds/KDE-Sys-Question.ogg sounds/KDE-Sys-Special.ogg sounds/KDE-Sys-Trash-Emptied.ogg sounds/KDE-Sys-Warning.ogg sounds/KDE-Window-All-Desktops-Not.ogg sounds/KDE-Window-All-Desktops.ogg sounds/KDE-Window-Close.ogg sounds/KDE-Window-Maximize.ogg sounds/KDE-Window-Minimize.ogg sounds/KDE-Window-Move-Stop.ogg sounds/KDE-Window-Move.ogg sounds/KDE-Window-Shade-Down.ogg sounds/KDE-Window-Shade-Up.ogg Diff: https://git.reviewboard.kde.org/r/117775/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117855: use renamed entry.desktop files (both language and country entry.desktop files have been renamed in kdelibs4support)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117855/ --- Review request for Plasma. Repository: khelpcenter Description --- use renamed entry.desktop files (both language and country entry.desktop files have been renamed in kdelibs4support) Diffs - docmetainfo.cpp d1b7b3552120135ab9e808fce5818e4aef92103a htmlsearch/kcmhtmlsearch.cpp 4bfa033fef2f11a6feb05922ba12f5b90f624737 Diff: https://git.reviewboard.kde.org/r/117855/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117856: do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117856/ --- Review request for Plasma. Repository: oxygen Description --- do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme Diffs - CMakeLists.txt 5521fe94c5f2dc2ce68af261081bc05c7f2ae571 Diff: https://git.reviewboard.kde.org/r/117856/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117856: do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme
On April 29, 2014, 10:22 a.m., Marco Martin wrote: hmm, not sure about that. is true that for a long timekde4 will stay installed, but i think it should sill work even when kde4 is not installed (especially because iirc cursors came from kde-workspace, that will be the first to not be installed anymore when the migration is going) would it be possible for distributions to do the following? have cursors in another package (different packages per repo should be something all distros can do?) and have the cursors package conflicting as an alternative package From an upstream view why would we ship something in Plasma releases that Plasma doesn't use? Note similar issues in https://git.reviewboard.kde.org/r/117775/ for sound files - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117856/#review56846 --- On April 29, 2014, 10:13 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117856/ --- (Updated April 29, 2014, 10:13 a.m.) Review request for Plasma. Repository: oxygen Description --- do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme Diffs - CMakeLists.txt 5521fe94c5f2dc2ce68af261081bc05c7f2ae571 Diff: https://git.reviewboard.kde.org/r/117856/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Breeze repo
On Tue, Apr 29, 2014 at 12:32:04PM +0200, Marco Martin wrote: Aaaan, is done https://projects.kde.org/projects/kde/workspace/breeze right now it just contains the cursor theme (i would put also the temporary wallpaper we have in it) From a branding point of view the cursors have the brand Bridge, why do they not have the Breeze brand? Seems it'll kill any neat branding message possibility. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117857: use renamed entry.desktop files (both country and locale files have been renamed to kf5_entry.desktop)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117857/ --- Review request for Plasma. Repository: plasma-desktop Description --- use renamed entry.desktop files (both country and locale files have been renamed to kf5_entry.desktop) Diffs - kcms/locale/countryselectordialog.cpp 4a40f1737a1b66c09ea3087f49ea253391e42a68 kcms/locale/kcmlocale.h c7b29bcf5fb4eddf7a2a937b34a7d615f8f9120c kcms/locale/kcmlocale.cpp 9785c29991ce323a4bf581872039133a0d2c2bd5 Diff: https://git.reviewboard.kde.org/r/117857/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117857: use renamed entry.desktop files (both country and locale files have been renamed to kf5_entry.desktop)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117857/ --- (Updated April 29, 2014, 10:54 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description --- use renamed entry.desktop files (both country and locale files have been renamed to kf5_entry.desktop) Diffs - kcms/locale/countryselectordialog.cpp 4a40f1737a1b66c09ea3087f49ea253391e42a68 kcms/locale/kcmlocale.h c7b29bcf5fb4eddf7a2a937b34a7d615f8f9120c kcms/locale/kcmlocale.cpp 9785c29991ce323a4bf581872039133a0d2c2bd5 Diff: https://git.reviewboard.kde.org/r/117857/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117857: use renamed entry.desktop files (both country and locale files have been renamed to kf5_entry.desktop)
On April 29, 2014, 10:50 a.m., Marco Martin wrote: Ship It! shipped in http://commits.kde.org/plasma-desktop/d8e16186bb0a297b601f06383de6abb225c3593b - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117857/#review56849 --- On April 29, 2014, 10:47 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117857/ --- (Updated April 29, 2014, 10:47 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- use renamed entry.desktop files (both country and locale files have been renamed to kf5_entry.desktop) Diffs - kcms/locale/countryselectordialog.cpp 4a40f1737a1b66c09ea3087f49ea253391e42a68 kcms/locale/kcmlocale.h c7b29bcf5fb4eddf7a2a937b34a7d615f8f9120c kcms/locale/kcmlocale.cpp 9785c29991ce323a4bf581872039133a0d2c2bd5 Diff: https://git.reviewboard.kde.org/r/117857/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117856: do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme
On April 29, 2014, 11:02 a.m., Aleix Pol Gonzalez wrote: This doesn't make sense. We want oxygen cursors available. Cursor themes are not a new concept. It is not a question of themes, it is that two packages which install the same theme is a packaging problem. In this case kde-workspace and oxygen install the same theme. oxygen is a runtime component of KF5 based applications and should be co-installable with users runing Plasma 1 from kde-workspace - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117856/#review56856 --- On April 29, 2014, 10:13 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117856/ --- (Updated April 29, 2014, 10:13 a.m.) Review request for Plasma. Repository: oxygen Description --- do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme Diffs - CMakeLists.txt 5521fe94c5f2dc2ce68af261081bc05c7f2ae571 Diff: https://git.reviewboard.kde.org/r/117856/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117859: rename kioslave files for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117859/ --- Review request for Plasma. Repository: kio-extras Description --- rename kioslave files for co-installability ktrash - ktrash5 (I'm not aware of anything which uses this binary) network.xml - kf5_network.xml org.kde.network.kioslavenotifier.xml - kf5_org.kde.network.kioslavenotifier.xml (I don't know what uses this but I assume something must and will need updated) old review for pre-split kde-runtime https://git.reviewboard.kde.org/r/117092/ Diffs - doc/kioslave/bookmarks/CMakeLists.txt d90f510b27d725990d48bbc898171b31145cbce8 doc/kioslave/bzip2/CMakeLists.txt 164ff50123c4871380a049da0802390ee2fb4efe doc/kioslave/cgi/CMakeLists.txt 4474a13be8a4a08f2f4cf7d1551147e7ed456ca1 doc/kioslave/finger/CMakeLists.txt 54a06b03ac01f45d5a64b7ff9922685066e53031 doc/kioslave/fish/CMakeLists.txt a711911486a1dc23d3dd3b87b797a04172049e57 doc/kioslave/floppy/CMakeLists.txt 601a7e82d660152a43909fe7efb678b2dafb3097 doc/kioslave/gzip/CMakeLists.txt 15d9a61bdf4e3910111f4ce0f5936f6532958d6b doc/kioslave/info/CMakeLists.txt 3a4ace9354763d053226f70513faede36366c921 doc/kioslave/man/CMakeLists.txt 7375332b84d101c72bda6f34289681721b52a5d4 doc/kioslave/network/CMakeLists.txt 0921d20edb0c6813403106f3b6edd753a4a2ec61 doc/kioslave/nfs/CMakeLists.txt 5d98acec8bf00815c0bc9863e46517f7e6ae6167 doc/kioslave/sftp/CMakeLists.txt fe08290135151d759feabbbe9258f8f68fe40f42 doc/kioslave/smb/CMakeLists.txt 906e9452d8cd22fe8ef57bcbaaad6de37ddd0327 doc/kioslave/tar/CMakeLists.txt a699590a2befca7fd50091d1ed65edc02c1738ec doc/kioslave/thumbnail/CMakeLists.txt 555407db183cd9716b31911f99126f0da1e968db doc/kioslave/xz/CMakeLists.txt 731d5194d30627e8cf9fddb66af6cc40cdf0d251 network/kded/CMakeLists.txt e851f73edaeea551dc17917d2b72076f99c6e6a2 network/mimetypes/CMakeLists.txt c20dc905419f2308466310b24ae18662542c37e6 trash/CMakeLists.txt 7c72cdccd2d2876b5c33122a27bbf3372d0a93f3 Diff: https://git.reviewboard.kde.org/r/117859/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117855: use renamed entry.desktop files (both language and country entry.desktop files have been renamed in kdelibs4support)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117855/ --- (Updated April 29, 2014, 12:02 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: khelpcenter Description --- use renamed entry.desktop files (both language and country entry.desktop files have been renamed in kdelibs4support) Diffs - docmetainfo.cpp d1b7b3552120135ab9e808fce5818e4aef92103a htmlsearch/kcmhtmlsearch.cpp 4bfa033fef2f11a6feb05922ba12f5b90f624737 Diff: https://git.reviewboard.kde.org/r/117855/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117861: remove obsolete kconfig_update file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117861/ --- Review request for Plasma. Repository: kio-extras Description --- update to https://git.reviewboard.kde.org/r/117093 for split repositories remove kconf_update file which handles settings from kdelibs4 land. In kf5 land people will start with clean settings. Diffs - kurifilter-plugins/ikws/CMakeLists.txt 51294b5 kurifilter-plugins/ikws/kuriikwsfilter.upd 0874ce2 Diff: https://git.reviewboard.kde.org/r/117861/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117775: rename oxygen sound files for co-installability
On April 29, 2014, 11:04 a.m., Aleix Pol Gonzalez wrote: Wouldn't it make more sense to have sounds/oxygen and sounds/breeze? Not really, if we were to support the whole sound theme spec that would make sense but otherwise we're just kidding ourselves that we're able to support anything other than a list of filenames. http://www.freedesktop.org/wiki/Specifications/sound-theme-spec/ - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117775/#review56859 --- On April 29, 2014, 9:40 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117775/ --- (Updated April 29, 2014, 9:40 a.m.) Review request for Plasma and Jens Rutschmann. Repository: oxygen Description --- Oxygen sound files were part of kde-runtime so need to be co-installable with kdelibs4 world. Use Oxygen name to give them a different name and correct identify the sound theme. There are various .notifyrc files that use these files which I'll submit patches for should this one be accepted. Diffs - sounds/KDE-Im-Cant-Connect.ogg sounds/KDE-Im-Connection-Lost.ogg sounds/KDE-Im-Contact-In.ogg sounds/KDE-Im-Contact-Out.ogg sounds/KDE-Im-Error-On-Connection.ogg sounds/KDE-Im-Highlight-Msg.ogg sounds/KDE-Im-Internal-Error.ogg sounds/KDE-Im-Irc-Event.ogg sounds/KDE-Im-Low-Priority-Message.ogg sounds/KDE-Im-Message-In.ogg sounds/KDE-Im-Message-Out.ogg sounds/KDE-Im-Network-Problems.ogg sounds/KDE-Im-New-Mail.ogg sounds/KDE-Im-Nudge.ogg sounds/KDE-Im-Phone-Ring.ogg sounds/KDE-Im-Sms.ogg sounds/KDE-Im-User-Auth.ogg sounds/KDE-K3B-Finish-Error.ogg sounds/KDE-K3B-Finish-Success.ogg sounds/KDE-K3B-Insert-Medium.ogg sounds/KDE-Sys-App-Error-Critical.ogg sounds/KDE-Sys-App-Error-Serious-Very.ogg sounds/KDE-Sys-App-Error-Serious.ogg sounds/KDE-Sys-App-Error.ogg sounds/KDE-Sys-App-Message.ogg sounds/KDE-Sys-App-Negative.ogg sounds/KDE-Sys-App-Positive.ogg sounds/KDE-Sys-Error-Printing.ogg sounds/KDE-Sys-File-Open-Foes.ogg sounds/KDE-Sys-List-End.ogg sounds/KDE-Sys-List-Match-Multiple.ogg sounds/KDE-Sys-List-Match-No.ogg sounds/KDE-Sys-Log-In-Long.ogg sounds/KDE-Sys-Log-In-Short.ogg sounds/KDE-Sys-Log-In.ogg sounds/KDE-Sys-Log-Out.ogg sounds/KDE-Sys-Question.ogg sounds/KDE-Sys-Special.ogg sounds/KDE-Sys-Trash-Emptied.ogg sounds/KDE-Sys-Warning.ogg sounds/KDE-Window-All-Desktops-Not.ogg sounds/KDE-Window-All-Desktops.ogg sounds/KDE-Window-Close.ogg sounds/KDE-Window-Maximize.ogg sounds/KDE-Window-Minimize.ogg sounds/KDE-Window-Move-Stop.ogg sounds/KDE-Window-Move.ogg sounds/KDE-Window-Shade-Down.ogg sounds/KDE-Window-Shade-Up.ogg Diff: https://git.reviewboard.kde.org/r/117775/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117874: don't install kconf_update files from KDE4 land, KF5 apps start with a fresh install
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117874/ --- Review request for Plasma. Repository: plasma-workspace Description --- don't install kconf_update files from KDE4 land, KF5 apps start with a fresh install Diffs - drkonqi/CMakeLists.txt 4794621a747cdc0fe8b09b3fbd3811d30e207ba3 drkonqi/drkonqi-rename-config-section.upd 413908f7d1ba2c2053a8b18de5e3ed4dc349ce28 kglobalaccel/CMakeLists.txt 1ddee63193b79616493f874db3f7d930e76b3ec5 kglobalaccel/kconf/kdedglobalaccel_kde42.upd 260434aa2a768e3fedbecfd107d0bb2ce5315dc0 klipper/CMakeLists.txt f4bd8312b022401a3b34802751c4510fa85807f7 klipper/klipper-kconfigxt.upd 586948ed33b6252163e202b6a14254b5b75bb474 ksmserver/CMakeLists.txt 65af7d83750218ea369256a9394281404ead6206 ksmserver/ksmserver_shortcuts.upd 760f6a94fc5048eb919dfa36c52e3af51f71fefc ksmserver/screenlocker/data/CMakeLists.txt 624eaf3b043168260a2bb03832d3ae914cb1a1aa ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd cbc4d527f65c0e2d397e4b0bee40fd6f3969bbe4 Diff: https://git.reviewboard.kde.org/r/117874/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- Review request for Plasma. Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 019f46c Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117874: don't install kconf_update files from KDE4 land, KF5 apps start with a fresh install
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117874/ --- (Updated April 29, 2014, 3:10 p.m.) Review request for Plasma. Changes --- Update to delete the force_krunner_lock_shortcut_unreg binary too Repository: plasma-workspace Description --- don't install kconf_update files from KDE4 land, KF5 apps start with a fresh install Diffs (updated) - drkonqi/CMakeLists.txt 4794621 drkonqi/drkonqi-rename-config-section.upd 413908f kglobalaccel/CMakeLists.txt 1ddee63 kglobalaccel/kconf/kdedglobalaccel_kde42.upd 260434a klipper/CMakeLists.txt f4bd831 klipper/klipper-kconfigxt.upd 586948e ksmserver/CMakeLists.txt 65af7d8 ksmserver/ksmserver_shortcuts.upd 760f6a9 ksmserver/screenlocker/CMakeLists.txt 700cdff ksmserver/screenlocker/data/CMakeLists.txt 624eaf3 ksmserver/screenlocker/data/force_krunner_lock_shortcut_unreg.cpp fe1cd8a ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd cbc4d52 Diff: https://git.reviewboard.kde.org/r/117874/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117877: use correct soversion in libtaskmanager
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117877/ --- Review request for Plasma. Repository: plasma-workspace Description --- do not use obsolete version variable, as with libkworkspace just set version statically and set soversion to 5 Diffs - libtaskmanager/CMakeLists.txt 6fa69261d1f97e14fdc4ee3012b8220616a7ff0e Diff: https://git.reviewboard.kde.org/r/117877/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
.desktop translations disappeared in plasma-workspace
many .desktop translations disappeared in plasma-workspace today, I don't think that's right. http://quickgit.kde.org/?p=plasma-workspace.gita=commith=7340ee797284ce5ba049e2288a5905554e7a41db Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated April 29, 2014, 3:29 p.m.) Review request for Plasma. Changes --- rename dbus service file too Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs (updated) - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 2dec197 Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117877: use correct soversion in libtaskmanager
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117877/ --- (Updated April 29, 2014, 3:34 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- do not use obsolete version variable, as with libkworkspace just set version statically and set soversion to 5 Diffs - libtaskmanager/CMakeLists.txt 6fa69261d1f97e14fdc4ee3012b8220616a7ff0e Diff: https://git.reviewboard.kde.org/r/117877/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117884: rename binaries for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117884/ --- Review request for Plasma. Repository: kde-cli-tools Description --- these cli tools are in kde-runtime in KDE 4 land so need to be renames so they are co-installable. Many are unused in the KDE codebase according to lxr but some are used and I'll submit renaming patches to them if this is accepted.. keditfiletype used by: frameworks/kio/src/widgets/kpropertiesdialog.cpp frameworks/kwidgetsaddons/src/kmimetypechooser.cpp applications/kde-baseapps/lib/konq/konq_operations.cpp workspace/plasma-desktop/containments/folder/plugin/internallibkonq/konq_operations.cpp workspace/plasma-desktop/kcms/componentchooser/componentchooserfilemanager.cpp kmimetypefinder: unused ktraderclient: used in kde/workspace/kio-extras/kurifilter-plugins/tests/kurifiltertest.cpp kioclient: used in applications/kde-baseapps/konqueror/client/kfmclient.cpp workspace/plasma-workspace/applets/devicenotifier/test-predicate-openinwindow.desktop workspace/plasma-workspace/ksmserver/startup.cpp workspace/plasma-workspace/drkonqi/data/mappings kdecp: unused kdemv: unused kde-open: unused ksvgtopng: unused I note keditfiletype is used in frameworks so I should also look into moving that into a framework. Diffs - keditfiletype/CMakeLists.txt 0adfde946b783cbee09661cfe445792eb1a54649 kioclient/CMakeLists.txt cca4f5c222a3266f7ec468fa138bd2cefa880902 kmimetypefinder/CMakeLists.txt 720ccb07bd7a0a6a567b3bf70caa00d532232663 kstart/CMakeLists.txt e7810d2788290b5f33447f90948dc020e1c8b1b9 ksvgtopng/CMakeLists.txt 82602887bb7370e591545b059418a68457c85c28 ktraderclient/CMakeLists.txt 028aac3ef9c5e293078df0796ee35577b0679afb Diff: https://git.reviewboard.kde.org/r/117884/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117775: rename oxygen sound files for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117775/ --- (Updated April 30, 2014, 9:08 a.m.) Review request for Plasma. Repository: oxygen Description --- Oxygen sound files were part of kde-runtime so need to be co-installable with kdelibs4 world. Use Oxygen name to give them a different name and correct identify the sound theme. There are various .notifyrc files that use these files which I'll submit patches for should this one be accepted. Diffs - sounds/KDE-Im-Cant-Connect.ogg sounds/KDE-Im-Connection-Lost.ogg sounds/KDE-Im-Contact-In.ogg sounds/KDE-Im-Contact-Out.ogg sounds/KDE-Im-Error-On-Connection.ogg sounds/KDE-Im-Highlight-Msg.ogg sounds/KDE-Im-Internal-Error.ogg sounds/KDE-Im-Irc-Event.ogg sounds/KDE-Im-Low-Priority-Message.ogg sounds/KDE-Im-Message-In.ogg sounds/KDE-Im-Message-Out.ogg sounds/KDE-Im-Network-Problems.ogg sounds/KDE-Im-New-Mail.ogg sounds/KDE-Im-Nudge.ogg sounds/KDE-Im-Phone-Ring.ogg sounds/KDE-Im-Sms.ogg sounds/KDE-Im-User-Auth.ogg sounds/KDE-K3B-Finish-Error.ogg sounds/KDE-K3B-Finish-Success.ogg sounds/KDE-K3B-Insert-Medium.ogg sounds/KDE-Sys-App-Error-Critical.ogg sounds/KDE-Sys-App-Error-Serious-Very.ogg sounds/KDE-Sys-App-Error-Serious.ogg sounds/KDE-Sys-App-Error.ogg sounds/KDE-Sys-App-Message.ogg sounds/KDE-Sys-App-Negative.ogg sounds/KDE-Sys-App-Positive.ogg sounds/KDE-Sys-Error-Printing.ogg sounds/KDE-Sys-File-Open-Foes.ogg sounds/KDE-Sys-List-End.ogg sounds/KDE-Sys-List-Match-Multiple.ogg sounds/KDE-Sys-List-Match-No.ogg sounds/KDE-Sys-Log-In-Long.ogg sounds/KDE-Sys-Log-In-Short.ogg sounds/KDE-Sys-Log-In.ogg sounds/KDE-Sys-Log-Out.ogg sounds/KDE-Sys-Question.ogg sounds/KDE-Sys-Special.ogg sounds/KDE-Sys-Trash-Emptied.ogg sounds/KDE-Sys-Warning.ogg sounds/KDE-Window-All-Desktops-Not.ogg sounds/KDE-Window-All-Desktops.ogg sounds/KDE-Window-Close.ogg sounds/KDE-Window-Maximize.ogg sounds/KDE-Window-Minimize.ogg sounds/KDE-Window-Move-Stop.ogg sounds/KDE-Window-Move.ogg sounds/KDE-Window-Shade-Down.ogg sounds/KDE-Window-Shade-Up.ogg Diff: https://git.reviewboard.kde.org/r/117775/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated April 30, 2014, 9:20 a.m.) Review request for Plasma. Changes --- fix renaming target Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs (updated) - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 2dec197 Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
On April 29, 2014, 10:56 p.m., Hrvoje Senjan wrote: kuiserver/CMakeLists.txt, line 73 https://git.reviewboard.kde.org/r/117876/diff/2/?file=269233#file269233line73 i guess also org.kde.kuiserver.service would need adjusting ... Marco Martin wrote: shouldn't the services maintain their name? i don't think we want co-runnability no? (if changed everybody using them should be adapted, leading to things breaking with no obvious reasons) The patch does rename org.kde.kuiserver.service. From http://www.freedesktop.org/wiki/IntroductionToDBus/ write a service file bankcounter.service (the name is arbitrary, so long as it ends with .service) - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/#review56933 --- On April 30, 2014, 9:20 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated April 30, 2014, 9:20 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 2dec197 Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117859: rename kioslave files for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117859/ --- (Updated April 30, 2014, 9:36 a.m.) Review request for Plasma. Changes --- Also move path to documentation to match kio Repository: kio-extras Description --- rename kioslave files for co-installability ktrash - ktrash5 (I'm not aware of anything which uses this binary) network.xml - kf5_network.xml org.kde.network.kioslavenotifier.xml - kf5_org.kde.network.kioslavenotifier.xml (I don't know what uses this but I assume something must and will need updated) old review for pre-split kde-runtime https://git.reviewboard.kde.org/r/117092/ Diffs (updated) - archive/tar.protocol 9442d4d bookmarks/bookmarks.protocol 68503d8 cgi/cgi.protocol 862758a doc/kioslave/bookmarks/CMakeLists.txt d90f510 doc/kioslave/bzip2/CMakeLists.txt 164ff50 doc/kioslave/cgi/CMakeLists.txt 4474a13 doc/kioslave/finger/CMakeLists.txt 54a06b0 doc/kioslave/fish/CMakeLists.txt a711911 doc/kioslave/floppy/CMakeLists.txt 601a7e8 doc/kioslave/gzip/CMakeLists.txt 15d9a61 doc/kioslave/info/CMakeLists.txt 3a4ace9 doc/kioslave/man/CMakeLists.txt 7375332 doc/kioslave/network/CMakeLists.txt 0921d20 doc/kioslave/nfs/CMakeLists.txt 5d98ace doc/kioslave/sftp/CMakeLists.txt fe08290 doc/kioslave/smb/CMakeLists.txt 906e945 doc/kioslave/tar/CMakeLists.txt a699590 doc/kioslave/thumbnail/CMakeLists.txt 555407d doc/kioslave/xz/CMakeLists.txt 731d519 filter/bzip.protocol eceae18 filter/bzip2.protocol 3db24ff filter/gzip.protocol b0fa2b3 filter/lzma.protocol cdaa888 filter/xz.protocol fc66e28 finger/finger.protocol dda641b fish/fish.protocol fd577c8 floppy/floppy.protocol cbd288a info/info.protocol c001580 kurifilter-plugins/ikws/CMakeLists.txt 51294b5 kurifilter-plugins/ikws/kuriikwsfilter.upd 0874ce2 man/man.protocol cd03f9f network/kded/CMakeLists.txt e851f73 network/mimetypes/CMakeLists.txt c20dc90 nfs/nfs.protocol 4781b3c sftp/sftp.protocol 6e49ed2 smb/smb.protocol e15395e thumbnail/thumbnail.protocol 216f428 trash/CMakeLists.txt 7c72cdc Diff: https://git.reviewboard.kde.org/r/117859/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Beta moved to Friday
KF5 beta has moved forward a few days to this Sunday. So I've updated http://techbase.kde.org/Schedules/Plasma/2014.6_Release_Schedule to move the beta forward to Friday 9th May. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117899: Use Breeze bridge mouse cursor theme by default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117899/ --- Review request for Plasma. Repository: plasma-workspace Description --- In startkde set the breeze bridge mouse cursor theme to be the default for new plasma next users. Diffs - startkde/startkde.cmake c4782ab Diff: https://git.reviewboard.kde.org/r/117899/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Fwd: Re: KDE Cursor Set
I'll post a review to rename the mouse cursors to breeze Jonathan - Forwarded message from Ken Vermette verme...@gmail.com - Date: Wed, 30 Apr 2014 09:35:41 -0400 Subject: Re: KDE Cursor Set From: Ken Vermette verme...@gmail.com To: Jonathan Riddell j...@jriddell.org Sorry I haven't been active on the forums! I probably would have known about this if I managed to check in sooner. Anyway, I was probably the most vocal one about not liking the name bridge anyway, so please do change the name! 100% ++ doubleplusgood, I quite like it. As soon as I start getting some decent free time again I'm going to start hopping back onto the forums and contributing, but you have my sincere apologies that I couldn't keep up and made you go out of your way. I'll at least visit the forums later tonight to read up on what's been happening. - Ken On Wed, Apr 30, 2014 at 9:21 AM, Jonathan Riddell j...@jriddell.org wrote: Hi, I expect you know your Bridge cursor set has been chosen as the default one for Plasma 2014.6. It's another great addition to KDE Software. Can we rename it to Breeze to match the rest of the artwork in KDE Plasma? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117899: Use Breeze bridge mouse cursor theme by default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117899/ --- (Updated April 30, 2014, 2:01 p.m.) Review request for Plasma. Changes --- update for rename to breeze see https://git.reviewboard.kde.org/r/117901/ Repository: plasma-workspace Description --- In startkde set the breeze bridge mouse cursor theme to be the default for new plasma next users. Diffs (updated) - startkde/startkde.cmake c4782ab Diff: https://git.reviewboard.kde.org/r/117899/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117899: Use Breeze bridge mouse cursor theme by default
On April 30, 2014, 1:30 p.m., Sebastian Kügler wrote: Yes, please. (Is the breeze repo already integrated into kdesrc-build?) just added to kdesrc-build - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117899/#review56987 --- On April 30, 2014, 2:01 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117899/ --- (Updated April 30, 2014, 2:01 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- In startkde set the breeze bridge mouse cursor theme to be the default for new plasma next users. Diffs - startkde/startkde.cmake c4782ab Diff: https://git.reviewboard.kde.org/r/117899/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117904: Set soversion to match Plasma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117904/ --- Review request for Plasma, Solid and Àlex Fiestas. Repository: powerdevil Description --- Set SOVERSION to 5 to match libraries elsewhere in Plasma Diffs - CMakeLists.txt 0dfc422 Diff: https://git.reviewboard.kde.org/r/117904/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117906: set soversion to 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117906/ --- Review request for Plasma. Repository: plasma-desktop Description --- as with other libraries in workspace bump soversion to 5 Diffs - kcms/kfontinst/lib/CMakeLists.txt d174596 Diff: https://git.reviewboard.kde.org/r/117906/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117899: Use Breeze mouse cursor theme by default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117899/ --- (Updated May 1, 2014, 1:32 p.m.) Review request for Plasma. Summary (updated) - Use Breeze mouse cursor theme by default Repository: plasma-workspace Description --- In startkde set the breeze bridge mouse cursor theme to be the default for new plasma next users. Diffs - startkde/startkde.cmake c4782ab Diff: https://git.reviewboard.kde.org/r/117899/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117899: Use Breeze mouse cursor theme by default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117899/ --- (Updated May 1, 2014, 1:32 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- In startkde set the breeze bridge mouse cursor theme to be the default for new plasma next users. Diffs - startkde/startkde.cmake c4782ab Diff: https://git.reviewboard.kde.org/r/117899/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117906: set soversion to 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117906/ --- (Updated May 1, 2014, 3:16 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description --- as with other libraries in workspace bump soversion to 5 Diffs - kcms/kfontinst/lib/CMakeLists.txt d174596 Diff: https://git.reviewboard.kde.org/r/117906/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117941: use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117941/ --- Review request for Plasma. Repository: plasma-desktop Description --- use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/ Diffs - kcms/locale/kcmlocale.cpp c430bcd048b962dc3eaf49a278ba8fffb5244bb0 Diff: https://git.reviewboard.kde.org/r/117941/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117941: use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117941/ --- (Updated May 2, 2014, 1:14 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-desktop Description --- use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/ Diffs - kcms/locale/kcmlocale.cpp c430bcd048b962dc3eaf49a278ba8fffb5244bb0 Diff: https://git.reviewboard.kde.org/r/117941/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117942: use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117942/ --- Review request for Plasma. Repository: plasma-desktop Description --- use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/ Diffs - kcms/locale/kcmlocale.h f3a691596128c438ce9db7f45b1712fc585ae042 kcms/locale/kcmlocale.cpp c430bcd048b962dc3eaf49a278ba8fffb5244bb0 Diff: https://git.reviewboard.kde.org/r/117942/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [plasma-devel] Plasma 5?
Plasma 5 certainly makes it a lot easier to name betas. It also means if the release date slips there's no need for a quick reversion. Frameworks want an extra beta so it may well slip. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: KDE Frameworks: There will be a beta 3
Currently we have.. Fri, 9th May: Beta Tue, 27th May: RC1 Thu, 29th May: Artwork freeze Tue, 10th June: Tagging Plasma 2014.6 Tue, 17th June: Plasma 2014.6 Final I propose.. Thursday June 5, Beta 2 tars, release on Monday 9th Thursday July 3, RC tars, release on Monday 7th Thursday July 10, Final tars, release on Monday 14th Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117767: do not use minor library version for soversion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117767/ --- (Updated May 8, 2014, 1:32 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Aleix Pol Gonzalez and John Tapsell. Repository: libksysguard Description --- set SOVERSION in CMakeLists.txt and use that for each library, minor version number is wrong to use Diffs - CMakeLists.txt 5aa86ab ksgrd/CMakeLists.txt 3daff17 lsofui/CMakeLists.txt d107611 processcore/CMakeLists.txt f2a84ae processui/CMakeLists.txt 599640f signalplotter/CMakeLists.txt 759aacf Diff: https://git.reviewboard.kde.org/r/117767/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117770: rename liboxygen libraries
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117770/ --- (Updated May 8, 2014, 3:43 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Martin Gräßlin. Repository: oxygen Description --- liboxygen libraries used for the oxygen widget style should be renamed as they are runtime items which need to coinstall with equivalents from kdelibs4 land. Diffs - kstyle/config/CMakeLists.txt 560c409 kwin-decoration/CMakeLists.txt ff99b25 kstyle/CMakeLists.txt 8c76de3 kwin-decoration/config/CMakeLists.txt c7e6d49 kwin-decoration/demo/CMakeLists.txt 60c3018 liboxygen/CMakeLists.txt 4419809 Diff: https://git.reviewboard.kde.org/r/117770/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117775: rename oxygen sound files for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117775/ --- (Updated May 8, 2014, 3:46 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: oxygen Description --- Oxygen sound files were part of kde-runtime so need to be co-installable with kdelibs4 world. Use Oxygen name to give them a different name and correct identify the sound theme. There are various .notifyrc files that use these files which I'll submit patches for should this one be accepted. Diffs - sounds/KDE-Im-Cant-Connect.ogg sounds/KDE-Im-Connection-Lost.ogg sounds/KDE-Im-Contact-In.ogg sounds/KDE-Im-Contact-Out.ogg sounds/KDE-Im-Error-On-Connection.ogg sounds/KDE-Im-Highlight-Msg.ogg sounds/KDE-Im-Internal-Error.ogg sounds/KDE-Im-Irc-Event.ogg sounds/KDE-Im-Low-Priority-Message.ogg sounds/KDE-Im-Message-In.ogg sounds/KDE-Im-Message-Out.ogg sounds/KDE-Im-Network-Problems.ogg sounds/KDE-Im-New-Mail.ogg sounds/KDE-Im-Nudge.ogg sounds/KDE-Im-Phone-Ring.ogg sounds/KDE-Im-Sms.ogg sounds/KDE-Im-User-Auth.ogg sounds/KDE-K3B-Finish-Error.ogg sounds/KDE-K3B-Finish-Success.ogg sounds/KDE-K3B-Insert-Medium.ogg sounds/KDE-Sys-App-Error-Critical.ogg sounds/KDE-Sys-App-Error-Serious-Very.ogg sounds/KDE-Sys-App-Error-Serious.ogg sounds/KDE-Sys-App-Error.ogg sounds/KDE-Sys-App-Message.ogg sounds/KDE-Sys-App-Negative.ogg sounds/KDE-Sys-App-Positive.ogg sounds/KDE-Sys-Error-Printing.ogg sounds/KDE-Sys-File-Open-Foes.ogg sounds/KDE-Sys-List-End.ogg sounds/KDE-Sys-List-Match-Multiple.ogg sounds/KDE-Sys-List-Match-No.ogg sounds/KDE-Sys-Log-In-Long.ogg sounds/KDE-Sys-Log-In-Short.ogg sounds/KDE-Sys-Log-In.ogg sounds/KDE-Sys-Log-Out.ogg sounds/KDE-Sys-Question.ogg sounds/KDE-Sys-Special.ogg sounds/KDE-Sys-Trash-Emptied.ogg sounds/KDE-Sys-Warning.ogg sounds/KDE-Window-All-Desktops-Not.ogg sounds/KDE-Window-All-Desktops.ogg sounds/KDE-Window-Close.ogg sounds/KDE-Window-Maximize.ogg sounds/KDE-Window-Minimize.ogg sounds/KDE-Window-Move-Stop.ogg sounds/KDE-Window-Move.ogg sounds/KDE-Window-Shade-Down.ogg sounds/KDE-Window-Shade-Up.ogg Diff: https://git.reviewboard.kde.org/r/117775/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117884: rename binaries for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117884/ --- (Updated May 8, 2014, 4:17 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: kde-cli-tools Description --- these cli tools are in kde-runtime in KDE 4 land so need to be renames so they are co-installable. Many are unused in the KDE codebase according to lxr but some are used and I'll submit renaming patches to them if this is accepted.. keditfiletype used by: frameworks/kio/src/widgets/kpropertiesdialog.cpp frameworks/kwidgetsaddons/src/kmimetypechooser.cpp applications/kde-baseapps/lib/konq/konq_operations.cpp workspace/plasma-desktop/containments/folder/plugin/internallibkonq/konq_operations.cpp workspace/plasma-desktop/kcms/componentchooser/componentchooserfilemanager.cpp kmimetypefinder: unused ktraderclient: used in kde/workspace/kio-extras/kurifilter-plugins/tests/kurifiltertest.cpp kioclient: used in applications/kde-baseapps/konqueror/client/kfmclient.cpp workspace/plasma-workspace/applets/devicenotifier/test-predicate-openinwindow.desktop workspace/plasma-workspace/ksmserver/startup.cpp workspace/plasma-workspace/drkonqi/data/mappings kdecp: unused kdemv: unused kde-open: unused ksvgtopng: unused I note keditfiletype is used in frameworks so I should also look into moving that into a framework. Diffs - keditfiletype/CMakeLists.txt 0adfde946b783cbee09661cfe445792eb1a54649 kioclient/CMakeLists.txt cca4f5c222a3266f7ec468fa138bd2cefa880902 kmimetypefinder/CMakeLists.txt 720ccb07bd7a0a6a567b3bf70caa00d532232663 kstart/CMakeLists.txt e7810d2788290b5f33447f90948dc020e1c8b1b9 ksvgtopng/CMakeLists.txt 82602887bb7370e591545b059418a68457c85c28 ktraderclient/CMakeLists.txt 028aac3ef9c5e293078df0796ee35577b0679afb Diff: https://git.reviewboard.kde.org/r/117884/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117859: rename kioslave files for co-installability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117859/ --- (Updated May 9, 2014, 7:07 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: kio-extras Description --- rename kioslave files for co-installability ktrash - ktrash5 (I'm not aware of anything which uses this binary) network.xml - kf5_network.xml org.kde.network.kioslavenotifier.xml - kf5_org.kde.network.kioslavenotifier.xml (I don't know what uses this but I assume something must and will need updated) old review for pre-split kde-runtime https://git.reviewboard.kde.org/r/117092/ Diffs - archive/tar.protocol 9442d4d bookmarks/bookmarks.protocol 68503d8 cgi/cgi.protocol 862758a doc/kioslave/bookmarks/CMakeLists.txt d90f510 doc/kioslave/bzip2/CMakeLists.txt 164ff50 doc/kioslave/cgi/CMakeLists.txt 4474a13 doc/kioslave/finger/CMakeLists.txt 54a06b0 doc/kioslave/fish/CMakeLists.txt a711911 doc/kioslave/floppy/CMakeLists.txt 601a7e8 doc/kioslave/gzip/CMakeLists.txt 15d9a61 doc/kioslave/info/CMakeLists.txt 3a4ace9 doc/kioslave/man/CMakeLists.txt 7375332 doc/kioslave/network/CMakeLists.txt 0921d20 doc/kioslave/nfs/CMakeLists.txt 5d98ace doc/kioslave/sftp/CMakeLists.txt fe08290 doc/kioslave/smb/CMakeLists.txt 906e945 doc/kioslave/tar/CMakeLists.txt a699590 doc/kioslave/thumbnail/CMakeLists.txt 555407d doc/kioslave/xz/CMakeLists.txt 731d519 filter/bzip.protocol eceae18 filter/bzip2.protocol 3db24ff filter/gzip.protocol b0fa2b3 filter/lzma.protocol cdaa888 filter/xz.protocol fc66e28 finger/finger.protocol dda641b fish/fish.protocol fd577c8 floppy/floppy.protocol cbd288a info/info.protocol c001580 kurifilter-plugins/ikws/CMakeLists.txt 51294b5 kurifilter-plugins/ikws/kuriikwsfilter.upd 0874ce2 man/man.protocol cd03f9f network/kded/CMakeLists.txt e851f73 network/mimetypes/CMakeLists.txt c20dc90 nfs/nfs.protocol 4781b3c sftp/sftp.protocol 6e49ed2 smb/smb.protocol e15395e thumbnail/thumbnail.protocol 216f428 trash/CMakeLists.txt 7c72cdc Diff: https://git.reviewboard.kde.org/r/117859/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117874: don't install kconf_update files from KDE4 land, KF5 apps start with a fresh install
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117874/ --- (Updated May 9, 2014, 7:29 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- don't install kconf_update files from KDE4 land, KF5 apps start with a fresh install Diffs - drkonqi/CMakeLists.txt 4794621 drkonqi/drkonqi-rename-config-section.upd 413908f kglobalaccel/CMakeLists.txt 1ddee63 kglobalaccel/kconf/kdedglobalaccel_kde42.upd 260434a klipper/CMakeLists.txt f4bd831 klipper/klipper-kconfigxt.upd 586948e ksmserver/CMakeLists.txt 65af7d8 ksmserver/ksmserver_shortcuts.upd 760f6a9 ksmserver/screenlocker/CMakeLists.txt 700cdff ksmserver/screenlocker/data/CMakeLists.txt 624eaf3 ksmserver/screenlocker/data/force_krunner_lock_shortcut_unreg.cpp fe1cd8a ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd cbc4d52 Diff: https://git.reviewboard.kde.org/r/117874/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117861: remove obsolete kconfig_update file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117861/ --- (Updated May 9, 2014, 7:31 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: kio-extras Description --- update to https://git.reviewboard.kde.org/r/117093 for split repositories remove kconf_update file which handles settings from kdelibs4 land. In kf5 land people will start with clean settings. Diffs - kurifilter-plugins/ikws/CMakeLists.txt 51294b5 kurifilter-plugins/ikws/kuriikwsfilter.upd 0874ce2 Diff: https://git.reviewboard.kde.org/r/117861/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated May 9, 2014, 7:35 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 2dec197 Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117942: use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117942/ --- (Updated May 9, 2014, 7:44 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description --- use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/ Diffs - kcms/locale/kcmlocale.h f3a691596128c438ce9db7f45b1712fc585ae042 kcms/locale/kcmlocale.cpp c430bcd048b962dc3eaf49a278ba8fffb5244bb0 Diff: https://git.reviewboard.kde.org/r/117942/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117942: use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117942/ --- (Updated May 9, 2014, 7:44 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/ Diffs - kcms/locale/kcmlocale.h f3a691596128c438ce9db7f45b1712fc585ae042 kcms/locale/kcmlocale.cpp c430bcd048b962dc3eaf49a278ba8fffb5244bb0 Diff: https://git.reviewboard.kde.org/r/117942/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117904: Set soversion to match Plasma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117904/ --- (Updated May 9, 2014, 8:01 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Solid and Àlex Fiestas. Repository: powerdevil Description --- Set SOVERSION to 5 to match libraries elsewhere in Plasma Diffs - CMakeLists.txt 0dfc422 Diff: https://git.reviewboard.kde.org/r/117904/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma Next Beta 1
Tars are available for Plasma Next Beta 1 Soon to be landing on depot.kde.org unstable/plasma/4.96.0 Temporary site: http://starsky.19inch.net/~jr/tmp/plasma-4.96.0/ http://starsky.19inch.net/~jr/tmp/plasma-4.96.0/SHA256Sum This release works with Qt 5.2 although it is probably better with Qt 5.3 RC. It'll need KDE Frameworks 5 Beta 2 which was quietly released yesterday. It should not overlap with kde-runtime or kdelibs from kdelibs4 land but much of it will overlap with kde-workspace from kdelibs4 land, it's new versions. The translations will also overlap with translations from kde sc 4.13. One suggested solution it to install 4.13 translations into their own directory and patch kdelibs4 to read from that directory. I may well have made mistakes, this release is still quite undefined. If there are tars I should/should not have included, if there are branches I should have used, if there are version numbers I should have set differently either in the tars or internally let me know. The Plasma team is still discussing what it still be called so for now I'll call it Plasma Next. I hope to announce this on Tuesday but how knows. Good luck :) Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Next Beta 1
On Sat, May 10, 2014 at 08:24:30PM +0200, šumski wrote: Yeah. Thus also kfilemetadata (so this baloo tar is unbuildable - not just cause master branch is packaged instead of frameworks one ;-) And since the WIP kde-baseapps is here (somehow this would fit more with Applications releases than Plasma?), IMHO, one could possibly include Kate, Konsole and plasma-nm (with required libs) - though libs target to be part of KF5? kfilemetadata added 924a6450f7d37132d8cb7afc025cd58b4c4aa562e1ddee82976f14f60df861c6 milou added 33fec64b34a9f7bebffd422e3f221cf6461fc49355f5081cf04b5612d752325d baloo remade from frameworks branch daa5fcb94d18f54e082d09dd32131f161dcd7e3f99e0b54eaa7f9a280fb0940a kde-baseapps removed sysadmin ticket filed to update, files also at.. http://starsky.19inch.net/~jr/tmp/plasma-4.96.0/ Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
plasma packages in kde-workspace
Some parts of what is now being released as Plasma aren't in kde-workspace on projects.kde.org. I'd like to move the following to kde-workspace, let me know if that's a problem baloo milou powerdevil kfilemetadata Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118257: explicit dependency on kpty as needed by kdesu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118257/ --- Review request for Plasma. Repository: kde-cli-tools Description --- explicit dependency on kpty as needed by kdesu Diffs - CMakeLists.txt fa32ecc12e9f17c1925c79729bd3aa346f75fa04 Diff: https://git.reviewboard.kde.org/r/118257/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118257: explicit dependency on kpty as needed by kdesu
On May 22, 2014, 11:40 a.m., Michael Palimaka wrote: Where is the kpty usage located? When compiling without kpty installed: In file included from /usr/include/KF5/KDESu/kdesu/stubprocess.h:13:0, from /usr/include/KF5/KDESu/kdesu/suprocess.h:15, from /usr/include/KF5/KDESu/kdesu/su.h:2, from ../../kdesu/sudlg.h:13, from ../../kdesu/sudlg.cpp:7: /usr/include/KF5/KDESu/kdesu/ptyprocess.h:22:18: fatal error: kpty.h: No such file or directory #include kpty.h ^ compilation terminated. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118257/#review58292 --- On May 22, 2014, 11:23 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118257/ --- (Updated May 22, 2014, 11:23 a.m.) Review request for Plasma. Repository: kde-cli-tools Description --- explicit dependency on kpty as needed by kdesu Diffs - CMakeLists.txt fa32ecc12e9f17c1925c79729bd3aa346f75fa04 Diff: https://git.reviewboard.kde.org/r/118257/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma 5 Beta 2 tars
Tars are up for Plasma 5 Beta 2, please try them out and let me know of problems. I'd especially like to know if translations successfully install as I noticed some not doing so last time. Appearing here soon http://download.kde.org/unstable/plasma/4.97.0/src/ Temporarily here in the mean time http://starsky.19inch.net/~jr/tmp/plasma-4.97.0/ md5sums http://starsky.19inch.net/~jr/tmp/plasma-4.97.0/4.97.0-release-data I've renamed baloo and milou to have -kf5 in the tar name as you may well want the kdelibs4 versions around. Also kfilemetadata as kfilemetadata5. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5 Beta 2 tars
On Fri, Jun 06, 2014 at 11:11:05AM +0200, Mario Fux wrote: Why appending some packages with -kf5 and some with 5? Seems quite confusing. And baloo and milou are not really (or not yet for baloo) KDE Frameworks. See if it all they should be appended with a 5 and the term kf5 should be kept for KDE Frameworks. Just the convention I've been using, it may well not make sense. kfilemetadata source becomes kfilemetadata5 because it's a library and 5 is the new soversion. baloo is more than a library so I added kf5 because it's the version of baloo which uses KF5. Same for milou. Thinking about it now I think milou isn't expected to be co-installable any more than Plasma Desktop so I don't think it needs a rename. Baloo isn't co-installable except the libraries so there's no reason it should be treated differently than kfilemetadata. I'll make new tars. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5 Beta 2 tars
New tars up at http://starsky.19inch.net/~jr/tmp/plasma-4.97.0/ changes: plasma-workspace has changed API commit reverted milou-kf5 tar now milou baloo-kf5 tar now baloo5 oxygen-fonts now using correct branch plasma-workspace;master;6903e1e94f4b5a0ab15a19bfe77d6b362b976280;plasma-workspace-4.97.0.tar.xz;b6e433d71eb4ac3453d1f6df42c7e275 milou;frameworks;5599a7dabb28f048af700f0202096c281ff3098d;milou-4.97.0.tar.xz;173f4ece0cf4d5832a4c7f74472baae8 baloo;frameworks;5b454c0f5662e9e5c1b669c45367bbe73c546aac;baloo5-4.97.0.tar.xz;529b4ecdcaea2501aeffceda1759d194 oxygen-fonts;release-0.4;556f299a8c562e4beaf72b60bd8e55e0647c8616;oxygen-fonts-0.3.97.tar.xz;1ecdc2af7be15425f76fa9b3308b85b5 Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma 5 branding
A decision needs to be made on Plasma branding because we are now a month away from release. I plan to use Plasma 5 for the generation of Plasma using KDE Frameworks 5. For technical numbers I'm using 4.97.0 for this beta and plan to release 5.0.0 in July. Following releases will be 5.0.90 going for a release of 5.1. That leaves the marketing release names. My best idea is Summer 2014 etc so this release will be the Plasma 5 Summer 2014 release. This may annoy our antipodean and south american users however. Suggestions welcome but we do need to make a decision toot sweet. And the term Plasma release should be avoided, it sounds squelchy. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/#review59409 --- I think you'll have to argue this out with vishesh, on discussing it with him he was happy for the libraries to be co-installable but didn't see a need for the development files to be co-installable. Same for Baloo, only libraries with new sonames, otherwise it's a new version of everything. - Jonathan Riddell On June 4, 2014, 6:28 a.m., Matthew Dawson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/ --- (Updated June 4, 2014, 6:28 a.m.) Review request for Plasma, Jonathan Riddell and Vishesh Handa. Bugs: https://bugs.gentoo.org/show_bug.cgi?id=512334 http://bugs.kde.org/show_bug.cgi?id=https://bugs.gentoo.org/show_bug.cgi?id=512334 Repository: kfilemetadata Description --- I've posted this RR as an RFC about the general structure of this idea. I just choose KFileMetaData as that is what my package manager conflicted over first. Ideally I want to push this change to any needed repositories for Plasma Next. As far as I understand the ability for Plasma Next and KDE4 application to be co-installed, all libraries should be co-installable except as listed on this page: http://community.kde.org/Plasma/Coinstallability . However, on source based distributions, such as Gentoo, to have both the KDE4 and KF5 versions simultaneously installed requires that the development files are also co-installable. As mentioned on this Gentoo bug[1], the header files are trivially dealt with, and the library simlink will probably be a downstream specific solution (as CMake doesn't require it for compiling). However, the CMake configuration files are another matter. This is take one of trying to fix this issue. If a different naming scheme, or if some different CMake trickery is desired I'll see about changing things to that, otherwise I think this is the simple and easy solution. I also volunteer to go through all the dependent packages and have patches ready (as best as I am able), as well as fix up any build failures that occur due to this change. Only find_package calls need modification, targets are left alone. [1] https://bugs.gentoo.org/show_bug.cgi?id=512334 Diffs - src/CMakeLists.txt 82dbd5c32050081642e9fff958d229f55893d40c KFileMetaDataConfig.cmake.in b4d1c93b7a23ffcbb03a89e9d4a11559d7e22037 CMakeLists.txt aa2b0864ca8b2126ffcabf5cbad28b06dbb682b2 Diff: https://git.reviewboard.kde.org/r/118512/diff/ Testing --- Tested compiling Baloo against a system install with this patch applied. Baloo sucessfully linked against the KF5 version and all Baloo tests ran to completion. All KFileMetaData unit tests passed too ;) Thanks, Matthew Dawson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5 branding
On Fri, Jun 06, 2014 at 12:33:43PM +0200, Sebastian Kügler wrote: That leaves the marketing release names. My best idea is Summer 2014 etc so this release will be the Plasma 5 Summer 2014 release. This may annoy our antipodean and south american users however. Suggestions welcome but we do need to make a decision toot sweet. The marketing name is Plasma. We want to avoid using the version number as much as possible, but if need be, don't introduce something new, but use the technically correct version number -- anything else will just cause major confusion. So what's a good headline for this release will be Plasma 5 5.0 ? Or Plasma 5 first release? And the next version Plasma 5.1? Or Plasma 5 second release? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5 branding
On Fri, Jun 06, 2014 at 01:18:09PM +0200, Martin Gräßlin wrote: why would the headline need a version number? We need some way to distinguish this release from the following release for users. We need something to put in the headline. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5 Beta 2 tars
New tars to fix cmake issue 5676822dd981f2b8035868cd6f6b90162ede52ac300d2cfbf3810fb7957e7851 khotkeys-4.97.0.tar.xz 6e75432104f34b9538a99461fa29bc10d0e6f17bf5fa835ac2d02c5718836f29 khelpcenter-4.97.0.tar.xz 2c6298b94f5a98982cb43779c3d1843b88b561050b60324a83975909cef8f8c5 kinfocenter-4.97.0.tar.xz a150e5279301cb787190e20d9256d4739846267e46a847108406345f2f405a9a kio-extras-4.97.0.tar.xz Up at http://starsky.19inch.net/~jr/tmp/plasma-4.97.0/ and coming soon to depot. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
