D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

[Radek Hušek]

Pitel added a comment.


  @martinkostolny I will try to give it some testing this week.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11071

To: Pitel, #plasma, martinkostolny
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D7537: KDE logout screen - change black icons & texts to white/greyish

[Radek Hušek]

Pitel added a comment.


  I finally found what was wrong here: the background should not be black when 
button background color is light but the calculation introduced by D5036 
 is wrong. My attempt to fix it is D11262 
.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7537

To: pekkah, #plasma_workspaces, #plasma, #breeze, mart
Cc: davidedmundson, Pitel, mvourlakos, ngraham, mart, bshah, #breeze, pekkah, 
#plasma_workspaces, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D7537: KDE logout screen - change black icons & texts to white/greyish

[Radek Hušek]

Pitel added a comment.


  @mvourlakos I did some more testing and I am really confused. The important 
color seems to be button text color in Plasma theme setting. Results:
  
  With `colorGroup: PlasmaCore.Theme.ComplementaryColorGroup` (which is 
currently hardcoded):
  
  - with white button text color: all text is white -- OK
  - with black button text color: all text is black -- not OK for text outside 
of buttons
  
  With `colorGroup: PlasmaCore.Theme.NormalColorGroup` (or just deleting 
`colorGroup` property):
  
  - with white button text color: all text is white -- OK
  - with black button text color: text on buttons is black, other text is white 
-- OK
  
  I have no idea why button text color affects color of text outside of buttons 
with Complementary color group but does not affect it with Normal.
  
  (By buttons I mean OK and Cancel who draw their backgrounds.)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7537

To: pekkah, #plasma_workspaces, #plasma, #breeze, mart
Cc: Pitel, mvourlakos, ngraham, mart, bshah, #breeze, pekkah, 
#plasma_workspaces, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D7537: KDE logout screen - change black icons & texts to white/greyish

[Radek Hušek]

Pitel added a comment.


  I guess I am not that confused anymore -- with normal color group the color 
of text (outside of buttons) is determined by text color theme setting but with 
complementary group by button text color.
  
  I think correct solution would be to construct `ColorScope` with `textColor` 
set to default text color if it is not too dark and white otherwise (the 
background color is handled in similar way). The problem is I do not see any 
way to construct `ColorScope` with custom colors -- it always takes colors from 
some color group of current theme.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7537

To: pekkah, #plasma_workspaces, #plasma, #breeze, mart
Cc: Pitel, mvourlakos, ngraham, mart, bshah, #breeze, pekkah, 
#plasma_workspaces, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11262: KDE logout screen background color fix

[Radek Hušek]

Pitel added a comment.


  With dark button background as it used to F5750710: 
Screenshot_20180312_151959.png 
  but if you choose some crazy combination (like black text on green 
background) it will also work (without this patch the background here would be 
still black)F5750713: Screenshot_20180312_152132.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11262: KDE logout screen background color fix

[Radek Hušek]

Pitel added a comment.


  In D11262#224113 , @ngraham wrote:
  
  > Would you be interested in producing similar patches for the Lock and Login 
screens, which suffer from the same issue?
  >
  > - Login screen: https://bugs.kde.org/show_bug.cgi?id=388622
  > - Lock screen: https://bugs.kde.org/show_bug.cgi?id=369676
  
  
  Those two seem to be a bit more complicated because the logout screen covers 
the desktop by some color overlay so we know how the background looks. But with 
login & lock screen there is only picture on the background and no color 
overlay.
  
  Adding color overlays on them seems unnatural and ugly. Other thing I tried 
is to add Glow effect. It solves readability problem but I do not like how it 
looks and documentation says it also needs OpenGL.
  
  Using background dependent color would require to calculate an "average 
color" of an image in qml and I do not see how to do that. So the only solution 
I see right know is to add config options to select text color for lock & login 
screens.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11262: KDE logout screen background color fix

[Radek Hušek]

Pitel created this revision.
Pitel added reviewers: mart, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  The patch D5036  did calculate wrong 
whether the background color is light or not which resulted in always black 
background. The problem was that color reported by plasma is in range 0.0 -- 
1.0 not 0 -- 255. Now the background is black only when button background color 
is dark and otherwise it respects button background color.
  
  FIXES 382264

REPOSITORY
  R120 Plasma Workspace

BRANCH
  logoutColorFix

REVISION DETAIL
  https://phabricator.kde.org/D11262

AFFECTED FILES
  lookandfeel/contents/logout/Logout.qml

To: Pitel, mart, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  Make task mananger applet use only space it needs and not eat more
  
  - it looks better with global menu in same the panel.
  
  Maybe convert this to configuration option?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

AFFECTED FILES
  applets/taskmanager/package/contents/ui/main.qml

To: Pitel
Cc: plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel added a comment.


  I am aware of `getFixedItemId`, only forgot to mention it in summary. Right 
now it is not included mostly because it is another hack (but fixing stupid 
behavior of someone else so unavoidable) and I do not use DropBox, but if this 
gets any closer to landing, we should reintroduce it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel
Cc: wsdfhjxc, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11262: KDE logout screen background color fix

[Radek Hušek]

Pitel added a comment.


  I see that relative luminance formula is more correct but I would like to 
point out that we do not need here to calculate precise luminance. The point of 
the `?:` statement is to collapse colors close to back to real black because 
gray overlay with 50 % opacity does not look good. So the current formula looks 
good enough for me and I would even think about moving the threshold down a bit 
to 0.4 or 0.3. (Generally not collapsing to black is the save way, it may not 
look so good but the text will be still easy to read.)
  
  For reference a screenshot with gray background (similar to default breeze) 
without collapsing it to black: F5752690: Screenshot_20180313_175108.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel added a comment.


  Ping. The current version adds a configuration option `fillWidth` (enabled by 
default) which allows the applet to grow beyond its preferred size. I tested it 
in usual setup and with `fillWidth` enabled the behavior is unchanged.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

To: Pitel, ngraham, mart
Cc: mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel added a comment.


  In D11292#225006 , @davidedmundson 
wrote:
  
  > FWIW, the crash you're referring to is also fixed with an up-to-date (not 
released yet) Qt.
  
  
  If you are referring to https://codereview.qt-project.org/#/c/50/ I tried 
patching my Qt with it and it prevents the crash but after closing settings the 
systray starts to misbehave instead. Qml reports a lot of `TypeError`'s in 
`AbstractItem.qml` in assignment:
  
onContainsMouseChanged: {
if (hidden && containsMouse) {
root.hiddenLayout.hoveredItem = abstractItem
}
}
  
  And plasmoids in systray stop responding to mouse clicks or expand inside of 
systray (like if some objects got reparented wrong?).
  
  But that might be result of me cherry-picking one patch on top of 5.9.4 qt...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel, #plasma, #vdg
Cc: davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  My try at ordered system try heavily inspired by D11233 
.
  
  Features (and problems):
  
  - the main intention was to keep code as simple as possible
  - items can be reordered by drag & drop and removed from config by dragging 
into trash bin
  - item list is by design loaded only at opening settings dialog (doing 
on-the-fly updates seems complicated for very little gain)
  - new items are added at right end of systray and remeber their position (so 
the first start the order will be random but on subsequent starts the order 
will remain the same)
  - all this is backed by only one new config option `itemOrder` of type 
`StringList`
  - items currently not existent are displayed in italics (and without icon 
because there is nowhere to get it)
  - now also all status notifier items are always in italics because I removed 
using `statusNotifierModel` from setting which solves crash after closing 
setting (and ugly > crash)
  - contains an ugly hack to workaround `ComboBox`'es going crazy when 
`TableView` model is changed (I have no clue what causes this, only than 
`currentItem` binding is not to blame)
  - the drag & drop support was adapted from R884 
 (most 
notably `OrderItem.qml` comes from there and was only lightly modified
  
  Any c

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray

REVISION DETAIL
  https://phabricator.kde.org/D11292

AFFECTED FILES
  applets/systemtray/package/contents/config/main.xml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/OrderableItem.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11233: Ordered system tray

[Radek Hušek]

Pitel added a comment.


  I really like the idea of being able to reorder the systray as I wish. I 
could not resist and took my stab on the issue (with drag) D11292 
.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11233

To: wsdfhjxc, #plasma_workspaces, #plasma, #vdg
Cc: mart, broulik, ngraham, anthonyfieroni, Pitel, alexeymin, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel updated this revision to Diff 29457.
Pitel added a comment.


  - modified `onConfigurationChanged` so it triggers updates of properties 
depending on `cfg_shownItems` and `cfg_hiddenItems`
  - make trash bin not draggable
  - removed `ComboBox` hack (which was not working anyway) and added an overlay 
label to combobox showing `S` for items in `cfg_shownItems` and `H` for items 
in `cfg_hiddenItems` (this is meant as debugging tool only) -- when dragging 
the visibility values in comboboxes go wrong but those letter remain correct 
which leads me to conclusion that the problem is `ComboBox` component 
(@wsdfhjxc can you verify this behavior?)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11292?vs=29421=29457

BRANCH
  stableSystray

REVISION DETAIL
  https://phabricator.kde.org/D11292

AFFECTED FILES
  applets/systemtray/package/contents/config/main.xml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/OrderableItem.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel, #plasma, #vdg
Cc: zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel added a comment.


  Ahh sorry I misunderstood you. Moving this option to containment level seems 
reasonable although I'm not sure for how many other applets it might be useful 
-- except taskbar and Active Windows Control (the global menu applet in my 
screen shot and it already has this option) all applets I use are fixed width.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

To: Pitel, ngraham, mart
Cc: hein, mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel added a comment.


  I understand you do not like adding options that you do not like adding 
options adjust think which should be configured on another level. But to be 
able to configure filling empty space at level of panel applets must not claim 
they need more space than they really do (and now taskmanager is doing exactly 
that). So possible solutions I see are:
  
  - Always limit taskmanager to needed space only (i.e. set `maximumWidth: 
preferredWidth`): The best solution from technical point of view, lets you 
config filling empty space by adding expanding spacers into panel **but** it 
breaks existing setups which is highly undesirable as I understood from 
previous comments.
  - Add config option as proposed by this patch: It enables the desired 
behavior without breaking existing setups, but adds a bit non-systematic config 
option.
  - Do nothing: Taskmanager will keep eating all space and and some reasonable 
setups will be impossible to achieve.  F5735027: Screenshot_20180301_175311.png 

  
  I believe the last option is the worst by far.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

To: Pitel, ngraham, mart
Cc: hein, mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel added a comment.


  In D11352#227065 , @wsdfhjxc wrote:
  
  > Doesn't seem to work for me. Only Notifications item is visible by default 
while there are multiple items set to be shown in the configuration. Also, 
changing the visibility state doesn't make any difference and the items are 
neither in panel nor in hidden panel, they just disappear. Only after going 
through configuration and manually switching every item to hidden and then to 
shown makes most of them visible.
  
  
  That seems like you are getting some javascript error in 
`updateItemVisibility`. Can look at what plasma shell is reporting (or paste it 
here)?
  
  > As for the item order, those categories are rather broad and sorting the 
items by their ids or texts within them will always produce odd results. Given 
there is a limited pool of known embedded items, maybe it would be better to 
predefine ordering values for some of them (battery=0, volume=1, networks=2, 
..., kdeconnect=5, devicenotifier=6, printers=7, etc.) to make the actual 
groups more sensible for humans?
  
  I do not like the idea of large per applet order list because it will always 
be incomplete and give ugly results if user chooses to replace e.g. usual 
battery applet with some custom one. If we conclude that sort based on 
categories + text is no sufficient I would strongly prefer using D11292 
 possibly with a larger default config 
rather hardcoding half random long list into `main.qml`. (Long list in default 
config is fine by me because user can modify that to their wishes.)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel
Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D7537: KDE logout screen - change black icons & texts to white/greyish

[Radek Hušek]

Pitel added a comment.


  I have the same problem in 5.12.2 release. I think the root of it is assuming 
that foreground in `PlasmaCore.Theme.ComplementaryColorGroup` is white(ish) and 
background is dark (this is true only if normal color scheme uses dark text on 
light background, which is default) and forcing that background is really dark 
(since D5036 ). My personal hack is just to 
replace `ComplementaryColorGroup` with `NormalColorGroup` (which obviously 
breaks default setup). A bit less of a hack would be choosing either 
`NormalColorGroup` or `ComplementaryColorGroup` depending on which one has 
darker background.
  
  The same problem also hits lock screen and user switcher.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7537

To: pekkah, #plasma_workspaces, #plasma, #breeze, mart
Cc: Pitel, mvourlakos, ngraham, mart, bshah, #breeze, pekkah, 
#plasma_workspaces, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Radek Hušek]

Pitel added a comment.


  +1 for picture instead of blue. With the current UI I would really appreciate 
option to choose text color independently on plasma color scheme (and such 
option would solve any static picture). Other possibility I was thinking about 
was 50 % opaque (default black) rectangle (with rounded corners) around control 
elements (i.e. like logout screen but only around controls not whole screen) 
but I have not found the way to position it where I want it to be...

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: Pitel, progwolff, abetts, hein, mart, graesslin, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D10837: bad textarea width for rename file if filename too short

[Radek Hušek]

Pitel added a comment.


  @painlessroaster is not me. What gave you impression he is?

REVISION DETAIL
  https://phabricator.kde.org/D10837

To: painlessroaster, #plasma, hein
Cc: Pitel, cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11072: [Active Window Control] Show window title when app name is missing

[Radek Hušek]

Pitel added a comment.


  I do not have write access.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11072

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  @mart dislikes idea of manually ordering the systray (D11233 
, D11292 
) but prefers auto
  ordering instead. To make my opinion I hacked up this and started testing on 
myself.
  Current version breaks if two items have the same category and text (I guess 
this
  should not happen but...).
  
  Note that category order is more or less randomly chosen (I do believe 
someone else
  has an opinion what the correct order is).
  
  This is mutually exclusive with D11292 .

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel
Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel added a comment.


  To compare with auto ordering (as @mart would like) see D11352 
.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel, #plasma, #vdg
Cc: mart, zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

[Radek Hušek]

Pitel added a comment.


  The patch definitely can wait until you finish the rework. A few thoughts 
that crossed my mind when reading proposed changes:
  
  - I really like the standalone basic items placed by drag and drop.
  - Is floating really floating or just another layer of occupying? E.g. thick 
panel and on bottom appmenu (on left) and buttons (on right) (floating because 
they are over window label -- or this option going away?): would the appmenu 
elide [1] or be drawn over the buttons? (Note: I'm not saying this should be a 
supported use-case, just playing with possible setups in my mind and the 
floating is really floating would be much easier to implement.)
  - To support my use-case #2 all items should have
- show on: mouse out | mouse in | always (and possibly never show unless it 
is covered by other options, show on mouse out not available for buttons and 
appmenu)
- checkbox to restrict mouse area used by "show on" option only to rect 
occupied by given item (for the in-parenthesis part of use-case #2)
  - Some predefined presents are a great idea -- do you intent to support 
saving current setup as a present?
  - All around the rework looks like a big improvement.
  
  The use-cases I am most interested in are:
  
  - One Liner with buttons on right
  - The previous one but with appmenu shown only on mouse-in and window text 
only on mouse-out (and preferably the mouse events should be restricted to area 
between icon and buttons -- i.e. if i click buttons window text is shown). This 
is better than One Liner setups for small screens.
  
  [1] I think this is an important feature, I tried implementing it in D11073 
. I must say I am surprised that there is 
no ElidingGridLayout or something -- the patch tries to emulate it, but without 
touching internal positioning code of the layout it will always be a hack... 
(Also why is the backend plugin private?)

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11071

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11065: [Active Window Control] Slightly fix vertical alignment of window name

[Radek Hušek]

Pitel updated this revision to Diff 28886.
Pitel added a comment.


  Moving appmenu instead of window title.

REPOSITORY
  R884 Active Window Control Applet for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11065?vs=28738=28886

BRANCH
  realign

REVISION DETAIL
  https://phabricator.kde.org/D11065

AFFECTED FILES
  package/contents/ui/AppMenu.qml

To: Pitel, #plasma, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11072: [Active Window Control] Show window title when app name is missing

[Radek Hušek]

Pitel added a comment.


  Do I need to do anything to make it land?

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11072

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11410: [RFC] Add option to make applet fixed width

[Radek Hušek]

Pitel updated this revision to Diff 30728.
Pitel added a comment.


  - Remove QtQuick.Controls import (was needed only by Checkbox)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11410?vs=30555=30728

BRANCH
  fixedSizeOverride

REVISION DETAIL
  https://phabricator.kde.org/D11410

AFFECTED FILES
  containments/panel/contents/config/main.xml
  containments/panel/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/main.qml

To: Pitel, #plasma
Cc: mart, hein, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11262: KDE logout screen background color fix

[Radek Hušek]

Pitel added a comment.


  I finally got to do some testing and it is not looking good for luminance 
formula `0.2126*r + 0.7152*g + 0.0722*b`.
  
  Screenshot with background color `#5500FF` (blueish, button background on 
picture), you can see that black text is readable on it, but it has luminance 
only 0.14 so in overlay it is replaced by black.
  F5769603: Screenshot_20180327_174715.png 

  
  So I would rather stay conservative, and used formula `max(r, g, b)`. I am 
still not sure whether the threshold should be `0.5` or a bit lower...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ragreen, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11262: KDE logout screen background color fix

[Radek Hušek]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:af2a74341d5f: KDE logout screen background color fix 
(authored by Pitel).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11262?vs=29324=30937

REVISION DETAIL
  https://phabricator.kde.org/D11262

AFFECTED FILES
  lookandfeel/contents/logout/Logout.qml

To: Pitel, mart, #plasma
Cc: fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ragreen, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11262: KDE logout screen background color fix

[Radek Hušek]

Pitel added a comment.


  It is meant as one. I am still kinda new here, so I am not exactly sure how 
to that (without confusing Phabricator).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: fvogt, cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, 
ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11262: KDE logout screen background color fix

[Radek Hušek]

Pitel added a comment.


  I guess I should have renamed it from `isLightColor` to something like 
`isNotAlmostBlack`... The point was to replace almost black colors with real 
black because it looks better with opacity. IMHO `(0,0,128)`, which is deep 
blue, is far enough from black to not mess with it because font colors readable 
on deep blue background might not be readable on black one.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, 
ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11262: KDE logout screen background color fix

[Radek Hušek]

Pitel added a comment.


  It also should be in `Plasma/5.12` now.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: ragreen, fvogt, cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D11262: KDE logout screen background color fix

[Radek Hušek]

Pitel added a comment.


  In D11262#237099 , @ragreen wrote:
  
  > > I am not sure what artifacts is he referring to (but I am usually blind 
to this kind of issues)...
  >
  > I'm not.
  
  
  I did not mean that I want to ignore them, I just need them pointed out for 
me to start seeing them.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: ragreen, fvogt, cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D11262: KDE logout screen background color fix

[Radek Hušek]

Pitel added a comment.


  @ragreen I am sorry to disappoint but this patch does not remove the (usually 
black) half-opaque overlay the G+ post refers to. It only changes its color to 
button background color in the case that button background color is too far 
from black to make sure the text is readable. I guess the readability of text 
was the reason to introduce the overlay in the first place because only 
blurring the background (like 5.8 seems to do) is not enough in general.
  
  I am not sure what artifacts is he referring to (but I am usually blind to 
this kind of issues)...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: ragreen, fvogt, cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel updated this revision to Diff 30963.
Pitel added a comment.


Convert `changeVolume` helper into a Job... Right now it does not check 
wheter the DBus call is successful - I tried to wire it in but ended with 
segfault. I will investigate it further. Except that I hope it is ok.

(I also started thinking how to change the job system into something easier 
to work with. Were there any attempts in this direction?)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11021?vs=28729=30963

BRANCH
  mediacontroller

REVISION DETAIL
  https://phabricator.kde.org/D11021

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml
  dataengines/mpris2/mpris2.operations
  dataengines/mpris2/multiplexedservice.cpp
  dataengines/mpris2/playeractionjob.cpp
  dataengines/mpris2/playercontrol.cpp
  dataengines/mpris2/playercontrol.h

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11065: [Active Window Control] Slightly fix vertical alignment of window name

[Radek Hušek]

This revision was automatically updated to reflect the committed changes.
Closed by commit R884:1119c47f1756: [Active Window Control] Slightly fix 
vertical alignment of window name (authored by Pitel).

REPOSITORY
  R884 Active Window Control Applet for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11065?vs=28886=30832

REVISION DETAIL
  https://phabricator.kde.org/D11065

AFFECTED FILES
  package/contents/ui/AppMenu.qml

To: Pitel, #plasma, martinkostolny
Cc: abetts, broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11072: [Active Window Control] Show window title when app name is missing

[Radek Hušek]

This revision was automatically updated to reflect the committed changes.
Closed by commit R884:f48d5afac734: Show window title when app name is missing 
(authored by Pitel).

REPOSITORY
  R884 Active Window Control Applet for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11072?vs=28763=30833

REVISION DETAIL
  https://phabricator.kde.org/D11072

AFFECTED FILES
  package/contents/ui/main.qml

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel added inline comments.

INLINE COMMENTS

> Pitel wrote in AbstractItem.qml:80
> Probably not, I have not observed any problems even without this rule, I just 
> wanted to be safe. I see that I can use `applet.id` or even 
> `applet.pluginName` as there should be at most one instace of given plasmoid 
> in systray but I am not so sure about statusnotifiers, spec says that `Id` 
> should be unique for given app, but what if user launches two instances of 
> the app? Or am I overthinking this?

I tested multiple instances of vlc and all their properties exported by 
`statusnotifier` engine have the same values so `creationId` is required after 
all.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel, #vdg, #plasma, mart
Cc: ngraham, wsdfhjxc, mart, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel updated this revision to Diff 30859.
Pitel added a comment.


  - Remove debug print

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11352?vs=30111=30859

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel, #vdg, #plasma, mart
Cc: ngraham, wsdfhjxc, mart, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

[Radek Hušek]

Pitel added a comment.


  >> show on: mouse out | mouse in | always (and possibly never show unless it 
is covered by other options, show on mouse out not available for buttons and 
appmenu)
  > 
  > This one I don't fully understand. Why show on: mouse_out|mouse_in for all 
items is not enough to satisfy all scenarios?
  
  They are if you think about them as two checkboxes, I thought about it as 
single combobox...

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11071

To: Pitel, #plasma, martinkostolny
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11746: Assign notification area category

[Radek Hušek]

Pitel added a comment.


  @wsdfhjxc can you land it yourself or should I do it? I would like to land 
this, D11748 , D11749 
, D11750 
, and D11751 
, so D11352 
 can land without the category override 
hack.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  patch-1

REVISION DETAIL
  https://phabricator.kde.org/D11746

To: wsdfhjxc, #plasma, broulik
Cc: Pitel, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11021: [Media controller] Add simple volume control

[Radek Hušek]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bd5619e0155a: [Media controller] Add simple volume 
control (authored by Pitel).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11021?vs=30963=31231

REVISION DETAIL
  https://phabricator.kde.org/D11021

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml
  dataengines/mpris2/mpris2.operations
  dataengines/mpris2/multiplexedservice.cpp
  dataengines/mpris2/playeractionjob.cpp
  dataengines/mpris2/playercontrol.cpp
  dataengines/mpris2/playercontrol.h

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11410: [RFC] Add option to make applet fixed width

[Radek Hušek]

Pitel added inline comments.

INLINE COMMENTS

> mart wrote in ConfigOverlay.qml:385
> this will probably need as well
> currentApplet.applet.pluginName == "org.kde.plasma.panelspacer"
> 
> or it gets lost when the spacer is configured as not expanding and i guess 
> the spacer is special and we want this option to be always there
> (step 2 would be removing the option in the spacer and make it use this 
> system, but it's for a next commit)

It does not, it is already in definition of `expandingApplet` (line 254 of 
`main.qml`).

> mart wrote in ConfigOverlay.qml:402
> is it necessary to use a temp copy?

My reasons for temp copy were:

- `push` method has no effect on `plasmoid.configuration.fixedSizeOverride` (I 
assume this has something to do with the whole configuration magic behind but 
it might be worth further investigating.)
- QML does not notify the change of property if the property is an array and 
you change only its elements (because the property still contains the same 
object) so we need to trigger this signal somehow.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11410

To: Pitel, #plasma
Cc: mart, hein, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11410: [RFC] Add option to make applet fixed width

[Radek Hušek]

Pitel updated this revision to Diff 31036.
Pitel added a comment.


  Fix tooltip text.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11410?vs=30728=31036

BRANCH
  fixedSizeOverride

REVISION DETAIL
  https://phabricator.kde.org/D11410

AFFECTED FILES
  containments/panel/contents/config/main.xml
  containments/panel/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/main.qml

To: Pitel, #plasma
Cc: mart, hein, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel added a comment.


  > i would prefer the final version to be quiet
  
  Sure.

INLINE COMMENTS

> mart wrote in AbstractItem.qml:80
> This is probably not necessary: both plasmoids and statusnotifieritems have 
> ids that you can access (numeric for plasmoids, alphanumeric for 
> statusnotifiers, which would then make them ordered after plasmoids but 
> that's fine)

Probably not, I have not observed any problems even without this rule, I just 
wanted to be safe. I see that I can use `applet.id` or even `applet.pluginName` 
as there should be at most one instace of given plasmoid in systray but I am 
not so sure about statusnotifiers, spec says that `Id` should be unique for 
given app, but what if user launches two instances of the app? Or am I 
overthinking this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel, #vdg, #plasma, mart
Cc: ngraham, wsdfhjxc, mart, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11410: [RFC] Add option to make applet fixed width

[Radek Hušek]

Pitel updated this revision to Diff 30555.
Pitel added a comment.


  - Replace checkbox with a checkable button
  - Add support for panel spacer -- currently we just check whether the applet 
is panel spacer and if it is we use `applet.configuration.expanding` instead of 
our `fixedSizeOverride`. I think we should remove context action to set 
`expanding` from panel spacer after this is landed and then convert it to use 
`fixedSizeOverride` array.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11410?vs=29940=30555

BRANCH
  fixedSizeOverride

REVISION DETAIL
  https://phabricator.kde.org/D11410

AFFECTED FILES
  containments/panel/contents/config/main.xml
  containments/panel/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/main.qml

To: Pitel, #plasma
Cc: mart, hein, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel planned changes to this revision.
Pitel added a comment.


  Ok, that looks that I did screw something. Time to investigate...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel
Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel updated this revision to Diff 29690.
Pitel added a comment.


  @mart you were very right to point out the `callLater` because that is 
exactly what was broken. The code assumed that all calls of `callLater` with 
different arguments are executed but in fact only those eith different function 
are, rest of arguments does not matter. I somehow managed to run an older 
version of patch on my machine were `callLater` was applied to local helper 
function so it worked for me...
  
  - Removed `callLater` stuff and also removed the `onParentChanged` hook (not 
sure why it was needed in the first place...)
  - Renamed `getCategoryOrder` to `indexForItemCategory` and `itemCompare` to 
`compareItems`.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11352?vs=29592=29690

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel
Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel updated this revision to Diff 29973.
Pitel added a comment.


  - put UnknownCategory first
  - treat applets with category not in the list as UnknownCategory
  - split reorderItem function into two
  - add temporary hack whcih allows overriding applet's category (applets with 
wrong category are from diferent repos, so till they are fixed I added this 
hack, also does not contain Keyboard and Discover applets because I was unable 
to find their itemIds)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11352?vs=29690=29973

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel
Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel added inline comments.

INLINE COMMENTS

> broulik wrote in multiplexedservice.h:38
> Shouldn't this be a job? So you use the `startOperationCall` stuff used 
> elsewhere (for e.g. Play and so on)

I guess it would look more consistent if it was a job but somehow I fail to see 
why any of this is job in the first place: all the actions are very simple so 
offloading work to other thread is not needed and it hides interface in ugly 
way... Do you have any insight why?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel updated this revision to Diff 29977.
Pitel added a comment.


  ty, updated

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11352?vs=29973=29977

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel
Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel added a comment.


  ping

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11410: [RFC] Add option to make applet fixed width

[Radek Hušek]

Pitel updated this revision to Diff 29940.
Pitel added a comment.


  In D11410#229277 , @mart wrote:
  
  > it's moving on the right track.. i would like the checkbox to appear like 
the one in the panel spacer, in the context menu could be tricky as would need 
to inject into the applet's contextualactons, so let's forget about it for now.
  
  
  I'm not sure that is good idea: There are already some items injected in 
context menus (e.g. Unlock widgets action) and looking at my panel some 
applets' context menus are not injected. I believe it is because they have 
multiple menus bound to specific parts of itself and only applet's global menu 
is (and can) be injected. Most notable examples are systray except the 
expansion arrow and task icon manager except empty space (if it has set 
`fixedWidth` I was unable to find a place in it which would show me context 
menu containing Unlock widget action).
  
  > one thing that could be done is to put that button in the applet handle 
that appears on hover when the panel controller is open, with the same icon of 
the add panel spacer in a checkable toolbutton (just icon, tooltip on hover) 
the panel spacer should use the same config ui.
  
  The combox is currently in the popup showing on hover when panel controller 
is open. I can make it replace spacer's specific option. I can just remove 
spacer's option from its context menu and add some temporary code to convert 
spacer's option into the new one. (And a few version later we can drop this 
code.) Is it what you meant or did I misunderstand you?
  
  > i would like to expose this ui only for applets that want to expand, and 
not for those that are already compact (i don't think this option would make 
any sense in kicoff for instance)
  
  Done.
  
  Changes:
  
  - Fix config item label
  - Show checkbox only for expanding applets
  - A bit polish checkbox placement

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11410?vs=29745=29940

BRANCH
  fixedSizeOverride

REVISION DETAIL
  https://phabricator.kde.org/D11410

AFFECTED FILES
  containments/panel/contents/config/main.xml
  containments/panel/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/main.qml

To: Pitel, #plasma
Cc: mart, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel updated this revision to Diff 30111.
Pitel added a comment.


  Great, but I found one more bug (and it affected order of items). This fixes 
it.
  
  - Add tie breaking (for the unlikely case of the same category & text)
  - Add debug print
  - Fix sorting algorithm (the order was wrong if item was created with empty 
text and filled it in later)
  
  Note that I do not have write access, so I cannot land this myself.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11352?vs=29977=30111

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel, #vdg, #plasma, mart
Cc: ngraham, wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel abandoned this revision.
Pitel added a comment.


  Replaced by D11352 .

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel, #plasma, #vdg
Cc: mart, zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel added a comment.


  I am using Czech translation and I am satisfied with item order (but I keep 
only a few items in my systray). I like the current rule because it is simple 
and have some internal logic (even though it might not be obvious what the 
`text` of an applet is) and it is not just a fixed random order. I would rather 
not implement some crazy compare function just because it has somewhat 
reasonable results.
  
  To me just the consistent order is a big step forward compared to the current 
state. I would also like to hear opinion of someone working in ui design. #VDG 
?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel, #vdg, #plasma
Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11410: [RFC] Add option to make applet fixed width

[Radek Hušek]

Pitel added a comment.


  Also do we want this or two options instead:
  
  - no expanding: `maximumWidth = preferredWidth`, and
  - no shrinking: `minimumWidth = preferredWidth`?
  
  Because when attempting to use `fillWidth = false` with full version of task 
manager it will probably overflow the panel.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11410

To: Pitel
Cc: mart, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D11410: [RFC] Add option to make applet fixed width

[Radek Hušek]

Pitel created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  @hein refused D10944  with wish to move 
the config option to contaiment level.
  This patch does it: It adds a `IntList` config option `fixedSizeOverride`
  to panel containment, checkbox in config overlay to modify it, and
  sets `fillWidth` and `fillHeight` of an applet to `false` if it is
  in `fixedSizeOverride` array.
  
  Note that the checkbox introduced by this patch still needs some polishing.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixedSizeOverride

REVISION DETAIL
  https://phabricator.kde.org/D11410

AFFECTED FILES
  containments/panel/contents/config/main.xml
  containments/panel/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/main.qml

To: Pitel
Cc: mart, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel abandoned this revision.
Pitel added a comment.


  Replaced by D11410 .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

To: Pitel, ngraham, mart
Cc: hein, mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel added a comment.


  I guess Phabricator does not let me only respond to inline comments.

INLINE COMMENTS

> mart wrote in main.qml:65
> as convention we usually don't have getFoo as names (and this is not getting 
> a property anyways)
> i would like a more descriptive name like indexForCategory and have the 
> category as parameter instead of the item

What about `indexForItemCategory`? I need to pass in item not category because 
of special treatment of notifications.

Also I'll rename `itemCompare` to `compareItems`.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel
Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel added a comment.


  Phabricator:Pitel   2:0

INLINE COMMENTS

> mart wrote in AbstractItem.qml:81
> what's the reson for using callLater?

The main reason is to avoid calling `updateItemVisibility` from itself which 
might happen if `stackAfter` fires the `onParentChanged` event at wrong time 
(wrong time is right at reparent before changing order of items, and I believe 
the exact time is implementation detail we should not depend on anyway).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel
Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11021: [Media contoller] Add simple volume control

[Radek Hušek]

Pitel created this revision.
Pitel added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  Add simple volume control to Media Controller applet. Volume can by changed 
by:
  
  - mouse wheel on applet icon (3 % step), and
  - new global shortcuts (5 % step, unbound by default).
  
  There is no mute support currently (mpris interface does not have a mute 
method so we would have to keep
  track of old volume).
  
  Currently the patch does only prevent volume from being negative but it will 
try to set volume larger than 1 (mpris spec
  does not prevent players from using larger volumes).

TEST PLAN
  Tested in daily use with Cantata and SMPlayer. There is no UI change.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml
  dataengines/mpris2/multiplexedservice.cpp

To: Pitel, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11021: [Media contoller] Add simple volume control

[Radek Hušek]

Pitel added a comment.


  The idea crossed my mind but I rarely use expanded version of the applet and 
there are two problems to deal with:
  
  - Where exactly to place the slider (I am bad at designing UI).
  - What should upper bound of slider be -- usually 1 is good option but mpris 
does not prevent apps from using larger volumes and there is not "getMaxVolume" 
method / property. It might be possible to just hardcode 1 as max but care 
would be needed not to mess the volume up if it was set to (say) 1.5 by other 
means. (And the user experience would be somewhat inconsistent, but I am not 
sure how many apps really uses volume > 1.)
  
  So I decided to keep it simple at first try.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma
Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel retitled this revision from "[Media contoller] Add simple volume control" 
to "[Media controller] Add simple volume control".

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma
Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel added a reviewer: broulik.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel updated this revision to Diff 28701.
Pitel added a comment.


  - Added OSD support.
  - Refactored osd & volume bounding logic into helper 
`MultiplexedService::changeVolume`.
  
  Is there any way to get player name & icon without adding 
`PlayerControl::container`?

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11021?vs=28604=28701

REVISION DETAIL
  https://phabricator.kde.org/D11021

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml
  dataengines/mpris2/multiplexedservice.cpp
  dataengines/mpris2/multiplexedservice.h
  dataengines/mpris2/playercontrol.h

To: Pitel, #plasma
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11021: [Media controller] Add simple volume control

[Radek Hušek]

Pitel updated this revision to Diff 28729.
Pitel added a comment.


  The `changeVolume` helper must be in `PlayerControl` class and 
`MultiplexedService` must only forward calls to it in order to volume change by 
mouse wheel also work for other sources than only mutliplex one.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11021?vs=28701=28729

REVISION DETAIL
  https://phabricator.kde.org/D11021

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml
  dataengines/mpris2/multiplexedservice.cpp
  dataengines/mpris2/multiplexedservice.h
  dataengines/mpris2/playercontrol.cpp
  dataengines/mpris2/playercontrol.h

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11065: [Active Window Control] Slightly fix vertical alignment of window name

[Radek Hušek]

Pitel created this revision.
Pitel added reviewers: Plasma, martinkostolny.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  On my setup the window label was 1px lower than global menu items (with Fill 
height enabled) which was very annoying.
  I guess it was caused by some rounding error. This patch fixes it.
  
  Old: F5742154: Screenshot_20180305_191056.png 

  
  New: F5742155: Screenshot_20180305_191530.png 

  
  (Red rectangle was added so the issue is easier to spot.)

TEST PLAN
  Checked that window label is still vertically centered.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11065

AFFECTED FILES
  package/contents/ui/main.qml

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11065: [Active Window Control] Slightly fix vertical alignment of window name

[Radek Hušek]

Pitel added a comment.


  Would it be better to move global menu 1px down instead?
  
 PlasmaComponents.Label {
 id: appmenuButtonTitle
-anchors.centerIn: appmenuButtonBackground
+anchors.top: appmenuButtonBackground.top
+anchors.bottom: appmenuButtonBackground.bottom
+verticalAlignment: Text.AlignVCenter
+anchors.horizontalCenter: 
appmenuButtonBackground.horizontalCenter
 font.pixelSize: fontPixelSize * 
plasmoid.configuration.appmenuButtonTextSizeScale
 text: activeMenu.replace('&', '')
 font.weight: appmenuFontBold ? Font.Bold : 
theme.defaultFont.weight
  
  It also fixes the issue (although I liked the 1px higher a bit better in this 
specific case).
  
  F5742205: Screenshot_20180305_200905.png 

  
  Anyway the root of the problem seems to be that each of them was centered in 
a different way.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11065

To: Pitel, #plasma, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

[Radek Hušek]

Pitel created this revision.
Pitel added reviewers: Plasma, martinkostolny.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  Currently global menu is always aligned on the other side than buttons 
(minimize / maximize / close) are.
  This patch tries to make alignment of global menu independent.
  
  F5742391: Screenshot_20180305_212852.png 

  
  It fails for some setups -- e.g. the left margin of window label is too 
large: F5742413: Screenshot_20180305_214250.png 

  
  I tried hard to find a better solution but failed so far.
  
  Any suggestions are welcome.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11071

AFFECTED FILES
  package/contents/config/main.xml
  package/contents/ui/AppMenu.qml
  package/contents/ui/config/ConfigAppMenu.qml

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11072: [Active Window Control] Show window title when app name is missing

[Radek Hušek]

Pitel created this revision.
Pitel added reviewers: Plasma, martinkostolny.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  Some apps do not have application name (e.g. Android Emulator) so we display 
window title instead of empty string.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11072

AFFECTED FILES
  package/contents/ui/main.qml

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11073: [RFC] [Active Window Control] Elide appmenu when it is too long

[Radek Hušek]

Pitel created this revision.
Pitel added reviewers: Plasma, martinkostolny.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  When appmenu is too large to fit in and "»" button instead of overflowing.
  
  F5742423: Screenshot_20180305_215938.png 

  
  There is a change to C++ backend -- button indexes -10 and lower mean a drop 
down menu which contains some suffix of menubar items -- -10 contains them all, 
-11 all without first one and so on.
  
  The tricky part is to determine which items to hide -- current approach is to 
draw all at first and then iterate through them and hide ones too much on right 
(`fixOverflow` function). Property `effectiveWidth` calculates how much space 
we can use and is only correct when buttons are on right and should not be 
overlapped by the menu. (Should be resolved after D11071: [RFC] [Active Window 
Control] Allow global menu be left alligned with buttons on right 
.)
  
  If the backend changes and hiding logic are considered sane, it might be 
worth porting to Global Menu applet (there the computation of available space 
would be much simplier).
  
  This patch was only tested on top of D11071: [RFC] [Active Window Control] 
Allow global menu be left alligned with buttons on right 
.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11073

AFFECTED FILES
  lib/appmenuapplet.cpp
  package/contents/ui/AppMenu.qml

To: Pitel, #plasma, martinkostolny
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel added a comment.


  Not really -- if I understand correctly allocating space works following way: 
All widgets get space they claim they need and the surplus is split among 
widgets with fillWidth == true in ratio which seems proportinal to width of 
given widgets. So even if global menu took space needed to display all menu 
items there still would be an ugly gap on right side of taskmanager.
  
  As a side note: hiding part of menu is not really an usability issue because 
the global menu applet is able show rest of it as a dropdown menu which is a 
patch yet to be upstreamed and I guess I also should port it to Global Menu 
applet (I am using Active Window Control applet which also shows name of app 
and buttuns to close /min / max window).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

To: Pitel, ngraham, mart
Cc: mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel added a comment.


  Screenshots with Global Menu applet (panel contains Global menu, growing 
Spacer and icon taskmanager).
  
  Old: F5736170: Screenshot_20180302_112934.png 

  
  New: F5736172: Screenshot_20180302_112956.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

To: Pitel, ngraham, mart
Cc: mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel updated this revision to Diff 28345.
Pitel added a comment.


  Choice whether to fill or not fill width was turned into config option and i 
possible to set (and used) only for iconsOnly
  version of taskmanager.
  
  Screenshot with original behavior: F5735025: Screenshot_20180301_175247.png 

  And new one: F5735027: Screenshot_20180301_175311.png 


REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10944?vs=28328=28345

REVISION DETAIL
  https://phabricator.kde.org/D10944

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/main.qml

To: Pitel, ngraham, mart
Cc: mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel updated this revision to Diff 28405.
Pitel added a comment.


  In previous revisions I used fillWidth = false but it is wrong because it not 
only prevents expanding but also it prevents applet from shrinking. So use 
Layout.maximumWidth = Layout.preferredWidth instead. Also after further testing 
I do not think the option must be restricted to icon version of applet only -- 
with full version (and Spacer applet) it allows you to align task on right side 
of panel which was impossible before.
  
  F5736447: Screenshot_20180302_144855.png 

  
  Note: By default the new "fillWidth" option is enabled, so no behaviour 
changes until user explicitly configures the applet.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10944?vs=28345=28405

REVISION DETAIL
  https://phabricator.kde.org/D10944

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/main.qml

To: Pitel, ngraham, mart
Cc: mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11410: [RFC] Add option to make applet fixed width

[Radek Hušek]

Pitel updated this revision to Diff 66260.
Pitel added a comment.


  Reabse & polish UI

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11410?vs=31036=66260

BRANCH
  fixedSizeOverride2

REVISION DETAIL
  https://phabricator.kde.org/D11410

AFFECTED FILES
  containments/panel/contents/config/main.xml
  containments/panel/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/main.qml

To: Pitel, #plasma
Cc: mart, hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel updated this revision to Diff 66209.
Pitel added a comment.


  Rebase on current master and squash

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11352?vs=30859=66209

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel, #vdg, #plasma, mart
Cc: ognarb, ngraham, wsdfhjxc, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol