[Differential] [Commented On] D1769: [Service Runner] Don't use KRun::runService

2016-06-06 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  Would it make sense to add such API in KRun@KIOWidgets?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1769

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: apol, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1744: Fix the ignore struts multi-screen handling

2016-06-10 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  I just tested the patch, the issue isn't solved here.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1744

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, lbeltrame, apol
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1810: Don't call a plugin "something plugin"

2016-06-09 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1810

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1809: Fix i18n in plasmacalendarintegration

2016-06-09 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1809

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1676: kfontinst: Port to QApplication and QCommandLineParser

2016-05-25 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1676

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma, apol
Cc: apol, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1685: kfontinst: Port to QDebug

2016-05-25 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1685

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma, apol
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1686: kfontinst: Port away from KIO::NetAccess

2016-05-25 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1686

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma, apol
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1687: kfontinst: Port to QFileDialog

2016-05-25 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma, apol
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1688: kfontinst: Port to QSaveFile

2016-05-25 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1688

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma, apol
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1689: kfontinst: Port to QMimeDatabase

2016-05-25 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> FontFilter.cpp:169
> +QStringList mimes;
> +foreach (QString pattern, mime.globPatterns())
> +mimes.append(pattern.replace("*.", ""));

const QString &

> FontFilter.cpp:170
> +foreach (QString pattern, mime.globPatterns())
> +mimes.append(pattern.replace("*.", ""));
>  act->setData(mimes);

`""` -> QString() or `{}`

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1689

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma, apol
Cc: apol, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D1866: Use QVector and QLatin1String, and range-based for

2016-06-14 Thread apol (Aleix Pol Gonzalez) 
apol added inline comments.

INLINE COMMENTS

> xrandroutput.cpp:258
>  
> -Q_FOREACH(const QString , embedded) {
> +for (const QLatin1String  : embedded) {
>  if (name.toUpper().startsWith(pre)) {

This one is fine, but I wouldn't change from `foreach -> for` as a norm, as it 
can easily backfire.

REPOSITORY
  rLIBKSCREEN KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D1866

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: apol, broulik, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1705: [System Tray] Don't iterate keys()

2016-05-29 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
apol added a comment.
This revision is now accepted and ready to land.


  Good stuff! Clazy? Or you actually found this to be a paint point?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1705

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, apol
Cc: apol, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D782: Require Qt 5.5

2016-01-11 Thread apol (Aleix Pol Gonzalez) 
apol added a subscriber: apol.
apol added a comment.

+1


REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D782

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: apol, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D861: Port away from kdelibs4support

2016-01-25 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  drop-kdelibs4support

REVISION DETAIL
  https://phabricator.kde.org/D861

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, apol
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1171: simple cleanup in geometryByDistance

2016-03-19 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense, for readability.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1171

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, Plasma, apol
Cc: apol, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1066: Fix saving correct length of panel

2016-03-03 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  +1

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1066

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma
Cc: apol, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1279: Add a template for Weather Ion dataengines

2016-04-01 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  LGTM

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1279

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, apol
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1498: Fix memory leak in system tray

2016-04-26 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM, thanks!

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1498

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, Plasma, apol
Cc: apol, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1647: kfontinst: Port to QDialog

2016-05-20 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  Other than that it looks quite good, interesting how much code gets cleaned 
up.

INLINE COMMENTS

> Printer.cpp:349
> +
> +QDialogButtonBox *buttonBox = new 
> QDialogButtonBox(QDialogButtonBox::Cancel);
> +connect(buttonBox, SIGNAL(rejected()), this, SLOT(slotCancelClicked()));

Pass this as the last argument, so it has a parent and doesn't leak. On this 
one and the rest of `new QDialogButtonBox`.

> Printer.cpp:350
> +QDialogButtonBox *buttonBox = new 
> QDialogButtonBox(QDialogButtonBox::Cancel);
> +connect(buttonBox, SIGNAL(rejected()), this, SLOT(slotCancelClicked()));
> +

Use new syntax. `::rejected` and `::slotCancelClicked`

> DuplicatesDialog.cpp:76
> +itsButtonBox = new QDialogButtonBox(QDialogButtonBox::Cancel);
> +connect(itsButtonBox, SIGNAL(clicked(QAbstractButton*)), this, 
> SLOT(slotButtonClicked(QAbstractButton*)));
> +QVBoxLayout *mainLayout = new QVBoxLayout;

use new syntax as well.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1647

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma
Cc: apol, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1676: kfontinst: Port to QApplication and QCommandLineParser

2016-05-24 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  LGTM +1

INLINE COMMENTS

> Viewer.cpp:131
>  {
> -for (int i = 0; i < args->count(); ++i)
> +for (int i = 0; i < urlArgs.count(); ++i)
>  {

Prefer foreach to iterate a QList

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1676

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma
Cc: apol, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1675: kfontinst: Port to QTemporaryDir

2016-05-24 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  I'd say it's generally better to use QDir::filePath there. it will be easier 
to read.

INLINE COMMENTS

> FontThumbnail.cpp:96
>  {
> -realPath=tempDir->name()+entry->name();
> +
> realPath=tempDir->path()+QLatin1Char('/')+entry->name();
>  break;

can't you use filePath there?

> FontThumbnail.cpp:100
>  else
> -
> ::unlink(QFile::encodeName(tempDir->name()+entry->name()).data());
> +
> ::unlink(QFile::encodeName(tempDir->path()+QLatin1Char('/')+entry->name()).data());
>  }

filePath?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1675

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma
Cc: apol, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1588: [Shell] Replace foreach by range-for where possible

2016-05-11 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  In https://phabricator.kde.org/D1588#29377, @davidedmundson wrote:
  
  > maybe we can, but why?
  >
  > foreach is always correct
  >
  > for is sometimes correct
  >
  > what's the benefit?
  
  
  I tend to think along those lines... if it was actually a problem, it could 
just be specified as:
  
#define Q_FOREACH(a, b) for((a) : qAsConst(b))
  
  And live happily ever after. Or at least, until they fix the weird copies. 
FWIW, it's discussed in qt-development@ as we're speaking.
  A direct improvement is about 100bytes less of generated code for every 
foreach (which then needs to be executed).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1588

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma
Cc: apol, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1514: [Milou] Optimize sources model

2016-05-01 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  A test would be good, with ModelTest it would be great.

INLINE COMMENTS
  lib/sourcesmodel.cpp:304 This looks wrong. Begin should be on top...
  lib/sourcesmodel.cpp:307 Same

REPOSITORY
  rMILOU Milou

REVISION DETAIL
  https://phabricator.kde.org/D1514

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma
Cc: apol, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1675: kfontinst: Port to QTemporaryDir

2016-05-25 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  Ugh, I was convinced it would exist! My apologies for not checking.
  
  For now, can you at least just change from "/" -> QLatin1Char('/')?
  Also if you can look into adding the API to Qt that would be great as well.
  
  Other than that, +1

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1675

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma
Cc: apol, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1675: kfontinst: Port to QTemporaryDir

2016-05-25 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1675

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volkov, Plasma, apol
Cc: apol, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2305: Prefer alias to new property

2016-07-28 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI69d297937b01: Prefer alias to new property (authored 
by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2305?vs=5541=5543#toc

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2305?vs=5541=5543

REVISION DETAIL
  https://phabricator.kde.org/D2305

AFFECTED FILES
  src/controls/BasicListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4 lines] D2305: Prefer alias to new property

2016-07-28 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It's better to just have a property aliased than duplicating it. Both for 
readability and performance

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2305

AFFECTED FILES
  src/controls/BasicListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 45 lines] D2306: Make it possible to provide a page header to ScrollablePage

2016-07-28 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 5547.
apol added a comment.


  Add api documentation

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2306?vs=5546=5547

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2306

AFFECTED FILES
  examples/gallery/contents/ui/gallery/ListViewGallery.qml
  src/controls/ScrollablePage.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 45 lines] D2306: Make it possible to provide a page header to ScrollablePage

2016-07-28 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 5549.
apol added a comment.


  Fix naming

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2306?vs=5547=5549

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2306

AFFECTED FILES
  examples/gallery/contents/ui/gallery/ListViewGallery.qml
  src/controls/ScrollablePage.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2306: Make it possible to provide a page header to ScrollablePage

2016-07-29 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  In https://phabricator.kde.org/D2306#42989, @mart wrote:
  
  > seems to behave a bit strangely, especially its interaction with the global 
ApplicationHeader is quite strange
  
  
  What is that you don't like exactly? I can look into it if you tell me.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2306

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2306: Make it possible to provide a page header to ScrollablePage

2016-07-29 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  In https://phabricator.kde.org/D2306#43024, @mart wrote:
  
  > it should just be a fixed header, always visible and laid out with the main 
content or flickable, it should be in Page (and just happening to work in 
scrollablepage too) and the property called just header, not pageHeader
  >
  > ie it has to be as much identical as possible to 
  >  http://doc.qt.io/qt-5/qml-qtquick-controls2-page.html
  >
  > because Page is going to inherit from that one in the future
  
  
  I'm not sure that's what I need. Should I implement it in Discover and when 
we move to Qt 5.7 we see what should be upstreamed, if anything?

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2306

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 5 lines] D2326: Properly check if the page is in bounds

2016-08-01 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We were just checking on the lower bounds

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2326

AFFECTED FILES
  src/controls/templates/private/PageRow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2326: Properly check if the page is in bounds

2016-08-01 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMIe24d9e255616: Properly check if the page is in bounds 
(authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2326?vs=5605=5608

REVISION DETAIL
  https://phabricator.kde.org/D2326

AFFECTED FILES
  src/controls/templates/private/PageRow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4 lines] D2327: Let the drawer contents take the full width

2016-08-01 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  I'm not sure why it was done like that, but otherwise we're forced into
  some margins which look weird, especially when having ListItems at the
  bottom, because they don't look like the ones on top

TEST PLAN
  Works on kirigamigallery, works on Discover

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2327

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 2 lines] D2335: Respect the bottomPadding for the bottom of the drawer

2016-08-02 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Make it possible to not leave an empty space below the drawer

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  bottom

REVISION DETAIL
  https://phabricator.kde.org/D2335

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Abandoned] D2329: Let the drawer contents take the full width

2016-08-02 Thread apol (Aleix Pol Gonzalez) 
apol abandoned this revision.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2329

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2334: Respect the bottomPadding for the bottom of the drawer

2016-08-02 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI7f92f7f9a314: Respect the bottomPadding for the 
bottom of the drawer (authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2334?vs=5636=5637

REVISION DETAIL
  https://phabricator.kde.org/D2334

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2335: Respect the bottomPadding for the bottom of the drawer

2016-08-02 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI2e8371f5bc69: Respect the bottomPadding for the 
bottom of the drawer (authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2335?vs=5631=5632

REVISION DETAIL
  https://phabricator.kde.org/D2335

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 15 lines] D2334: Respect the bottomPadding for the bottom of the drawer

2016-08-02 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 5635.
apol added a comment.


  Use padding to place the top element as well

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2334?vs=5633=5635

BRANCH
  margins

REVISION DETAIL
  https://phabricator.kde.org/D2334

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 17 lines] D2334: Respect the bottomPadding for the bottom of the drawer

2016-08-02 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Use Layout attached property margins rather than trying to compute sizes

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  drawermargins

REVISION DETAIL
  https://phabricator.kde.org/D2334

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 15 lines] D2334: Respect the bottomPadding for the bottom of the drawer

2016-08-02 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 5633.
apol added a comment.


  Update patch

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2334?vs=5630=5633

BRANCH
  margins

REVISION DETAIL
  https://phabricator.kde.org/D2334

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 15 lines] D2334: Respect the bottomPadding for the bottom of the drawer

2016-08-02 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 5636.
apol added a comment.


  Use padding when necessary

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2334?vs=5635=5636

BRANCH
  margins

REVISION DETAIL
  https://phabricator.kde.org/D2334

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2399: New new SDDM theme

2016-08-10 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  Shouldn't we be keeping the old theme for nostalgia and such? It's a theme 
after all.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D2240: Anchors in a layout item is always wrong

2016-07-21 Thread apol (Aleix Pol Gonzalez) 
apol added inline comments.

INLINE COMMENTS

> WidgetExplorer.qml:264
>  id: closeButton
> -anchors {
> -right: parent.right

If it needs to be aligned to the right, shouldn't it have a `Layout.alignment: 
Qt.AlignRight`?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2240

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: apol, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 27 lines] D2144: Fix warnings

2016-07-20 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 5345.
apol added a comment.


  Fix morphing, proper testing

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2144?vs=5344=5345

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2144

AFFECTED FILES
  src/controls/OverlayDrawer.qml
  src/controls/Page.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/private/ContextIcon.qml
  src/controls/templates/private/MenuIcon.qml
  src/controls/templates/private/PageRow.qml
  src/styles/Desktop/OverlayDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2144: Fix warnings

2016-07-20 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI50b4b7b032a2: Fix warnings (authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2144?vs=5345=5346

REVISION DETAIL
  https://phabricator.kde.org/D2144

AFFECTED FILES
  src/controls/OverlayDrawer.qml
  src/controls/Page.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/private/ContextIcon.qml
  src/controls/templates/private/MenuIcon.qml
  src/controls/templates/private/PageRow.qml
  src/styles/Desktop/OverlayDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 22 lines] D2144: Fix warnings

2016-07-20 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 5344.
apol added a comment.


  Address Marco's comment

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2144?vs=5096=5344

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2144

AFFECTED FILES
  src/controls/OverlayDrawer.qml
  src/controls/Page.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/private/ContextIcon.qml
  src/controls/templates/private/MenuIcon.qml
  src/controls/templates/private/PageRow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2144: Fix warnings

2016-07-20 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  > why adding check over mainFlickable.currentItem ? doesn't guard anything
  
  We don't want `mainFlickable.currentItem.width` to fail if 
`mainFlickable.currentItem` is null.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2144

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 15 lines] D2144: Fix warnings

2016-07-12 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Make sure we don't ever call null objects

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2144

AFFECTED FILES
  src/controls/Page.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/private/ContextIcon.qml
  src/controls/templates/private/PageRow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Abandoned] D2137: Fix warning in BasicListItem.width

2016-07-12 Thread apol (Aleix Pol Gonzalez) 
apol abandoned this revision.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2137

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2117: Consider the primary screen as default screen

2016-07-11 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEd1210f5fda01: Consider the primary screen as 
default screen (authored by apol).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2117?vs=5016=5083

REVISION DETAIL
  https://phabricator.kde.org/D2117

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: jriddell, plasma-devel, #neon, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2110: Create a Colors page in the Gallery

2016-07-07 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  Screenshot: http://i.imgur.com/7agXRFB.png

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2110

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4 lines] D2117: Consider the primary screen as default screen

2016-07-08 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added a reviewer: Plasma.
apol added a subscriber: Neon.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We used to append them, but that didn't work well and was crashing plasmashell
  on fresh start.
  A default desktop would be created alongside with the one provided by the
  layout instead of replacing it.
  If a layout wants to provide an additional screen for a desktop in the 
secondary
  screen, it should specify the screen.

TEST PLAN
  Now the plasmashell tests pass. In fact I noticed it was broken due to an 
e-mail
  Jonathan sent me that the test on neon was timing out. The test in neon will
  freeze when the test crashes. Probably something to look into.
  It can be reproduced by running:
  
xvfb-run -a --server-args="-screen 0 1024x768x24" dbus-launch 
--exit-with-session 
  
  Where `exec` is the process we need to run.
  
  Now the test passes.
  It's a crash that I had reproduced locally in the past. I can't now.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2117

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: plasma-devel, #neon, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2118: add neon mapping

2016-07-08 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2118

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, apol
Cc: #neon, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 68 lines] D2110: Create a Colors page in the Gallery

2016-07-07 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Will list all available colors and show them in a rectangle, so that
  the user can see what we're talking about.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2110

AFFECTED FILES
  examples/android/resources.qrc
  examples/gallery/contents/ui/MainPage.qml
  examples/gallery/contents/ui/gallery/ColorsGallery.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2110: Create a Colors page in the Gallery

2016-07-11 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI1f949f4eaf7f: Create a Colors page in the Gallery 
(authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2110?vs=5003=5074

REVISION DETAIL
  https://phabricator.kde.org/D2110

AFFECTED FILES
  examples/android/resources.qrc
  examples/gallery/contents/ui/MainPage.qml
  examples/gallery/contents/ui/gallery/ColorsGallery.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 3 lines] D2137: Fix warning in BasicListItem.width

2016-07-11 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  .../org/kde/kirigami/GlobalDrawer.qml:360:25: QML BasicListItem: Binding
  loop detected for property "width"
  Don't explicitly make sure that the width will be the same as the parent,
  instead only do it if it's in a layout.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2137

AFFECTED FILES
  src/controls/templates/AbstractListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2117: Consider the primary screen as default screen

2016-07-11 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  You mean you applied the patch?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2117

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: jriddell, plasma-devel, #neon, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 45 lines] D2329: Let the drawer contents take the full width

2016-08-01 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  I'm not sure why it was done like that, but otherwise we're forced into
  some margins which look weird, especially when having ListItems at the
  bottom, because they don't look like the ones on top
  
  For reference:
  Before: http://i.imgur.com/nAdxT8F.png
  After: http://i.imgur.com/0oksXoo.png

TEST PLAN
  Works on discover, works on kirigamigallery

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2329

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2327: Let the drawer contents take the full width

2016-08-01 Thread apol (Aleix Pol Gonzalez) 
apol updated the summary for this revision.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2327

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2327: Let the drawer contents take the full width

2016-08-01 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMIcf7ea0a6adda: Let the drawer contents take the full 
width (authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2327?vs=5609=5615

REVISION DETAIL
  https://phabricator.kde.org/D2327

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 40 lines] D2306: Make it possible to provide a page header to ScrollablePage

2016-07-28 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Sometimes we show some information on top of a flickable that goes away as
  soon as the user scrolls down.
  This introduces a property that offers a component to be shown when the view
  is scrolled, optionally of course.

TEST PLAN
  Extends the ListView example. Been tested locally on Discover.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2306

AFFECTED FILES
  examples/gallery/contents/ui/gallery/ListViewGallery.qml
  src/controls/ScrollablePage.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 8 lines] D2517: Fix warning

2016-08-21 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Can't assign an edge to an anchor
  
  
file:///home/apol/devel/kde5/lib64/qml/org/kde/kirigami/styles/Desktop/OverlayDrawer.qml:115:23:
 Unable to assign int to QQuickAnchorLine
  
file:///home/apol/devel/kde5/lib64/qml/org/kde/kirigami/styles/Desktop/OverlayDrawer.qml:116:24:
 Unable to assign int to QQuickAnchorLine

TEST PLAN
  There's no such warning anymore

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2517

AFFECTED FILES
  src/styles/Desktop/OverlayDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel

[Differential] [Closed] D2517: Fix warning

2016-08-22 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI518d1101c129: Fix warning (authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2517?vs=6116=6147

REVISION DETAIL
  https://phabricator.kde.org/D2517

AFFECTED FILES
  src/styles/Desktop/OverlayDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel

[Differential] [Closed] D2589: Make the AbstractListItem a Rectangle

2016-09-11 Thread apol (Aleix Pol Gonzalez) 
apol closed this revision.
apol added a comment.


  Submitted as of:
  
commit 9261ecc98d10f38c4eade84746eb5a9b71bff4ff
Author: Aleix Pol 
Date:   Tue Sep 6 17:33:20 2016 +0200
  
  I'm unsure why it didn't close the request.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2589

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Updated, 2 lines] D2693: Standardize Drawer width

2016-09-12 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 6659.
apol added a comment.


  - Fix warnings

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2693?vs=6538=6659

BRANCH
  arcpatch-D2693

REVISION DETAIL
  https://phabricator.kde.org/D2693

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol

[Differential] [Closed] D2705: Fix warnings

2016-09-12 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI341dd95310fa: Fix warnings (authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2705?vs=6542=6658

REVISION DETAIL
  https://phabricator.kde.org/D2705

AFFECTED FILES
  src/styles/Desktop/SwipeListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Closed] D2693: Standardize Drawer width

2016-09-12 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI616af4327cc6: Standardize Drawer width (authored by 
apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2693?vs=6659=6660

REVISION DETAIL
  https://phabricator.kde.org/D2693

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol

[Differential] [Updated, 3 lines] D2776: Silence warnings

2016-09-14 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 6738.
apol added a comment.


  Don't compute and discard

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2776?vs=6737=6738

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2776

AFFECTED FILES
  src/controls/templates/OverlaySheet.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Request, 3 lines] D2776: Silence warnings

2016-09-14 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  I usually get many like this:
  
file:///home/apol/devel/kde5/lib64/qml/org/kde/kirigami/templates/OverlaySheet.qml:150:
 TypeError: Type error

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2776

AFFECTED FILES
  src/controls/templates/OverlaySheet.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Abandoned] D2593: Unify looks of the GlobalDrawer

2016-09-14 Thread apol (Aleix Pol Gonzalez) 
apol abandoned this revision.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2593

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Request, 7 lines] D2778: Expose the banner sourceSize

2016-09-14 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This way one can put svg images

TEST PLAN
  Works with Discover using it and kirigamigallery as is

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2778

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Updated, 4 lines] D2776: Silence warnings

2016-09-14 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 6739.
apol added a comment.


  I misunderstood the problem

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2776?vs=6738=6739

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2776

AFFECTED FILES
  src/controls/templates/OverlaySheet.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Closed] D2776: Silence warnings

2016-09-14 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI0af136764a9b: Silence warnings (authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2776?vs=6740=6741

REVISION DETAIL
  https://phabricator.kde.org/D2776

AFFECTED FILES
  src/controls/templates/OverlaySheet.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Updated, 3 lines] D2776: Silence warnings

2016-09-14 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 6740.
apol added a comment.


  as agreed with marco

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2776?vs=6739=6740

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2776

AFFECTED FILES
  src/controls/templates/OverlaySheet.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Commented On] D2779: Port to Grid.

2016-09-14 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  It's often useful not to have the type on a variable's name so that patches 
like this don't need to happen.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2779

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2779: Port to Grid.

2016-09-14 Thread apol (Aleix Pol Gonzalez) 
apol added inline comments.

INLINE COMMENTS

> main.qml:178
>  
>  property int effectiveRows: {
> +if (!pagerModel.count) {

Looks like this should be readonly...

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2779

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 5 lines] D2790: Make application close upon Ctrl+Q

2016-09-15 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Should possibly integrate with the system's defaults but
  shortcuts are not abstracted out just yet.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2790

AFFECTED FILES
  src/controls/AbstractApplicationWindow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Updated] D2790: Make application close upon Ctrl+Q

2016-09-15 Thread apol (Aleix Pol Gonzalez) 
apol marked an inline comment as done.
apol added a comment.


  Thanks!

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol

[Differential] [Updated, 5 lines] D2790: Make application close upon Ctrl+Q

2016-09-15 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 6764.
apol added a comment.


  Turns out it was already there

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2790?vs=6763=6764

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2790

AFFECTED FILES
  src/controls/AbstractApplicationWindow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol

[Differential] [Updated] D2790: Make application close upon Ctrl+Q

2016-09-15 Thread apol (Aleix Pol Gonzalez) 
apol updated the summary for this revision.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol

[Differential] [Commented On] D2790: Make application close upon Ctrl+Q

2016-09-15 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  In https://phabricator.kde.org/D2790#51966, @broulik wrote:
  
  > So, Ctrl+Q always quits without confirmation? What about having a
  >
  >   singal aboutToQuit(var event)
  >
  > and then do:
  >
  >   onActivated: {
  >   var event = {accepted: false}
  >   aboutToQuit(event);
  >   if (!event.accepted) {
  >   Qt.quit();
  >   }
  >   }
  >
  > Then an app can
  >
  >   onAboutToQuit: {
  >   if (hasUnsavedChanges) {
  >   event.accepted = true;
  >   // ask for confirmation
  >   }
  >   }
  
  
  That could be interesting but could be out of scope for the patch? There's 
other ways the application can be closed.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol

[Differential] [Updated, 5 lines] D2790: Make application close upon Ctrl+Q

2016-09-15 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 6767.
apol added a comment.


  Use Window.close rather than Qt.quit
  
  Gives the opportunity to the application to do something about the
  closing

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2790?vs=6764=6767

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2790

AFFECTED FILES
  src/controls/AbstractApplicationWindow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart, broulik
Cc: broulik, plasma-devel, apol

[Differential] [Commented On] D2580: possible to use OverlaySheet with ListView

2016-09-12 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  In https://phabricator.kde.org/D2580#50546, @mart wrote:
  
  > In https://phabricator.kde.org/D2580#50121, @apol wrote:
  >
  > > We've been looking into it with @colomar and we like how it works. We 
think it would be useful if we'd get a small margin on either side so that it's 
easy to close when we're half-way through the scrolling process.
  > >
  > > Other than that, +1
  >
  >
  > as i explained, on the case of a listview, i can't make it narrower than 
the page, because of how listview works, i can't have the touch sensitive area 
being wider then the list itself, so clicking outside the list on the sides 
wouldn't dismiss it, while it would when clicking on top or bottom (it's 
structural in the ListView c++ stuff, so belongs on the "don't even try" 
category).
  
  
  But this makes the sheet become rather hard to dismiss. I'd say let's get 
this in, as the current component just breaks awkwardly, and then we'll see how 
to make it usable, possibly from the application itself.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2580

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #kirigami, #vdg, apol
Cc: colomar, plasma-devel, apol

[Differential] [Accepted] D2580: possible to use OverlaySheet with ListView

2016-09-12 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  phab/listviewsheet

REVISION DETAIL
  https://phabricator.kde.org/D2580

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #kirigami, #vdg, apol
Cc: colomar, plasma-devel, apol

[Differential] [Accepted] D2858: Fix Plasma discover with the Kirigami it can depend on

2016-09-26 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
apol added a comment.
This revision is now accepted and ready to land.


  Please also merge to master and revert the patch there.

REPOSITORY
  rDISCOVER Discover Software Store

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D2858

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2859: Bump kirigami dependency to include things we rely on

2016-09-26 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rDISCOVER Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2859

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Requested Changes To] D2858: Fix Plasma discover with the Kirigami it can depend on

2016-09-26 Thread apol (Aleix Pol Gonzalez) 
apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Should be discarded, it's incompatible with another RR

REPOSITORY
  rDISCOVER Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D2858

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2887: Fix kcminit phase 1 and 2

2016-10-05 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2887

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2930: purpose is a runtime dependency, do not conditional on it at build time

2016-10-04 Thread apol (Aleix Pol Gonzalez) 
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D2930

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2968: Don't control the look of the delegate on completion

2016-10-06 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI33d03d4920db: Don't control the look of the delegate 
on completion (authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2968?vs=7160=7165

REVISION DETAIL
  https://phabricator.kde.org/D2968

AFFECTED FILES
  src/controls/private/DefaultListItemBackground.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Commented On] D2913: Make the background of the logout screen darker

2016-10-06 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  FWIW it could still make sense. the text is not super readable sometimes, as 
it's gray (at least on my system).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2913

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design
Cc: mart, davidedmundson, plasma-devel, apol, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 6 lines] D2968: Don't control the look of the delegate on completion

2016-10-06 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The index could change at any time

TEST PLAN
  Still works, doesn't fix the dreaded warning

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2968

AFFECTED FILES
  src/controls/private/DefaultListItemBackground.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Closed] D2813: Readability. Simplify overly complex code

2016-09-19 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE89c34a853b64: Readability. Simplify overly 
complex code (authored by apol).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2813?vs=6815=6816

REVISION DETAIL
  https://phabricator.kde.org/D2813

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2812: Make sure the panel is within the screen's geometry

2016-09-19 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE3bf1372dffed: Make sure the panel is within 
the screen's geometry (authored by apol).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2812?vs=6813=6814

REVISION DETAIL
  https://phabricator.kde.org/D2812

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 1 line] D2812: Make sure the panel is within the screen's geometry

2016-09-19 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Whenever we restore, the position of the panel can be random, we need to 
ensure
  that it's placed in the screen boundaries.
  I could easily reproduce by having the a vertical set up where the primary
  persistent screen is below. Disconnecting the screen above would call restore
  but leave the screen in the same position (with very big Y) but with the new
  width.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2812

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 38 lines] D2813: Readability. Simplify overly complex code

2016-09-19 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We have a big case because the size depend on whether the panel is vertical 
or horizontal
  but it doesn't really bring much.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2813

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 28 lines] D2827: Polish SwipeListItem

2016-09-21 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 6856.
apol added a comment.


  Reduce magic numbers

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2827?vs=6855=6856

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2827

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Updated] D2827: Polish SwipeListItem

2016-09-21 Thread apol (Aleix Pol Gonzalez) 
apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> mart wrote in SwipeListItem.qml:362
> what's the rationale for this?

Good point, fixed.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2827

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Closed] D2827: Polish SwipeListItem

2016-09-21 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
apol marked an inline comment as done.
Closed by commit rKIRIGAMIf90a5ca65f04: Polish SwipeListItem (authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2827?vs=6856=6857

REVISION DETAIL
  https://phabricator.kde.org/D2827

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

  1   2   3   >