[platform-dev] Eclipse an Equinox 4.28 M1 Reminder

[Rahul Mohanan via platform-dev]

Hello,

Next week is the milestone week for 4.28 M1.

Monday
- Last day of development, (and even then, no "big changes").
- After Monday 18:00 ET only regression fixes, no feature work or unrelated 
fixes.

Tuesday
- All-day test pass. Nobody should develop or fix anything.

Wednesday
- Fix day with a focus on fixing regressions found during the test day 
(Tuesday). No unrelated fixes. Review and thoroughly test all commits.
- The last Wednesday build is the release candidate every team signs off on 
Thursday.
- The "New and Noteworthy" entries are due on Wednesday evening.
- Git repo: 
https://github.com/eclipse-platform/www.eclipse.org-eclipse-news
- Live website: https://www.eclipse.org/eclipse/news/4.28/

Thursday
- Sign-off after re-testing, or at least confirming no changes have been made 
to your component's code since the last time the component was tested well.

Friday
- Build is officially declared and made available.
- The master branch stays closed until the milestone is officially released.

Thanks and Regards,

Rahul Mohanan
Software Developer
IBM ISL Kochi
Eclipse SDK Team
___
platform-dev mailing list
platform-dev@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/platform-dev

Re: [platform-dev] Review practice

[jkubitz-eclipse]

“The Committers of a Project or component decide which changes may be committed 
to the master code base of a Project or component respectively. Three +1 ('yes' 
votes) with no -1 ('no' votes or vetoes) are needed to approve a code change. 
Vetoes must be followed by an explanation for the veto within 24 hours or the 
veto becomes invalid. All votes are conducted via the developer mailing list 
associated with the Project or component.”

[1] https://www.eclipse.org/eclipse/eclipse-charter.php

 

While we barely find a single reviewer I suggest to wait that 24h if anybody 
wants to review before merging without a single reviewer.

Further I suggest, that the PMC clarifies such rule and updates that document 
to the current practice to clearly state that reviewtools (like gerrit/github) 
can be used instead of mailing list.

 

Jörg

 

 

___
platform-dev mailing list
platform-dev@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/platform-dev

Re: [platform-dev] Review practice

[Aleksandar Kurtakov]

On Thu, Mar 30, 2023 at 2:40 PM Sebastian Zarnekow <
sebastian.zarne...@gmail.com> wrote:

> Hi there,
>
> It might be my poor understanding of the current process, so I'm asking
> here on the mailing list:
>
> Are reviews a prerequisite for stuff that's supposed to be merged into
> platform?
>

Unfortunately, we are not in a position to have such a prereq (although I
would love this to be the case). Very few people do reviews and PRs stand
in the queue (https://github.com/pulls?user=eclipse-platform) longer than
acceptable thus the overall practice is that committers push things without
review when feeling comfortable about the stability of the patch. Of
course, this doesn't mean that things couldn't be done better or even that
there wouldn't be issues - it just means that's the only way to make
progress with current resources.
Help would be more than appreciated to review pending patches in the review
queue, agree on what "timely" reply/review means and eventually raise the
requirements.


>
> Best
> Sebastian
> ___
> platform-dev mailing list
> platform-dev@eclipse.org
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/platform-dev
>


-- 
Aleksandar Kurtakov
Red Hat Eclipse Team
___
platform-dev mailing list
platform-dev@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/platform-dev

Re: [platform-dev] Review practice

[Sebastian Zarnekow]

Hu there,

indeed I was surprised by this change to be merged without review
https://github.com/eclipse-platform/eclipse.platform.text/pull/175

I left comment after-the-fact here:
https://github.com/mickaelistria/eclipse.platform.text/commit/9515786e802f59563010d395caa90260bb65e95b

Would be good if someone could take a second look.

Best
Sebastian


On Thu, Mar 30, 2023 at 1:58 PM Hoepfner, Marcus via platform-dev <
platform-dev@eclipse.org> wrote:

> Why are you asking? Did you see a concrete issue in particular?
> I general I’d not commit without code review. I usually get helpful
> comments.
> And even it is just about a typo in Javadoc, it is worth it.
>
>
> A colleague once said, code review is kind of deferred pair programming. I
> like that, though it might not be 100% correct.
>
>
>
>
>
> On Thu, Mar 30, 2023 at 1:40 PM Sebastian Zarnekow <
> sebastian.zarne...@gmail.com> wrote:
>
> Hi there,
>
>
>
> It might be my poor understanding of the current process, so I'm asking
> here on the mailing list:
>
> Are reviews a prerequisite for stuff that's supposed to be merged into
> platform?
>
>
>
> A working build+test is usually a requirement. Peer reviews are not a
> prerequisite for committers, but it's still a good practice to get someone
> else to look at a patch before merging, even for committers. For
> non-committers, a review/approval from a committer is a requirement before
> a merge anyway.
>
> HTH
> ___
> platform-dev mailing list
> platform-dev@eclipse.org
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/platform-dev
>
___
platform-dev mailing list
platform-dev@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/platform-dev

Re: [platform-dev] Review practice

[Hoepfner, Marcus via platform-dev]

Why are you asking? Did you see a concrete issue in particular?
I general I’d not commit without code review. I usually get helpful comments.
And even it is just about a typo in Javadoc, it is worth it.

A colleague once said, code review is kind of deferred pair programming. I like 
that, though it might not be 100% correct.


On Thu, Mar 30, 2023 at 1:40 PM Sebastian Zarnekow 
mailto:sebastian.zarne...@gmail.com>> wrote:
Hi there,

It might be my poor understanding of the current process, so I'm asking here on 
the mailing list:
Are reviews a prerequisite for stuff that's supposed to be merged into platform?

A working build+test is usually a requirement. Peer reviews are not a 
prerequisite for committers, but it's still a good practice to get someone else 
to look at a patch before merging, even for committers. For non-committers, a 
review/approval from a committer is a requirement before a merge anyway.
HTH
___
platform-dev mailing list
platform-dev@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/platform-dev

Re: [platform-dev] Review practice

[Mickael Istria]

On Thu, Mar 30, 2023 at 1:40 PM Sebastian Zarnekow <
sebastian.zarne...@gmail.com> wrote:

> Hi there,
>
> It might be my poor understanding of the current process, so I'm asking
> here on the mailing list:
> Are reviews a prerequisite for stuff that's supposed to be merged into
> platform?
>

A working build+test is usually a requirement. Peer reviews are not a
prerequisite for committers, but it's still a good practice to get someone
else to look at a patch before merging, even for committers. For
non-committers, a review/approval from a committer is a requirement before
a merge anyway.
HTH
___
platform-dev mailing list
platform-dev@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/platform-dev

[platform-dev] Review practice

[Sebastian Zarnekow]

Hi there,

It might be my poor understanding of the current process, so I'm asking
here on the mailing list:

Are reviews a prerequisite for stuff that's supposed to be merged into
platform?

Best
Sebastian
___
platform-dev mailing list
platform-dev@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/platform-dev