Re: port using nodejs to build, binary in /tmp

2021-05-24 Thread Stephane Guedon
Le lundi 24 mai 2021 19:52:01 CEST, vous avez écrit :
> Stephane Guedon writes:
> > Hello
> > 
> > I am beginning to write a peertube port, just as a way to better
> > manage my instance. I don't know if it will succeed.
> > 
> > PeerTube uses nodejs and requires having the node binary in /tmp to
> > build its modules. Is there a way to deal with that or should I
> > write a "pre-build" target to copy/link node in the chroot phase ?
> 
> Is this yarn that is getting the node bin in /tmp? If so does the yarn
> from ports fix it?
> 
> The issue (likely) is that node expects to be able to determine it's
> exec path arbitrarily via `process.execPath`.
> 
> If you aren't using yarn, perhaps give it a shot (from pkg_add yarn).

I learned only recently of the yarn package. I have no idea if it was 
the actual problem. I did install yarn via npm. Later, when launching it 
in the node repository, it complained if node was not in /tmp.






Re: port using nodejs to build, binary in /tmp

2021-05-24 Thread Stephane Guedon
Le lundi 24 mai 2021, 18:24:36 CEST Stuart Henderson a écrit :
> On 2021/05/24 18:10, Stephane Guedon wrote:
> > Le lundi 24 mai 2021, 16:59:15 CEST Stuart Henderson a écrit :
> > > On 2021/05/24 15:25, Stephane Guedon wrote:
> > > > Hello
> > > > 
> > > > I am beginning to write a peertube port, just as a way to better
> > > > manage my instance. I don't know if it will succeed.
> > > > 
> > > > PeerTube uses nodejs and requires having the node binary in /tmp
> > > > to
> > > > build its modules. Is there a way to deal with that or should I
> > > > write a "pre-build" target to copy/link node in the chroot phase
> > > > ?
> > > > 
> > > > (I hope I understood the building process fine and that I make
> > > > myself
> > > > understood ok too.)
> > > > 
> > > > Thanks for help
> > > 
> > > It's not going to work, you can't rely on /tmp being mounted with
> > > "wxallowed".
> > 
> > Shouldn't the actual tmp repository being used during building be in
> > /usr/obj/ports/portname/something/tmp ... ? meaning in the /usr
> > partition, where it is normally allowed ?
> 
> Port build directories themselves can be expected to have wxallowed,
> but that doesn't fit with your software which requires the node binary
> in /tmp. (that seems a strange requirement in the first place; it's
> not all that uncommon to mount /tmp "noexec" even).

Ok, well, I am not the one who wrote the particular node module which 
requires that... Only that I wish to ease my own work (and maybe help 
other admins there).
 
> 
> Between this, and common requirement that dependencies are fetched
> with yarn/npm at build time (which is not permitted in ports; only
> the ports infrastructure itself may fetch from the network, the build
> process itself must only use files from disk), software written in
> node is not usually a viable candidate for adding to ports.

Ok, that part is also a breaking point, I guess that it makes it clear 
there won't be a port for PeerTube.

Thank you for explanation.




Re: port using nodejs to build, binary in /tmp

2021-05-24 Thread Stephane Guedon
Le lundi 24 mai 2021, 18:11:42 CEST Theo de Raadt a écrit :
> Stephane Guedon  wrote:
> > Le lundi 24 mai 2021, 16:59:15 CEST Stuart Henderson a écrit :
> > > On 2021/05/24 15:25, Stephane Guedon wrote:
> > > > Hello
> > > > 
> > > > I am beginning to write a peertube port, just as a way to better
> > > > manage my instance. I don't know if it will succeed.
> > > > 
> > > > PeerTube uses nodejs and requires having the node binary in /tmp
> > > > to
> > > > build its modules. Is there a way to deal with that or should I
> > > > write a "pre-build" target to copy/link node in the chroot phase
> > > > ?
> > > > 
> > > > (I hope I understood the building process fine and that I make
> > > > myself
> > > > understood ok too.)
> > > > 
> > > > Thanks for help
> > > 
> > > It's not going to work, you can't rely on /tmp being mounted with
> > > "wxallowed".
> > 
> > Shouldn't the actual tmp repository being used during building be in
> > /usr/obj/ports/portname/something/tmp ... ? meaning in the /usr
> > partition, where it is normally allowed ?
> 
> This latter part is incorrect, unless /usr/local is inside /usr,
> which happens only for small disks.
> 
> Won't help.

Ah Ok.

Thanks anyway...




Re: port using nodejs to build, binary in /tmp

2021-05-24 Thread Stephane Guedon
Le lundi 24 mai 2021, 16:59:15 CEST Stuart Henderson a écrit :
> On 2021/05/24 15:25, Stephane Guedon wrote:
> > Hello
> > 
> > I am beginning to write a peertube port, just as a way to better
> > manage my instance. I don't know if it will succeed.
> > 
> > PeerTube uses nodejs and requires having the node binary in /tmp to
> > build its modules. Is there a way to deal with that or should I
> > write a "pre-build" target to copy/link node in the chroot phase ?
> > 
> > (I hope I understood the building process fine and that I make
> > myself
> > understood ok too.)
> > 
> > Thanks for help
> 
> It's not going to work, you can't rely on /tmp being mounted with
> "wxallowed".

Shouldn't the actual tmp repository being used during building be in 
/usr/obj/ports/portname/something/tmp ... ? meaning in the /usr 
partition, where it is normally allowed ?





port using nodejs to build, binary in /tmp

2021-05-24 Thread Stephane Guedon
Hello

I am beginning to write a peertube port, just as a way to better manage 
my instance. I don't know if it will succeed.

PeerTube uses nodejs and requires having the node binary in /tmp to 
build its modules. Is there a way to deal with that or should I write a 
"pre-build" target to copy/link node in the chroot phase ?

(I hope I understood the building process fine and that I make myself 
understood ok too.)

Thanks for help 




upgrade port libvips to 8.10.0

2020-08-10 Thread Stephane Guedon
Hello all.

This is to tell about the port upgrade of libvips 8.10.0. To me it looks 
like it's just a little bump upgrade, therefor just updating the version 
number.

It builds fine for me.

Any comments ? Does it blocks for someone ?

Thanks and good day.

libvips-8.10.tar.gz
Description: application/compressed-tar


peertube rc script

2020-05-24 Thread Stephane Guedon
Good day people.

I have tried for a good period of time now to work out the writing of a 
good rc script to peertube (the P2P video sharing system). I have been 
advised by a fellow member of this community to ask for better advice 
here.

Technically, Peertube is actually a node process launch in a particular 
way. It comes with several parameters and has to be launched in a 
specific directory. This just makes it all the more fun. Or not.

Here is the current script as I wrote it :


#!/bin/ksh
daemon_user="_peertube"

HOME_DIR="/var/www/peertube"
CONF_DIR="${HOME_DIR}/config/"

daemon="HOME=${HOME_DIR} NODE_CONFIG_DIR=${CONF_DIR} \
NODE_ENV=production USER=${daemon_user} \
 /usr/local/bin/node ${HOME_DIR}/peertube-latest/dist/server"

. /etc/rc.d/rc.subr

daemon_timeout=60
rc_reload=NO

pexp="node"

rc_cmd $1

--

So first, rcctl cannot find its process back (when making rcctl check 
peertube, it just times out - the same when the process is started).

But I know it launches the thing.

Here is the peertube line in the list of processes :

_peertub 71223  0.0 12.5 125632 129388 p2  S+ 11:45PM   11:48.91 
node: peertube (node)



To had a layer of sophistication, it has to be launched in a 
subdirectory of its own installation.

It is installed in /var/www/peertube (which is $HOME_DIR in the script 
above), with configuration, video storage and logs around, but the 
software itself is in /var/www/peertube/versions/peertube-v-X.Y.Z and I 
create a synbolic link at each peertube upgrade to the new version. And 
so it has to be launched from that place. In order to achieve that, the 
_peertube user's home directory is set to /var/www/peertube/peertube-
latest/ (so the symbolic link target).

This is totally unorthodox I know, but I found no better way to do that.
I hope you have interesting comments.

Thanks for your attention.




Re: update to libvips 8.9.0

2020-02-09 Thread Stephane Guedon
Le samedi 1 février 2020, 15:43:59 CET Stuart Henderson a écrit :
> On 2020/02/01 10:06, Stephane Guedon wrote:
> > Le mercredi 29 janvier 2020, 22:20:25 CET Stuart Henderson a écrit :
> > > - either use the directory "vips", or name the package "libvips",
> > > just pick one or the other. "PKGNAME= lib${DISTNAME}" will do if
> > > you
> > > want libvips.
> > > 
> > > (if it's better known as a library then prefer "libvips", if it's
> > > better known for the tools then prefer just "vips").
> > > 
> > > - seems more like a port that should be in "graphics" rather than
> > > multimedia?
> > > 
> > > - the comment "# Dependencies" doesn't add anything that
> > > LIB_DEPENDS
> > > doesn't already say, please zap
> > > 
> > > - plist was generated on stable or old current, it should be
> > > udpated
> > > on -current (some of the files will get "@static-lib" markers)
> > > 
> > > - there are a number of unlisted dependencies that are picked up
> > > by configure if present at build time. these must either be
> > > disabled,
> > > or explicit dependencies added. at least one of these adds extra
> > > PLIST files (gir) and I get about 50 lines of output from "make
> > > port-lib-depends-check" for things which are either "NOT
> > > REACHABLE"
> > > (no LIB_DEPENDS to pull in the library) or just "Missing:" (where
> > > there is a dependency path but no WANTLIB entry for them).
> > > 
> > > libvips-8.9.0(graphics/libvips):
> > > Missing lib: Half-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT
> > > REACHABLE) Missing: ICE.11 (/usr/local/lib/libvips.so.0.0) (system
> > > lib) Missing lib: Iex-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT
> > > REACHABLE) Missing lib: IexMath-2_4.0
> > > (/usr/local/lib/libvips.so.0.0)
> > > (NOT REACHABLE) Missing lib: IlmImf-2_4.0
> > > (/usr/local/lib/libvips.so.0.0) (NOT REACHABLE) Missing lib:
> > > IlmThread-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT REACHABLE)
> > > Missing lib: Imath-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT
> > > REACHABLE) Missing lib: MagickCore-6.Q16.7
> > > (/usr/local/lib/libvips.so.0.0) (NOT REACHABLE) Missing: SM.9
> > > (/usr/local/lib/libvips.so.0.0) (system lib)
> > > Missing: X11.17 (/usr/local/lib/libvips.so.0.0) (system lib)
> > > Missing: Xext.13 (/usr/local/lib/libvips.so.0.0) (system lib)
> > > Missing: Xrender.6 (/usr/local/lib/libvips.so.0.0) (system lib)
> > > Missing: Xt.11 (/usr/local/lib/libvips.so.0.0) (system lib)
> > > Missing: bz2.10 from bzip2-1.0.8 (/usr/local/lib/libvips.so.0.0)
> > > Missing lib: cairo-gobject.2 (/usr/local/lib/libvips.so.0.0) (NOT
> > > REACHABLE) Missing lib: cairo.13 (/usr/local/lib/libvips.so.0.0)
> > > (NOT
> > > REACHABLE) Missing lib: djvulibre.26
> > > (/usr/local/lib/libvips.so.0.0)
> > > (NOT REACHABLE) <..snip..>
> > > 
> > > and an excerpt from the configure check showing the sort of things
> > > you're looking for in there, all various things where there's a
> > > check
> > > which doesn't find the relevant dependency, decide whether you
> > > want
> > > to list the dependency or add the relevant CONFIGURE_ARGS line to
> > > disable it.
> > > 
> > > checking for IceConnectionNumber in -lICE... (cached) yes
> > > checking for NIFTI... libraries (none), headers (none)
> > > checking for HEIF... no
> > > configure: WARNING: libheif not found; disabling HEIF support
> > > checking for PDFIUM... libraries (none), headers (none)
> > > checking for POPPLER... yes
> > > checking for RSVG... yes
> > > checking for ZLIB... yes
> > > checking for OPENSLIDE... no
> > > configure: OpenSlide >= 3.4.0 not found; checking for >= 3.3.0
> > > checking for OPENSLIDE... no
> > > configure: WARNING: OpenSlide >= 3.3.0 not found; disabling
> > > virtual
> > > slide support checking for MATIO... no
> > > configure: WARNING: matio not found; disabling matio support
> > > checking for CFITSIO... no
> > > configure: WARNING: cfitsio not found; disabling cfitsio support
> > > checking for LIBWEBP... yes
> > > checking for PANGOFT2... yes
> > > checking for TIFF... yes
> > > checking whether COMPRESSION_WEBP is declared..

Re: update to libvips 8.9.0

2020-02-09 Thread Stephane Guedon
Le samedi 1 février 2020, 15:43:59 CET Stuart Henderson a écrit :
> On 2020/02/01 10:06, Stephane Guedon wrote:
> > Le mercredi 29 janvier 2020, 22:20:25 CET Stuart Henderson a écrit :
> > > - either use the directory "vips", or name the package "libvips",
> > > just pick one or the other. "PKGNAME= lib${DISTNAME}" will do if
> > > you
> > > want libvips.
> > > 
> > > (if it's better known as a library then prefer "libvips", if it's
> > > better known for the tools then prefer just "vips").
> > > 
> > > - seems more like a port that should be in "graphics" rather than
> > > multimedia?
> > > 
> > > - the comment "# Dependencies" doesn't add anything that
> > > LIB_DEPENDS
> > > doesn't already say, please zap
> > > 
> > > - plist was generated on stable or old current, it should be
> > > udpated
> > > on -current (some of the files will get "@static-lib" markers)
> > > 
> > > - there are a number of unlisted dependencies that are picked up
> > > by configure if present at build time. these must either be
> > > disabled,
> > > or explicit dependencies added. at least one of these adds extra
> > > PLIST files (gir) and I get about 50 lines of output from "make
> > > port-lib-depends-check" for things which are either "NOT
> > > REACHABLE"
> > > (no LIB_DEPENDS to pull in the library) or just "Missing:" (where
> > > there is a dependency path but no WANTLIB entry for them).
> > > 
> > > libvips-8.9.0(graphics/libvips):
> > > Missing lib: Half-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT
> > > REACHABLE) Missing: ICE.11 (/usr/local/lib/libvips.so.0.0) (system
> > > lib) Missing lib: Iex-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT
> > > REACHABLE) Missing lib: IexMath-2_4.0
> > > (/usr/local/lib/libvips.so.0.0)
> > > (NOT REACHABLE) Missing lib: IlmImf-2_4.0
> > > (/usr/local/lib/libvips.so.0.0) (NOT REACHABLE) Missing lib:
> > > IlmThread-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT REACHABLE)
> > > Missing lib: Imath-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT
> > > REACHABLE) Missing lib: MagickCore-6.Q16.7
> > > (/usr/local/lib/libvips.so.0.0) (NOT REACHABLE) Missing: SM.9
> > > (/usr/local/lib/libvips.so.0.0) (system lib)
> > > Missing: X11.17 (/usr/local/lib/libvips.so.0.0) (system lib)
> > > Missing: Xext.13 (/usr/local/lib/libvips.so.0.0) (system lib)
> > > Missing: Xrender.6 (/usr/local/lib/libvips.so.0.0) (system lib)
> > > Missing: Xt.11 (/usr/local/lib/libvips.so.0.0) (system lib)
> > > Missing: bz2.10 from bzip2-1.0.8 (/usr/local/lib/libvips.so.0.0)
> > > Missing lib: cairo-gobject.2 (/usr/local/lib/libvips.so.0.0) (NOT
> > > REACHABLE) Missing lib: cairo.13 (/usr/local/lib/libvips.so.0.0)
> > > (NOT
> > > REACHABLE) Missing lib: djvulibre.26
> > > (/usr/local/lib/libvips.so.0.0)
> > > (NOT REACHABLE) <..snip..>
> > > 
> > > and an excerpt from the configure check showing the sort of things
> > > you're looking for in there, all various things where there's a
> > > check
> > > which doesn't find the relevant dependency, decide whether you
> > > want
> > > to list the dependency or add the relevant CONFIGURE_ARGS line to
> > > disable it.
> > > 
> > > checking for IceConnectionNumber in -lICE... (cached) yes
> > > checking for NIFTI... libraries (none), headers (none)
> > > checking for HEIF... no
> > > configure: WARNING: libheif not found; disabling HEIF support
> > > checking for PDFIUM... libraries (none), headers (none)
> > > checking for POPPLER... yes
> > > checking for RSVG... yes
> > > checking for ZLIB... yes
> > > checking for OPENSLIDE... no
> > > configure: OpenSlide >= 3.4.0 not found; checking for >= 3.3.0
> > > checking for OPENSLIDE... no
> > > configure: WARNING: OpenSlide >= 3.3.0 not found; disabling
> > > virtual
> > > slide support checking for MATIO... no
> > > configure: WARNING: matio not found; disabling matio support
> > > checking for CFITSIO... no
> > > configure: WARNING: cfitsio not found; disabling cfitsio support
> > > checking for LIBWEBP... yes
> > > checking for PANGOFT2... yes
> > > checking for TIFF... yes
> > > checking whether COMPRESSION_WEBP is declared..

Re: update to libvips 8.9.0

2020-02-01 Thread Stephane Guedon
Le mercredi 29 janvier 2020, 22:20:25 CET Stuart Henderson a écrit :
> - either use the directory "vips", or name the package "libvips",
> just pick one or the other. "PKGNAME= lib${DISTNAME}" will do if you
> want libvips.
> 
> (if it's better known as a library then prefer "libvips", if it's
> better known for the tools then prefer just "vips").
> 
> - seems more like a port that should be in "graphics" rather than
> multimedia?
> 
> - the comment "# Dependencies" doesn't add anything that LIB_DEPENDS
> doesn't already say, please zap
> 
> - plist was generated on stable or old current, it should be udpated
> on -current (some of the files will get "@static-lib" markers)
> 
> - there are a number of unlisted dependencies that are picked up
> by configure if present at build time. these must either be disabled,
> or explicit dependencies added. at least one of these adds extra
> PLIST files (gir) and I get about 50 lines of output from "make
> port-lib-depends-check" for things which are either "NOT REACHABLE"
> (no LIB_DEPENDS to pull in the library) or just "Missing:" (where
> there is a dependency path but no WANTLIB entry for them).
> 
> libvips-8.9.0(graphics/libvips):
> Missing lib: Half-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT
> REACHABLE) Missing: ICE.11 (/usr/local/lib/libvips.so.0.0) (system
> lib) Missing lib: Iex-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT
> REACHABLE) Missing lib: IexMath-2_4.0 (/usr/local/lib/libvips.so.0.0)
> (NOT REACHABLE) Missing lib: IlmImf-2_4.0
> (/usr/local/lib/libvips.so.0.0) (NOT REACHABLE) Missing lib:
> IlmThread-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT REACHABLE)
> Missing lib: Imath-2_4.0 (/usr/local/lib/libvips.so.0.0) (NOT
> REACHABLE) Missing lib: MagickCore-6.Q16.7
> (/usr/local/lib/libvips.so.0.0) (NOT REACHABLE) Missing: SM.9
> (/usr/local/lib/libvips.so.0.0) (system lib)
> Missing: X11.17 (/usr/local/lib/libvips.so.0.0) (system lib)
> Missing: Xext.13 (/usr/local/lib/libvips.so.0.0) (system lib)
> Missing: Xrender.6 (/usr/local/lib/libvips.so.0.0) (system lib)
> Missing: Xt.11 (/usr/local/lib/libvips.so.0.0) (system lib)
> Missing: bz2.10 from bzip2-1.0.8 (/usr/local/lib/libvips.so.0.0)
> Missing lib: cairo-gobject.2 (/usr/local/lib/libvips.so.0.0) (NOT
> REACHABLE) Missing lib: cairo.13 (/usr/local/lib/libvips.so.0.0) (NOT
> REACHABLE) Missing lib: djvulibre.26 (/usr/local/lib/libvips.so.0.0)
> (NOT REACHABLE) <..snip..>
> 
> and an excerpt from the configure check showing the sort of things
> you're looking for in there, all various things where there's a check
> which doesn't find the relevant dependency, decide whether you want
> to list the dependency or add the relevant CONFIGURE_ARGS line to
> disable it.
> 
> checking for IceConnectionNumber in -lICE... (cached) yes
> checking for NIFTI... libraries (none), headers (none)
> checking for HEIF... no
> configure: WARNING: libheif not found; disabling HEIF support
> checking for PDFIUM... libraries (none), headers (none)
> checking for POPPLER... yes
> checking for RSVG... yes
> checking for ZLIB... yes
> checking for OPENSLIDE... no
> configure: OpenSlide >= 3.4.0 not found; checking for >= 3.3.0
> checking for OPENSLIDE... no
> configure: WARNING: OpenSlide >= 3.3.0 not found; disabling virtual
> slide support checking for MATIO... no
> configure: WARNING: matio not found; disabling matio support
> checking for CFITSIO... no
> configure: WARNING: cfitsio not found; disabling cfitsio support
> checking for LIBWEBP... yes
> checking for PANGOFT2... yes
> checking for TIFF... yes
> checking whether COMPRESSION_WEBP is declared... no
> checking for giflib... libraries -L/usr/local/lib -lgif, headers
> -I/usr/local/include checking for PNG... yes
> checking for png_set_chunk_malloc_max... yes
> checking for IMAGEQUANT... no
> configure: WARNING: libimagequant not found; disabling 8bpp PNG
> support checking for JPEG... yes
> checking for jpeg_c_bool_param_supported... no
> checking for EXIF... yes
> checking exif-data.h usability... yes
> checking exif-data.h presence... yes
> checking for exif-data.h... yes
> 
> Tip: if you're doing various rebuilds while working on disabling
> things etc, building with USE_CCACHE=Yes (set in mk.conf or on the
> make command-line) will save you a bunch of time.

Hello. Here is a new try after that I tried to apply your advices. Let 
me know what you think.

I disabled some optional dependencies and placed the port in graphics 
notably.


libvips.8.9.1.tar.gz
Description: application/compressed-tar


libvips.8.9.1

2020-01-29 Thread Stephane Guedon
Just as I got validated for libvips 8.9.0, a new version came out, 
namely 8.9.1, so here it is.

comments ?

libvips.8.9.1.tar.gz
Description: application/compressed-tar


Re: update to libvips 8.9.0

2020-01-26 Thread Stephane Guedon
Le samedi 25 janvier 2020, 17:12:19 CET Denis Fondras a écrit :

> Almost here.  Remove remaining PLIST.orig and then you are good :)

Crossing fingers that I did not forget anything more... :D

Thank you all for guidance.

libvips.8.9.0.tar.gz
Description: application/compressed-tar


Re: update to libvips 8.9.0

2020-01-22 Thread Stephane Guedon
Le mardi 21 janvier 2020 11:45:39 CET, vous avez écrit :
> On Mon, Jan 20, 2020 at 10:43:49PM +0100, Stephane Guedon wrote:
> > > In Makefile :
> > > - SHARED_LIBS should start at 0.0
> > > - LIB_DEPENDS should be one dep per line
> > > 
> > > Also pkg/DESCR is shorter, any reason why ?
> > 
> > Mistake happened. Apologies.
> 
> No worries :)
> 
> It seems you did not update PLIST.
> Also it would be better to indent "\" in Makefile.
> 
> Thank you

I thought I did the plist thing already. Sorry :)


libvips.8.9.0.tar.gz
Description: application/compressed-tar


Re: update to libvips 8.9.0

2020-01-20 Thread Stephane Guedon
Le lundi 20 janvier 2020 09:13:52 CET, vous avez écrit :
> On Sun, Jan 19, 2020 at 11:00:03PM +0100, Stephane Guedon wrote:
> > > It seem you haven't updated the latest Makefile.
> > 
> > Yes I did : newest version number, checked with it.
> > 
> > All I see to miss is maybe my name as maintainer.
> > Do I miss more ?
> 
> In Makefile :
> - SHARED_LIBS should start at 0.0
> - LIB_DEPENDS should be one dep per line
> 
> Also pkg/DESCR is shorter, any reason why ?

Mistake happened. Apologies.



libvips.8.9.0.tar.gz
Description: application/compressed-tar


Re: update to libvips 8.9.0

2020-01-19 Thread Stephane Guedon
Le dimanche 19 janvier 2020, 20:27:53 CET Denis Fondras a écrit :
> On Sun, Jan 19, 2020 at 05:50:28PM +0100, Stephane Guedon wrote:
> > Hello members of ports@.
> > 
> > Here is my update of libvips port with Denis @ledeuns' patch
> > integrated upstream.
> 
> Credits go to tb@ :)

So he shall have. :)

> 
> It seem you haven't updated the latest Makefile.

Yes I did : newest version number, checked with it.

All I see to miss is maybe my name as maintainer.
Do I miss more ?
 
> 
> Denis






update to libvips 8.9.0

2020-01-19 Thread Stephane Guedon
Hello members of ports@.

Here is my update of libvips port with Denis @ledeuns' patch integrated 
upstream.

What do you think ?

Thanks 

libvips.8.9.0.tar.gz
Description: application/compressed-tar


Re: libvips 8.8.4

2019-12-30 Thread Stephane Guedon
Le dimanche 29 décembre 2019, 23:56:57 CET Theo Buehler a écrit :
> > That's a problem on my side, I will sort it and retry.
> 
> This diff fixes it:
> 
> Index: libvips/iofuncs/init.c
> --- libvips/iofuncs/init.c.orig
> +++ libvips/iofuncs/init.c
> @@ -858,7 +858,7 @@ extract_prefix( const char *dir, const char *name
> ) for( i = 0; i < (int) strlen( vname ); i++ )
>   if( vips_isprefix( G_DIR_SEPARATOR_S "." 
G_DIR_SEPARATOR_S,
>   vname + i ) )
> - memcpy( vname + i, vname + i + 2,
> + memmove( vname + i, vname + i + 2,
>   strlen( vname + i + 2 ) + 1 );
>   if( vips_ispostfix( vname, G_DIR_SEPARATOR_S "." ) )
>   vname[strlen( vname ) - 2] = '\0';

I think I should not integrate it in the port, right ? I can build the 
port on my own.




Re: libvips 8.8.4

2019-12-29 Thread Stephane Guedon
Le dimanche 29 décembre 2019, 19:21:40 CET Stuart Henderson a écrit :
> On 2019/12/29 16:35, Denis Fondras wrote:
> > On Sun, Dec 29, 2019 at 01:28:24PM +0100, Stephane Guedon wrote:
> > > You will find here an update for my port for libvips. It is, among
> > > other things, a dependency to PeerTube.
> > > 
> > > I welcome any comment on the port as I am learning it. I am still
> > > ok to be the maintainer or to let it to a person of more skills
> > > than me. :)
> > Thank you Stephane.
> > 
> > You missed step 17 of
> > https://www.openbsd.org/faq/ports/guide.html#PortsChecklist. You
> > can also add yourself as MAINTAINER.

Ok, done.

> > You can check with /usr/ports/infrastructure/bin/portcheck.

Just did.

> > 
> > I am not a port expert but these lines look wrong :
> > SHARED_LIBS +=  vips 0.1   # 53.1
> > SHARED_LIBS +=  vips-cpp 0.1# 53.1
> 
> yep, please start at 0.0,

It was what I did first time. But I guess it starts only when the port is 
in the tree. :) So it's back to 0.0.

> also please split LIB_DEPENDS out to
> one-per-line i.e.
> 
> LIB_DEPENDS =   devel/glib2 \
> graphics/png \
> [...]

Done.

> > Apart from this, it works great on amd64. I am OK to import when
> > these are fixed.

Thank you for the advices

libvips-8.8.4.tar.gz
Description: application/compressed-tar


libvips 8.8.4

2019-12-29 Thread Stephane Guedon
Hello

You will find here an update for my port for libvips. It is, among other 
things, a dependency to PeerTube.

I welcome any comment on the port as I am learning it. I am still ok to 
be the maintainer or to let it to a person of more skills than me. :) 

This update is just an update to the last release. A new release (8.9.0) 
is supposed to come soonish according to the developer's webpage.

I wish you all a happy new year.

libvips-8.8.4.tar.gz
Description: application/compressed-tar


multimedia/libvips 8.8.3

2019-09-25 Thread Stephane Guedon
Hello

I updated the libvips port to 8.8.3 and tried to integrate your comments 
from last times (notably what I think to be generic dependencies for 
this lib').

Could this be integrated ? I propose myself as maintainer.

Thank you.

libvips.tar.gz
Description: application/compressed-tar


Re: port libvips

2019-09-15 Thread Stephane Guedon
Le mercredi 11 septembre 2019, 23:30:30 CEST Stuart Henderson a écrit :


> > > 
> > > Please add "COMPILER = base-clang ports-gcc" since some C++ code
> > > is
> > > built.
> > > 
> > > I suspect devel/glib2 should be in LIB_DEPENDS and not
> > > RUN_DEPENDS.
> > > 
> > > 
> > > See ./configure --help, all optional dependencies (see below) you
> > > don't want should be disabled explicitely with --without-.
> > > "CONFIGURE_ARGS = --without-foo ..."
> > > Generally speaking all the libraries you want to use should be
> > > listed
> > > in LIB_DEPENDS (then don't forget to regen WANTLIB).
> > 
> > Thing is... I don't care for those. But I think the users might.
> > Will
> > they want or not to use cairo ? PNG ? JPG ? It should be for them to
> > choose. No ? (I see things this way). Or should I make flavours ? I
> > am not sure. :)
> 
> OpenBSD ports typically do things one of two ways:
> 
> 1 (most common), pick a sane set of dependencies and avoid the
> options. Things that will already be installed on a typical system
> of a user who would use the software.
> 
> 2 (I don't think this applies to libvips), in some cases there is a
> 'modular' build where the code relying on optional dependencies are
> kept in a separate file (executable or .so module), in this case
> sometimes the port will build a wide set but split the less common
> ones off to subpackages.
> 
> Sometimes a port will have multiple flavours but this is relatively
> uncommon as it's a pain to test, upgrade, and with interactions with
> other ports, especially for a library.
> 
> > The port builds well like that, auto detection of libraries and
> > such,
> > and for what I can see, no problem running.
> 
> The main purpose of having a port in OpenBSD is so that packages can
> be built, and those packages should not vary depending on what
> software is installed on the machine at the time. For faster arches
> we do snapshot package builds of the entire ports tree 5+ times a
> week and the set of packages installed on the system will change from
> build to build (and maybe removed at any time during the build, aka
> "junked", unless they are recorded as a dependency in the port). So
> these need to either be listed explicitly or disabled.
> 
> 
> SHARED_LIBS +=  vips 53.1 # 53.1
> SHARED_LIBS +=  vips-cpp 53.1 # 53.1
> 
> upstream's original version number (from shared_libs.log etc) should
> be kept in the comment, but the version number actually used by the
> port should start at 0.0. see
> www.openbsd.org/faq/ports/specialtopics.html about control of shared
> library versions.

Is it better ? :)

Thanks for help and comments


libvips.tar.gz
Description: application/compressed-tar


Re: port libvips

2019-09-11 Thread Stephane Guedon
Le lundi 9 septembre 2019, 22:57:07 CEST Jeremie Courreges-Anglas a 
écrit :
> On Sun, Sep 08 2019, Stephane Guedon  
wrote:
> > Good day
> > 
> > This is the first time I mail this mailing list. I hope not the last
> > time.
> > 
> > I have managed to make PeerTube run on my OpenBSD 6.6 beta home
> > server, so I wish to try to propose a port for it. But first,
> > PeerTube has libvips as a dependency, which is not in ports. So as
> > a training for a much harder thing, here is my proposed port of
> > libvips-8.8.2, which I have been able to build on said server via
> > the port system.
> > 
> > Vips is a fast image processing library, and as a result, I put it
> > in
> > multimedia category.
> > 
> > The library has some optional dependencies (it can support quite a
> > lot of image formats if you have support libraries on the machine).
> > Which I don't really know how to indicate.
> 
> Please add "COMPILER = base-clang ports-gcc" since some C++ code is
> built.
> 
> I suspect devel/glib2 should be in LIB_DEPENDS and not RUN_DEPENDS.
> 
> I would strip "libvips is licensed under the LGPL 2.1+." from DESCR.
> 
> See ./configure --help, all optional dependencies (see below) you
> don't want should be disabled explicitely with --without-.
> "CONFIGURE_ARGS = --without-foo ..."
> Generally speaking all the libraries you want to use should be listed
> in LIB_DEPENDS (then don't forget to regen WANTLIB).

Thing is... I don't care for those. But I think the users might. Will 
they want or not to use cairo ? PNG ? JPG ? It should be for them to 
choose. No ? (I see things this way). Or should I make flavours ? I am 
not sure. :)

The port builds well like that, auto detection of libraries and such, 
and for what I can see, no problem running.

> Please clean up the Makefile, there's a lot of stuff commented out
> that isn't useful. :)

Yeah, that's because I wanted to keep maximum of the template's 
comments.

But appart, I just incorporated your comments, and the build still runs 
fine. No trouble (no surprise here).


libvips.tar.gz
Description: application/compressed-tar


port libvips

2019-09-08 Thread Stephane Guedon
Good day

This is the first time I mail this mailing list. I hope not the last 
time.

I have managed to make PeerTube run on my OpenBSD 6.6 beta home server, 
so I wish to try to propose a port for it. But first, PeerTube has 
libvips as a dependency, which is not in ports. So as a training for a 
much harder thing, here is my proposed port of libvips-8.8.2, which I 
have been able to build on said server via the port system.

Vips is a fast image processing library, and as a result, I put it in 
multimedia category.

The library has some optional dependencies (it can support quite a lot 
of image formats if you have support libraries on the machine). Which I 
don't really know how to indicate.

I am waiting for comments.


libvips.tar.gz
Description: application/compressed-tar