Re: [NEW] devel/ninja
On Thu, May 2, 2013 at 11:12 AM, Matthew Dempsky wrote: > On Thu, May 2, 2013 at 12:40 AM, David Coppa wrote: >> Python is only needed for building ninja, so I've added MODPY_RUNDEP=No. > > No, it's needed at run time too for the "ninja -t browse" functionality too. Ah... Didn't spot this. Ok then. >> patch-bootstrap_py is not needed, 'cause ninja only wants libc, >> libm and libstdc++ that come all from base. > > Ok by me. For the regress tests, it wants to build/link against > gtest, but I didn't try to wire that up to the Makefile. > >> I've added a patch 'patch-src_util_cc' to get the number of cpus >> on OpenBSD too (just a couple of extra #ifdefs, the code is the >> same as for FreeBSD). > > I don't think that's necessary. We already support > sysconf(_SC_NPROCESSORS_ONLN), which is implemented by just grabbing > the hw.ncpu sysctl anyway. ok. So, ok dcoppa@ to import this. Thanks, David
Re: [NEW] devel/ninja
On Thu, May 2, 2013 at 2:21 AM, David Coppa wrote: > Ah... Didn't spot this. No problem. I almost didn't notice it either until I decided to run "grep python src/*.cc". :) > So, ok dcoppa@ to import this. Thanks, I'll import it tomorrow then. It's too late for me to risk a botched cvs import right now. :)
Re: [NEW] devel/ninja
On Thu, May 2, 2013 at 12:40 AM, David Coppa wrote: > Python is only needed for building ninja, so I've added MODPY_RUNDEP=No. No, it's needed at run time too for the "ninja -t browse" functionality too. > patch-bootstrap_py is not needed, 'cause ninja only wants libc, > libm and libstdc++ that come all from base. Ok by me. For the regress tests, it wants to build/link against gtest, but I didn't try to wire that up to the Makefile. > I've added a patch 'patch-src_util_cc' to get the number of cpus > on OpenBSD too (just a couple of extra #ifdefs, the code is the > same as for FreeBSD). I don't think that's necessary. We already support sysconf(_SC_NPROCESSORS_ONLN), which is implemented by just grabbing the hw.ncpu sysctl anyway.
Re: [NEW] devel/ninja
On 2013/05/02 09:40, David Coppa wrote:
> On Wed, 01 May 2013, Matthew Dempsky wrote:
>
> > On Wed, May 01, 2013 at 03:24:25PM -0700, Matthew Dempsky wrote:
> > > Attached is a port of the Ninja build system:
> > > http://martine.github.io/ninja/
> >
> > D'oh, attached for real this time...
>
> Hi!
>
> Just some comments:
>
> Python is only needed for building ninja, so I've added MODPY_RUNDEP=No.
>
> I've fixed some paths to the python interpreter using MODPY_ADJ_FILES.
>
> patch-bootstrap_py is not needed, 'cause ninja only wants libc,
> libm and libstdc++ that come all from base.
>
> I've added a patch 'patch-src_util_cc' to get the number of cpus
> on OpenBSD too (just a couple of extra #ifdefs, the code is the
> same as for FreeBSD).
>
>
> Ciao,
> David
Sigh, another project who don't make proper releases and rely on
on-the-fly generated distfiles... v1.2.0.tar.gz is not suitable as a
filename - if upstream won't make proper releases then either
mirror it or use this hack:
V = 1.2.0
DISTNAME = ninja-$V
MASTER_SITES =
https://github.com/martine/ninja/archive/v$V.tar.gz?bleh=/
(will also need to regen distinfo).
Also it should honour CXX rather than hardcode g++:
MAKE_ENV = CXX="${CXX}"
I don't have a new enough system handy to finish testing right now
but if it works for you with these changes then OK with me.
Re: [NEW] devel/ninja
On Thu, May 2, 2013 at 9:40 AM, David Coppa wrote: > On Wed, 01 May 2013, Matthew Dempsky wrote: > >> On Wed, May 01, 2013 at 03:24:25PM -0700, Matthew Dempsky wrote: >> > Attached is a port of the Ninja build system: >> > http://martine.github.io/ninja/ >> >> D'oh, attached for real this time... > > Hi! > > Just some comments: > > Python is only needed for building ninja, so I've added MODPY_RUNDEP=No. > > I've fixed some paths to the python interpreter using MODPY_ADJ_FILES. > > patch-bootstrap_py is not needed, 'cause ninja only wants libc, > libm and libstdc++ that come all from base. > > I've added a patch 'patch-src_util_cc' to get the number of cpus > on OpenBSD too (just a couple of extra #ifdefs, the code is the > same as for FreeBSD). P.S.: I've just tested it with "cmake -G Ninja" and it works fine.
Re: [NEW] devel/ninja
On Wed, 01 May 2013, Matthew Dempsky wrote: > On Wed, May 01, 2013 at 03:24:25PM -0700, Matthew Dempsky wrote: > > Attached is a port of the Ninja build system: > > http://martine.github.io/ninja/ > > D'oh, attached for real this time... Hi! Just some comments: Python is only needed for building ninja, so I've added MODPY_RUNDEP=No. I've fixed some paths to the python interpreter using MODPY_ADJ_FILES. patch-bootstrap_py is not needed, 'cause ninja only wants libc, libm and libstdc++ that come all from base. I've added a patch 'patch-src_util_cc' to get the number of cpus on OpenBSD too (just a couple of extra #ifdefs, the code is the same as for FreeBSD). Ciao, David ninja_2.tar.gz Description: application/tar-gz
Re: [NEW] devel/ninja
On Wed, May 01, 2013 at 03:24:25PM -0700, Matthew Dempsky wrote: > Attached is a port of the Ninja build system: http://martine.github.io/ninja/ D'oh, attached for real this time... ninja.tar.gz Description: application/tar-gz
[NEW] devel/ninja
Attached is a port of the Ninja build system: http://martine.github.io/ninja/ It needs ppoll() support, so you'll need to test with a recent release snapshot containing libc.so.68.1. The patches to add OpenBSD support have already been merged upstream (https://github.com/martine/ninja/pull/565), so they'll be included in the next upstream release. ok? $ cat pkg/DESCR Ninja is a small build system with a focus on speed.
