Re: [NEW] devel/p5-Data-SExpression

[attila]

Jeremie Courreges-Anglas  writes:

> Andrew Fresh  writes:
>
>> On Mon, Dec 26, 2016 at 11:51:32AM -0600, attila wrote:
>>> 
>>> attila  writes:
>>> 
>>> > attila  writes:
>>> >
>>> >> Hi ports@,
>>> >>
>>> >> Attached is a port for the Data::SExpression Perl module.  It is a
>>> >> dependency of the Perl interface I recently contributed to mail/mu
>>> >> upstream, and which will be coming down the pike in some new mu
>>> >> release fairly soon.
>>> >>
>>> >> $ cat pkg/DESCR
>>> >> Data::SExpression is a Perl module that parses LISP-like
>>> >> S-expressions into Perl data structures.
>>> >>
>>> >> Passes make test on i386.
>>
>> Also on amd64, if it is in the "cpan" directory.
>>
>>
>>> >> Comments, feedback most welcome.
>>
>> There is no "cpan" category, need to pick one.  Perhaps devel, or
>> textproc?
>
> Tough.  I'd choose devel/ because the output is perl data structures,
> and because considering s-expressions as text seems far-stretched to me.
> But then, most ports dealing with XML are under textproc/...  your call.
>
>> Don't start off the COMMENT with a capital letter unless it is
>> semantically important (like the COMMENT is the expansion of an acronym
>> or somesuch).  
>>
>> You should add yourself as maintainer if you are interested in that.
>>
>> Should add a test dependency on devel/p5-Test-Memory-Cycle to avoid
>> skipping tests.
>
> Test-Deep should probably go in TEST_DEPENDS instead of BUILD_DEPENDS,
> it's not needed to build the package.
>
>> Some of the newlines in the Makefile can go away.
>>
>> Other than that, it looks OK to me.
>
> Same here.  With the issues above addressed, ok jca@

Thanks a lot for the feedback.  Attached is a revised port that I
believe addresses all concerns raised.  Passes tests on amd64.

Pax, -A
--
https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net}
pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D  09C1 4068 D5D5 62A7 29CF


p5-Data-SExpression-bis.tgz
Description: updated port of Data::SExpression

Re: [NEW] devel/p5-Data-SExpression

[Jeremie Courreges-Anglas]

Andrew Fresh  writes:

> On Mon, Dec 26, 2016 at 11:51:32AM -0600, attila wrote:
>> 
>> attila  writes:
>> 
>> > attila  writes:
>> >
>> >> Hi ports@,
>> >>
>> >> Attached is a port for the Data::SExpression Perl module.  It is a
>> >> dependency of the Perl interface I recently contributed to mail/mu
>> >> upstream, and which will be coming down the pike in some new mu
>> >> release fairly soon.
>> >>
>> >> $ cat pkg/DESCR
>> >> Data::SExpression is a Perl module that parses LISP-like
>> >> S-expressions into Perl data structures.
>> >>
>> >> Passes make test on i386.
>
> Also on amd64, if it is in the "cpan" directory.
>
>
>> >> Comments, feedback most welcome.
>
> There is no "cpan" category, need to pick one.  Perhaps devel, or
> textproc?

Tough.  I'd choose devel/ because the output is perl data structures,
and because considering s-expressions as text seems far-stretched to me.
But then, most ports dealing with XML are under textproc/...  your call.

> Don't start off the COMMENT with a capital letter unless it is
> semantically important (like the COMMENT is the expansion of an acronym
> or somesuch).  
>
> You should add yourself as maintainer if you are interested in that.
>
> Should add a test dependency on devel/p5-Test-Memory-Cycle to avoid
> skipping tests.

Test-Deep should probably go in TEST_DEPENDS instead of BUILD_DEPENDS,
it's not needed to build the package.

> Some of the newlines in the Makefile can go away.
>
> Other than that, it looks OK to me.

Same here.  With the issues above addressed, ok jca@

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Re: [NEW] devel/p5-Data-SExpression

[Andrew Fresh]

On Mon, Dec 26, 2016 at 11:51:32AM -0600, attila wrote:
> 
> attila  writes:
> 
> > attila  writes:
> >
> >> Hi ports@,
> >>
> >> Attached is a port for the Data::SExpression Perl module.  It is a
> >> dependency of the Perl interface I recently contributed to mail/mu
> >> upstream, and which will be coming down the pike in some new mu
> >> release fairly soon.
> >>
> >> $ cat pkg/DESCR
> >> Data::SExpression is a Perl module that parses LISP-like
> >> S-expressions into Perl data structures.
> >>
> >> Passes make test on i386.

Also on amd64, if it is in the "cpan" directory.


> >> Comments, feedback most welcome.

There is no "cpan" category, need to pick one.  Perhaps devel, or
textproc?

Don't start off the COMMENT with a capital letter unless it is
semantically important (like the COMMENT is the expansion of an acronym
or somesuch).  

You should add yourself as maintainer if you are interested in that.

Should add a test dependency on devel/p5-Test-Memory-Cycle to avoid
skipping tests.

Some of the newlines in the Makefile can go away.

Other than that, it looks OK to me.

l8rZ,
-- 
andrew - http://afresh1.com

Full-time system administration is a delicate balance 
between proactiveness and laziness.
  --  jhorwitz from use.perl.org

Re: [NEW] devel/p5-Data-SExpression

[attila]

attila  writes:

> attila  writes:
>
>> Hi ports@,
>>
>> Attached is a port for the Data::SExpression Perl module.  It is a
>> dependency of the Perl interface I recently contributed to mail/mu
>> upstream, and which will be coming down the pike in some new mu
>> release fairly soon.
>>
>> $ cat pkg/DESCR
>> Data::SExpression is a Perl module that parses LISP-like
>> S-expressions into Perl data structures.
>>
>> Passes make test on i386.
>>
>> Comments, feedback most welcome.
>>
>> Pax, -A
>
> Ping?  Port attached.

Belated reping with updated port attached, this time done via portgen
(which I did not know about the first time).  Same logic behind
submitting it: dependency needed for mail/mu Perl interface, which has
now been released upstream.

>
> Pax, -A

Feedback, comments, criticism most welcome.

Pax, -A
--
https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net}
pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D  09C1 4068 D5D5 62A7 29CF


p5-Data-SExpression.tgz
Description: devel/p5-Data-SExpression

Re: [NEW] devel/p5-Data-SExpression

[attila]

attila  writes:

> Hi ports@,
>
> Attached is a port for the Data::SExpression Perl module.  It is a
> dependency of the Perl interface I recently contributed to mail/mu
> upstream, and which will be coming down the pike in some new mu
> release fairly soon.
>
> $ cat pkg/DESCR
> Data::SExpression is a Perl module that parses LISP-like
> S-expressions into Perl data structures.
>
> Passes make test on i386.
>
> Comments, feedback most welcome.
>
> Pax, -A

Ping?  Port attached.

Pax, -A
-- 
http://trac.haqistan.net | att...@stalphonsos.com | 0xE6CC1EDB


p5-Data-SExpression.tgz
Description: proposed new port: devel/p5-Data-SExpression

[NEW] devel/p5-Data-SExpression

[attila]

Hi ports@,

Attached is a port for the Data::SExpression Perl module.  It is a
dependency of the Perl interface I recently contributed to mail/mu
upstream, and which will be coming down the pike in some new mu
release fairly soon.

$ cat pkg/DESCR
Data::SExpression is a Perl module that parses LISP-like
S-expressions into Perl data structures.

Passes make test on i386.

Comments, feedback most welcome.

Pax, -A
-- 
http://trac.haqistan.net | att...@stalphonsos.com | 0xE6CC1EDB


p5-Data-SExpression.tgz
Description: proposed new port: devel/p5-Data-SExpression