Re: [NEW] devel/p5-String-Formatter 0.102084 (Perl+MPD 3/5)
On Fri, Feb 22, 2019 at 06:40:01PM +0100, Charlene Wendling wrote: > Thanks for the rationale behind the proposed changes - i applied them > accordingly. OK bluhm@
Re: [NEW] devel/p5-String-Formatter 0.102084 (Perl+MPD 3/5)
On Thu, 21 Feb 2019 22:08:57 -0700
Andrew Hewus Fresh wrote:
> On Fri, Feb 22, 2019 at 12:53:06AM +0100, Alexander Bluhm wrote:
> > On Thu, Feb 21, 2019 at 11:22:12PM +0100, Charlene Wendling wrote:
> > > Here is a new port, String::Formatter. It will be needed for
> > > updating audio/p5-Audio-MPD-Common.
> >
> > I think you should keep String/Formatter/Cookbook.pm, it makes
> > perldoc String::Formatter::Cookbook work.
> >
> > Instead of an extra post-install target, you could just comment out
> > bench.pl from PLIST.
> >
> > @comment ${P5SITE}/String/bench.pl
> >
> > I don't like the @rm -f. The @ prevents that you see what is going
> > on, and with -f it cannot fail. What happens if in a later version
> > bench.pl is not part of the distribution? You will never notice
> > that rm -f would not work.
> >
> > with that OK bluhm@
>
> I agree, @comment is the expected way to avoid installing things as
> long as it goes through the rest of the build fine.
>
> with bluhm's changes, OK afresh1@
>
Hi,
Thanks for the rationale behind the proposed changes - i applied them
accordingly.
Charlène.
p5-String-Formatter.tgz
Description: Binary data
Re: [NEW] devel/p5-String-Formatter 0.102084 (Perl+MPD 3/5)
On Fri, Feb 22, 2019 at 12:53:06AM +0100, Alexander Bluhm wrote:
> On Thu, Feb 21, 2019 at 11:22:12PM +0100, Charlene Wendling wrote:
> > Here is a new port, String::Formatter. It will be needed for updating
> > audio/p5-Audio-MPD-Common.
>
> I think you should keep String/Formatter/Cookbook.pm, it makes
> perldoc String::Formatter::Cookbook work.
>
> Instead of an extra post-install target, you could just comment out
> bench.pl from PLIST.
>
> @comment ${P5SITE}/String/bench.pl
>
> I don't like the @rm -f. The @ prevents that you see what is going
> on, and with -f it cannot fail. What happens if in a later version
> bench.pl is not part of the distribution? You will never notice
> that rm -f would not work.
>
> with that OK bluhm@
I agree, @comment is the expected way to avoid installing things as long
as it goes through the rest of the build fine.
with bluhm's changes, OK afresh1@
Re: [NEW] devel/p5-String-Formatter 0.102084 (Perl+MPD 3/5)
On Thu, Feb 21, 2019 at 11:22:12PM +0100, Charlene Wendling wrote:
> Here is a new port, String::Formatter. It will be needed for updating
> audio/p5-Audio-MPD-Common.
I think you should keep String/Formatter/Cookbook.pm, it makes
perldoc String::Formatter::Cookbook work.
Instead of an extra post-install target, you could just comment out
bench.pl from PLIST.
@comment ${P5SITE}/String/bench.pl
I don't like the @rm -f. The @ prevents that you see what is going
on, and with -f it cannot fail. What happens if in a later version
bench.pl is not part of the distribution? You will never notice
that rm -f would not work.
with that OK bluhm@
[NEW] devel/p5-String-Formatter 0.102084 (Perl+MPD 3/5)
Here is a new port, String::Formatter. It will be needed for updating audio/p5-Audio-MPD-Common. It has been created by portgen. 'make test' passes. Comment: build sprintf-like functions of your own Description: String::Formatter is a tool for building sprintf-like formatting routines. It supports named or positional formatting, custom conversions, fixed string interpolation, and simple width-matching out of the box. Comments/feedback are welcome :) Charlène. p5-String-Formatter.tgz Description: Binary data
