Re: [NEW PORT] math/mpdecimal

2021-02-27 Thread Stefan Krah 
On Thu, Feb 25, 2021 at 10:36:10PM +, Stuart Henderson wrote:
> https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs

Thanks! I'm not sure though how to replace SHARED_LIBS automatically in
the GNU machinery, so I resorted to patches (which will have to be
updated if SHARED_LIBS changes).


> missing WANTLIB, see "make port-lib-depends-check"

``make lib-depends-check'' is not happy about the internal dependency
of libmpdec++ on libmpdec:

openbsd-amd64# make lib-depends-check
 
mpdecimal-2.5.1(math/mpdecimal):
Missing lib: mpdec.0 (/usr/local/lib/libmpdec++.so.0.0) (NOT REACHABLE)
Extra:  c.96
Scanning: ok
*** Error 1 in /usr/ports/math/mpdecimal 
(/usr/ports/infrastructure/mk/bsd.port.mk:2430 'lib-depends-check': @case 
X${_DEPENDS_CACHE} in  X)...)



I also tried splitting the package into two libraries by literally
copying devel/gmp/Makefile and substituting the necessary parts.

But I never got that particular check to work.


> portcheck(1) may spot other things

portcheck -N is silent, I've attached a new version, which does not
split the library packages.


Stefan Krah




mpdecimal-openbsd-port-2.tar.gz
Description: application/gzip

Re: [NEW PORT] math/mpdecimal

2021-02-25 Thread Stuart Henderson 
On 2021/02/25 22:49, Stefan Krah wrote:
> On Thu, Feb 25, 2021 at 09:33:39PM +, Stuart Henderson wrote:
> > > it would be nice to add math/mpdecimal.  If the port is accepted, Python
> > 
> > Please send as an attachment
> 
> Ok, here it is.


thanks - some quick comments,

the Makefile should look more like other Makefiles in ports, you are at
least missing a license marker, and the order is a bit different to the
standard (it's not absolutely cast in stone but generally lines should
be in the same order as in ports/infrastructure/Makefile.template)

library versioning doesn't follow openbsd standards.
libraries need to be listed in SHARED_LIBS and that needs to control
the version number in the produced libraries (change SHARED_LIBS ->
library changes in the build). openbsd uses .so.X.Y and doesn't use
use .so / .so.X symlinks, ports should start with .so.0.0 irrespective
of what upstream uses. there's some more info in
https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs

missing WANTLIB, see "make port-lib-depends-check"

C++ ports always need a COMPILER line, usually

COMPILER=   base-clang ports-gcc

the WWW link (HOMEPAGE) is added automatically, don't set it yourself
in DESCR otherwise it is duplicated

portcheck(1) may spot other things

Re: [NEW PORT] math/mpdecimal

2021-02-25 Thread Stefan Krah 
On Thu, Feb 25, 2021 at 09:33:39PM +, Stuart Henderson wrote:
> > it would be nice to add math/mpdecimal.  If the port is accepted, Python
> 
> Please send as an attachment

Ok, here it is.


mpdecimal-openbsd-port.tar.gz
Description: application/gzip

Re: [NEW PORT] math/mpdecimal

2021-02-25 Thread Stuart Henderson 
On 2021/02/25 19:58, Stefan Krah wrote:
> 
> Hello,
> 
> it would be nice to add math/mpdecimal.  If the port is accepted, Python
> could be build --with-system-libmpdec.  Here's the archive:
> 
>https://www.bytereef.org/contrib/mpdecimal-openbsd-port.tar.gz
> 
> 
> Stefan Krah
> 
> 

Please send as an attachment

[NEW PORT] math/mpdecimal

2021-02-25 Thread Stefan Krah 


Hello,

it would be nice to add math/mpdecimal.  If the port is accepted, Python
could be build --with-system-libmpdec.  Here's the archive:

   https://www.bytereef.org/contrib/mpdecimal-openbsd-port.tar.gz


Stefan Krah