Re: [Update] textproc/discount 1.6.4

[Scott Vokes]

On Sat, May 1, 2010 at 9:37 AM, Joachim Schipper
joac...@joachimschipper.nl wrote:
 How about the following diff (relative to the in-ports version)? I changed:
 [...]
   Sounds good to me, thanks. (I think I made a mistake with cvs - one
of my local change fixed the fake issue, but didn't get added to the
patch.)

   Is there any policy or convention for renaming files in a port, by
the way? I don't see anything in the porting guidelines.

Thanks,
Scott

Re: [Update] textproc/discount 1.6.4

[Scott Vokes]

 - I think being able to install both py-markdown and discount is useful,
  so I'd prefer having distinct names
 [...]
 Otherwise, the regression tests work for me too, on amd64, and I'd like
 to see this update.
Ok, please retry with this patch. I'm renaming the standalone program
to 'discount', and added a note to that effect in pkg/MESSAGE. Also, I
fixed the issue with the regression tests - it wasn't patching the
filename in the test runner. --enable-all-features should be fine.

Thanks,
Scott


discount-1.6.4-renaming
Description: Binary data

Re: [Update] textproc/discount 1.6.4

[Joachim Schipper]

On Sat, Apr 24, 2010 at 02:00:26PM -0400, Scott Vokes wrote:
 This updates discount to 1.6.4. Upgrading is highly recommended, as
 the update fixes a couple security issues.
 
 Also, I'm no longer renaming the standalone executable from 'markdown'
 to 'discount'. Instead, it's marked as @conflicting with
 textproc/markdown. Is that ok?
 
 Tested on amd64, and make regress passes. Please test and commit.

Some comments:

- I think being able to install both py-markdown and discount is useful,
  so I'd prefer having distinct names
- Some regression test pick up an installed py-markdown, testing it
  instead of discount; some also fail if no markdown is installed. (E.g.
  tests/div.t, tests/dl.t). This seems to be the result of your changes
  in pre-configure.
- Is --enable-all-features backwards compatible?

Otherwise, the regression tests work for me too, on amd64, and I'd like
to see this update.

Joachim

[Update] textproc/discount 1.6.4

[Scott Vokes]

This updates discount to 1.6.4. Upgrading is highly recommended, as
the update fixes a couple security issues.

Also, I'm no longer renaming the standalone executable from 'markdown'
to 'discount'. Instead, it's marked as @conflicting with
textproc/markdown. Is that ok?

Tested on amd64, and make regress passes. Please test and commit.

Scott


discount-1.6.4
Description: Binary data