Re: NEW: audio/deadbeef-plugin-mpris2
On 2024/02/15 22:59:01 +, Klemens Nanni wrote: > On Thu, Feb 15, 2024 at 11:44:30PM +0100, Omar Polo wrote: > > I'm attaching an updated tarball with kn and sthen comments addressed > > (more usual licence marker, no explicit libtool depends) and sorted > > WANTLIBS, that's OK for me to import. (it's also of course OK for me if > > whoever imports it wants to remove or @comment the *.la files.) > > > > (as i haven't tested it --i'm happy with my own music player :P, was > > just curious to mess around with a new port-- I'd prefer if it was > > someone else to actually import it) > > > > > Thanks for the patience with me. > > > > No problem, it was a solid submission with just some nits to address. > > OK kn I've imported it then, thanks :)
Re: NEW: audio/deadbeef-plugin-mpris2
On Thu, Feb 15, 2024 at 11:44:30PM +0100, Omar Polo wrote: > I'm attaching an updated tarball with kn and sthen comments addressed > (more usual licence marker, no explicit libtool depends) and sorted > WANTLIBS, that's OK for me to import. (it's also of course OK for me if > whoever imports it wants to remove or @comment the *.la files.) > > (as i haven't tested it --i'm happy with my own music player :P, was > just curious to mess around with a new port-- I'd prefer if it was > someone else to actually import it) > > > Thanks for the patience with me. > > No problem, it was a solid submission with just some nits to address. OK kn
Re: NEW: audio/deadbeef-plugin-mpris2
On 2024/02/14 17:38:43 -0600, izder456 wrote: > Hey, > > Just wanna pop in here and clarify why i did things the way i did. > > Jose Maldonado wrote: > > Why rename deadbeef-mpris2-plugin to deadbeef-plugin-mpris2? > the thought process was simple here, there are other plugins that > people may want to port for DeaDBeeF. with this naming scheme, all of > the plugins would be prefixed by deadbeef-plugin and followed by > -pluginname. this is more of a consistency measure in case future ports > from me or others come about. fwiw i agree, it reads fine to have deadbeef-plugin-foo rather than deadbeef-foo-plugin if there are several potentially. (otherwise I would have advised to follow upstream naming.) > Omar Polo wrote: > > - why removing the *la files? > > like Klemens said, I saw other ports did this, namely the > audio/deadbeef port specifically. Just replicating existing patterns. > Not sure why though. no strong opinion either, was just a curiosity. (and have to admit that for a few files i prefer to @comment them in the PLIST, but it's matter of style here and won't object removing, @commenting or keeping these files) > Omar Polo wrote: > > longer explanation: the port links to glib (plus a lot of other > > dependencies) and it's not listed in LIB_DEPENDS. Yet, it's reachable > > at runtime via audio/deadbeef, so portchecks detects that you're > > missing > > something in LIB_DEPENDS. The idea of "masked ldeps" means a > > LIB_DEPENDS that's not actually listed as LIB_DEPENDS. > > I assumed it was something along those lines. If I understand > correctly, the audio/deadbeef depend "blankets" the need for the > LIB_DEPENDS, right? yeah, the deadbeef rdeps hides the lib depends in this case. (actually i think it's the first time I encounter this particular behaviour :-) > thanks for the information. > > OK to import? I'm attaching an updated tarball with kn and sthen comments addressed (more usual licence marker, no explicit libtool depends) and sorted WANTLIBS, that's OK for me to import. (it's also of course OK for me if whoever imports it wants to remove or @comment the *.la files.) (as i haven't tested it --i'm happy with my own music player :P, was just curious to mess around with a new port-- I'd prefer if it was someone else to actually import it) > Thanks for the patience with me. No problem, it was a solid submission with just some nits to address. Thanks, Omar Polo deadbeef-plugin-mpris2.tar.gz Description: GNU Zip compressed data
Re: NEW: audio/deadbeef-plugin-mpris2
El Wed, 14 Feb 2024 17:38:43 -0600 izder456 escribió: > Hey, > > Just wanna pop in here and clarify why i did things the way i did. > > Jose Maldonado wrote: > > Why rename deadbeef-mpris2-plugin to deadbeef-plugin-mpris2? > the thought process was simple here, there are other plugins that > people may want to port for DeaDBeeF. with this naming scheme, all of > the plugins would be prefixed by deadbeef-plugin and followed by > -pluginname. this is more of a consistency measure in case future > ports from me or others come about. > The person who wrote that was not me, it was Klemens. But it doesn't matter, I agree with you about renaming the package so that it is: deadbeef-plugin-plugin_name It becomes more readable and since it is the first deadbeef plugin to reach ports we can use this scheme for PKGNAMEs related to deadbeef plugins. -- * Dios en su cielo, todo bien en la Tierra
Re: NEW: audio/deadbeef-plugin-mpris2
Hey, Just wanna pop in here and clarify why i did things the way i did. Jose Maldonado wrote: > Why rename deadbeef-mpris2-plugin to deadbeef-plugin-mpris2? the thought process was simple here, there are other plugins that people may want to port for DeaDBeeF. with this naming scheme, all of the plugins would be prefixed by deadbeef-plugin and followed by -pluginname. this is more of a consistency measure in case future ports from me or others come about. Omar Polo wrote: > - why removing the *la files? like Klemens said, I saw other ports did this, namely the audio/deadbeef port specifically. Just replicating existing patterns. Not sure why though. Omar Polo wrote: > longer explanation: the port links to glib (plus a lot of other > dependencies) and it's not listed in LIB_DEPENDS. Yet, it's reachable > at runtime via audio/deadbeef, so portchecks detects that you're > missing > something in LIB_DEPENDS. The idea of "masked ldeps" means a > LIB_DEPENDS that's not actually listed as LIB_DEPENDS. I assumed it was something along those lines. If I understand correctly, the audio/deadbeef depend "blankets" the need for the LIB_DEPENDS, right? thanks for the information. OK to import? Thanks for the patience with me. -- izzy Meyer (they/them) https://izder456.neocities.org/
Re: NEW: audio/deadbeef-plugin-mpris2
On 2024/02/14 19:27, Omar Polo wrote: > +BUILD_DEPENDS = audio/deadbeef \ > + devel/libtool that is gnu libtool, which is only used if USE_LIBTOOL=gnu is set (and in that case the BDEP isn't needed). the dep should be removed.
Re: NEW: audio/deadbeef-plugin-mpris2
On Wed, Feb 14, 2024 at 07:27:11PM +0100, Omar Polo wrote:
> then, some comments about the port.
+1
> - why removing the *la files?
A bunch of ports do this, not sure why, though.
deadbeef's builtin plugins also come without .la files.
> I'm attaching an updated ports and a diff against your makefile. The
> port looks fine to me now, but as I don't use deadbeef I haven't gone
> further than `make package'.
License marker "GPLv2" would be consistent with ports.
devel/libtool is automatically added as BDEP and can be dropped.
Why rename deadbeef-mpris2-plugin to deadbeef-plugin-mpris2?
Not sure it matters much, but seems simpler and less confusing without.
Took me a while to find out that deadbeef defaults to the null audio output
and I had to select PulseAudio to hear something, but after that using
playerctl to contol volume and playback just worked.
> --- Makefile.orig Wed Feb 14 18:49:28 2024
> +++ Makefile Wed Feb 14 19:15:33 2024
> @@ -1,13 +1,11 @@
> COMMENT =deadbeef plugin for mpris2 support
>
> -V = 1.16
> +V = 1.16
> DIST_TUPLE +=github DeaDBeeF-Player deadbeef-mpris2-plugin v${V} .
> PKGNAME =deadbeef-plugin-mpris2-${V}
>
> CATEGORIES = audio
>
> -HOMEPAGE =
> https://github.com/DeaDBeeF-Player/deadbeef-mpris2-plugin
> -
> MAINTAINER = izzy Meyer
>
> # GPL v2 only
> @@ -16,30 +14,25 @@
> WANTLIB += gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0 gthread-2.0
> WANTLIB += pthread iconv intl pcre2-8 z ffi
>
> -COMPILER = base-clang ports-gcc
> -
> -
> -LIB_DEPENDS =devel/pcre2
> -BUILD_DEPENDS = devel/libtool \
> - devel/libffi \
> - devel/pcre2
> +LIB_DEPENDS =devel/glib2 \
> + devel/libffi \
> + devel/pcre2
> +BUILD_DEPENDS = audio/deadbeef \
> + devel/libtool
> RUN_DEPENDS =audio/deadbeef
>
> CONFIGURE_STYLE =autoreconf
>
> -CONFIGURE_ENV += CPPFLAGS='-I${LOCALBASE}/include \
> - -I${X11BASE}/include' \
> - LDFLAGS='-L${LOCALBASE}/lib
> -L${X11BASE}/lib' \
> +CPPFLAGS += -I${LOCALBASE}/include \
> + -I${X11BASE}/include
> +LDFLAGS += -L${LOCALBASE}/lib \
> + -L${X11BASE}/lib
> +CONFIGURE_ENV += CPPFLAGS='${CPPFLAGS}' \
> + LDFLAGS='${LDFLAGS}'
>
> -CONFIGURE_ARGS = --prefix ${LOCALBASE} \
> - --disable-static
> -
> LIBTOOL_FLAGS = --tag=disable-static
>
> -AUTOCONF_VERSION = 2.69
> +AUTOCONF_VERSION = 2.71
> AUTOMAKE_VERSION = 1.16
> -
> -post-install:
> - @rm ${PREFIX}/lib/deadbeef/*.la
>
> .include
>
>
Re: NEW: audio/deadbeef-plugin-mpris2
El Wed, 14 Feb 2024 19:27:11 +0100
Omar Polo escribió:
> On 2024/02/13 11:48:26 -0600, izder456 wrote:
> > Hey ports@,
> >
> > I want to import the mpris2 plugin for the DeaDBeeF music player.
> >
> > This allows mpris2 support in the music player, so ports like
> > multimedia/playerctl can interface with and operate DeaDBeeF.
> >
> > A couple questions:
> >
> > 1. I put this in CATEGORY = audio, I'm unsure if this was the
> > correct location for a plugin like this. Is there a better
> > (possibly more suitable CATEGORY for this port?)
>
> I think audio is fine.
>
> > 2. portcheck returns
> >```
> >the following libraries in WANTLIB look like masked by
> > RUN_DEPENDS: gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0 gthread-2.0
> > iconv intl ffi audio/deadbeef-plugin-mpris2
> >```
> >is this normal? I don't exactly know what this means or what I
> > should do to suppress it if its not OK..
>
> it's an edge case. TL;DR, remove deadbeef from RUN_DEPENDS, re-run
> make port-lib-depends-check, fix LIB_DEPENDS, re-add deadbeef to
> RUN_DEPENDS.
>
> longer explanation: the port links to glib (plus a lot of other
> dependencies) and it's not listed in LIB_DEPENDS. Yet, it's reachable
> at runtime via audio/deadbeef, so portchecks detects that you're
> missing something in LIB_DEPENDS. The idea of "masked ldeps" means a
> LIB_DEPENDS that's not actually listed as LIB_DEPENDS.
>
> then, some comments about the port.
>
> - the identation is a bit inconsistent. make sure your editor is
>configured with tabs 8 columns wide (that's emacs default, but
> YMMV)
>
> - HOMEPAGE is set by DIST_TUPLE = github
>
> - add a missing build depends on audio/deadbeef
>
> - listing a library as BUILD_DEPENDS is 99.99% of the times wrong.
>libffi is a LIB_DEPENDS.
>
> - (matter of personal style) tidy CONFIGURE_ENV by defining some
> local variables
>
> - CONFIGURE_ARGS is not needed, and even if it were it would be
> --prefix ${PREFIX} or ${TRUEPREFIX}, not ${LOCALBASE}. {TRUE,}PREFIX
> is for this very port, LOCALBASE is where other ports are installed.
>In practice the difference doesn't matter, but use the right
> variable nevertheless.
>
> - bump AUTOCONF_VERSION to 2.71: there are a couple of warnings about
>deprecated macros, but otherwise works. 2.69 is a bit ancient.
>
> - why removing the *la files?
>
> I'm attaching an updated ports and a diff against your makefile. The
> port looks fine to me now, but as I don't use deadbeef I haven't gone
> further than `make package'.
>
>
> --- Makefile.orig Wed Feb 14 18:49:28 2024
> +++ Makefile Wed Feb 14 19:15:33 2024
> @@ -1,13 +1,11 @@
> COMMENT =deadbeef plugin for mpris2 support
>
> -V = 1.16
> +V = 1.16
> DIST_TUPLE +=github DeaDBeeF-Player deadbeef-mpris2-plugin
> v${V} . PKGNAME = deadbeef-plugin-mpris2-${V}
>
> CATEGORIES = audio
>
> -HOMEPAGE =
> https://github.com/DeaDBeeF-Player/deadbeef-mpris2-plugin -
> MAINTAINER = izzy Meyer
>
> # GPL v2 only
> @@ -16,30 +14,25 @@
> WANTLIB += gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0
> gthread-2.0 WANTLIB +=pthread iconv intl pcre2-8 z ffi
>
> -COMPILER = base-clang ports-gcc
> -
> -
> -LIB_DEPENDS =devel/pcre2
> -BUILD_DEPENDS = devel/libtool \
> - devel/libffi \
> - devel/pcre2
> +LIB_DEPENDS =devel/glib2 \
> + devel/libffi \
> + devel/pcre2
> +BUILD_DEPENDS = audio/deadbeef \
> + devel/libtool
> RUN_DEPENDS =audio/deadbeef
>
> CONFIGURE_STYLE =autoreconf
>
> -CONFIGURE_ENV += CPPFLAGS='-I${LOCALBASE}/include \
> - -I${X11BASE}/include' \
> - LDFLAGS='-L${LOCALBASE}/lib
> -L${X11BASE}/lib' \ +CPPFLAGS += -I${LOCALBASE}/include \
> + -I${X11BASE}/include
> +LDFLAGS += -L${LOCALBASE}/lib \
> + -L${X11BASE}/lib
> +CONFIGURE_ENV += CPPFLAGS='${CPPFLAGS}' \
> + LDFLAGS='${LDFLAGS}'
>
> -CONFIGURE_ARGS = --prefix ${LOCALBASE} \
> - --disable-static
> -
> LIBTOOL_FLAGS = --tag=disable-static
>
> -AUTOCONF_VERSION = 2.69
> +AUTOCONF_VERSION = 2.71
> AUTOMAKE_VERSION = 1.16
> -
> -post-install:
> - @rm ${PREFIX}/lib/deadbeef/*.la
>
> .include
>
>
Good observations @Omar, I have learned a lot from that!
I have built the port and installed it with your changes, everything
works correctly.
--
*
Dios en su cielo, todo bien en la Tierra
Re: NEW: audio/deadbeef-plugin-mpris2
On 2024/02/13 11:48:26 -0600, izder456 wrote:
> Hey ports@,
>
> I want to import the mpris2 plugin for the DeaDBeeF music player.
>
> This allows mpris2 support in the music player, so ports like
> multimedia/playerctl can interface with and operate DeaDBeeF.
>
> A couple questions:
>
> 1. I put this in CATEGORY = audio, I'm unsure if this was the correct
> location for a plugin like this. Is there a better (possibly more
> suitable CATEGORY for this port?)
I think audio is fine.
> 2. portcheck returns
>```
>the following libraries in WANTLIB look like masked by RUN_DEPENDS:
>gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0 gthread-2.0 iconv intl ffi
>audio/deadbeef-plugin-mpris2
>```
>is this normal? I don't exactly know what this means or what I should
>do to suppress it if its not OK..
it's an edge case. TL;DR, remove deadbeef from RUN_DEPENDS, re-run make
port-lib-depends-check, fix LIB_DEPENDS, re-add deadbeef to RUN_DEPENDS.
longer explanation: the port links to glib (plus a lot of other
dependencies) and it's not listed in LIB_DEPENDS. Yet, it's reachable
at runtime via audio/deadbeef, so portchecks detects that you're missing
something in LIB_DEPENDS. The idea of "masked ldeps" means a
LIB_DEPENDS that's not actually listed as LIB_DEPENDS.
then, some comments about the port.
- the identation is a bit inconsistent. make sure your editor is
configured with tabs 8 columns wide (that's emacs default, but YMMV)
- HOMEPAGE is set by DIST_TUPLE = github
- add a missing build depends on audio/deadbeef
- listing a library as BUILD_DEPENDS is 99.99% of the times wrong.
libffi is a LIB_DEPENDS.
- (matter of personal style) tidy CONFIGURE_ENV by defining some local
variables
- CONFIGURE_ARGS is not needed, and even if it were it would be --prefix
${PREFIX} or ${TRUEPREFIX}, not ${LOCALBASE}. {TRUE,}PREFIX is for
this very port, LOCALBASE is where other ports are installed.
In practice the difference doesn't matter, but use the right variable
nevertheless.
- bump AUTOCONF_VERSION to 2.71: there are a couple of warnings about
deprecated macros, but otherwise works. 2.69 is a bit ancient.
- why removing the *la files?
I'm attaching an updated ports and a diff against your makefile. The
port looks fine to me now, but as I don't use deadbeef I haven't gone
further than `make package'.
--- Makefile.orig Wed Feb 14 18:49:28 2024
+++ MakefileWed Feb 14 19:15:33 2024
@@ -1,13 +1,11 @@
COMMENT = deadbeef plugin for mpris2 support
-V =1.16
+V =1.16
DIST_TUPLE += github DeaDBeeF-Player deadbeef-mpris2-plugin v${V} .
PKGNAME = deadbeef-plugin-mpris2-${V}
CATEGORIES = audio
-HOMEPAGE =
https://github.com/DeaDBeeF-Player/deadbeef-mpris2-plugin
-
MAINTAINER = izzy Meyer
# GPL v2 only
@@ -16,30 +14,25 @@
WANTLIB += gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0 gthread-2.0
WANTLIB += pthread iconv intl pcre2-8 z ffi
-COMPILER = base-clang ports-gcc
-
-
-LIB_DEPENDS = devel/pcre2
-BUILD_DEPENDS =devel/libtool \
- devel/libffi \
- devel/pcre2
+LIB_DEPENDS = devel/glib2 \
+ devel/libffi \
+ devel/pcre2
+BUILD_DEPENDS =audio/deadbeef \
+ devel/libtool
RUN_DEPENDS = audio/deadbeef
CONFIGURE_STYLE = autoreconf
-CONFIGURE_ENV += CPPFLAGS='-I${LOCALBASE}/include \
- -I${X11BASE}/include' \
- LDFLAGS='-L${LOCALBASE}/lib
-L${X11BASE}/lib' \
+CPPFLAGS +=-I${LOCALBASE}/include \
+ -I${X11BASE}/include
+LDFLAGS += -L${LOCALBASE}/lib \
+ -L${X11BASE}/lib
+CONFIGURE_ENV += CPPFLAGS='${CPPFLAGS}' \
+ LDFLAGS='${LDFLAGS}'
-CONFIGURE_ARGS = --prefix ${LOCALBASE} \
- --disable-static
-
LIBTOOL_FLAGS =--tag=disable-static
-AUTOCONF_VERSION = 2.69
+AUTOCONF_VERSION = 2.71
AUTOMAKE_VERSION = 1.16
-
-post-install:
- @rm ${PREFIX}/lib/deadbeef/*.la
.include
deadbeef-plugin-mpris2.tar.gz
Description: GNU Zip compressed data
Re: NEW: audio/deadbeef-plugin-mpris2
El Wed, 14 Feb 2024 00:04:41 -0600 izder456 escribió: > On Tue, 13 Feb 2024 19:21:20 -0400 > > I know that `make port-lib-depends-check` returns OK, I asked about > portcheck (located at /usr/ports/infrastructure/bin/portcheck). > > It is good it works for you, but could you check via port check too? I > dunno about what this error/warning means specifically, since things > seem to be functional. That was more about what I was asking to be > clarified there. > > Thanks, > Hello! You are correct, trying with portcheck I have seen the error, the required change is to add devel/glib2 in LIB_DEPENDS. I am attaching the changes for this port. -- * Dios en su cielo, todo bien en la Tierra deadbeef-plugin-mpris2.tar.gz Description: application/gzip
Re: NEW: audio/deadbeef-plugin-mpris2
On Tue, 13 Feb 2024 19:21:20 -0400 Jose Maldonado wrote: > El Tue, 13 Feb 2024 11:48:26 -0600 > izder456 escribió: > > Hey ports@, > > > > I want to import the mpris2 plugin for the DeaDBeeF music player. > > > > This allows mpris2 support in the music player, so ports like > > multimedia/playerctl can interface with and operate DeaDBeeF. > > > > A couple questions: > > > > 1. I put this in CATEGORY = audio, I'm unsure if this was the > > correct location for a plugin like this. Is there a better > > (possibly more suitable CATEGORY for this port?) > > 2. portcheck returns > >``` > >the following libraries in WANTLIB look like masked by > > RUN_DEPENDS: gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0 gthread-2.0 > > iconv intl ffi audio/deadbeef-plugin-mpris2 > >``` > >is this normal? I don't exactly know what this means or what I > > should do to suppress it if its not OK.. > > > > Any answers to the above questions would be appreciated. > > > > Thanks > > > > Port is attached > > > > -- > > izzy Meyer (they/them) > > > > https://izder456.neocities.org/ > > Hi! > > I build the port, not problems all work ok. > > "make port-lib-depends-check" don´t show me nothing wrong with the > libs. > > I know that `make port-lib-depends-check` returns OK, I asked about portcheck (located at /usr/ports/infrastructure/bin/portcheck). It is good it works for you, but could you check via port check too? I dunno about what this error/warning means specifically, since things seem to be functional. That was more about what I was asking to be clarified there. Thanks, -- izzy Meyer (they/them) https://izder456.neocities.org/
Re: NEW: audio/deadbeef-plugin-mpris2
El Tue, 13 Feb 2024 11:48:26 -0600 izder456 escribió: > Hey ports@, > > I want to import the mpris2 plugin for the DeaDBeeF music player. > > This allows mpris2 support in the music player, so ports like > multimedia/playerctl can interface with and operate DeaDBeeF. > > A couple questions: > > 1. I put this in CATEGORY = audio, I'm unsure if this was the correct > location for a plugin like this. Is there a better (possibly more > suitable CATEGORY for this port?) > 2. portcheck returns >``` >the following libraries in WANTLIB look like masked by RUN_DEPENDS: >gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0 gthread-2.0 iconv intl ffi >audio/deadbeef-plugin-mpris2 >``` >is this normal? I don't exactly know what this means or what I > should do to suppress it if its not OK.. > > Any answers to the above questions would be appreciated. > > Thanks > > Port is attached > > -- > izzy Meyer (they/them) > > https://izder456.neocities.org/ Hi! I build the port, not problems all work ok. "make port-lib-depends-check" don´t show me nothing wrong with the libs. -- * Dios en su cielo, todo bien en la Tierra
NEW: audio/deadbeef-plugin-mpris2
Hey ports@, I want to import the mpris2 plugin for the DeaDBeeF music player. This allows mpris2 support in the music player, so ports like multimedia/playerctl can interface with and operate DeaDBeeF. A couple questions: 1. I put this in CATEGORY = audio, I'm unsure if this was the correct location for a plugin like this. Is there a better (possibly more suitable CATEGORY for this port?) 2. portcheck returns ``` the following libraries in WANTLIB look like masked by RUN_DEPENDS: gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0 gthread-2.0 iconv intl ffi audio/deadbeef-plugin-mpris2 ``` is this normal? I don't exactly know what this means or what I should do to suppress it if its not OK.. Any answers to the above questions would be appreciated. Thanks Port is attached -- izzy Meyer (they/them) https://izder456.neocities.org/ deadbeef-plugin-mpris2.tgz Description: application/compressed-tar
