Re: [PATCH] editors/elvis: clang and other fixes

2017-04-20 Thread Donovan Watteau
On Mon, 17 Apr 2017, Stuart Henderson wrote:
> > * Various fixes from a forked Github version (there was no official
> >   elvis release since 2004), clang warns about most of them.
> 
> Not an elvis user or familiar with development, but would it make
> any sense to switch to the fork rather than just take some patches?

Yes, I agree.  However, we'd probably be the first to use this fork,
so I want to make sure that the first patches are OK, and I'll probably
switch to the forked version in a second step.

On Mon, 17 Apr 2017, Stuart Henderson wrote:
> On 2017/04/17 15:55, Donovan Watteau wrote:
> > * Fix a build failure with clang; some  symbols were
> >   redefined (patch-guitcap_c).
> 
> This class of failures is being looked at (and doesn't affect arm64
> which is the only arch where this will actually be built with clang
> in bulks for now) so I think it makes sense to skip this one for now.
> 
> Others committed.

OK, thank you!



Re: [PATCH] editors/elvis: clang and other fixes

2017-04-17 Thread Stuart Henderson
On 2017/04/17 15:55, Donovan Watteau wrote:
> * Fix a build failure with clang; some  symbols were
>   redefined (patch-guitcap_c).

This class of failures is being looked at (and doesn't affect arm64
which is the only arch where this will actually be built with clang
in bulks for now) so I think it makes sense to skip this one for now.

Others committed.



Re: [PATCH] editors/elvis: clang and other fixes

2017-04-17 Thread Stuart Henderson
On 2017/04/17 15:55, Donovan Watteau wrote:
> Here are various fixes for editors/elvis:

Nice, thanks. Will test in a bit.

> * Various fixes from a forked Github version (there was no official
>   elvis release since 2004), clang warns about most of them.

Not an elvis user or familiar with development, but would it make
any sense to switch to the fork rather than just take some patches?