Re: NEW: x11/tabbed
On Sun, Jul 08, 2012 at 10:11:57PM +0200, Landry Breuil wrote: Works fine here @i386, a nice one to have ! I'm not really fond of patches/patch-config_def_h but you get to choose the defaults since you maintain it :) I looked how other suckless ports are done and used the same defaults as dwm to keep things consistent. Regards, Joerg
Re: NEW: x11/tabbed
* Joerg Zinke m...@umaxx.net [120709 03:47]: On Sun, Jul 08, 2012 at 10:11:57PM +0200, Landry Breuil wrote: Works fine here @i386, a nice one to have ! I'm not really fond of patches/patch-config_def_h but you get to choose the defaults since you maintain it :) I looked how other suckless ports are done and used the same defaults as dwm to keep things consistent. Regards, Joerg Regarding dwm, my port, my rules. Ok, well just my color scheme then. ;-) jim@
Re: NEW: x11/tabbed
Add something like this MAKE_FLAGS= CC=${CC} then it's ok sthen, tested with urxvt. On 2012/07/07 21:22, Joerg Zinke wrote: Bumping this up now make me feel like a soliloquizing vulture. But this is still in my tree and I use it daily with www/surf. For example my ~/.xsession contains: surf -e `tabbed -d` Please, any objections or any OKs to import? On Sat, Nov 12, 2011 at 03:07:33PM +0100, Joerg Zinke wrote: Bump. No responses yet. Flames or okay from anyone? On Fri, 16 Sep 2011 16:13:03 +0200 Joerg Zinke m...@umaxx.net wrote: Hi, please find attached a port for tabbed-0.3 Description: Simple generic tabbed fronted to xembed aware applications, originally designed for surf but also usable with many other application, i.e. uzbl, urxvt and xterm. More info: http://tools.suckless.org/tabbed Port is attached or can be downloaded from: https://www.umaxx.net/src/tabbed.tar.gz The port and patches are modeled after other suckless ports (dwm). Please test, comment and give OKs. Regards, Joerg
Re: NEW: x11/tabbed
Hi Stuart, On Sun, Jul 08, 2012 at 02:51:53PM +0200, Stuart Henderson wrote: Add something like this MAKE_FLAGS= CC=${CC} Done. then it's ok sthen, tested with urxvt. Upstream rolled a new release *last* night. Please find an update for tabbed-0.4 attached. This new release is more generic and can handle arbitrary xembed aware applications. Examples from the manpage: $ tabbed surf -e $ tabbed urxvt -embed $ tabbed xterm -into $ $(tabbed -d /tmp/tabbed.xid); urxvt -embed $(/tmp/tabbed.xid); Please test (once again). Regards, Joerg On 2012/07/07 21:22, Joerg Zinke wrote: Bumping this up now make me feel like a soliloquizing vulture. But this is still in my tree and I use it daily with www/surf. For example my ~/.xsession contains: surf -e `tabbed -d` Please, any objections or any OKs to import? On Sat, Nov 12, 2011 at 03:07:33PM +0100, Joerg Zinke wrote: Bump. No responses yet. Flames or okay from anyone? On Fri, 16 Sep 2011 16:13:03 +0200 Joerg Zinke m...@umaxx.net wrote: Hi, please find attached a port for tabbed-0.3 Description: Simple generic tabbed fronted to xembed aware applications, originally designed for surf but also usable with many other application, i.e. uzbl, urxvt and xterm. More info: http://tools.suckless.org/tabbed Port is attached or can be downloaded from: https://www.umaxx.net/src/tabbed.tar.gz The port and patches are modeled after other suckless ports (dwm). Please test, comment and give OKs. Regards, Joerg tabbed.tar.gz Description: application/tar-gz
Re: NEW: x11/tabbed
On Sun, Jul 08, 2012 at 03:35:41PM +0200, Joerg Zinke wrote: Hi Stuart, On Sun, Jul 08, 2012 at 02:51:53PM +0200, Stuart Henderson wrote: Add something like this MAKE_FLAGS= CC=${CC} Done. then it's ok sthen, tested with urxvt. Upstream rolled a new release *last* night. Please find an update for tabbed-0.4 attached. This new release is more generic and can handle arbitrary xembed aware applications. Examples from the manpage: $ tabbed surf -e $ tabbed urxvt -embed $ tabbed xterm -into $ $(tabbed -d /tmp/tabbed.xid); urxvt -embed $(/tmp/tabbed.xid); Please test (once again). Works fine here @i386, a nice one to have ! I'm not really fond of patches/patch-config_def_h but you get to choose the defaults since you maintain it :) ok for me Landry
Re: NEW: x11/tabbed
Bumping this up now make me feel like a soliloquizing vulture. But this is still in my tree and I use it daily with www/surf. For example my ~/.xsession contains: surf -e `tabbed -d` Please, any objections or any OKs to import? On Sat, Nov 12, 2011 at 03:07:33PM +0100, Joerg Zinke wrote: Bump. No responses yet. Flames or okay from anyone? On Fri, 16 Sep 2011 16:13:03 +0200 Joerg Zinke m...@umaxx.net wrote: Hi, please find attached a port for tabbed-0.3 Description: Simple generic tabbed fronted to xembed aware applications, originally designed for surf but also usable with many other application, i.e. uzbl, urxvt and xterm. More info: http://tools.suckless.org/tabbed Port is attached or can be downloaded from: https://www.umaxx.net/src/tabbed.tar.gz The port and patches are modeled after other suckless ports (dwm). Please test, comment and give OKs. Regards, Joerg tabbed.tar.gz Description: application/tar-gz
Re: NEW: x11/tabbed
Bump. No responses yet. Flames or okay from anyone? On Fri, 16 Sep 2011 16:13:03 +0200 Joerg Zinke m...@umaxx.net wrote: Hi, please find attached a port for tabbed-0.3 Description: Simple generic tabbed fronted to xembed aware applications, originally designed for surf but also usable with many other application, i.e. uzbl, urxvt and xterm. More info: http://tools.suckless.org/tabbed Port is attached or can be downloaded from: https://www.umaxx.net/src/tabbed.tar.gz The port and patches are modeled after other suckless ports (dwm). Please test, comment and give OKs. Regards, Joerg tabbed.tar.gz Description: GNU Zip compressed data
Re: NEW: x11/tabbed
On Tue, Dec 22, 2009 at 10:55:32PM +, Cesare Gargano wrote: While this is a nice tool, some things are still slightly wrong. With tabbed(1) itself as well as with the port: [...] See this. http://marc.info/?l=openbsd-portsm=125856017426815w=2 It still doesn't fix the problems I mentioned. Here's a slightly better version of the port (based on Jona Joacjims submission), but still not very useful (hardcoded surf). Ciao, Kili tabbed.tgz Description: application/tar-gz
Re: NEW: x11/tabbed
Hi, On Tue, Dec 22, 2009 at 04:45:50PM +0100, Jona Joachim wrote: From pkg/DESCR: Tabbed is a simple generic tabbed fronted to Xembed aware applications, originally designed for surf but also usable with many other applications, i.e. uzbl, urxvt and xterm. To get started: TABBEDWID=`tabbed -d` surf -e ${TABBEDWID} xterm -into ${TABBEDWID} While this is a nice tool, some things are still slightly wrong. With tabbed(1) itself as well as with the port: - It hard-codes terminus as its font, so it should run-depend on it. - It hard-codes surf as the program started on Ctrl-Shift-Return. So it should either run-depend on surf, or you should patch the action to just launching an xterm (I'd prefer the latter, even if the intention of the suckless people was to write this tool mainly for surf). - The usage mentioned in the README contained in the distfile, the usage message displayed by tabbed(1), and the usage in the manpage differ. Furthermore, something like $ tabbed http://www.openbsd.org doesn't work. At least the manpage should be fixed (that's probably something you want to send upstream). Also, the manpage should mention that the tabbed(1) writes the window id to stdout. Adding an example section with the example you mention would be a good idea (of course, also for upstream). - Providing a config.mk in files/ isn't good. All this could be overridden from the port makefile (using MAKE_FLAGS). However, even this isn't enough (see next point). - CFLAGS and LDFLAGS aren't honoured, and the executable isn't stripped. I think you should patch the Makefile to an absolute minimum and use ${BSD_INSTALL_PROGRAM} and the other BSD_INSTALL_* variables provided by the ports framework. This way you'll get a stripped executable automagically unless DEBUG is set (e.g. DEBUG=-g). And since the Makefile has to be patched, you can as well patch it to use CFLAGS and LDFLAGS from the environment. And please get rid of things like -Os in CFLAGS ;-) Ciao, Kili ps: while the stuff from suckless.org is really neat, their Makefiles almost always suck more.
Re: NEW: x11/tabbed
On Tue, Dec 22, 2009 at 08:57:26PM +0100, Matthias Kilian wrote: Hi, On Tue, Dec 22, 2009 at 04:45:50PM +0100, Jona Joachim wrote: From pkg/DESCR: Tabbed is a simple generic tabbed fronted to Xembed aware applications, originally designed for surf but also usable with many other applications, i.e. uzbl, urxvt and xterm. To get started: TABBEDWID=`tabbed -d` surf -e ${TABBEDWID} xterm -into ${TABBEDWID} While this is a nice tool, some things are still slightly wrong. With tabbed(1) itself as well as with the port: - It hard-codes terminus as its font, so it should run-depend on it. - It hard-codes surf as the program started on Ctrl-Shift-Return. So it should either run-depend on surf, or you should patch the action to just launching an xterm (I'd prefer the latter, even if the intention of the suckless people was to write this tool mainly for surf). - The usage mentioned in the README contained in the distfile, the usage message displayed by tabbed(1), and the usage in the manpage differ. Furthermore, something like $ tabbed http://www.openbsd.org doesn't work. At least the manpage should be fixed (that's probably something you want to send upstream). Also, the manpage should mention that the tabbed(1) writes the window id to stdout. Adding an example section with the example you mention would be a good idea (of course, also for upstream). - Providing a config.mk in files/ isn't good. All this could be overridden from the port makefile (using MAKE_FLAGS). However, even this isn't enough (see next point). - CFLAGS and LDFLAGS aren't honoured, and the executable isn't stripped. I think you should patch the Makefile to an absolute minimum and use ${BSD_INSTALL_PROGRAM} and the other BSD_INSTALL_* variables provided by the ports framework. This way you'll get a stripped executable automagically unless DEBUG is set (e.g. DEBUG=-g). And since the Makefile has to be patched, you can as well patch it to use CFLAGS and LDFLAGS from the environment. And please get rid of things like -Os in CFLAGS ;-) Ciao, Kili ps: while the stuff from suckless.org is really neat, their Makefiles almost always suck more. See this. http://marc.info/?l=openbsd-portsm=125856017426815w=2 See you! C.
Re: NEW: x11/tabbed
On Tue, Dec 22, 2009 at 10:55:32PM +, Cesare Gargano wrote: On Tue, Dec 22, 2009 at 08:57:26PM +0100, Matthias Kilian wrote: Hi, On Tue, Dec 22, 2009 at 04:45:50PM +0100, Jona Joachim wrote: [snip] See this. http://marc.info/?l=openbsd-portsm=125856017426815w=2 sorry, didn't see that -- Worse is better Richard P. Gabriel