Re: UPDATE: security/aircrack-ng to 1.5.2 fix linking on i386, use ld.bfd

2019-03-08 Thread Stuart Henderson
In the absence of a better idea, if it runs OK with this, then go ahead.
Please add a comment to the Makefile next to USE_LLD like this so people
can see the error without finding an i386 and building:

# ld: error: undefined symbol: __i686.get_pc_thunk.bx


On 2019/03/08 19:49, Sebastian Reitenbach wrote:
> anyone?
>=20
> Am Samstag, M=E4rz 02, 2019 19:07 CET, "Sebastian Reitenbach"  schrieb:
>=20
> > Am Mittwoch, Februar 27, 2019 19:50 CET, Stuart Henderson  schrieb:
> >
> > > this update fails on i386:
> > >
> > > /usr/bin/libtool --tag=3Ddisable-static  --tag=3DCC   --mode=3Dlink c=
c -pthread   -Wall -Wno-unused-command-line-argument -O3 -std=3Dgnu99 -fno-=
strict-aliasing -Wpointer-arith -Wstrict-overflow=3D2 -Wstrict-prototypes -=
fvisibility=3Dhidden -fstack-protector-strong -Wno-array-bounds -O2 -pipe -=
release 1.3.0 -no-undefined  -o libaircrack-crypto.la -rpath /usr/local/lib=
 libaircrack_crypto_la-memory.lo libaircrack_crypto_la-sha1-git.lo libaircr=
ack_crypto_la-wpapsk.lo libaircrack_crypto_la-crypto_engine.lo sha1-sse2.lo=
 -lpthread -lcrypto -lz -lm
> > > libtool: link: cc -shared -fPIC -DPIC -o .libs/libaircrack-crypto-1.3=
=2E0.so -pthread -Wall -Wno-unused-command-line-argument -O3 -std=3Dgnu99 -=
fno-strict-aliasing -Wpointer-arith -Wstrict-overflow=3D2 -Wstrict-prototyp=
es -fvisibility=3Dhidden -fstack-protector-strong -Wno-array-bounds -O2 -pi=
pe .libs/libaircrack_crypto_la-memory.o .libs/libaircrack_crypto_la-sha1-gi=
t.o .libs/libaircrack_crypto_la-wpapsk.o .libs/libaircrack_crypto_la-crypto=
_engine.o .libs/sha1-sse2.o -L.libs -lpthread -lcrypto -lz -lm -Wl,-soname,=
libaircrack-crypto-1.3.0.so
> > > ld: error: undefined symbol: __i686.get_pc_thunk.bx
> > > >>> referenced by sha1-sse2.S
> > > >>>   .libs/sha1-sse2.o:(.text+0x1)
> > >
> > > ld: error: undefined symbol: __i686.get_pc_thunk.bx
> > > >>> referenced by sha1-sse2.S
> > > >>>   .libs/sha1-sse2.o:(.text+0x4D)
> > >
> > > ld: error: undefined symbol: __i686.get_pc_thunk.bx
> > > >>> referenced by sha1-sse2.S
> > > >>>   .libs/sha1-sse2.o:(.text+0x185)
> > > cc: error: linker command failed with exit code 1 (use -v to see invo=
cation)
> > > Error while executing cc -shared -fPIC -DPIC -o .libs/libaircrack-cry=
pto-1.3.0.so -pthread -Wall -Wno-unused-command-line-argument -O3 -std=3Dgn=
u99 -fno-strict-aliasing -Wpointer-arith -Wstrict-overflow=3D2 -Wstrict-pro=
totypes -fvisibility=3Dhidden -fstack-protector-strong -Wno-array-bounds -O=
2 -pipe .libs/libaircrack_crypto_la-memory.o .libs/libaircrack_crypto_la-sh=
a1-git.o .libs/libaircrack_crypto_la-wpapsk.o .libs/libaircrack_crypto_la-c=
rypto_engine.o .libs/sha1-sse2.o -L.libs -lpthread -lcrypto -lz -lm -Wl,-so=
name,libaircrack-crypto-1.3.0.so
> > >
> > > Full log below.
> >
> > seems the linker. The snapshot I made the port on was from Mid/End of J=
anuary.
> > Updated to a recent snapshot, and ran into the same issue.
> > Following patch lets me build it, basically USE_LLD=3DNo
> > The USE_LIBTOOL line accidently snucked in when I updated it.
> > I bumpred revision, since removal of the USE_LIBTOOL for other
> > platforms than i386.
> >
> > My limited research so far says, that the linker error has something to=
 do with
> > PIC code, so no idea if there is a better fix for the problem, as this =
is also not
> > really my expert area ;)
> >
> > anyone with a better idea how to work around the problem, and use lld?
> >
> > cheers,
> > Sebastian
> >
> >
> > ? fix-for-i386.diff
> > Index: Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > RCS file: /cvs/ports/security/aircrack-ng/Makefile,v
> > retrieving revision 1.22
> > diff -u -p -u -r1.22 Makefile
> > --- Makefile23 Feb 2019 22:23:25 -  1.22
> > +++ Makefile28 Feb 2019 21:30:09 -
> > @@ -2,6 +2,7 @@
> >
> >  COMMENT=3D 802.11 WEP and WPA-PSK keys cracking program
> >  DISTNAME=3Daircrack-ng-1.5.2
> > +REVISION=3D0
> >  CATEGORIES=3D  security
> >
> >  HOMEPAGE=3Dhttps://www.aircrack-ng.org/
> > @@ -27,7 +28,9 @@ LIB_DEPENDS=3Ddatabases/sqlite3 \
> >  RUN_DEPENDS+=3Dnet/arp-scan,-mac>=3D20190128
> >
> >  USE_GMAKE=3D   Yes
> > -USE_LIBTOOL=3D Yes
> > +.if ${MACHINE_ARCH} =3D=3D "i386"
> > +USE_LLD=3D No
> > +.endif
> >  LIBTOOL_FLAGS=3D   --tag=3Ddisable-static
> >  AUTOCONF_VERSION=3D2.69
> >  AUTOMAKE_VERSION=3D1.16
> >
> >
> >
> >
> > >
> > >
> > > >>> Building on localhost under security/aircrack-ng
> > >BDEPENDS =3D [devel/autoconf/2.69;devel/shtool;devel/metaauto;devel=
/pcre;devel/pkgconf;devel/gmake;devel/automake/1.16;databases/sqlite3;devel=
/libtool]
> > >DIST =3D [security/aircrack-ng:aircrack-ng-1.5.2.tar.gz]
> > >   

Re: UPDATE: security/aircrack-ng to 1.5.2 fix linking on i386, use ld.bfd

2019-03-08 Thread Sebastian Reitenbach
anyone?

Am Samstag, März 02, 2019 19:07 CET, "Sebastian Reitenbach" 
 schrieb:

> Am Mittwoch, Februar 27, 2019 19:50 CET, Stuart Henderson 
>  schrieb:
>
> > this update fails on i386:
> >
> > /usr/bin/libtool --tag=disable-static  --tag=CC   --mode=link cc -pthread   
> > -Wall -Wno-unused-command-line-argument -O3 -std=gnu99 -fno-strict-aliasing 
> > -Wpointer-arith -Wstrict-overflow=2 -Wstrict-prototypes -fvisibility=hidden 
> > -fstack-protector-strong -Wno-array-bounds -O2 -pipe -release 1.3.0 
> > -no-undefined  -o libaircrack-crypto.la -rpath /usr/local/lib 
> > libaircrack_crypto_la-memory.lo libaircrack_crypto_la-sha1-git.lo 
> > libaircrack_crypto_la-wpapsk.lo libaircrack_crypto_la-crypto_engine.lo 
> > sha1-sse2.lo -lpthread -lcrypto -lz -lm
> > libtool: link: cc -shared -fPIC -DPIC -o .libs/libaircrack-crypto-1.3.0.so 
> > -pthread -Wall -Wno-unused-command-line-argument -O3 -std=gnu99 
> > -fno-strict-aliasing -Wpointer-arith -Wstrict-overflow=2 
> > -Wstrict-prototypes -fvisibility=hidden -fstack-protector-strong 
> > -Wno-array-bounds -O2 -pipe .libs/libaircrack_crypto_la-memory.o 
> > .libs/libaircrack_crypto_la-sha1-git.o .libs/libaircrack_crypto_la-wpapsk.o 
> > .libs/libaircrack_crypto_la-crypto_engine.o .libs/sha1-sse2.o -L.libs 
> > -lpthread -lcrypto -lz -lm -Wl,-soname,libaircrack-crypto-1.3.0.so
> > ld: error: undefined symbol: __i686.get_pc_thunk.bx
> > >>> referenced by sha1-sse2.S
> > >>>   .libs/sha1-sse2.o:(.text+0x1)
> >
> > ld: error: undefined symbol: __i686.get_pc_thunk.bx
> > >>> referenced by sha1-sse2.S
> > >>>   .libs/sha1-sse2.o:(.text+0x4D)
> >
> > ld: error: undefined symbol: __i686.get_pc_thunk.bx
> > >>> referenced by sha1-sse2.S
> > >>>   .libs/sha1-sse2.o:(.text+0x185)
> > cc: error: linker command failed with exit code 1 (use -v to see invocation)
> > Error while executing cc -shared -fPIC -DPIC -o 
> > .libs/libaircrack-crypto-1.3.0.so -pthread -Wall 
> > -Wno-unused-command-line-argument -O3 -std=gnu99 -fno-strict-aliasing 
> > -Wpointer-arith -Wstrict-overflow=2 -Wstrict-prototypes -fvisibility=hidden 
> > -fstack-protector-strong -Wno-array-bounds -O2 -pipe 
> > .libs/libaircrack_crypto_la-memory.o .libs/libaircrack_crypto_la-sha1-git.o 
> > .libs/libaircrack_crypto_la-wpapsk.o 
> > .libs/libaircrack_crypto_la-crypto_engine.o .libs/sha1-sse2.o -L.libs 
> > -lpthread -lcrypto -lz -lm -Wl,-soname,libaircrack-crypto-1.3.0.so
> >
> > Full log below.
>
> seems the linker. The snapshot I made the port on was from Mid/End of January.
> Updated to a recent snapshot, and ran into the same issue.
> Following patch lets me build it, basically USE_LLD=No
> The USE_LIBTOOL line accidently snucked in when I updated it.
> I bumpred revision, since removal of the USE_LIBTOOL for other
> platforms than i386.
>
> My limited research so far says, that the linker error has something to do 
> with
> PIC code, so no idea if there is a better fix for the problem, as this is 
> also not
> really my expert area ;)
>
> anyone with a better idea how to work around the problem, and use lld?
>
> cheers,
> Sebastian
>
>
> ? fix-for-i386.diff
> Index: Makefile
> ===
> RCS file: /cvs/ports/security/aircrack-ng/Makefile,v
> retrieving revision 1.22
> diff -u -p -u -r1.22 Makefile
> --- Makefile  23 Feb 2019 22:23:25 -  1.22
> +++ Makefile  28 Feb 2019 21:30:09 -
> @@ -2,6 +2,7 @@
>
>  COMMENT= 802.11 WEP and WPA-PSK keys cracking program
>  DISTNAME=aircrack-ng-1.5.2
> +REVISION=0
>  CATEGORIES=  security
>
>  HOMEPAGE=https://www.aircrack-ng.org/
> @@ -27,7 +28,9 @@ LIB_DEPENDS=databases/sqlite3 \
>  RUN_DEPENDS+=net/arp-scan,-mac>=20190128
>
>  USE_GMAKE=   Yes
> -USE_LIBTOOL= Yes
> +.if ${MACHINE_ARCH} == "i386"
> +USE_LLD= No
> +.endif
>  LIBTOOL_FLAGS=   --tag=disable-static
>  AUTOCONF_VERSION=2.69
>  AUTOMAKE_VERSION=1.16
>
>
>
>
> >
> >
> > >>> Building on localhost under security/aircrack-ng
> >  BDEPENDS = 
> > [devel/autoconf/2.69;devel/shtool;devel/metaauto;devel/pcre;devel/pkgconf;devel/gmake;devel/automake/1.16;databases/sqlite3;devel/libtool]
> >  DIST = [security/aircrack-ng:aircrack-ng-1.5.2.tar.gz]
> >  FULLPKGNAME = aircrack-ng-1.5.2
> >  RDEPENDS = [net/arp-scan,-mac;databases/sqlite3;devel/pcre]
> > (Junk lock obtained for localhost at 1551287252)
> > >>> Running depends in security/aircrack-ng at 1551287252
> >last junk was in devel/p5-MooseX-Log-Log4perl
> > /usr/sbin/pkg_add -aI -Drepair autoconf-2.69p2 automake-1.16.1 
> > gmake-4.2.1p0 libtool-2.4.2p0 metaauto-1.0p3 pcre-8.41p2 pkgconf-1.4.2 
> > shtool-2.0.8 sqlite3-3.26.0
> > was: /usr/sbin/pkg_add -aI -Drepair autoconf-2.69p2 automake-1.16.1 
> > gmake-4.2.1p0 libtool-2.4.2p0 metaauto-1.0p3 pcre-8.41p2 pkgconf-1.4.2 
> > shtool-2.0.8 

Re: UPDATE: security/aircrack-ng to 1.5.2

2019-03-02 Thread Sebastian Reitenbach
Am Mittwoch, Februar 27, 2019 19:50 CET, Stuart Henderson 
 schrieb:

> this update fails on i386:
>
> /usr/bin/libtool --tag=disable-static  --tag=CC   --mode=link cc -pthread   
> -Wall -Wno-unused-command-line-argument -O3 -std=gnu99 -fno-strict-aliasing 
> -Wpointer-arith -Wstrict-overflow=2 -Wstrict-prototypes -fvisibility=hidden 
> -fstack-protector-strong -Wno-array-bounds -O2 -pipe -release 1.3.0 
> -no-undefined  -o libaircrack-crypto.la -rpath /usr/local/lib 
> libaircrack_crypto_la-memory.lo libaircrack_crypto_la-sha1-git.lo 
> libaircrack_crypto_la-wpapsk.lo libaircrack_crypto_la-crypto_engine.lo 
> sha1-sse2.lo -lpthread -lcrypto -lz -lm
> libtool: link: cc -shared -fPIC -DPIC -o .libs/libaircrack-crypto-1.3.0.so 
> -pthread -Wall -Wno-unused-command-line-argument -O3 -std=gnu99 
> -fno-strict-aliasing -Wpointer-arith -Wstrict-overflow=2 -Wstrict-prototypes 
> -fvisibility=hidden -fstack-protector-strong -Wno-array-bounds -O2 -pipe 
> .libs/libaircrack_crypto_la-memory.o .libs/libaircrack_crypto_la-sha1-git.o 
> .libs/libaircrack_crypto_la-wpapsk.o 
> .libs/libaircrack_crypto_la-crypto_engine.o .libs/sha1-sse2.o -L.libs 
> -lpthread -lcrypto -lz -lm -Wl,-soname,libaircrack-crypto-1.3.0.so
> ld: error: undefined symbol: __i686.get_pc_thunk.bx
> >>> referenced by sha1-sse2.S
> >>>   .libs/sha1-sse2.o:(.text+0x1)
>
> ld: error: undefined symbol: __i686.get_pc_thunk.bx
> >>> referenced by sha1-sse2.S
> >>>   .libs/sha1-sse2.o:(.text+0x4D)
>
> ld: error: undefined symbol: __i686.get_pc_thunk.bx
> >>> referenced by sha1-sse2.S
> >>>   .libs/sha1-sse2.o:(.text+0x185)
> cc: error: linker command failed with exit code 1 (use -v to see invocation)
> Error while executing cc -shared -fPIC -DPIC -o 
> .libs/libaircrack-crypto-1.3.0.so -pthread -Wall 
> -Wno-unused-command-line-argument -O3 -std=gnu99 -fno-strict-aliasing 
> -Wpointer-arith -Wstrict-overflow=2 -Wstrict-prototypes -fvisibility=hidden 
> -fstack-protector-strong -Wno-array-bounds -O2 -pipe 
> .libs/libaircrack_crypto_la-memory.o .libs/libaircrack_crypto_la-sha1-git.o 
> .libs/libaircrack_crypto_la-wpapsk.o 
> .libs/libaircrack_crypto_la-crypto_engine.o .libs/sha1-sse2.o -L.libs 
> -lpthread -lcrypto -lz -lm -Wl,-soname,libaircrack-crypto-1.3.0.so
>
> Full log below.

seems the linker. The snapshot I made the port on was from Mid/End of January.
Updated to a recent snapshot, and ran into the same issue.
Following patch lets me build it, basically USE_LLD=No
The USE_LIBTOOL line accidently snucked in when I updated it.
I bumpred revision, since removal of the USE_LIBTOOL for other
platforms than i386.

My limited research so far says, that the linker error has something to do with
PIC code, so no idea if there is a better fix for the problem, as this is also 
not
really my expert area ;)

anyone with a better idea how to work around the problem, and use lld?

cheers,
Sebastian


? fix-for-i386.diff
Index: Makefile
===
RCS file: /cvs/ports/security/aircrack-ng/Makefile,v
retrieving revision 1.22
diff -u -p -u -r1.22 Makefile
--- Makefile23 Feb 2019 22:23:25 -  1.22
+++ Makefile28 Feb 2019 21:30:09 -
@@ -2,6 +2,7 @@

 COMMENT=   802.11 WEP and WPA-PSK keys cracking program
 DISTNAME=  aircrack-ng-1.5.2
+REVISION=  0
 CATEGORIES=security

 HOMEPAGE=  https://www.aircrack-ng.org/
@@ -27,7 +28,9 @@ LIB_DEPENDS=  databases/sqlite3 \
 RUN_DEPENDS+=  net/arp-scan,-mac>=20190128

 USE_GMAKE= Yes
-USE_LIBTOOL=   Yes
+.if ${MACHINE_ARCH} == "i386"
+USE_LLD=   No
+.endif
 LIBTOOL_FLAGS= --tag=disable-static
 AUTOCONF_VERSION=  2.69
 AUTOMAKE_VERSION=  1.16




>
>
> >>> Building on localhost under security/aircrack-ng
>BDEPENDS = 
> [devel/autoconf/2.69;devel/shtool;devel/metaauto;devel/pcre;devel/pkgconf;devel/gmake;devel/automake/1.16;databases/sqlite3;devel/libtool]
>DIST = [security/aircrack-ng:aircrack-ng-1.5.2.tar.gz]
>FULLPKGNAME = aircrack-ng-1.5.2
>RDEPENDS = [net/arp-scan,-mac;databases/sqlite3;devel/pcre]
> (Junk lock obtained for localhost at 1551287252)
> >>> Running depends in security/aircrack-ng at 1551287252
>last junk was in devel/p5-MooseX-Log-Log4perl
> /usr/sbin/pkg_add -aI -Drepair autoconf-2.69p2 automake-1.16.1 gmake-4.2.1p0 
> libtool-2.4.2p0 metaauto-1.0p3 pcre-8.41p2 pkgconf-1.4.2 shtool-2.0.8 
> sqlite3-3.26.0
> was: /usr/sbin/pkg_add -aI -Drepair autoconf-2.69p2 automake-1.16.1 
> gmake-4.2.1p0 libtool-2.4.2p0 metaauto-1.0p3 pcre-8.41p2 pkgconf-1.4.2 
> shtool-2.0.8 sqlite3-3.26.0
> /usr/sbin/pkg_add -aI -Drepair autoconf-2.69p2 automake-1.16.1 gmake-4.2.1p0 
> libtool-2.4.2p0 metaauto-1.0p3 pcre-8.41p2 pkgconf-1.4.2 shtool-2.0.8 
> sqlite3-3.26.0
> >>> Running show-prepare-results in security/aircrack-ng at 1551287257
> ===> security/aircrack-ng
> 

Re: UPDATE: security/aircrack-ng to 1.5.2

2019-02-27 Thread Stuart Henderson
this update fails on i386:

/usr/bin/libtool --tag=3Ddisable-static  --tag=3DCC   --mode=3Dlink cc -pth=
read   -Wall -Wno-unused-command-line-argument -O3 -std=3Dgnu99 -fno-strict=
-aliasing -Wpointer-arith -Wstrict-overflow=3D2 -Wstrict-prototypes -fvisib=
ility=3Dhidden -fstack-protector-strong -Wno-array-bounds -O2 -pipe -releas=
e 1.3.0 -no-undefined  -o libaircrack-crypto.la -rpath /usr/local/lib libai=
rcrack_crypto_la-memory.lo libaircrack_crypto_la-sha1-git.lo libaircrack_cr=
ypto_la-wpapsk.lo libaircrack_crypto_la-crypto_engine.lo sha1-sse2.lo -lpth=
read -lcrypto -lz -lm
libtool: link: cc -shared -fPIC -DPIC -o .libs/libaircrack-crypto-1.3.0.so =
-pthread -Wall -Wno-unused-command-line-argument -O3 -std=3Dgnu99 -fno-stri=
ct-aliasing -Wpointer-arith -Wstrict-overflow=3D2 -Wstrict-prototypes -fvis=
ibility=3Dhidden -fstack-protector-strong -Wno-array-bounds -O2 -pipe .libs=
/libaircrack_crypto_la-memory.o .libs/libaircrack_crypto_la-sha1-git.o .lib=
s/libaircrack_crypto_la-wpapsk.o .libs/libaircrack_crypto_la-crypto_engine.=
o .libs/sha1-sse2.o -L.libs -lpthread -lcrypto -lz -lm -Wl,-soname,libaircr=
ack-crypto-1.3.0.so
ld: error: undefined symbol: __i686.get_pc_thunk.bx
>>> referenced by sha1-sse2.S
>>>   .libs/sha1-sse2.o:(.text+0x1)

ld: error: undefined symbol: __i686.get_pc_thunk.bx
>>> referenced by sha1-sse2.S
>>>   .libs/sha1-sse2.o:(.text+0x4D)

ld: error: undefined symbol: __i686.get_pc_thunk.bx
>>> referenced by sha1-sse2.S
>>>   .libs/sha1-sse2.o:(.text+0x185)
cc: error: linker command failed with exit code 1 (use -v to see invocation)
Error while executing cc -shared -fPIC -DPIC -o .libs/libaircrack-crypto-1.=
3.0.so -pthread -Wall -Wno-unused-command-line-argument -O3 -std=3Dgnu99 -f=
no-strict-aliasing -Wpointer-arith -Wstrict-overflow=3D2 -Wstrict-prototype=
s -fvisibility=3Dhidden -fstack-protector-strong -Wno-array-bounds -O2 -pip=
e .libs/libaircrack_crypto_la-memory.o .libs/libaircrack_crypto_la-sha1-git=
=2Eo .libs/libaircrack_crypto_la-wpapsk.o .libs/libaircrack_crypto_la-crypt=
o_engine.o .libs/sha1-sse2.o -L.libs -lpthread -lcrypto -lz -lm -Wl,-soname=
,libaircrack-crypto-1.3.0.so

Full log below.


>>> Building on localhost under security/aircrack-ng
 BDEPENDS =3D 
[devel/autoconf/2.69;devel/shtool;devel/metaauto;devel/pcre;=
devel/pkgconf;devel/gmake;devel/automake/1.16;databases/sqlite3;devel/libto=
ol]
 DIST =3D [security/aircrack-ng:aircrack-ng-1.5.2.tar.gz]
 FULLPKGNAME =3D aircrack-ng-1.5.2
 RDEPENDS =3D [net/arp-scan,-mac;databases/sqlite3;devel/pcre]
(Junk lock obtained for localhost at 1551287252)
>>> Running depends in security/aircrack-ng at 1551287252
   last junk was in devel/p5-MooseX-Log-Log4perl
/usr/sbin/pkg_add -aI -Drepair autoconf-2.69p2 automake-1.16.1 gmake-4.2.1p=
0 libtool-2.4.2p0 metaauto-1.0p3 pcre-8.41p2 pkgconf-1.4.2 shtool-2.0.8 sql=
ite3-3.26.0
was: /usr/sbin/pkg_add -aI -Drepair autoconf-2.69p2 automake-1.16.1 gmake-4=
=2E2.1p0 libtool-2.4.2p0 metaauto-1.0p3 pcre-8.41p2 pkgconf-1.4.2 shtool-2.=
0.8 sqlite3-3.26.0
/usr/sbin/pkg_add -aI -Drepair autoconf-2.69p2 automake-1.16.1 gmake-4.2.1p=
0 libtool-2.4.2p0 metaauto-1.0p3 pcre-8.41p2 pkgconf-1.4.2 shtool-2.0.8 sql=
ite3-3.26.0
>>> Running show-prepare-results in security/aircrack-ng at 1551287257
=3D=3D=3D> security/aircrack-ng
=3D=3D=3D> aircrack-ng-1.5.2 depends on: metaauto-* -> metaauto-1.0p3
=3D=3D=3D> aircrack-ng-1.5.2 depends on: autoconf-2.69 -> autoconf-2.69p2
=3D=3D=3D> aircrack-ng-1.5.2 depends on: automake->=3D1.16,<1.17 -> automak=
e-1.16.1
=3D=3D=3D> aircrack-ng-1.5.2 depends on: libtool-* -> libtool-2.4.2p0
=3D=3D=3D> aircrack-ng-1.5.2 depends on: shtool-* -> shtool-2.0.8
=3D=3D=3D> aircrack-ng-1.5.2 depends on: pkgconf-* -> pkgconf-1.4.2
=3D=3D=3D> aircrack-ng-1.5.2 depends on: gmake-* -> gmake-4.2.1p0
=3D=3D=3D> aircrack-ng-1.5.2 depends on: sqlite3-* -> sqlite3-3.26.0
=3D=3D=3D> aircrack-ng-1.5.2 depends on: pcre-* -> pcre-8.41p2
=3D=3D=3D>  Verifying specs:  c pthread crypto z pcre c++ c++abi pthread m =
sqlite3
=3D=3D=3D>  found c.95.0 pthread.26.1 crypto.45.3 z.5.0 pcre.3.0 c++.2.1 c+=
+abi.0.1 m.10.1 sqlite3.37.4
autoconf-2.69p2
automake-1.16.1
gmake-4.2.1p0
libtool-2.4.2p0
metaauto-1.0p3
pcre-8.41p2
pkgconf-1.4.2
shtool-2.0.8
sqlite3-3.26.0
(Junk lock released for localhost at 1551287258)
distfiles size=3D7138360
>>> Running extract in security/aircrack-ng at 1551287258
=3D=3D=3D> security/aircrack-ng
=3D=3D=3D>  Checking files for aircrack-ng-1.5.2
`/mnt/distfiles/aircrack-ng-1.5.2.tar.gz' is up to date.
=3D=3D=3D>  Extracting for aircrack-ng-1.5.2
>>> Running patch in security/aircrack-ng at 1551287260
=3D=3D=3D> security/aircrack-ng
=3D=3D=3D>  Patching for aircrack-ng-1.5.2
=3D=3D=3D>   Applying OpenBSD patch patch-src_Makefile_am
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--
|$OpenBSD: patch-src_Makefile_am,v 1.1 2019/02/23 22:23:25 sebastia 

Re: UPDATE: security/aircrack-ng to 1.5.2

2019-02-22 Thread Benoit Lecocq




On 2/1/19 11:16 PM, Sebastian Reitenbach wrote:

Am Dienstag, Januar 29, 2019 16:29 CET, "Sebastian Reitenbach" 
 schrieb:


Hi,

I think I addressed all the comments/concerns:
  * homepage and mastersite HTTPS
  * run autoreconfig in do-gen: stage
  * fix to use base libtool (had to patch Makefile.am to explicitly add library 
our base libtool did
 not find)
  * don't install airtun-ng manpage
  * added LIBTOOL_FLAGS to disable static libs
  * the libaircrack-crypto* libraries are loaded via dlopen, however there seem 
to be some
 of them arch-dependent I only tested building on amd64 and i386, so didn't 
spotted it
  * Added PFRAG.ARCH for x86, ppc and arm
  * added RUN_DEPENDS to mac-vendors package, and point airodump-ng to that OUI 
file,
therefore the README is obsolete, so deleted it
  * I haven't seen anything to put the crypto libraries into a subdirectory

In src/aircrack-util/crypto_engine_loader.c there is this:
 if (simd_features & SIMD_SUPPORTS_AVX512F)
 {
 strncat(buffer, "-x86-avx512", buffer_remaining);
 }
 else if (simd_features & SIMD_SUPPORTS_AVX2)
 {
 strncat(buffer, "-x86-avx2", buffer_remaining);
 }
 else if (simd_features & SIMD_SUPPORTS_AVX)
 {
 strncat(buffer, "-x86-avx", buffer_remaining);
 }
 else if (simd_features & SIMD_SUPPORTS_SSE2)
 {
 strncat(buffer, "-x86-sse2", buffer_remaining);
 }
 else if (simd_features & SIMD_SUPPORTS_ASIMD)
 {
 strncat(buffer, "-arm-neon", buffer_remaining);
 }
 else if (simd_features & SIMD_SUPPORTS_NEON)
 {
 strncat(buffer, "-arm-neon", buffer_remaining);
 }
 else if (simd_features & SIMD_SUPPORTS_POWER8)
 {
 strncat(buffer, "-ppc-power8", buffer_remaining);
 }
 else if (simd_features & SIMD_SUPPORTS_ALTIVEC)
 {
 strncat(buffer, "-ppc-altivec", buffer_remaining);
 }

So I guess the arm crypto libs only built on arm, and ppc-* libs only build
on macppc. Don't know if the arm- one would also be created on aarch64?I don't 
have a working macppc anymore, and don't have any arm type
device around to test there, so tests on other platforms and with otherdevices 
(I only tested with rum(4)) welcome.

updated version attached.


in the meantime also tested with athn on i386, working as well as the rum.


tested on amd64, ok benoit@





cheers,
Sebastian






Re: UPDATE: security/aircrack-ng to 1.5.2

2019-02-01 Thread Sebastian Reitenbach
Am Dienstag, Januar 29, 2019 16:29 CET, "Sebastian Reitenbach" 
 schrieb:

> Hi,
>
> I think I addressed all the comments/concerns:
>  * homepage and mastersite HTTPS
>  * run autoreconfig in do-gen: stage
>  * fix to use base libtool (had to patch Makefile.am to explicitly add 
> library our base libtool did
> not find)
>  * don't install airtun-ng manpage
>  * added LIBTOOL_FLAGS to disable static libs
>  * the libaircrack-crypto* libraries are loaded via dlopen, however there 
> seem to be some
> of them arch-dependent I only tested building on amd64 and i386, so 
> didn't spotted it
>  * Added PFRAG.ARCH for x86, ppc and arm
>  * added RUN_DEPENDS to mac-vendors package, and point airodump-ng to that 
> OUI file,
>therefore the README is obsolete, so deleted it
>  * I haven't seen anything to put the crypto libraries into a subdirectory
>
> In src/aircrack-util/crypto_engine_loader.c there is this:
> if (simd_features & SIMD_SUPPORTS_AVX512F)
> {
> strncat(buffer, "-x86-avx512", buffer_remaining);
> }
> else if (simd_features & SIMD_SUPPORTS_AVX2)
> {
> strncat(buffer, "-x86-avx2", buffer_remaining);
> }
> else if (simd_features & SIMD_SUPPORTS_AVX)
> {
> strncat(buffer, "-x86-avx", buffer_remaining);
> }
> else if (simd_features & SIMD_SUPPORTS_SSE2)
> {
> strncat(buffer, "-x86-sse2", buffer_remaining);
> }
> else if (simd_features & SIMD_SUPPORTS_ASIMD)
> {
> strncat(buffer, "-arm-neon", buffer_remaining);
> }
> else if (simd_features & SIMD_SUPPORTS_NEON)
> {
> strncat(buffer, "-arm-neon", buffer_remaining);
> }
> else if (simd_features & SIMD_SUPPORTS_POWER8)
> {
> strncat(buffer, "-ppc-power8", buffer_remaining);
> }
> else if (simd_features & SIMD_SUPPORTS_ALTIVEC)
> {
> strncat(buffer, "-ppc-altivec", buffer_remaining);
> }
>
> So I guess the arm crypto libs only built on arm, and ppc-* libs only build
> on macppc. Don't know if the arm- one would also be created on aarch64?I 
> don't have a working macppc anymore, and don't have any arm type
> device around to test there, so tests on other platforms and with 
> otherdevices (I only tested with rum(4)) welcome.
>
> updated version attached.

in the meantime also tested with athn on i386, working as well as the rum.

>
> cheers,
> Sebastian



Re: UPDATE: security/aircrack-ng to 1.5.2

2019-01-29 Thread Sebastian Reitenbach
Hi,

I think I addressed all the comments/concerns:
 * homepage and mastersite HTTPS
 * run autoreconfig in do-gen: stage
 * fix to use base libtool (had to patch Makefile.am to explicitly add library 
our base libtool did
not find)
 * don't install airtun-ng manpage
 * added LIBTOOL_FLAGS to disable static libs
 * the libaircrack-crypto* libraries are loaded via dlopen, however there seem 
to be some
of them arch-dependent I only tested building on amd64 and i386, so didn't 
spotted it
 * Added PFRAG.ARCH for x86, ppc and arm
 * added RUN_DEPENDS to mac-vendors package, and point airodump-ng to that OUI 
file,
   therefore the README is obsolete, so deleted it
 * I haven't seen anything to put the crypto libraries into a subdirectory

In src/aircrack-util/crypto_engine_loader.c there is this:
if (simd_features & SIMD_SUPPORTS_AVX512F)
{
strncat(buffer, "-x86-avx512", buffer_remaining);
}
else if (simd_features & SIMD_SUPPORTS_AVX2)
{
strncat(buffer, "-x86-avx2", buffer_remaining);
}
else if (simd_features & SIMD_SUPPORTS_AVX)
{
strncat(buffer, "-x86-avx", buffer_remaining);
}
else if (simd_features & SIMD_SUPPORTS_SSE2)
{
strncat(buffer, "-x86-sse2", buffer_remaining);
}
else if (simd_features & SIMD_SUPPORTS_ASIMD)
{
strncat(buffer, "-arm-neon", buffer_remaining);
}
else if (simd_features & SIMD_SUPPORTS_NEON)
{
strncat(buffer, "-arm-neon", buffer_remaining);
}
else if (simd_features & SIMD_SUPPORTS_POWER8)
{
strncat(buffer, "-ppc-power8", buffer_remaining);
}
else if (simd_features & SIMD_SUPPORTS_ALTIVEC)
{
strncat(buffer, "-ppc-altivec", buffer_remaining);
}

So I guess the arm crypto libs only built on arm, and ppc-* libs only build
on macppc. Don't know if the arm- one would also be created on aarch64?
I don't have a working macppc anymore, and don't have any arm type
device around to test there, so tests on other platforms and with other
devices (I only tested with rum(4)) welcome.

updated version attached.

cheers,
Sebastian


aircrack-ng-1.5.2.diff
Description: Binary data


Re: UPDATE: security/aircrack-ng to 1.5.2

2019-01-28 Thread Sebastian Reitenbach
Hi Stuart, Jeremie,

thanks for your input, I'll look into all of it a.s.a.p. and send updated patch.

cheers,
Sebastian



Am Montag, Januar 28, 2019 17:56 CET, Stuart Henderson  
schrieb:

> On 2019/01/28 16:27, Jeremie Courreges-Anglas wrote:
> > On Mon, Jan 28 2019, "Sebastian Reitenbach"  
> > wrote:
> > > Hi,
> > >
> > > this updates the quite outdated aircrack-ng to currrent 1.5.2 release.
> > > Tested on i386 with rum(4) interface, save captures with airodump,
> > > deauth a couple of clients, wordlist cracking with aircrack-ng.
>
> This could use tests on a wider range of interfaces.
>
> > >  USE_GMAKE=   Yes
> > > +USE_LIBTOOL= gnu
>
> I'd like to see an explanatory comment next to any USE_LIBTOOL=gnu ..
> (or even better a fix to avoid the need).
>
> If this is *only* needed for libtoolize/libtool.m4 then just use
> BUILD_DEPENDS=devel/libtool instead.
>
> > >  pre-configure:
> > > - ${SUBST_CMD} ${WRKSRC}/src/airodump-ng.h
> > > + cd ${WRKSRC} &&  AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
> > > + AUTOCONF_VERSION=${AUTOCONF_VERSION} autoreconf -i
>
> use something like this instead: (from memory, needs checking :)
>
> do-gen:
>   cd ${WRKSRC} && ${AUTOCONF_ENV} autoreconf -i
>
> > > RCS file: patches/patch-scripts_airodump-ng-oui-update
> > > diff -N patches/patch-scripts_airodump-ng-oui-update
> > > --- /dev/null 1 Jan 1970 00:00:00 -
> > > +++ patches/patch-scripts_airodump-ng-oui-update  28 Jan 2019 15:04:26 
> > > -
> > > @@ -0,0 +1,17 @@
> > > +$OpenBSD$
> > > +
> > > +The Windows line breaks break the terminal output
> > > +requires dos2unix installed,
> > > +sed -i 's/\r$//'
> > > +didn't cut it
> > > +
> > > +Index: scripts/airodump-ng-oui-update
> > > +--- scripts/airodump-ng-oui-update.orig
> > >  scripts/airodump-ng-oui-update
> > > +@@ -90,4 +90,6 @@ else
> > > + exit 1
> > > + fi
> > > +
> > > ++dos2unix ${AIRODUMP_NG_OUI}
> > > ++
>
> Looking at 
> https://github.com/aircrack-ng/aircrack-ng/blob/master/scripts/airodump-ng-oui-update
> it seems there are some hardcoded paths (/etc, /usr/local/etc, /usr/share).
>
> But... We already have the OUI database in a couple of formats in
> ports/net/arp-scan,-mac - with the update I just committed I've added a
> new output file that should be in the format aircrack-ng expects.
>
> So if you add a dependency on that and patch the program to use
> ${LOCALBASE}/share/mac-vendor/aircrack-oui.txt instead, users will
> get a reasonably frequently updated file (and then you can drop
> airodump-ng-oui-update with its unnecessary "run wget/curl/dos2unix
> as root" and the step in pkg/README).
>
> > > -@man man/man1/airbase-ng.1
> > > +@bin bin/wpaclean
> > > +lib/libaircrack-crypto-1.3.0.so
> >
> > I guess those are dlopened modules, not shared libs?
> >
> > > +lib/libaircrack-crypto-x86-avx-1.3.0.so
> > > +lib/libaircrack-crypto-x86-avx.a
> > > +lib/libaircrack-crypto-x86-avx.la
> > > +lib/libaircrack-crypto-x86-avx.so
> > > +lib/libaircrack-crypto-x86-avx2-1.3.0.so
> > > +lib/libaircrack-crypto-x86-avx2.a
> > > +lib/libaircrack-crypto-x86-avx2.la
> > > +lib/libaircrack-crypto-x86-avx2.so
> > > +lib/libaircrack-crypto-x86-sse2-1.3.0.so
> > > +lib/libaircrack-crypto-x86-sse2.a
> > > +lib/libaircrack-crypto-x86-sse2.la
> > > +lib/libaircrack-crypto-x86-sse2.so
> >
> > Aren't those x86/amd64 only files?
> >
> > > +lib/libaircrack-crypto.a
> > > +lib/libaircrack-crypto.la
> > > +lib/libaircrack-crypto.so
> > > +lib/libaircrack-osdep-1.3.0.so
> > > +lib/libaircrack-osdep.a
> > > +lib/libaircrack-osdep.la
> > > +lib/libaircrack-osdep.so
>
> Looks like it. And the .a's are probably useless - see if you can
> avoid building them with "LIBTOOL_FLAGS = --tag=disable-static"
>
> Is there a configure flag to use a subdirectory for them?
>



Re: UPDATE: security/aircrack-ng to 1.5.2

2019-01-28 Thread Stuart Henderson
On 2019/01/28 16:27, Jeremie Courreges-Anglas wrote:
> On Mon, Jan 28 2019, "Sebastian Reitenbach"  
> wrote:
> > Hi,
> >
> > this updates the quite outdated aircrack-ng to currrent 1.5.2 release.
> > Tested on i386 with rum(4) interface, save captures with airodump,
> > deauth a couple of clients, wordlist cracking with aircrack-ng.

This could use tests on a wider range of interfaces.

> >  USE_GMAKE= Yes
> > +USE_LIBTOOL=   gnu

I'd like to see an explanatory comment next to any USE_LIBTOOL=gnu ..
(or even better a fix to avoid the need).

If this is *only* needed for libtoolize/libtool.m4 then just use
BUILD_DEPENDS=devel/libtool instead.

> >  pre-configure:
> > -   ${SUBST_CMD} ${WRKSRC}/src/airodump-ng.h
> > +   cd ${WRKSRC} &&  AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
> > +   AUTOCONF_VERSION=${AUTOCONF_VERSION} autoreconf -i

use something like this instead: (from memory, needs checking :)

do-gen:
cd ${WRKSRC} && ${AUTOCONF_ENV} autoreconf -i

> > RCS file: patches/patch-scripts_airodump-ng-oui-update
> > diff -N patches/patch-scripts_airodump-ng-oui-update
> > --- /dev/null   1 Jan 1970 00:00:00 -
> > +++ patches/patch-scripts_airodump-ng-oui-update28 Jan 2019 15:04:26 
> > -
> > @@ -0,0 +1,17 @@
> > +$OpenBSD$
> > +
> > +The Windows line breaks break the terminal output
> > +requires dos2unix installed,
> > +sed -i 's/\r$//'
> > +didn't cut it
> > +
> > +Index: scripts/airodump-ng-oui-update
> > +--- scripts/airodump-ng-oui-update.orig
> >  scripts/airodump-ng-oui-update
> > +@@ -90,4 +90,6 @@ else
> > +   exit 1
> > + fi
> > +
> > ++dos2unix ${AIRODUMP_NG_OUI}
> > ++

Looking at 
https://github.com/aircrack-ng/aircrack-ng/blob/master/scripts/airodump-ng-oui-update
it seems there are some hardcoded paths (/etc, /usr/local/etc, /usr/share).

But... We already have the OUI database in a couple of formats in
ports/net/arp-scan,-mac - with the update I just committed I've added a
new output file that should be in the format aircrack-ng expects.

So if you add a dependency on that and patch the program to use
${LOCALBASE}/share/mac-vendor/aircrack-oui.txt instead, users will
get a reasonably frequently updated file (and then you can drop
airodump-ng-oui-update with its unnecessary "run wget/curl/dos2unix
as root" and the step in pkg/README).

> > -@man man/man1/airbase-ng.1
> > +@bin bin/wpaclean
> > +lib/libaircrack-crypto-1.3.0.so
> 
> I guess those are dlopened modules, not shared libs?
> 
> > +lib/libaircrack-crypto-x86-avx-1.3.0.so
> > +lib/libaircrack-crypto-x86-avx.a
> > +lib/libaircrack-crypto-x86-avx.la
> > +lib/libaircrack-crypto-x86-avx.so
> > +lib/libaircrack-crypto-x86-avx2-1.3.0.so
> > +lib/libaircrack-crypto-x86-avx2.a
> > +lib/libaircrack-crypto-x86-avx2.la
> > +lib/libaircrack-crypto-x86-avx2.so
> > +lib/libaircrack-crypto-x86-sse2-1.3.0.so
> > +lib/libaircrack-crypto-x86-sse2.a
> > +lib/libaircrack-crypto-x86-sse2.la
> > +lib/libaircrack-crypto-x86-sse2.so
> 
> Aren't those x86/amd64 only files?
> 
> > +lib/libaircrack-crypto.a
> > +lib/libaircrack-crypto.la
> > +lib/libaircrack-crypto.so
> > +lib/libaircrack-osdep-1.3.0.so
> > +lib/libaircrack-osdep.a
> > +lib/libaircrack-osdep.la
> > +lib/libaircrack-osdep.so

Looks like it. And the .a's are probably useless - see if you can
avoid building them with "LIBTOOL_FLAGS = --tag=disable-static"

Is there a configure flag to use a subdirectory for them?



Re: UPDATE: security/aircrack-ng to 1.5.2

2019-01-28 Thread Jeremie Courreges-Anglas
On Mon, Jan 28 2019, "Sebastian Reitenbach"  
wrote:
> Hi,
>
> this updates the quite outdated aircrack-ng to currrent 1.5.2 release.
> Tested on i386 with rum(4) interface, save captures with airodump,
> deauth a couple of clients, wordlist cracking with aircrack-ng.
>
> Also installed airodump-ng-oui-update script that fetches the oui
> data. It's using wget or curl to fetch it, however I didn't put these
> into the RUN_DEPS, since one of them is most likely installed already
> as well as the script tells you if it can't find it.
>
> Any comments, tests or even OK?

The patch doesn't apply here.

--8<--
[...]
Patching file patches/patch-common_mak using Plan A...
Empty context always matches.
Hunk #1 failed at 0.
1 out of 1 hunks failed--saving rejects to patches/patch-common_mak.rej
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--
|Index: patches/patch-manpages_airodump-ng_1
|===
|RCS file: patches/patch-manpages_airodump-ng_1
|diff -N patches/patch-manpages_airodump-ng_1
|--- patches/patch-manpages_airodump-ng_1   17 Feb 2015 19:47:01 -  
1.1
|+++ /dev/null  1 Jan 1970 00:00:00 -
--
Patching file patches/patch-manpages_airodump-ng_1 using Plan A...
patch:  malformed patch at line 145: format (it is a shortcut for --ivs). 
'csv' will create an airodump-ng
-->8--

You're using dos2unix but it's not listed in BUILD_DEPENDS. sed(1) won't
recognize s/\r$// but perl -pi -e can handle it.

Looks like both HOMEPAGE and MASTER_SITES can be moved to https.

> Index: Makefile
> ===
> RCS file: /cvs/ports/security/aircrack-ng/Makefile,v
> retrieving revision 1.21
> diff -u -r1.21 Makefile
> --- Makefile  4 Sep 2018 12:46:20 -   1.21
> +++ Makefile  28 Jan 2019 15:04:26 -
> @@ -1,8 +1,7 @@
>  # $OpenBSD: Makefile,v 1.21 2018/09/04 12:46:20 espie Exp $
>
>  COMMENT= 802.11 WEP and WPA-PSK keys cracking program
> -DISTNAME=aircrack-ng-1.1
> -REVISION=15
> +DISTNAME=aircrack-ng-1.5.2
>  CATEGORIES=  security
>
>  HOMEPAGE=http://www.aircrack-ng.org/
> @@ -12,23 +11,31 @@
>  # GPLv2
>  PERMIT_PACKAGE_CDROM=   Yes
>
> -WANTLIB= c pthread crypto ssl z
> +WANTLIB+=c pthread crypto z pcre
> +WANTLIB+=${COMPILER_LIBCXX} m sqlite3
>
>  MASTER_SITES=http://download.aircrack-ng.org/
>
> -WANTLIB +=   sqlite3
> -LIB_DEPENDS= databases/sqlite3
> +BUILD_DEPENDS=   devel/shtool \
> + devel/pkgconf
> +LIB_DEPENDS= databases/sqlite3 \
> + devel/pcre
>
>  USE_GMAKE=   Yes
> +USE_LIBTOOL= gnu
> +AUTOCONF_VERSION=2.69
> +AUTOMAKE_VERSION=1.16
> +CONFIGURE_STYLE= gnu
> +
>  MAKE_ENV+=   SQLITE=true UNSTABLE=true
>  MAKE_FLAGS+= CC=${CC}
>
> -NO_TEST= Yes
> -
> -post-extract:
> - perl -i -pe 's/\r\n/\n/' ${WRKSRC}/src/osdep/byteorder.h
> -
>  pre-configure:
> - ${SUBST_CMD} ${WRKSRC}/src/airodump-ng.h
> + cd ${WRKSRC} &&  AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
> + AUTOCONF_VERSION=${AUTOCONF_VERSION} autoreconf -i
> +
> +post-install:
> + ${INSTALL_SCRIPT} ${WRKSRC}/scripts/airodump-ng-oui-update \
> + ${PREFIX}/bin/airodump-ng-oui-update
>
>  .include 
> Index: distinfo
> ===
> RCS file: /cvs/ports/security/aircrack-ng/distinfo,v
> retrieving revision 1.3
> diff -u -r1.3 distinfo
> --- distinfo  1 Jul 2014 12:15:10 -   1.3
> +++ distinfo  28 Jan 2019 15:04:26 -
> @@ -1,2 +1,2 @@
> -SHA256 (aircrack-ng-1.1.tar.gz) = 
> sTa1SbfSonUcIXkxAAdepDso3pr0wZaVCLuVvMkiJK0=
> -SIZE (aircrack-ng-1.1.tar.gz) = 1453272
> +SHA256 (aircrack-ng-1.5.2.tar.gz) = 
> nlkv52WARiIOCsCm0FxAJpA/MHeySIk+AFbMvk7ogkE=
> +SIZE (aircrack-ng-1.5.2.tar.gz) = 7138360
> Index: patches/patch-common_mak
> ===
> RCS file: patches/patch-common_mak
> diff -N patches/patch-common_mak
> --- patches/patch-common_mak  6 May 2009 20:39:29 -   1.1.1.1
> +++ /dev/null 1 Jan 1970 00:00:00 -
> @@ -1,32 +0,0 @@
>  common.mak.orig  Thu Mar 26 22:01:02 2009
> -+++ common.mak   Wed Apr 15 18:36:48 2009
> -@@ -31,16 +31,16 @@ COMMON_CFLAGS   += -DCYGWIN
> - endif
> -
> - ifeq ($(SQLITE), true)
> --COMMON_CFLAGS   += -I/usr/local/include -DHAVE_SQLITE
> -+COMMON_CFLAGS   += -I${LOCALBASE}/include -DHAVE_SQLITE
> - else
> - ifeq ($(sqlite), true)
> --COMMON_CFLAGS   += -I/usr/local/include -DHAVE_SQLITE
> -+COMMON_CFLAGS   += -I${LOCALBASE}/include -DHAVE_SQLITE
> - else
> - ifeq ($(SQLITE), TRUE)
> --COMMON_CFLAGS   += 

UPDATE: security/aircrack-ng to 1.5.2

2019-01-28 Thread Sebastian Reitenbach
Hi,

this updates the quite outdated aircrack-ng to currrent 1.5.2 release.
Tested on i386 with rum(4) interface, save captures with airodump,
deauth a couple of clients, wordlist cracking with aircrack-ng.

Also installed airodump-ng-oui-update script that fetches the oui
data. It's using wget or curl to fetch it, however I didn't put these
into the RUN_DEPS, since one of them is most likely installed already
as well as the script tells you if it can't find it.

Any comments, tests or even OK?

Index: Makefile
===
RCS file: /cvs/ports/security/aircrack-ng/Makefile,v
retrieving revision 1.21
diff -u -r1.21 Makefile
--- Makefile4 Sep 2018 12:46:20 -   1.21
+++ Makefile28 Jan 2019 15:04:26 -
@@ -1,8 +1,7 @@
 # $OpenBSD: Makefile,v 1.21 2018/09/04 12:46:20 espie Exp $

 COMMENT=   802.11 WEP and WPA-PSK keys cracking program
-DISTNAME=  aircrack-ng-1.1
-REVISION=  15
+DISTNAME=  aircrack-ng-1.5.2
 CATEGORIES=security

 HOMEPAGE=  http://www.aircrack-ng.org/
@@ -12,23 +11,31 @@
 # GPLv2
 PERMIT_PACKAGE_CDROM=   Yes

-WANTLIB=   c pthread crypto ssl z
+WANTLIB+=  c pthread crypto z pcre
+WANTLIB+=  ${COMPILER_LIBCXX} m sqlite3

 MASTER_SITES=  http://download.aircrack-ng.org/

-WANTLIB += sqlite3
-LIB_DEPENDS=   databases/sqlite3
+BUILD_DEPENDS= devel/shtool \
+   devel/pkgconf
+LIB_DEPENDS=   databases/sqlite3 \
+   devel/pcre

 USE_GMAKE= Yes
+USE_LIBTOOL=   gnu
+AUTOCONF_VERSION=  2.69
+AUTOMAKE_VERSION=  1.16
+CONFIGURE_STYLE=   gnu
+
 MAKE_ENV+= SQLITE=true UNSTABLE=true
 MAKE_FLAGS+=   CC=${CC}

-NO_TEST=   Yes
-
-post-extract:
-   perl -i -pe 's/\r\n/\n/' ${WRKSRC}/src/osdep/byteorder.h
-
 pre-configure:
-   ${SUBST_CMD} ${WRKSRC}/src/airodump-ng.h
+   cd ${WRKSRC} &&  AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
+   AUTOCONF_VERSION=${AUTOCONF_VERSION} autoreconf -i
+
+post-install:
+   ${INSTALL_SCRIPT} ${WRKSRC}/scripts/airodump-ng-oui-update \
+   ${PREFIX}/bin/airodump-ng-oui-update

 .include 
Index: distinfo
===
RCS file: /cvs/ports/security/aircrack-ng/distinfo,v
retrieving revision 1.3
diff -u -r1.3 distinfo
--- distinfo1 Jul 2014 12:15:10 -   1.3
+++ distinfo28 Jan 2019 15:04:26 -
@@ -1,2 +1,2 @@
-SHA256 (aircrack-ng-1.1.tar.gz) = sTa1SbfSonUcIXkxAAdepDso3pr0wZaVCLuVvMkiJK0=
-SIZE (aircrack-ng-1.1.tar.gz) = 1453272
+SHA256 (aircrack-ng-1.5.2.tar.gz) = 
nlkv52WARiIOCsCm0FxAJpA/MHeySIk+AFbMvk7ogkE=
+SIZE (aircrack-ng-1.5.2.tar.gz) = 7138360
Index: patches/patch-common_mak
===
RCS file: patches/patch-common_mak
diff -N patches/patch-common_mak
--- patches/patch-common_mak6 May 2009 20:39:29 -   1.1.1.1
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,32 +0,0 @@
 common.mak.origThu Mar 26 22:01:02 2009
-+++ common.mak Wed Apr 15 18:36:48 2009
-@@ -31,16 +31,16 @@ COMMON_CFLAGS   += -DCYGWIN
- endif
-
- ifeq ($(SQLITE), true)
--COMMON_CFLAGS += -I/usr/local/include -DHAVE_SQLITE
-+COMMON_CFLAGS += -I${LOCALBASE}/include -DHAVE_SQLITE
- else
- ifeq ($(sqlite), true)
--COMMON_CFLAGS += -I/usr/local/include -DHAVE_SQLITE
-+COMMON_CFLAGS += -I${LOCALBASE}/include -DHAVE_SQLITE
- else
- ifeq ($(SQLITE), TRUE)
--COMMON_CFLAGS += -I/usr/local/include -DHAVE_SQLITE
-+COMMON_CFLAGS += -I${LOCALBASE}/include -DHAVE_SQLITE
- else
- ifeq ($(sqlite), TRUE)
--COMMON_CFLAGS += -I/usr/local/include -DHAVE_SQLITE
-+COMMON_CFLAGS += -I${LOCALBASE}/include -DHAVE_SQLITE
- endif
- endif
- endif
-@@ -70,7 +70,7 @@ OPTFLAGS= -D_FILE_OFFSET_BITS=64
- CFLAGS  ?= -g -W -Wall -Werror -O3
- CFLAGS  += $(OPTFLAGS) $(REVFLAGS) $(COMMON_CFLAGS)
-
--prefix  = /usr/local
-+prefix  = ${LOCALBASE}
- bindir  = $(prefix)/bin
- sbindir = $(prefix)/sbin
- mandir  = $(prefix)/man/man1
Index: patches/patch-manpages_airodump-ng_1
===
RCS file: patches/patch-manpages_airodump-ng_1
diff -N patches/patch-manpages_airodump-ng_1
--- patches/patch-manpages_airodump-ng_117 Feb 2015 19:47:01 -  
1.1
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,12 +0,0 @@
-$OpenBSD: patch-manpages_airodump-ng_1,v 1.1 2015/02/17 19:47:01 naddy Exp $
 manpages/airodump-ng.1.origSat Apr 24 22:06:16 2010
-+++ manpages/airodump-ng.1 Tue Feb 17 19:32:19 2015
-@@ -55,7 +55,7 @@ Active Scanning Simulation (send probe