Re: UPDATE: textproc/p5-ack to 2.18

[Alexander Bluhm]

On Sun, Mar 26, 2017 at 12:53:57PM +, Robert Peichaer wrote:
> This updates textproc/p5-ack to version 2.18.
> All tests pass.

> -V =  2.15_02
> +V =  2.18

In general I try to avoid _ development CPAN releases in ports.
Good that you fix this.

>  PKGNAME= p5-${DISTNAME:S/_/./}

This line is exists due to the old _ version.  You can remove it.
The cpan module should create the correct package name automatically.

> BUILD_DEPENDS=  ${RUN_DEPENDS}

A bunch of Perl ports have this line although it is not needed.  In
general a missing build dependency may print a warning during build
that is not important.  At some point there was consensus to avoid
this BUILD_DEPENDS to have less dependencies on the port build
machines.

Can you try whether it works without it and remove the line?

> RUN_DEPENDS=devel/p5-File-Next

Now the port needs File::Next => '1.16'.  We have this version in
our ports tree.  Could you change the dependency to
devel/p5-File-Next>=1.16 ?  This makes port updates easier as the
reviewer does not have to check /usr/ports/INDEX manually.

OK bluhm@

UPDATE: textproc/p5-ack to 2.18

[Robert Peichaer]

Hi

This updates textproc/p5-ack to version 2.18.
All tests pass.

OK ?


Index: Makefile
===
RCS file: /cvs/ports/textproc/p5-ack/Makefile,v
retrieving revision 1.22
diff -u -p -p -u -r1.22 Makefile
--- Makefile20 Mar 2016 19:57:12 -  1.22
+++ Makefile26 Mar 2017 12:46:27 -
@@ -4,7 +4,7 @@ COMMENT=grep like tool, aimed at progr
 
 MODULES=   cpan
 PKG_ARCH=  *
-V =2.15_02
+V =2.18
 DISTNAME=  ack-${V}
 PKGNAME=   p5-${DISTNAME:S/_/./}
 CPAN_AUTHOR=   PETDANCE
Index: distinfo
===
RCS file: /cvs/ports/textproc/p5-ack/distinfo,v
retrieving revision 1.12
diff -u -p -p -u -r1.12 distinfo
--- distinfo20 Dec 2015 09:47:13 -  1.12
+++ distinfo26 Mar 2017 12:46:30 -
@@ -1,2 +1,2 @@
-SHA256 (ack-2.15_02.tar.gz) = iT5GqSY7RG2b1+/q5SwS++5gkqOlufgW2PhMFkStcZk=
-SIZE (ack-2.15_02.tar.gz) = 228211
+SHA256 (ack-2.18.tar.gz) = +0oKEaVBHLpXZBY7jQdKRHwqdTdYghFRsx3HUzZj8Fg=
+SIZE (ack-2.18.tar.gz) = 232279
Index: pkg/PLIST
===
RCS file: /cvs/ports/textproc/p5-ack/pkg/PLIST,v
retrieving revision 1.6
diff -u -p -p -u -r1.6 PLIST
--- pkg/PLIST   1 Nov 2015 11:19:11 -   1.6
+++ pkg/PLIST   26 Mar 2017 12:46:51 -
@@ -20,8 +20,6 @@ ${P5SITE}/App/Ack/Filter/IsPath.pm
 ${P5SITE}/App/Ack/Filter/IsPathGroup.pm
 ${P5SITE}/App/Ack/Filter/Match.pm
 ${P5SITE}/App/Ack/Filter/MatchGroup.pm
-${P5SITE}/App/Ack/Resource/
 ${P5SITE}/App/Ack/Resource.pm
-${P5SITE}/App/Ack/Resource/Basic.pm
 ${P5SITE}/App/Ack/Resources.pm
 @man man/man1/ack.1
===
Stats: --- 5 lines 188 chars
Stats: +++ 3 lines 115 chars
Stats: -2 lines
Stats: -73 chars
-- 
-=[rpe]=-