Re: multimedia/gstreamer-0.10/plugins-good: Use /dev/null instead of /dev/mixer
On Sat, 11 Apr 2020 20:20:45 +0200
Alexandre Ratchov wrote:
> We switched libossaudio to sndio, but programs keep opening /dev/mixer
> but don't use it; so it could be replaced by /dev/null. It would be
> even better, to not use descriptors at all, but that's more difficult
> for gstreamer.
Your gstreamer diff works with xfce4-mixer on amd64. I can use
xfce4-mixer to set "Volume" (sndioctl output.level),
"In-gain" (hw/input.level), or "Out-gain" (hw/output.level).
There is another reference to "/dev/mixer" in gstosssrc.c, which you
are not patching. It would open /dev/mixer for recording audio, but
xfce4-mixer doesn't record (nor play) audio, so I'm not asking for
gsttosrc.c patch. I saw in ktrace(1) that xfce4-mixer opened /dev/null
and not /dev/mixer.
ok gkoehler@
> Index: Makefile
> ===
> RCS file: /cvs/ports/multimedia/gstreamer-0.10/plugins-good/Makefile,v
> retrieving revision 1.113
> diff -u -p -u -p -r1.113 Makefile
> --- Makefile 1 Feb 2020 15:04:26 - 1.113
> +++ Makefile 11 Apr 2020 16:54:59 -
> @@ -18,7 +18,7 @@ PKGNAME-dv= gstreamer-dv-${V}
> PKGNAME-caca=gstreamer-libcaca-${V}
> EPOCH-main= 0
>
> -REVISION-main= 25
> +REVISION-main= 26
> REVISION-aalib= 13
> REVISION-caca= 13
> REVISION-dv= 12
> Index: patches/patch-sys_oss_gstossmixerelement_c
> ===
> RCS file: patches/patch-sys_oss_gstossmixerelement_c
> diff -N patches/patch-sys_oss_gstossmixerelement_c
> --- /dev/null 1 Jan 1970 00:00:00 -
> +++ patches/patch-sys_oss_gstossmixerelement_c11 Apr 2020 16:54:59
> -
> @@ -0,0 +1,14 @@
> +$OpenBSD$
> +
> +Index: sys/oss/gstossmixerelement.c
> +--- sys/oss/gstossmixerelement.c.orig
> sys/oss/gstossmixerelement.c
> +@@ -42,7 +42,7 @@
> + GST_DEBUG_CATEGORY_EXTERN (oss_debug);
> + #define GST_CAT_DEFAULT oss_debug
> +
> +-#define DEFAULT_DEVICE "/dev/mixer"
> ++#define DEFAULT_DEVICE "/dev/null"
> + #define DEFAULT_DEVICE_NAME NULL
> +
> + enum
>
--
George Koehler
multimedia/gstreamer-0.10/plugins-good: Use /dev/null instead of /dev/mixer
We switched libossaudio to sndio, but programs keep opening /dev/mixer
but don't use it; so it could be replaced by /dev/null. It would be
even better, to not use descriptors at all, but that's more difficult
for gstreamer.
This change is important because /dev/mixer access will be disallowed
to regular users for security reasons (do you want random big programs
to be able to run random ioctls on /dev/mixer?)
OK?
BTW, any help to update other ports is welcome, this is my list of
programs that require access to /dev/mixer but don't use it:
- emulators/gambatte
- sysutils/conky
- sysutils/gkrellm/plugins/volume
- sysutils/tpb
- telephony/iaxclient
Index: Makefile
===
RCS file: /cvs/ports/multimedia/gstreamer-0.10/plugins-good/Makefile,v
retrieving revision 1.113
diff -u -p -u -p -r1.113 Makefile
--- Makefile1 Feb 2020 15:04:26 - 1.113
+++ Makefile11 Apr 2020 16:54:59 -
@@ -18,7 +18,7 @@ PKGNAME-dv= gstreamer-dv-${V}
PKGNAME-caca= gstreamer-libcaca-${V}
EPOCH-main=0
-REVISION-main= 25
+REVISION-main= 26
REVISION-aalib=13
REVISION-caca= 13
REVISION-dv= 12
Index: patches/patch-sys_oss_gstossmixerelement_c
===
RCS file: patches/patch-sys_oss_gstossmixerelement_c
diff -N patches/patch-sys_oss_gstossmixerelement_c
--- /dev/null 1 Jan 1970 00:00:00 -
+++ patches/patch-sys_oss_gstossmixerelement_c 11 Apr 2020 16:54:59 -
@@ -0,0 +1,14 @@
+$OpenBSD$
+
+Index: sys/oss/gstossmixerelement.c
+--- sys/oss/gstossmixerelement.c.orig
sys/oss/gstossmixerelement.c
+@@ -42,7 +42,7 @@
+ GST_DEBUG_CATEGORY_EXTERN (oss_debug);
+ #define GST_CAT_DEFAULT oss_debug
+
+-#define DEFAULT_DEVICE "/dev/mixer"
++#define DEFAULT_DEVICE "/dev/null"
+ #define DEFAULT_DEVICE_NAME NULL
+
+ enum
