Re: 2.0.3 officially released

2009-01-05 Thread Kenton Varda
On Thu, Dec 25, 2008 at 6:10 PM, Chris turingt...@gmail.com wrote:

 There is a small type on the web page about the custom options:

   optional int32 foo = 1 [(my_field_option = 4.5)];

 should be

  optional int32 foo = 1 [(my_field_option) = 4.5];


Thanks, I'll fix this.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Protocol Buffers group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to 
protobuf+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~--~~~~--~~--~--~---



Re: 2.0.3 officially released

2009-01-05 Thread Kenton Varda
On Sat, Jan 3, 2009 at 7:32 PM, Dave Wolfe dwolfe5...@hotmail.com wrote:


 FYI, it looks like a few new functions are missing __declspec()
 decorators.  I had to apply the trivial patch below in order to
 build a DLL version of protobuf under Windows.  (This applies to
 both 2.0.3 and the current trunk...)


Ouch, I guess I should explicitly test compiling DLLs before releasing.
 Strange, though, because I have a script which is supposed to add the
export decls for me.  Anyway, I'll look into this; thanks.




 --

 Index: src/google/protobuf/repeated_field.h
 ===
 --- src/google/protobuf/repeated_field.h(revision 90)
 +++ src/google/protobuf/repeated_field.h(working copy)
 @@ -93,7 +93,7 @@
  };

  // We need this (from generated_message_reflection.cc).
 -int StringSpaceUsedExcludingSelf(const string str);
 +LIBPROTOBUF_EXPORT int StringSpaceUsedExcludingSelf(const string
 str);

  }  // namespace internal

 Index: src/google/protobuf/stubs/common.h
 ===
 --- src/google/protobuf/stubs/common.h  (revision 90)
 +++ src/google/protobuf/stubs/common.h  (working copy)
 @@ -1075,7 +1075,7 @@

  // Checks if the buffer contains structurally-valid UTF-8.
 Implemented in
  // structurally_valid.cc.
 -bool IsStructurallyValidUTF8(const char* buf, int len);
 +LIBPROTOBUF_EXPORT bool IsStructurallyValidUTF8(const char* buf, int
 len);

  }  // namespace internal

 Index: src/google/protobuf/generated_message_reflection.h
 ===
 --- src/google/protobuf/generated_message_reflection.h  (revision 90)
 +++ src/google/protobuf/generated_message_reflection.h  (working copy)
 @@ -383,7 +383,7 @@
  // Compute the space used by a string, not including sizeof(string)
 itself.
  // This is slightly complicated because small strings store their
 data within
  // the string object but large strings do not.
 -int StringSpaceUsedExcludingSelf(const string str);
 +LIBPROTOBUF_EXPORT int StringSpaceUsedExcludingSelf(const string
 str);


  }  // namespace internal

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Protocol Buffers group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to 
protobuf+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~--~~~~--~~--~--~---



Re: 2.0.3 officially released

2008-12-15 Thread Kenton Varda
Yes, thanks for reminding me.  There still isn't any documentation on this
feature, even inside Google.  :(  I will try to write it this week.
(Sorry, it all comes down to me having too much work to do...)

On Sun, Dec 14, 2008 at 4:44 PM, codeazure codeaz...@gmail.com wrote:


 The language guide in the documentation still doesn't describe Field
 Options. I can see some references to them in some of the language
 specific sections (Java, Python), but nothing telling us how to use
 this feature either in fields or enums.

 With this and other changes, it's really helpful for developers to
 have access to current and complete documentation - doesn't have to be
 a huge amount, but just something to remind us that it's there.

 Thanks,
 Jeff

 On Dec 6, 5:48 am, Kenton Varda ken...@google.com wrote:
protoc
* Enum values may now have custom options, using syntax similar to
 field
  options.

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Protocol Buffers group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to 
protobuf+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~--~~~~--~~--~--~---



Re: 2.0.3 officially released

2008-12-06 Thread Jon Skeet

On Dec 5, 6:48 pm, Kenton Varda [EMAIL PROTECTED] wrote:
 http://code.google.com/p/protobuf/downloads/list
 Hopefully less buggy than last time.  :)

Congrats :)

   protoc

   * Fixed bug where .proto files which use custom options but don't actually
     define them (i.e. they import another .proto file defining the options)
     had to explicitly import descriptor.proto.

Excellent. This should make it easier for users of my project. I'll
update some time next week, hopefully.

I'd still like some way of marking either an import or a .proto file
itself as don't add as a dependency. The option support is a bit
unwieldy at the moment in terms of dependencies - if someone wants to
generate code for languages A, B and C, language A doesn't care about
the options for B and C, etc. Given that they're just options, they
can end up as uninterpreted options for languages which don't need
them - the relevant language would just need to explicitly register
their own extensions to pick up their options.

Does that make any sense? I feel I'm not explaining it terribly well.
This would have to be a change to protoc unfortunately as that's what
generates the list of dependencies.

   Java
   * New overload of mergeFrom() which parses a slice of a byte array instead
     of the whole thing.

Ooh. I guess I need to port that over to the C# at some point...

Jon


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Protocol Buffers group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~--~~~~--~~--~--~---