[jira] [Commented] (PROTON-515) Port to OpenVMS
[ https://issues.apache.org/jira/browse/PROTON-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151850#comment-15151850 ] Tomas Soltys commented on PROTON-515: - You are right, I do not use cmake. I just created my own DCL script (https://en.wikipedia.org/wiki/DIGITAL_Command_Language) which executes series of compile and link commands. Maybe worth of mentioning is that I have used following options for C compiler "/DEFINE=(USE_UUID_GENERATE,USE_OLD_STRERROR,USE_ATOLL,SO_NOSIGPIPE,_OPENVMS)/NAME=(SHORTENED)/NOOPT" #include is already there but it does not contain socklen_t definition. Also I was not able to find any other header on OpenVMS which would define socklen_t, therefore I have defined it my self. > Port to OpenVMS > --- > > Key: PROTON-515 > URL: https://issues.apache.org/jira/browse/PROTON-515 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.11.1 > Environment: OpenVMS >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: OpenVMS, patch > Attachments: > 0001-PROTON-515-Change-pn_handle_t-to-be-void-to-get-arou.patch, > CMakeLists.txt.patch, io.c.patch, pipe.c.patch > > > There is a need for proton-c port to OpenVMS platform. > To make proton-c functional on OpenVMS few changes in the source code are > required. > Here is list of files I have identified which require some attention: > proton-c/src/platform_fmt.h > proton-c/src/posix/driver.c > proton-c/src/object/object.c > proton-c/src/codec/codec.c -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1133) Proton C includes port number in AMQP Open hostname
[ https://issues.apache.org/jira/browse/PROTON-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151232#comment-15151232 ] ASF GitHub Bot commented on PROTON-1133: GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-proton/pull/66 PROTON-1133 - Remove the port from the connection hostname before cal… …ling pn_post_frame() You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-proton PROTON-1133-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/66.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #66 commit 702d0bb1248049332e4d4b1da30ee466fcc4bc32 Author: Ganesh MurthyDate: 2016-02-16T18:13:31Z PROTON-1133 - Remove the port from the connection hostname before calling pn_post_frame() > Proton C includes port number in AMQP Open hostname > --- > > Key: PROTON-1133 > URL: https://issues.apache.org/jira/browse/PROTON-1133 > Project: Qpid Proton > Issue Type: Bug >Affects Versions: 0.12.0 >Reporter: Chuck Rolke > > A command like: > {noformat} > qdmanage -b amqp://u1:password@photoserver:21000 --type policyStats query > {noformat} > sends the port number in the hostname field of the AMQP Open: > {noformat} > Mon Feb 8 11:37:46 2016 SERVER (trace) [2]:0 <- @open(16) > [container-id="34e49947-b4df-4a01-9570-0a74e9e57b5b", > hostname="photoserver:21000", channel-max=32767] > (/home/chug/git/qpid-dispatch/src/server.c:75) > {noformat} > Built in C example code using Proton only does the same thing. > This bug originally reported at > https://issues.apache.org/jira/browse/DISPATCH-214 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] qpid-proton pull request: PROTON-1133 - Remove the port from the c...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-proton/pull/66 PROTON-1133 - Remove the port from the connection hostname before cal⦠â¦ling pn_post_frame() You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-proton PROTON-1133-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/66.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #66 commit 702d0bb1248049332e4d4b1da30ee466fcc4bc32 Author: Ganesh MurthyDate: 2016-02-16T18:13:31Z PROTON-1133 - Remove the port from the connection hostname before calling pn_post_frame() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Error compiling proton C++ binding 0.12 with GCC 3.4
Hi, I am attempting to compile proton and the C++ binding using GCC 3.4 and get the following error when compiling the C++ bindings. (compiler flags have been removed in proton-c/CMakeLists.txt: -pedantic-errors -Wno-variadic-macros) > [ 33%] Building CXX object > proton-c/bindings/cpp/CMakeFiles/qpid-proton-cpp.dir/src/acceptor.cpp.o > In file included from > /tmp/qpid-proton-0.12.0/proton-c/bindings/cpp/src/contexts.hpp:28, > from > /tmp/qpid-proton-0.12.0/proton-c/bindings/cpp/src/acceptor.cpp:26: > /tmp/qpid-proton-0.12.0/proton-c/bindings/cpp/include/proton/container.hpp:129: > error: declaration of `void proton::container::link_options(const > proton::link_options&)' > /tmp/qpid-proton-0.12.0/proton-c/bindings/cpp/include/proton/link_options.hpp:60: > error: changes meaning of `link_options' from `class proton::link_options' > make[2]: *** > [proton-c/bindings/cpp/CMakeFiles/qpid-proton-cpp.dir/src/acceptor.cpp.o] > Error 1 > make[1]: *** [proton-c/bindings/cpp/CMakeFiles/qpid-proton-cpp.dir/all] Error > 2 From what I understand, this is due to a clash between the class proton::link_options and the method proton::container::link_options which cannot have the same name. Do you have an ideas for how I could make this compile with changing the API of proton::container? Thanks, Alexandre *** This e-mail contains information for the intended recipient only. It may contain proprietary material or confidential information. If you are not the intended recipient you are not authorised to distribute, copy or use this e-mail or any attachment to it. Murex cannot guarantee that it is virus free and accepts no responsibility for any loss or damage arising from its use. If you have received this e-mail in error please notify immediately the sender and delete the original email received, any attachments and all copies from your system.
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150842#comment-15150842 ] ASF subversion and git services commented on PROTON-1138: - Commit 45d59f7627670f7f7db204de6d13a9ec6cfc09b8 in qpid-proton's branch refs/heads/master from [~jr...@redhat.com] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=45d59f7 ] PROTON-1138: Capture and update header comments from review; some minor formatting adjustments > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-1138) Assorted C++ API cleanups
Justin Ross created PROTON-1138: --- Summary: Assorted C++ API cleanups Key: PROTON-1138 URL: https://issues.apache.org/jira/browse/PROTON-1138 Project: Qpid Proton Issue Type: Improvement Components: cpp-binding Affects Versions: 0.13.0 Reporter: Justin Ross Assignee: Cliff Jansen Fix For: 0.13.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross reassigned PROTON-1138: --- Assignee: Justin Ross (was: Cliff Jansen) > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1136) [proton-j] handle the case when pipelined SASL and OPEN frames are sent for ANONYMOUS login
[ https://issues.apache.org/jira/browse/PROTON-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150836#comment-15150836 ] Rob Godfrey commented on PROTON-1136: - Fair enough then - having default to off is definitely going to be the best for interoperability > [proton-j] handle the case when pipelined SASL and OPEN frames are sent for > ANONYMOUS login > --- > > Key: PROTON-1136 > URL: https://issues.apache.org/jira/browse/PROTON-1136 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.12.0 >Reporter: Ganesh Murthy > > Currently Proton-J is unable to handle pipelined SASL and OPEN frames for > ANONYMOUS logins, which are currently sent by proton-c, e.g see the below > trace log from Dispatch connecting out using ANONYMOUS: > {code} > [0x7f41f80079c0]: -> SASL > [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, > initial-response=b"anonymous@localhost.localdomain"] > [0x7f41f80079c0]: -> AMQP > [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", > max-frame-size=65536, channel-max=32767, idle-time-out=8000, > offered-capabilities=:"ANONYMOUS-RELAY", > properties={:product="qpid-dispatch-router", :version="0.6.0"}] > [0x7f41f80079c0]: <- SASL > [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] > [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] > [0x7f41f80079c0]: <- AMQP > {code} > Given that there are various clients using proton that might do this by > default (PROTON-1135 raised regarding that), proton-j should be updated to > cope with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1136) [proton-j] handle the case when pipelined SASL and OPEN frames are sent for ANONYMOUS login
[ https://issues.apache.org/jira/browse/PROTON-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150817#comment-15150817 ] Rob Godfrey commented on PROTON-1136: - Yeah - I'd agree that it'd be preferable to have "off" as the default but obviously that would be changing the current "functionality"... I wasn't sure if that sort of surprise would be welcome by existing users :-) > [proton-j] handle the case when pipelined SASL and OPEN frames are sent for > ANONYMOUS login > --- > > Key: PROTON-1136 > URL: https://issues.apache.org/jira/browse/PROTON-1136 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.12.0 >Reporter: Ganesh Murthy > > Currently Proton-J is unable to handle pipelined SASL and OPEN frames for > ANONYMOUS logins, which are currently sent by proton-c, e.g see the below > trace log from Dispatch connecting out using ANONYMOUS: > {code} > [0x7f41f80079c0]: -> SASL > [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, > initial-response=b"anonymous@localhost.localdomain"] > [0x7f41f80079c0]: -> AMQP > [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", > max-frame-size=65536, channel-max=32767, idle-time-out=8000, > offered-capabilities=:"ANONYMOUS-RELAY", > properties={:product="qpid-dispatch-router", :version="0.6.0"}] > [0x7f41f80079c0]: <- SASL > [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] > [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] > [0x7f41f80079c0]: <- AMQP > {code} > Given that there are various clients using proton that might do this by > default (PROTON-1135 raised regarding that), proton-j should be updated to > cope with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1136) [proton-j] handle the case when pipelined SASL and OPEN frames are sent for ANONYMOUS login
[ https://issues.apache.org/jira/browse/PROTON-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150804#comment-15150804 ] Robbie Gemmell commented on PROTON-1136: Your comment essentially exactly represents my thinking on things, and is basically what I said elsewhere yesterday (including the PLAIN bit)..though rather than have an option to turn it off at the 'client', I'd prefer an option to turn it on (e.g PROTON-1135). My understanding is proton-c would currently on do this for ANONYMOUS, at least since the sasl work done there in 0.10. > [proton-j] handle the case when pipelined SASL and OPEN frames are sent for > ANONYMOUS login > --- > > Key: PROTON-1136 > URL: https://issues.apache.org/jira/browse/PROTON-1136 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.12.0 >Reporter: Ganesh Murthy > > Currently Proton-J is unable to handle pipelined SASL and OPEN frames for > ANONYMOUS logins, which are currently sent by proton-c, e.g see the below > trace log from Dispatch connecting out using ANONYMOUS: > {code} > [0x7f41f80079c0]: -> SASL > [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, > initial-response=b"anonymous@localhost.localdomain"] > [0x7f41f80079c0]: -> AMQP > [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", > max-frame-size=65536, channel-max=32767, idle-time-out=8000, > offered-capabilities=:"ANONYMOUS-RELAY", > properties={:product="qpid-dispatch-router", :version="0.6.0"}] > [0x7f41f80079c0]: <- SASL > [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] > [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] > [0x7f41f80079c0]: <- AMQP > {code} > Given that there are various clients using proton that might do this by > default (PROTON-1135 raised regarding that), proton-j should be updated to > cope with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1136) [proton-j] handle the case when pipelined SASL and OPEN frames are sent for ANONYMOUS login
[ https://issues.apache.org/jira/browse/PROTON-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150790#comment-15150790 ] Rob Godfrey commented on PROTON-1136: - Presumably this issue is not restricted to ANONYMOUS, but any case where the "client" can pipeline the entire SASL exchange (e.g. EXTERNAL, PLAIN, etc...) >From the point of view of the spec.. as one of the co-authors I don't think I >ever anticipated pipelining then entire SASL interaction and then AMQP >operations so it certainly wasn't the intent that every implementation MUST be >able to handle the receipt of such... however for certain use cases I can see >why you't want to be able to send the entire thing asynchronously so I think >we SHOULD handle them... but maybe have a way of turning off such pipelining >(through config / connection options / whatever) on the sending side. > [proton-j] handle the case when pipelined SASL and OPEN frames are sent for > ANONYMOUS login > --- > > Key: PROTON-1136 > URL: https://issues.apache.org/jira/browse/PROTON-1136 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.12.0 >Reporter: Ganesh Murthy > > Currently Proton-J is unable to handle pipelined SASL and OPEN frames for > ANONYMOUS logins, which are currently sent by proton-c, e.g see the below > trace log from Dispatch connecting out using ANONYMOUS: > {code} > [0x7f41f80079c0]: -> SASL > [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, > initial-response=b"anonymous@localhost.localdomain"] > [0x7f41f80079c0]: -> AMQP > [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", > max-frame-size=65536, channel-max=32767, idle-time-out=8000, > offered-capabilities=:"ANONYMOUS-RELAY", > properties={:product="qpid-dispatch-router", :version="0.6.0"}] > [0x7f41f80079c0]: <- SASL > [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] > [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] > [0x7f41f80079c0]: <- AMQP > {code} > Given that there are various clients using proton that might do this by > default (PROTON-1135 raised regarding that), proton-j should be updated to > cope with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-1135) [proton-c] dont pipeline SASL and OPEN frames for ANONYMOUS logins by default
[ https://issues.apache.org/jira/browse/PROTON-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-1135: --- Description: Dispatch router (which uses Proton-c) currently sends pipelined SASL and OPEN frames by default when connecting out to other peers using the ANONYMOUS mech, as shown in the following trace - {code} [0x7f41f80079c0]: -> SASL [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b"anonymous@localhost.localdomain"] [0x7f41f80079c0]: -> AMQP [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", max-frame-size=65536, channel-max=32767, idle-time-out=8000, offered-capabilities=:"ANONYMOUS-RELAY", properties={:product="qpid-dispatch-router", :version="0.6.0"}] [0x7f41f80079c0]: <- SASL [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] [0x7f41f80079c0]: <- AMQP [0x7f41f80079c0]:0 <- @open(16) [container-id="ce103199-af03-4d37-bb35-24ad4e55653e", channel-max=32767, idle-time-out=8000, offered-capabilities=@PN_SYMBOL[:"ANONYMOUS-RELAY"], properties={:product="qpid-cpp", :version="0.35", :platform="Linux", :host="localhost.localdomain"}] {code} The AMQP 1.0 spec does not make it clear that this is supported (e.g. see diagram below) but in any case various components have shown difficulty with it (such as PROTON-1135 just raised, and QPID-6639 which has yet to be included in a release but permitted the above protocol trace log). {code} TCP Client TCP Server = AMQP%d3.1.0.0 -> <- AMQP%d3.1.0.0 : : : : AMQP%d0.1.0.0 -> (over SASL secured connection) <- AMQP%d0.1.0.0 open -> <- open {code} Proton should by default disable sending pipelined OPEN frames for ANONYMOUS logins, to aid compatibility with other components that don't expect/handle such behaviour. was: Dispatch router (which uses Proton-c) currently sends pipelined SASL and OPEN frames by default when connecting out to other peers using the ANONYMOUS mech, as shown in the following trace - {code} [0x7f41f80079c0]: -> SASL [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b"anonymous@localhost.localdomain"] [0x7f41f80079c0]: -> AMQP [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", max-frame-size=65536, channel-max=32767, idle-time-out=8000, offered-capabilities=:"ANONYMOUS-RELAY", properties={:product="qpid-dispatch-router", :version="0.6.0"}] [0x7f41f80079c0]: <- SASL [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] [0x7f41f80079c0]: <- AMQP [0x7f41f80079c0]:0 <- @open(16) [container-id="ce103199-af03-4d37-bb35-24ad4e55653e", channel-max=32767, idle-time-out=8000, offered-capabilities=@PN_SYMBOL[:"ANONYMOUS-RELAY"], properties={:product="qpid-cpp", :version="0.35", :platform="Linux", :host="localhost.localdomain"}] {code} The AMQP 1.0 spec does not make it clear that this is supported (e.g. see diagram below) but in any case various components have shown difficulty with it (such as PROTON-1135 just raised, and QPID-6639 which has yet to be included in a release but permitted the above protocol trace log). {code} TCP Client TCP Server = AMQP%d3.1.0.0 -> <- AMQP%d3.1.0.0 : : : : AMQP%d0.1.0.0 -> (over SASL secured connection) <- AMQP%d0.1.0.0 open -> <- open {code} Proton by default enables sending pipelined OPEN frames for ANONYMOUS logins to aid compatibility with other components. > [proton-c] dont pipeline SASL and OPEN frames for ANONYMOUS logins by default > - > > Key: PROTON-1135 > URL: https://issues.apache.org/jira/browse/PROTON-1135 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.12.0 >Reporter: Ganesh Murthy > > Dispatch router (which uses Proton-c) currently sends pipelined SASL and OPEN > frames by default when connecting out to other peers using the ANONYMOUS > mech, as shown in the following trace - > {code} > [0x7f41f80079c0]: -> SASL > [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, > initial-response=b"anonymous@localhost.localdomain"] > [0x7f41f80079c0]: -> AMQP > [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", > max-frame-size=65536, channel-max=32767, idle-time-out=8000, > offered-capabilities=:"ANONYMOUS-RELAY", >
[jira] [Updated] (PROTON-1135) [proton-c] dont pipeline SASL and OPEN frames for ANONYMOUS logins by default
[ https://issues.apache.org/jira/browse/PROTON-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated PROTON-1135: -- Description: Dispatch router (which uses Proton-c) currently sends pipelined SASL and OPEN frames by default when connecting out to other peers using the ANONYMOUS mech, as shown in the following trace - {code} [0x7f41f80079c0]: -> SASL [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b"anonymous@localhost.localdomain"] [0x7f41f80079c0]: -> AMQP [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", max-frame-size=65536, channel-max=32767, idle-time-out=8000, offered-capabilities=:"ANONYMOUS-RELAY", properties={:product="qpid-dispatch-router", :version="0.6.0"}] [0x7f41f80079c0]: <- SASL [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] [0x7f41f80079c0]: <- AMQP [0x7f41f80079c0]:0 <- @open(16) [container-id="ce103199-af03-4d37-bb35-24ad4e55653e", channel-max=32767, idle-time-out=8000, offered-capabilities=@PN_SYMBOL[:"ANONYMOUS-RELAY"], properties={:product="qpid-cpp", :version="0.35", :platform="Linux", :host="localhost.localdomain"}] {code} The AMQP 1.0 spec does not make it clear that this is supported (e.g. see diagram below) but in any case various components have shown difficulty with it (such as PROTON-1135 just raised, and QPID-6639 which has yet to be included in a release but permitted the above protocol trace log). {code} TCP Client TCP Server = AMQP%d3.1.0.0 -> <- AMQP%d3.1.0.0 : : : : AMQP%d0.1.0.0 -> (over SASL secured connection) <- AMQP%d0.1.0.0 open -> <- open {code} Proton should by default enables sending pipelined OPEN frames for ANONYMOUS logins to aid compatibility with other components. was: Dispatch router (which uses Proton-c) currently sends pipelined SASL and OPEN frames by default when connecting out to other peers using the ANONYMOUS mech, as shown in the following trace - {code} [0x7f41f80079c0]: -> SASL [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b"anonymous@localhost.localdomain"] [0x7f41f80079c0]: -> AMQP [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", max-frame-size=65536, channel-max=32767, idle-time-out=8000, offered-capabilities=:"ANONYMOUS-RELAY", properties={:product="qpid-dispatch-router", :version="0.6.0"}] [0x7f41f80079c0]: <- SASL [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] [0x7f41f80079c0]: <- AMQP [0x7f41f80079c0]:0 <- @open(16) [container-id="ce103199-af03-4d37-bb35-24ad4e55653e", channel-max=32767, idle-time-out=8000, offered-capabilities=@PN_SYMBOL[:"ANONYMOUS-RELAY"], properties={:product="qpid-cpp", :version="0.35", :platform="Linux", :host="localhost.localdomain"}] {code} The AMQP 1.0 spec does not make it clear that this is supported (e.g. see diagram below) but in any case various components have shown difficulty with it (such as PROTON-1135 just raised, and QPID-6639 which has yet to be included in a release but permitted the above protocol trace log). {code} TCP Client TCP Server = AMQP%d3.1.0.0 -> <- AMQP%d3.1.0.0 : : : : AMQP%d0.1.0.0 -> (over SASL secured connection) <- AMQP%d0.1.0.0 open -> <- open {code} Proton should by default stop enables sending pipelined OPEN frames for ANONYMOUS logins to aid compatibility with other components. > [proton-c] dont pipeline SASL and OPEN frames for ANONYMOUS logins by default > - > > Key: PROTON-1135 > URL: https://issues.apache.org/jira/browse/PROTON-1135 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.12.0 >Reporter: Ganesh Murthy > > Dispatch router (which uses Proton-c) currently sends pipelined SASL and OPEN > frames by default when connecting out to other peers using the ANONYMOUS > mech, as shown in the following trace - > {code} > [0x7f41f80079c0]: -> SASL > [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, > initial-response=b"anonymous@localhost.localdomain"] > [0x7f41f80079c0]: -> AMQP > [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", > max-frame-size=65536, channel-max=32767, idle-time-out=8000, > offered-capabilities=:"ANONYMOUS-RELAY", > properties={:product="qpid-dispatch-router", :version="0.6.0"}] >
[jira] [Updated] (PROTON-1135) [proton-c] dont pipeline SASL and OPEN frames for ANONYMOUS logins by default
[ https://issues.apache.org/jira/browse/PROTON-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated PROTON-1135: -- Description: Dispatch router (which uses Proton-c) currently sends pipelined SASL and OPEN frames by default when connecting out to other peers using the ANONYMOUS mech, as shown in the following trace - {code} [0x7f41f80079c0]: -> SASL [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b"anonymous@localhost.localdomain"] [0x7f41f80079c0]: -> AMQP [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", max-frame-size=65536, channel-max=32767, idle-time-out=8000, offered-capabilities=:"ANONYMOUS-RELAY", properties={:product="qpid-dispatch-router", :version="0.6.0"}] [0x7f41f80079c0]: <- SASL [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] [0x7f41f80079c0]: <- AMQP [0x7f41f80079c0]:0 <- @open(16) [container-id="ce103199-af03-4d37-bb35-24ad4e55653e", channel-max=32767, idle-time-out=8000, offered-capabilities=@PN_SYMBOL[:"ANONYMOUS-RELAY"], properties={:product="qpid-cpp", :version="0.35", :platform="Linux", :host="localhost.localdomain"}] {code} The AMQP 1.0 spec does not make it clear that this is supported (e.g. see diagram below) but in any case various components have shown difficulty with it (such as PROTON-1135 just raised, and QPID-6639 which has yet to be included in a release but permitted the above protocol trace log). {code} TCP Client TCP Server = AMQP%d3.1.0.0 -> <- AMQP%d3.1.0.0 : : : : AMQP%d0.1.0.0 -> (over SASL secured connection) <- AMQP%d0.1.0.0 open -> <- open {code} Proton by default enables sending pipelined OPEN frames for ANONYMOUS logins to aid compatibility with other components. was: Dispatch router (which uses Proton-c) currently sends pipelined SASL and OPEN frames by default when connecting out to other peers using the ANONYMOUS mech, as shown in the following trace - {code} [0x7f41f80079c0]: -> SASL [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b"anonymous@localhost.localdomain"] [0x7f41f80079c0]: -> AMQP [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", max-frame-size=65536, channel-max=32767, idle-time-out=8000, offered-capabilities=:"ANONYMOUS-RELAY", properties={:product="qpid-dispatch-router", :version="0.6.0"}] [0x7f41f80079c0]: <- SASL [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] [0x7f41f80079c0]: <- AMQP [0x7f41f80079c0]:0 <- @open(16) [container-id="ce103199-af03-4d37-bb35-24ad4e55653e", channel-max=32767, idle-time-out=8000, offered-capabilities=@PN_SYMBOL[:"ANONYMOUS-RELAY"], properties={:product="qpid-cpp", :version="0.35", :platform="Linux", :host="localhost.localdomain"}] {code} The AMQP 1.0 spec does not make it clear that this is supported (e.g. see diagram below) but in any case various components have shown difficulty with it (such as PROTON-1135 just raised, and QPID-6639 which has yet to be included in a release but permitted the above protocol trace log). {code} TCP Client TCP Server = AMQP%d3.1.0.0 -> <- AMQP%d3.1.0.0 : : : : AMQP%d0.1.0.0 -> (over SASL secured connection) <- AMQP%d0.1.0.0 open -> <- open {code} Proton should by default enables sending pipelined OPEN frames for ANONYMOUS logins to aid compatibility with other components. > [proton-c] dont pipeline SASL and OPEN frames for ANONYMOUS logins by default > - > > Key: PROTON-1135 > URL: https://issues.apache.org/jira/browse/PROTON-1135 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.12.0 >Reporter: Ganesh Murthy > > Dispatch router (which uses Proton-c) currently sends pipelined SASL and OPEN > frames by default when connecting out to other peers using the ANONYMOUS > mech, as shown in the following trace - > {code} > [0x7f41f80079c0]: -> SASL > [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, > initial-response=b"anonymous@localhost.localdomain"] > [0x7f41f80079c0]: -> AMQP > [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", > max-frame-size=65536, channel-max=32767, idle-time-out=8000, > offered-capabilities=:"ANONYMOUS-RELAY", > properties={:product="qpid-dispatch-router", :version="0.6.0"}] > [0x7f41f80079c0]:
[jira] [Updated] (PROTON-1136) [proton-j] handle the case when pipelined SASL and OPEN frames are sent for ANONYMOUS login
[ https://issues.apache.org/jira/browse/PROTON-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-1136: --- Description: Currently Proton-J is unable to handle pipelined SASL and OPEN frames for ANONYMOUS logins, which are currently sent by proton-c, e.g see the below trace log from Dispatch connecting out using ANONYMOUS: {code} [0x7f41f80079c0]: -> SASL [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b"anonymous@localhost.localdomain"] [0x7f41f80079c0]: -> AMQP [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", max-frame-size=65536, channel-max=32767, idle-time-out=8000, offered-capabilities=:"ANONYMOUS-RELAY", properties={:product="qpid-dispatch-router", :version="0.6.0"}] [0x7f41f80079c0]: <- SASL [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] [0x7f41f80079c0]: <- AMQP {code} Given that there are various clients using proton that might do this by default (PROTON-1135 raised regarding that), proton-j should be updated to cope with it. was: Currently Proton-J is unable to handle pipelined SASL and OPEN frames. Proton-J should be fixed such that it handles the following scenario {code} [0x7f41f80079c0]: -> SASL [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b"anonymous@localhost.localdomain"] [0x7f41f80079c0]: -> AMQP [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", max-frame-size=65536, channel-max=32767, idle-time-out=8000, offered-capabilities=:"ANONYMOUS-RELAY", properties={:product="qpid-dispatch-router", :version="0.6.0"}] [0x7f41f80079c0]: <- SASL [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] [0x7f41f80079c0]: <- AMQP {code} Summary: [proton-j] handle the case when pipelined SASL and OPEN frames are sent for ANONYMOUS login (was: Proton J must handle the case when pipelined SASL and OPEN frames are sent ) Tweaked description for clarity. > [proton-j] handle the case when pipelined SASL and OPEN frames are sent for > ANONYMOUS login > --- > > Key: PROTON-1136 > URL: https://issues.apache.org/jira/browse/PROTON-1136 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.12.0 >Reporter: Ganesh Murthy > > Currently Proton-J is unable to handle pipelined SASL and OPEN frames for > ANONYMOUS logins, which are currently sent by proton-c, e.g see the below > trace log from Dispatch connecting out using ANONYMOUS: > {code} > [0x7f41f80079c0]: -> SASL > [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, > initial-response=b"anonymous@localhost.localdomain"] > [0x7f41f80079c0]: -> AMQP > [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", > max-frame-size=65536, channel-max=32767, idle-time-out=8000, > offered-capabilities=:"ANONYMOUS-RELAY", > properties={:product="qpid-dispatch-router", :version="0.6.0"}] > [0x7f41f80079c0]: <- SASL > [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] > [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] > [0x7f41f80079c0]: <- AMQP > {code} > Given that there are various clients using proton that might do this by > default (PROTON-1135 raised regarding that), proton-j should be updated to > cope with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-1137) [proton-j] SaslSniffer throws exception if given less than 8 bytes.
Robbie Gemmell created PROTON-1137: -- Summary: [proton-j] SaslSniffer throws exception if given less than 8 bytes. Key: PROTON-1137 URL: https://issues.apache.org/jira/browse/PROTON-1137 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.12.0 Reporter: Robbie Gemmell The SaslSniffer 'transport wrapper' looks at the initial header to determine if Sasl is in use or not. It throws if the transport is fed less than 8 bytes. This seems incorrect since the full 8 may not yet be available at the time, and the full 8 may not even be needed to make a determination. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-1136) Proton J must handle the case when pipelined SASL and OPEN frames are sent
Ganesh Murthy created PROTON-1136: - Summary: Proton J must handle the case when pipelined SASL and OPEN frames are sent Key: PROTON-1136 URL: https://issues.apache.org/jira/browse/PROTON-1136 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.12.0 Reporter: Ganesh Murthy Currently Proton-J is unable to handle pipelined SASL and OPEN frames. Proton-J should be fixed such that it handles the following scenario {code} [0x7f41f80079c0]: -> SASL [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b"anonymous@localhost.localdomain"] [0x7f41f80079c0]: -> AMQP [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", max-frame-size=65536, channel-max=32767, idle-time-out=8000, offered-capabilities=:"ANONYMOUS-RELAY", properties={:product="qpid-dispatch-router", :version="0.6.0"}] [0x7f41f80079c0]: <- SASL [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] [0x7f41f80079c0]: <- AMQP {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-1135) By default the flag that allows AMQP SASL and OPEN frames to be pipelined must be turned off
Ganesh Murthy created PROTON-1135: - Summary: By default the flag that allows AMQP SASL and OPEN frames to be pipelined must be turned off Key: PROTON-1135 URL: https://issues.apache.org/jira/browse/PROTON-1135 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.12.0 Reporter: Ganesh Murthy Dispatch router (which uses Proton-c) sends pipelined SASL and OPEN frames by default like shown in the following trace - {code} [0x7f41f80079c0]: -> SASL [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b"anonymous@localhost.localdomain"] [0x7f41f80079c0]: -> AMQP [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", max-frame-size=65536, channel-max=32767, idle-time-out=8000, offered-capabilities=:"ANONYMOUS-RELAY", properties={:product="qpid-dispatch-router", :version="0.6.0"}] [0x7f41f80079c0]: <- SASL [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS] [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0] [0x7f41f80079c0]: <- AMQP [0x7f41f80079c0]:0 <- @open(16) [container-id="ce103199-af03-4d37-bb35-24ad4e55653e", channel-max=32767, idle-time-out=8000, offered-capabilities=@PN_SYMBOL[:"ANONYMOUS-RELAY"], properties={:product="qpid-cpp", :version="0.35", :platform="Linux", :host="localhost.localdomain"}] {code} As per the AMQP 1.0 spec - the OPEN frame is sent after the SASL exchange is complete as shown below - {code} TCP Client TCP Server = AMQP%d3.1.0.0 -> <- AMQP%d3.1.0.0 : : : : AMQP%d0.1.0.0 -> (over SASL secured connection) <- AMQP%d0.1.0.0 open -> <- open {code} Proton should by default turn off the flag that enables sending pipelined OPEN frames. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-515) Port to OpenVMS
[ https://issues.apache.org/jira/browse/PROTON-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Soltys updated PROTON-515: Attachment: pipe.c.patch io.c.patch CMakeLists.txt.patch Separate pn_pipe() for posix and OpenVMS. > Port to OpenVMS > --- > > Key: PROTON-515 > URL: https://issues.apache.org/jira/browse/PROTON-515 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.11.1 > Environment: OpenVMS >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: OpenVMS, patch > Attachments: > 0001-PROTON-515-Change-pn_handle_t-to-be-void-to-get-arou.patch, > CMakeLists.txt.patch, io.c.patch, pipe.c.patch > > > There is a need for proton-c port to OpenVMS platform. > To make proton-c functional on OpenVMS few changes in the source code are > required. > Here is list of files I have identified which require some attention: > proton-c/src/platform_fmt.h > proton-c/src/posix/driver.c > proton-c/src/object/object.c > proton-c/src/codec/codec.c -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-515) Port to OpenVMS
[ https://issues.apache.org/jira/browse/PROTON-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Soltys updated PROTON-515: Attachment: (was: io.c.patch) > Port to OpenVMS > --- > > Key: PROTON-515 > URL: https://issues.apache.org/jira/browse/PROTON-515 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.11.1 > Environment: OpenVMS >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: OpenVMS, patch > Attachments: > 0001-PROTON-515-Change-pn_handle_t-to-be-void-to-get-arou.patch > > > There is a need for proton-c port to OpenVMS platform. > To make proton-c functional on OpenVMS few changes in the source code are > required. > Here is list of files I have identified which require some attention: > proton-c/src/platform_fmt.h > proton-c/src/posix/driver.c > proton-c/src/object/object.c > proton-c/src/codec/codec.c -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-515) Port to OpenVMS
[ https://issues.apache.org/jira/browse/PROTON-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Soltys updated PROTON-515: Attachment: (was: object.h.patch) > Port to OpenVMS > --- > > Key: PROTON-515 > URL: https://issues.apache.org/jira/browse/PROTON-515 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.11.1 > Environment: OpenVMS >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: OpenVMS, patch > Attachments: > 0001-PROTON-515-Change-pn_handle_t-to-be-void-to-get-arou.patch > > > There is a need for proton-c port to OpenVMS platform. > To make proton-c functional on OpenVMS few changes in the source code are > required. > Here is list of files I have identified which require some attention: > proton-c/src/platform_fmt.h > proton-c/src/posix/driver.c > proton-c/src/object/object.c > proton-c/src/codec/codec.c -- This message was sent by Atlassian JIRA (v6.3.4#6332)