[GitHub] qpid-proton pull request: Fixing broken documentation links
Github user ssorj commented on the pull request: https://github.com/apache/qpid-proton/pull/68#issuecomment-187955488 https://github.com/github/pages-gem/issues/69 This ticket discusses the very same issue. It appears to be unresolved, but there are a few hacks there. Nothing that appealed to me right away. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixing broken documentation links
Github user astitcher commented on the pull request: https://github.com/apache/qpid-proton/pull/68#issuecomment-187952497 Is there no way to tell the process that renders the markdown to html to inspect the links and modify them as necessary (if they refer to another markdown document that is also being rendered into html)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixing broken documentation links
Github user ssorj commented on the pull request: https://github.com/apache/qpid-proton/pull/68#issuecomment-187951375 This is a little vexing. Your patch fixes those links for the documentation as rendered in GitHub, but it will break them elsewhere. We use markdown as a convenient way to produce static html, and static html requires the links to end in .html. I think this is more an issue with GitHub than it is the documentation in this case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixing broken documentation links
GitHub user robreeves opened a pull request: https://github.com/apache/qpid-proton/pull/68 Fixing broken documentation links Several links were changed from *.html to *.md. You can merge this pull request into a Git repository by running: $ git pull https://github.com/robreeves/qpid-proton broken_link Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/68.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #68 commit 70ebdd6662a5edacd97cf7b929c66a4886e28d97 Author: Rob Reeves Date: 2016-02-23T22:38:55Z Update index.md Fixing broken links commit 358bc288afa63370177ee2b96e54738ce20e5933 Author: Rob Reeves Date: 2016-02-23T22:39:54Z Update index.md Fixing broken links --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (PROTON-1141) Update JUnit Dependency and fix some warnings in the tests.
[ https://issues.apache.org/jira/browse/PROTON-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159427#comment-15159427 ] ASF subversion and git services commented on PROTON-1141: - Commit ff64a31605b32b2feb569a09b11a3ef43ba8a3b4 in qpid-proton's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=ff64a31 ] PROTON-1141 fix some more tests that use deprecated assertions. > Update JUnit Dependency and fix some warnings in the tests. > --- > > Key: PROTON-1141 > URL: https://issues.apache.org/jira/browse/PROTON-1141 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Affects Versions: 0.12.0 >Reporter: Timothy Bish >Assignee: Timothy Bish > Fix For: 0.13.0 > > > Update to the latest JUnit dependency and fix some use of deprecated JUnit > assertions in the tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1133) Proton C includes port number in AMQP Open hostname
[
https://issues.apache.org/jira/browse/PROTON-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159022#comment-15159022
]
Ken Giusti commented on PROTON-1133:
This issue is caused by a defect in the way Reactor obtains the socket address
for its connections.
The reactor - or more specifically, the io_handler used by connections created
via the reactor - expects to find the socket address in the Connection's
'hostname' property. See proton-c/src/reactor/connection.c:pni_handle_bound().
This isn't the correct use of 'hostname' as per the AMQP 1.0 spec:
"The name of the host (either fully qualified or relative) to which the sending
peer is connecting. It is
not mandatory to provide the hostname. If no hostname is provided the receiving
peer SHOULD
select a default based on its own configuration. This field can be used by AMQP
proxies to
determine the correct back-end service to connect the client to.
This field MAY already have been specified by the sasl-init frame, if a SASL
layer is used, or,
the server name indication extension as described in RFC-4366, if a TLS layer
is used, in which
case this field SHOULD be null or contain the same value. It is undefined what
a different value
to that already specified means"
Reactor assumes that the user will set the transport-level address (eg socket
address) in the hostname property. Thus port information needs to be placed in
the 'hostname' (if 5672 is not used). It also forces the user to set hostname
to a numeric address if necessary.
This conflicts with the above specification.
Reactor needs a different approach to configuring the transport-level address
that doesn't conflict with the hostname property.
> Proton C includes port number in AMQP Open hostname
> ---
>
> Key: PROTON-1133
> URL: https://issues.apache.org/jira/browse/PROTON-1133
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c, python-binding
>Affects Versions: 0.12.0
>Reporter: Chuck Rolke
> Fix For: 0.13.0
>
>
> A command like:
> {noformat}
> qdmanage -b amqp://u1:password@photoserver:21000 --type policyStats query
> {noformat}
> sends the port number in the hostname field of the AMQP Open:
> {noformat}
> Mon Feb 8 11:37:46 2016 SERVER (trace) [2]:0 <- @open(16)
> [container-id="34e49947-b4df-4a01-9570-0a74e9e57b5b",
> hostname="photoserver:21000", channel-max=32767]
> (/home/chug/git/qpid-dispatch/src/server.c:75)
> {noformat}
> Built in C example code using Proton only does the same thing.
> This bug originally reported at
> https://issues.apache.org/jira/browse/DISPATCH-214
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (PROTON-1133) Proton C includes port number in AMQP Open hostname
[
https://issues.apache.org/jira/browse/PROTON-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti updated PROTON-1133:
---
Fix Version/s: 0.13.0
0.12.1
Component/s: python-binding
proton-c
> Proton C includes port number in AMQP Open hostname
> ---
>
> Key: PROTON-1133
> URL: https://issues.apache.org/jira/browse/PROTON-1133
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c, python-binding
>Affects Versions: 0.12.0
>Reporter: Chuck Rolke
> Fix For: 0.13.0
>
>
> A command like:
> {noformat}
> qdmanage -b amqp://u1:password@photoserver:21000 --type policyStats query
> {noformat}
> sends the port number in the hostname field of the AMQP Open:
> {noformat}
> Mon Feb 8 11:37:46 2016 SERVER (trace) [2]:0 <- @open(16)
> [container-id="34e49947-b4df-4a01-9570-0a74e9e57b5b",
> hostname="photoserver:21000", channel-max=32767]
> (/home/chug/git/qpid-dispatch/src/server.c:75)
> {noformat}
> Built in C example code using Proton only does the same thing.
> This bug originally reported at
> https://issues.apache.org/jira/browse/DISPATCH-214
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (PROTON-1133) Proton C includes port number in AMQP Open hostname
[
https://issues.apache.org/jira/browse/PROTON-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti updated PROTON-1133:
---
Fix Version/s: (was: 0.12.1)
> Proton C includes port number in AMQP Open hostname
> ---
>
> Key: PROTON-1133
> URL: https://issues.apache.org/jira/browse/PROTON-1133
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c, python-binding
>Affects Versions: 0.12.0
>Reporter: Chuck Rolke
> Fix For: 0.13.0
>
>
> A command like:
> {noformat}
> qdmanage -b amqp://u1:password@photoserver:21000 --type policyStats query
> {noformat}
> sends the port number in the hostname field of the AMQP Open:
> {noformat}
> Mon Feb 8 11:37:46 2016 SERVER (trace) [2]:0 <- @open(16)
> [container-id="34e49947-b4df-4a01-9570-0a74e9e57b5b",
> hostname="photoserver:21000", channel-max=32767]
> (/home/chug/git/qpid-dispatch/src/server.c:75)
> {noformat}
> Built in C example code using Proton only does the same thing.
> This bug originally reported at
> https://issues.apache.org/jira/browse/DISPATCH-214
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-1050) 0.12.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158838#comment-15158838 ] ASF subversion and git services commented on PROTON-1050: - Commit f438f83d3d990dcf9f8b30ea3841ab7c7ab3dc79 in qpid-proton's branch refs/heads/0.12.x from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f438f83 ] PROTON-1050: bump versions on 0.12.x branch to 0.12.1-SNAPSHOT now that 0.12.0 is release > 0.12.0 release tasks > > > Key: PROTON-1050 > URL: https://issues.apache.org/jira/browse/PROTON-1050 > Project: Qpid Proton > Issue Type: Task > Components: release >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.12.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
