[GitHub] qpid-proton pull request: Fix nullPointerException in event impl i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/58


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] qpid-proton pull request: Fix nullPointerException in event impl i...

[gemmellr]

Github user gemmellr commented on the pull request:

https://github.com/apache/qpid-proton/pull/58#issuecomment-174484938
  
As it won't cause any harm I've pushed a change (essentially yours with the 
whitespace fixed) for this via PROTON-1105 to close out the PR, but as 
mentioned if you were seeing unpredictable behaviour around this then that 
probably points to some other issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] qpid-proton pull request: Fix nullPointerException in event impl i...

[gemmellr]

Github user gemmellr commented on the pull request:

https://github.com/apache/qpid-proton/pull/58#issuecomment-172036582
  
Hi Sreeram,

Do you actually mean that there was an NPE inside EventImpl as the title 
suggests? Given usage of the getTransport() inside EventImpl method, it doesnt 
seem like that would be the case or that the change would affect it.

If on the other hand you mean that a (your?) onSessionInit() handler calls 
getTransport() on the session init event (not entirely clear why it would?) and 
then NPE's when using the result then I guess I can see that. Its not 
particularly clear why that would only happen transiently though unless there 
is actually another issue at play. I think seeing a stacktrace would be good 
before making any changes.

P.S. no need to tag me when creating each PR, the mails all go to the same 
place so it wont typically make me spot it or do anything with it any quicker ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] qpid-proton pull request: Fix nullPointerException in event impl i...

[SreeramGarlapati]

GitHub user SreeramGarlapati opened a pull request:

https://github.com/apache/qpid-proton/pull/58

Fix nullPointerException in event impl in the Reactor.onSessionInit 
codePaths

Eventhubs java client depends on Proton-j Reactor APIs. While running our 
stress scenarios - we encountered a NullPointerException in this codepath - 
onSessionInit command (it happens transiently though). Will fill in with full 
stack trace if I encounter this error again.

(tagging @gemmellr for helping with merge).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SreeramGarlapati/qpid-proton 
fixNullRef.EventImpl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #58


commit db60278d3495b08dc8d07e7a3a720961b2cc341a
Author: Sreeram Garlapati 
Date:   2016-01-14T20:13:24Z

Fix nullPointerException in reactor codepath

commit c50666042d206a7a0e0ddb3a7548057e6e849dc7
Author: Sreeram Garlapati 
Date:   2016-01-14T22:30:12Z

fix NullPointerException in the Reactor codepaths - onSessionInit event




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---