[GitHub] qpid-proton pull request: Fixes for Mac OS X
Github user rhs commented on the pull request: https://github.com/apache/qpid-proton/pull/23#issuecomment-97009507 Hmm, I'm not sure how useful the trace is since it is once where all the tests passed. Any chance you could grab one where the tests fail? Thinking a bit more, I think the test makes the assumption that the underlying loopback interface is synchronous, i.e. as soon as a write succeeds, any corresponding reads will be ready. I've added info to the assert that will hopefully test this theory. Can you do a git pull and reproduce the failure again and post the traceback? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixes for Mac OS X
Github user rhs commented on the pull request: https://github.com/apache/qpid-proton/pull/23#issuecomment-97093665 For the record, I tried making the test assertion more specific, but it is difficult to come up with an assertion that accommodates the asynchronous behavior and isn't extremely brittle and specific. Given that I'm +1 on the change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixes for Mac OS X
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixes for Mac OS X
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/23#issuecomment-96820535 @rhs readily reproducible, [output from 20 runs](https://gist.github.com/dnwe/76c504f2a3067b32b904) and [python trace bz2](https://dl.dropboxusercontent.com/u/951543/trace.log.bz2) from a single run of the four tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixes for Mac OS X
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/23#issuecomment-96717495 @rhs I believe you originally wrote the SelectableMessengerTest, could you take a look at change and confirm if this is an acceptable change in the test behaviour? It wasn't clear to me if you were intending to validate that a single call to Pump#pump would always result in at least one message being flowed into incoming? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixes for Mac OS X
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/23 Fixes for Mac OS X 1. default to building universal binaries so the various language bindings can link against the system libraries out of the box 2. small fix to SelectableMessengerTest as it was regularly failing on Mac builds. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton fixes-for-mac Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/23.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #23 commit 2a120b8d401c6931f46757717e9883e4f8c41ebb Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-04-27T14:41:55Z NO-JIRA: default to universal binaries on Mac OS X The system-installed Perl, Python etc. are all built as universal binaries on Mac and so we need to build libqpid-proton to similarly contain both architectures. This allows the bindings to link successfully. commit c07377c780cb70153e5c1f9136e69fcbbbcfa5a2 Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-04-27T15:28:33Z NO-JIRA: fix SelectableMessengerTest on Mac The SelectableMessengerTest was failing intermittently on Mac builds, Modify the test slightly to be more resilient. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixes for Mac OS X
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/23#issuecomment-96722982 fixes-for-mac: ![build passing](https://travis-ci.org/dnwe/qpid-proton.svg?branch=fixes-for-mac) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixes for Mac OS X
Github user rhs commented on the pull request: https://github.com/apache/qpid-proton/pull/23#issuecomment-96734626 I'm a little puzzled as to why the test change would be necessary. Pump has been written to keep looping until there is no I/O left to perform for any of its messengers. Given that the receiving messenger has issued credit, and the sending messenger has posted messages for transfer, I think this is probably somehow indicative of a real bug somewhere (possibly in some of the test framework code). How easy is it to reproduce this on a mac? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---