Re: [ptxdist] [PATCH] Add modeline for vim to *.in files

2011-06-23 Thread Alexander Dahl
Hei hei, 

On Thu, 23 Jun 2011 17:48:02 +0200, Bernhard Walle wrote:
 Set the file type to kconfig. The *.make files have a modeline for vim,
 so why not also for the Kconfig files.

% grep vim: rules/*.in
rules/argtable2.in:# vim: syntax=kconfig
rules/calibrator.in:# vim: syntax=kconfig
rules/hackbench.in:# vim: syntax=kconfig

I would recommend altering these instead of adding an addtional line.
;-)

Despite of that: +1, very handy for vim users.

If you're already on this topic: Would you mind adapting the modeline
for the rules/*.make files to something like this?

# vim: ft=make noet

O:-)

But I guess the templates used by `ptxdist newpackage` should be
changed too, so freshly created packages get modelines in the same
style.

Greets
Alex

-- 
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

-- 
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH] Add modeline for vim to *.in files

2011-06-23 Thread Bernhard Walle
* Alexander Dahl p...@lespocky.de [2011-06-23 18:10]:
 Hei hei, 
 
 On Thu, 23 Jun 2011 17:48:02 +0200, Bernhard Walle wrote:
  Set the file type to kconfig. The *.make files have a modeline for vim,
  so why not also for the Kconfig files.
 
 % grep vim: rules/*.in
 rules/argtable2.in:# vim: syntax=kconfig
 rules/calibrator.in:# vim: syntax=kconfig
 rules/hackbench.in:# vim: syntax=kconfig
 
 I would recommend altering these instead of adding an addtional line.
 ;-)

Granted.

 Despite of that: +1, very handy for vim users.
 
 If you're already on this topic: Would you mind adapting the modeline
 for the rules/*.make files to something like this?
 
 # vim: ft=make noet

Well, IMO setting the filetype is better than just the syntax, because
then you can add

autocmd FileType kconfig set ts=8 sw=8 noet
autocmd FileType makeset ts=8 sw=8 noet

to your .vimrc.

 But I guess the templates used by `ptxdist newpackage` should be
 changed too, so freshly created packages get modelines in the same
 style.

My patch touched also the templates.


Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH] Add modeline for vim to *.in files

2011-06-23 Thread Alexander Dahl
Hello,

On 23.06.2011 18:37, Bernhard Walle wrote:
 Well, IMO setting the filetype is better than just the syntax, because
 then you can add
 
 autocmd FileType kconfig set ts=8 sw=8 noet
 autocmd FileType makeset ts=8 sw=8 noet
 
 to your .vimrc.

I would also recommend setting the file type. However the noet option
would be helpful in the mode line itself because Makefiles don't work
without tabs. Should one let this option of the user or override in the
mode line because it's the only sense making setting? What do you think?

Greets
Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH] Add modeline for vim to *.in files

2011-06-23 Thread Bernhard Walle
* Alexander Dahl p...@lespocky.de [2011-06-23 19:42]:
 Hello,
 
 On 23.06.2011 18:37, Bernhard Walle wrote:
  Well, IMO setting the filetype is better than just the syntax, because
  then you can add
  
  autocmd FileType kconfig set ts=8 sw=8 noet
  autocmd FileType makeset ts=8 sw=8 noet
  
  to your .vimrc.
 
 I would also recommend setting the file type. However the noet option
 would be helpful in the mode line itself because Makefiles don't work
 without tabs. Should one let this option of the user or override in the
 mode line because it's the only sense making setting? What do you think?

For Makefiles you're right, for Kconfig it's a matter of taste. But I
would use 'noexpandtab' because it's also readable for non vim-gurus
(although I myself use 'noet').

But let one of the ptxdist maintainers comment on the issue...


Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de