Re: [widgets] about test d1.wgt

2009-11-27 Thread Marcos Caceres

Hi Cyril,

Cyril Concolato wrote:

Hi Marcos,

Marcos Caceres a écrit :

Hi Cyril,

On Fri, Nov 20, 2009 at 5:50 PM, Cyril Concolato
 wrote:

Hi,

The test d1.wgt is about the src attribute of the icon element. It
says that
it tests the following assertion:
"If the src attribute of this icon element is absent, then the user
agent
must ignore this element."
but the config.xml contains an src attribute with an empty value.
This seems
a bit different to me. Maybe you should modify the spec as follows:

"If the src attribute of this icon element is absent *or empty*, then
the
user agent must ignore this element."


Ok, your are totally right (sorry, I didn't get it the first time!). A 
clarification was needed there and I've added it ("or an empty string" 
was needed in the spec).


I've made two tests:

test-suite/test-cases/ta-iipTwNshRg/000/d1.wgt (absent)
test-suite/test-cases/ta-iipTwNshRg/001/ga.wgt (empty)

{Robin: you might want to retest, but I'm sure Widgeon passes}.



Well, you get the same result when you actually search for the file
"", as it won't be found. But I agree, a simple clarification there
won't actually hurt or change the ways UAs work at the moment.


Also you should make sure the tests are aligned between the icon
element and
the content element. There does not seem to be such test with the
content
element. If you make such test, you should also align the spec in the
same
manner.


I'm not sure I understand, can you design the test to show what you
mean. I can then add it to the test suite.

I meant that there is test like:
http://www.w3.org/ns/widgets";>



but no test like:
http://www.w3.org/ns/widgets";>





I've added a test for this too:

test-suite/test-cases/ta-LTUJGJFCOU/002/gb.wgt (empty src)



Re: [widgets] about test d1.wgt

2009-11-26 Thread Cyril Concolato

Hi Marcos,

Marcos Caceres a écrit :

Hi Cyril,

On Fri, Nov 20, 2009 at 5:50 PM, Cyril Concolato
 wrote:

Hi,

The test d1.wgt is about the src attribute of the icon element. It says that
it tests the following assertion:
"If the src attribute of this icon element is absent, then the user agent
must ignore this element."
but the config.xml contains an src attribute with an empty value. This seems
a bit different to me. Maybe you should modify the spec as follows:

"If the src attribute of this icon element is absent *or empty*, then the
user agent must ignore this element."



Well, you get the same result when you actually search for the file
"", as it won't be found. But I agree, a simple clarification there
won't actually hurt or change the ways UAs work at the moment.


Also you should make sure the tests are aligned between the icon element and
the content element. There does not seem to be such test with the content
element. If you make such test, you should also align the spec in the same
manner.


I'm not sure I understand, can you design the test to show what you
mean. I can then add it to the test suite.

I meant that there is test like:
http://www.w3.org/ns/widgets";>
 


but no test like:
http://www.w3.org/ns/widgets";>
 


Regards,

Cyril

--
Cyril Concolato
Maître de Conférences/Associate Professor
Groupe Mutimedia/Multimedia Group
Département Traitement du Signal et Images
/Dept. Signal and Image Processing
Ecole Nationale Supérieure des Télécommunications
46 rue Barrault
75 013 Paris, France
http://tsi.enst.fr/~concolat 



Re: [widgets] about test d1.wgt

2009-11-20 Thread Marcos Caceres
Hi Cyril,

On Fri, Nov 20, 2009 at 5:50 PM, Cyril Concolato
 wrote:
> Hi,
>
> The test d1.wgt is about the src attribute of the icon element. It says that
> it tests the following assertion:
> "If the src attribute of this icon element is absent, then the user agent
> must ignore this element."
> but the config.xml contains an src attribute with an empty value. This seems
> a bit different to me. Maybe you should modify the spec as follows:
>
> "If the src attribute of this icon element is absent *or empty*, then the
> user agent must ignore this element."
>

Well, you get the same result when you actually search for the file
"", as it won't be found. But I agree, a simple clarification there
won't actually hurt or change the ways UAs work at the moment.

> Also you should make sure the tests are aligned between the icon element and
> the content element. There does not seem to be such test with the content
> element. If you make such test, you should also align the spec in the same
> manner.

I'm not sure I understand, can you design the test to show what you
mean. I can then add it to the test suite.

Kind regards,
Marcos

-- 
Marcos Caceres
http://datadriven.com.au