Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Kurt Wall updated an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: Kurt Wall QA Highest Test Level: Unit Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Kurt Wall updated an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: Kurt Wall QA Risk Assessment: Low Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Kurt Wall updated an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: Kurt Wall QA Risk Severity: Low Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Kurt Wall updated an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: Kurt Wall Comment: So,post-fix,ifIdropanexternalPowershell-basedfactontoa*nixsystem,facter(cfacter)willattempttoexecuteitifthefileis+xbutwillnotproduceawarningaboutanunparsedfile.Otherwise,ifthefileisnotexecutable,facterwilljustignoreaPowershell(.ps1)file. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Kurt Wall updated an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: Kurt Wall QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Kurt Wall updated an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: Kurt Wall QA Risk Probability: Medium Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Kurt Wall commented on FACT-752 Re: External powershell Facts are executed on unix hosts So, post-fix, if I drop an external Powershell-based fact onto a *nix system, facter (cfacter) will attempt to execute it if the file is +x but will not produce a warning about an unparsed file. Otherwise, if the file is not executable, facter will just ignore a Powershell (.ps1) file. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Kylo Ginsberg updated an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: Kylo Ginsberg Fix Version/s: FACT3.0.0 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Kylo Ginsberg assigned an issue to Unassigned Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: Kylo Ginsberg Assignee: EricSorenson Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Kylo Ginsberg commented on FACT-752 Re: External powershell Facts are executed on unix hosts Note that this will be fixed in Facter 3 per this HipChat convo: [11:02 AM] Ethan J. Brown: FACT-752 [11:02 AM] Kerminator Frogbot: [FACT-752] External powershell Facts are executed on unix hosts. Eric Sorenson / Ready for Engineering, no fix version https://tickets.puppetlabs.com/browse/FACT-752 [11:05 AM] Michael Smith: Is that still an issue? [11:06 AM] Josh Cooper: in ruby facter yes, not sure about native facter [11:11 AM] Peter Huene: native facter doesn't build-in support for powershell external facts on non-windows platforms currently [11:13 AM] Peter Huene: it will attempt to execute +x files though but said warning should not be present in native facter
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Greg Kitson commented on FACT-752 Re: External powershell Facts are executed on unix hosts As a workaround, adding `#!/bin/false` as the first line of the powershell external fact script will prevent it from being executed on Linux hosts. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Travis Fields commented on FACT-752 Re: External powershell Facts are executed on unix hosts What if the user has PASH installed? Do we want to hard code these not executing? Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Rob Reynolds commented on FACT-752 Re: External powershell Facts are executed on unix hosts Have you played with pash? It's likely stuff will break in unreasonable ways. We don't want to deal with supporting that scenario. Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Josh Cooper updated an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: Josh Cooper Sprint: PlatformClient2014-12-10 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Josh Cooper updated an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: Josh Cooper Sprint: PlatformClient2014-12-10 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title William Hopper commented on FACT-752 Re: External powershell Facts are executed on unix hosts For planning, I wasn't sure if this was something we wanted to tackle this sprint, but I'd be glad to work on it if it is. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title William Hopper updated an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: William Hopper Sprint: PlatformClient2014-11-26 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Rob Reynolds commented on FACT-752 Re: External powershell Facts are executed on unix hosts Interesting... so facter 2.3.1? Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Kylo Ginsberg updated an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: Kylo Ginsberg Sprint: PlatformClient2014-11-26 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title
William Hopper commented on FACT-752
Re: External powershell Facts are executed on unix hosts
Some context from a bit of debugging:
It looks like we're not actually trying to execute the file in the case of non-executable scripts, rather Facter is just generically warning that it failed to find a parser for the file.
Before loading an external fact, the external fact parser utility does a check to see what sort of fact we might have based on filename, and the only way it can know if a file is a script is if it's executable.
If it is not executable and is not something like a .txt file or .json file, the parser defaults to creating a NothingParser, which just returns nil, the same as what happens when there's an error parsing something like a JSON file.
This presents sort of a messy problem where we don't know why Facter failed to get a result from the file it found in its external fact directory. Either it actually failed to parse the file, or the file was non-executable and didn't fall into any of the non-script parsers like JSON or txt. It could also mean that the file was a directory. In any of these cases, Facter outputs the same warning as seen above:
61 data = "">
...
64 elsif data == {} or data == nil
65 Facter.warn Fact file #{file} was parsed but returned an
empty data set
data will be nil in one of several cases:
A failed JSON.load
The file is a directory
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Chris Barker created an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Issue Type: Bug Affects Versions: FACT 2.2.0 Assignee: Eric Sorenson Created: 2014/11/05 4:22 PM Environment: PE 3.7 build of Facter Priority: Normal Reporter: Chris Barker My external powershell fact is attempted to be run on my Linux host, when it shouldn't be because it is not marked as +x: [root@master ~]# ls -l /var/opt/lib/pe-puppet/facts.d/ total 8 rw-r r - 1 root root 266 Nov 5 23:27 mcafee.ps1 rw-r r - 1 root root 70 Nov 6 00:19 test.ps1 Debug output: Info: Loading facts Debug: Loading facts from /var/opt/lib/pe-puppet/lib/facter/staging_http_get.rb Debug: Loading facts from /var/opt/lib/pe-puppet/lib/facter/root_home.rb
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Ethan Brown commented on FACT-752 Re: External powershell Facts are executed on unix hosts I presumed that this was as result of +x on the files, and the Powershel ps1 exclusions not in the list here: https://github.com/puppetlabs/facter/blob/9a1fb56b6c868286ad0f37400f3dcd189daee72f/lib/facter/util/parser.rb#L134 But it would appear that's not correct based on what you've stated. Any fix here should address the ps1 extension in addition to the reported issue. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-752) External powershell Facts are executed on unix hosts
Title: Message Title Ethan Brown updated an issue Facter / FACT-752 External powershell Facts are executed on unix hosts Change By: Ethan Brown Labels: windows Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
