Jira (PUP-1908) incorrect parsing of range after DST change
Title: Message Title Josh Cooper commented on PUP-1908 Re: incorrect parsing of range after DST change This would be good to fix, but we don't have any plans on fixing it in the near future. Please reopen if this is still needed. Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.28309.1394462294000.52943.1623277500203%40Atlassian.JIRA.
Jira (PUP-1908) incorrect parsing of range after DST change
Title: Message Title Jacob Helwig updated an issue Puppet / PUP-1908 incorrect parsing of range after DST change Change By: Jacob Helwig Sub-team: Coremunity Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1908) incorrect parsing of range after DST change
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-1908 incorrect parsing of range after DST change Change By: Moses Mendoza Labels: help_wanted redmine triaged type_schedule Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1908) incorrect parsing of range after DST change
Title: Message Title Josh Cooper updated an issue Puppet / PUP-1908 incorrect parsing of range after DST change Change By: Josh Cooper Fix Version/s: PUP Future Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1908) incorrect parsing of range after DST change
Title: Message Title Maggie Dreyer updated an issue Puppet / PUP-1908 incorrect parsing of range after DST change Change By: Maggie Dreyer Labels: help_wanted redmine triaged type_schedule Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1908) incorrect parsing of range after DST change
Title: Message Title Josh Cooper updated an issue Puppet / PUP-1908 incorrect parsing of range after DST change Change By: Josh Cooper Fix Version/s: future Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1908) incorrect parsing of range after DST change
Title: Message Title Charlie Sharpsteen updated an issue Puppet / PUP-1908 incorrect parsing of range after DST change Change By: Charlie Sharpsteen Component/s: Types and Providers Labels: redmine schedules Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1908) incorrect parsing of range after DST change
Title: Message Title Charlie Sharpsteen updated an issue Puppet / PUP-1908 incorrect parsing of range after DST change Change By: Charlie Sharpsteen Labels: redmine schedules type_schedule Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1908) incorrect parsing of range after DST change
Title: Message Title
Charlie Sharpsteen updated an issue
Puppet / PUP-1908
incorrect parsing of range after DST change
Change By:
Charlie Sharpsteen
After the Daylight Savings Time change this morning, range statements are not being parsed correctly.The code: {code} schedule { 'daily2am':range => "02:00 - 02:59",period => daily,repeat => 1,} {code} Worked just fine for the last few months. After the DST change, this error is generated: {noformat} err: Could not apply complete catalog: Incorrectly converted time: Sun Mar 09 03:00:23 -0700 2008: 3 vs 2 at /etc/puppet/manifests/schedules/daily2am.pp:6 {noformat} This happens with versions 0.23.2 and 0.24.2
Add Comment
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1908) incorrect parsing of range after DST change
Title: Message Title
Charlie Sharpsteen commented on an issue
Re: incorrect parsing of range after DST change
I'm pretty sure the issue stems from this bit of code that compares the declared schedule against the current time:
time = Time.local(*ary)
unless time.hour == range[0]
self.devfail(
"Incorrectly converted time: #{time}: #{time.hour} vs #{range[0]}"
)
end
The problem is, for daylight savings systems that jump forward in the spring at 2 AM: the entire hour between 2:00 AM and 2:59 AM does not exist. So, a local time schedule that includes 2 AM is not valid every day of the year. This would match the error message being thrown:
err: Could not apply complete catalog: Incorrectly converted time: Sun Mar 09 03:00:23 -0700 2008: 3 vs 2 at /etc/puppet/manifests/schedules/daily2am.pp:6
From the schedule definition, Puppet was expecting 2 AM, but the call to Time.local returned 3 AM.
Some possible workarounds or fixes:
Re-write the schedule type to perform calculations in UTC instead of whatever localtime the server is set to.
Configure your servers to use UTC as the local time zone.
Only use schedules that contain temporal endpoints that exist for every day in your chosen timezone.
I'm not sure how much work it would take to migrate schedules to a UTC representation. If someone wants to look into it, we would be happy to review a pull request!
Add Comment
Jira (PUP-1908) incorrect parsing of range after DST change
Title: Message Title
redmine.exporter created an issue
Puppet / PUP-1908
incorrect parsing of range after DST change
Issue Type:
Bug
Assignee:
Unassigned
Created:
10/Mar/14 7:38 AM
Labels:
redmine
Priority:
Normal
Reporter:
redmine.exporter
After the Daylight Savings Time change this morning, range statements are not being parsed correctly.
The code: schedule { 'daily2am': range => "02:00 - 02:59", period => daily, repeat => 1, }
Worked just fine for the last few months. After the DST change, this error is generated:
err: Could not apply complete catalog: Incorrectly converted time: Sun Mar 09 03:00:23 -0700 2008: 3 vs 2 at /etc/puppet/manifests/schedules/daily2am.pp:6
This happens with versions 0.23.2 and 0.24.2
Add Comment
Jira (PUP-1908) incorrect parsing of range after DST change
Title: Message Title Ken Geis updated an issue Puppet / PUP-1908 incorrect parsing of range after DST change Change By: Ken Geis Affects Version/s: 3.4.3 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
