Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Rob Reynolds commented on an issue Re: `puppet module build` should use `metadata.json` as input format Created PUP-2484 to address the regression here prior to final release. Moving this to resolved. Add Comment Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format `puppet module build` This action is most impacted by this change though we will maintain compatibility with users still using Modulefile as their input format. Here's how that will work when a user initiates build. - If the user provides a Modulefile at the root of their module, PMT will use it exclusively to build the release and issue a deprecati... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Change By: Rob Reynolds Sprint: Week2014-4-30to2014-5-7 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Hunter Haugen assigned an issue to Hunter Haugen Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Change By: Hunter Haugen Assignee: HunterHaugen Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Hunter Haugen commented on an issue Re: `puppet module build` should use `metadata.json` as input format When using ea39a3de5705020d79ae89d6ab513b37fa662ce7 With Modulefile and metadata.json: Maybe success? It appears to work as specified, preferring the contents of the metadata.json and ignoring the Modulefile, but this is backwards incompatible as it previously would merge the two (eg, if there are dependencies declared in Modulefile but not in metadata.json, then the package will have no dependencies whereas before it WOULD have dependencies). This seems to be intended though. With Modulefile but no metadata.json: Success. It works as described. With no Modulefile but with metadata.json: Success. This was not previously supported so is not backwards-incompatible, and works as described. When using current master (90aad3fff7d270ef2683f486cdf999c003510cf0): With Modulefile and metadata.json: Same as above. With Modulefile but no metadata.json: Fail? The dependency list that appears in the repo Modulefile specifies two dependencies, but the package metadata.json appears like this: dependencies: [ #Puppet::ModuleTool::Dependency:0x007fc7c4218f48, #Puppet::ModuleTool::Dependency:0x007fc7c4218ac0 ] Perhaps this is on purpose, if master branch no longer supports Modulefile With no Modulefile but with metadata.json: Same as above. Other notes: I am seeing /Users/hunner/Documents/work/git/puppet/lib/puppet/version.rb:10: warning: already initialized constant PUPPETVERSION, but I see this on 3.5.1 as well. Add Comment
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Hunter Haugen updated an issue Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Change By: Hunter Haugen Assignee: HunterHaugen PietervandeBruggen Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Rob Reynolds commented on an issue Re: `puppet module build` should use `metadata.json` as input format Eric Sorenson - This appears to have failed review. Further this would break quite a few modules out there on the forge given that it ignores the old modulefile if there are both a modulefile and a metadata.json (some folks put different information in both). Add Comment Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format `puppet module build` This action is most impacted by this change though we will maintain compatibility with users still using Modulefile as their input format. Here's how that will work when a user initiates build. - If the user provides a Modulefile at the root of their module, PMT will use it exclusively to build the release and issue a deprecati... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Hunter Haugen commented on an issue Re: `puppet module build` should use `metadata.json` as input format I failed the review because based on the backwards-incompatible nature of this change, it will currently break the packaging of all of our modules. Example:: We only declare dependencies in the Modulefile but not metadata.json. We also don't synchronize the versions in Modulefile and metadata.json because pmt prefers the Modulefile version over metadata.json invisibly. Suggestion: The pmt should merge Modulefile and metadata.json entries, preferring the entries in Modulefile for conflicts. It should warn that support for Modulefile is deprecated and it will only use metadata.json in the future. It would also be helpful if it warned about every entry that exists in Modulefile but is different or non-existent in the metadata.json Add Comment Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format `puppet module build` This action is most impacted by this change though we will maintain compatibility with users still using Modulefile as their input format. Here's how that will work when a user initiates build. - If the user provides a Modulefile at the root of their module, PMT will use it exclusively to build the release and issue a deprecati... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Joshua Cooper commented on an issue Re: `puppet module build` should use `metadata.json` as input format Pieter van de Bruggen can you provide steps to verify this change, or get someone from the module team to review? Add Comment Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format `puppet module build` This action is most impacted by this change though we will maintain compatibility with users still using Modulefile as their input format. Here's how that will work when a user initiates build. - If the user provides a Modulefile at the root of their module, PMT will use it exclusively to build the release and issue a deprecati... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Pieter van de Bruggen commented on an issue Re: `puppet module build` should use `metadata.json` as input format puppet module build with an old (Modulefile-backed) module: you should be warned that Modulefile is deprecated, and a metadata.json file (with the same metadata) should be added to the module directory. That metadata.json file should be bundled in the tarball. puppet module build with a module containing both a Modulefile and a metadata.json: you should be warned the Modulefile is deprecated, that the tool is using the metadata.json file instead, the metadata.json file is not updated with data from the Modulefile, and that metadata.json file should be bundled in the tarball. puppet module build with only a metadata.json file: it should run without warning, and the metadata.json file should be bundled in the tarball. Add Comment Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format `puppet module build` This action is most impacted by this change though we will maintain compatibility with users still using Modulefile as their input format. Here's how that will work when a user initiates build. - If the user provides a Modulefile at the root of their module, PMT will use it exclusively to build the release and issue a deprecati... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Pieter van de Bruggen commented on an issue Re: `puppet module build` should use `metadata.json` as input format This was merged in ea39a3de5705020d79ae89d6ab513b37fa662ce7. Add Comment Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format `puppet module build` This action is most impacted by this change though we will maintain compatibility with users still using Modulefile as their input format. Here's how that will work when a user initiates build. - If the user provides a Modulefile at the root of their module, PMT will use it exclusively to build the release and issue a deprecati... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Change By: Kenn Hussey Fix Version/s: 3.7.0 Fix Version/s: 3.6.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Change By: Kenn Hussey Assignee: PietervandeBruggen Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Pieter van de Bruggen created an issue Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Issue Type: Improvement Affects Versions: 3.6.0 Assignee: Pieter van de Bruggen Created: 18/Mar/14 10:37 AM Priority: Normal Reporter: Pieter van de Bruggen `puppet module build` This action is most impacted by this change though we will maintain compatibility with users still using Modulefile as their input format. Here's how that will work when a user initiates build. If the user provides a Modulefile at the root of their module, PMT will use it exclusively to build the release and issue a deprecation warning. Let's call this the legacy build process. If the user provides a metadata.json file at the root of their module, PMT will use it exclusively to build the release. Let's call this the v3 build process. If the user providers both a Modulefile and metadata.json, PMT will use the v3 build process, ignoring the Modulefile but issuing a warning against including both files in the module root. The legacy build process will issue a deprecation warning but will otherwise behave as it does today.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Michelle Johansen updated an issue Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Change By: Michelle Johansen Assignee: PietervandeBruggen Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Michelle Johansen updated an issue Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Change By: Michelle Johansen Fix Version/s: 3.6.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Michelle Johansen updated an issue Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Change By: Michelle Johansen Affects Version/s: 3.6.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Pieter van de Bruggen commented on an issue Re: `puppet module build` should use `metadata.json` as input format Code can be found in https://github.com/puppetlabs/puppet/pull/2436. Add Comment Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format `puppet module build` This action is most impacted by this change though we will maintain compatibility with users still using Modulefile as their input format. Here's how that will work when a user initiates build. - If the user provides a Modulefile at the root of their module, PMT will use it exclusively to build the release and issue a deprecati... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Michelle Johansen updated an issue Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Change By: Michelle Johansen Component/s: PE Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Michelle Johansen updated an issue Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Change By: Michelle Johansen Fix Version/s: 3.6.0 Fix Version/s: 3.5.1 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Michelle Johansen updated an issue Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Change By: Michelle Johansen Fix Version/s: 3.5.1 Fix Version/s: 3.6.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1976) `puppet module build` should use `metadata.json` as input format
Title: Message Title Michelle Johansen updated an issue Puppet / PUP-1976 `puppet module build` should use `metadata.json` as input format Change By: Michelle Johansen Story Points: 1 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
