Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Josh Cooper updated an issue Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Josh Cooper Release Notes Summary: The puppet agent uses a lock file to ensure that only one instance is running at a time. However, the agent was susceptible to a race condition that could cause two agents to try to acquire the lock at the same time, and have one of them fail with a generic "Could not run" error. Now the agent will atomically try to acquire the lock, and if that fails, log a meaningful error. Original Estimate: 0 minutes Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options,
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Shaigy Nixon assigned an issue to Shaigy Nixon Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Shaigy Nixon Assignee: qa ShaigyNixon Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Shaigy Nixon commented on PUP-2573 Re: Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not This is mostly an internal change and is adequately covered by the unit test. Manually validated whether running two agents simultaneously causes one to error out. Validated on puppet-agent SHA:9b28aee3e99572f4d98973d683592dc11239f8d6 On redhat-7-x86_64, output from two simultaneous runs: [root@h8vih00e5qmj3h3 ~]# puppet agent --test --server h8vih00e5qmj3h3.delivery.puppetlabs.net Info: Retrieving pluginfacts Info: Retrieving plugin Info: Caching catalog for h8vih00e5qmj3h3.delivery.puppetlabs.net Info: Applying configuration version '1436387833' Notice: Applied catalog in 0.01 seconds [root@h8vih00e5qmj3h3 ~]# puppet agent --test --server h8vih00e5qmj3h3.delivery.puppetlabs.net Notice: Run of Puppet configuration client already in progress; skipping (/opt/puppetlabs/puppet/cache/state/agent_catalog_run.lock exists)
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Shaigy Nixon updated an issue Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Shaigy Nixon QA Risk Severity: Medium QA Risk Probability: Low QA Risk Assessment: Low QA Risk Assessment Reason: Internalfix,adequatelycoveredinunittest QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Josh Cooper updated an issue Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Josh Cooper Component/s: Community Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Josh Cooper assigned an issue to qa Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Josh Cooper Status: Readyfor CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Josh Cooper updated an issue Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Josh Cooper Scrum Team: ClientPlatform Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Peter Huene updated an issue Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Peter Huene Fix Version/s: PUPfuture Fix Version/s: PUP4.3.0 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Peter Huene updated an issue Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Peter Huene Sprint: Client2015-07-22 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Peter Huene updated an issue Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Peter Huene Affects Version/s: PUP4.2.0 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Peter Huene updated an issue Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Peter Huene Affects Version/s: PUP4.2.0 Affects Version/s: PUP4.x Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Erik Daln commented on PUP-2573 Re: Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Sent a PR for this: https://github.com/puppetlabs/puppet/pull/3934 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Kylo Ginsberg Fix Version/s: 3.7.0 Fix Version/s: 4.0.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title
Adrien Thebo commented on an issue
Re: Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
We don't plan on working on this in the immediate future so we're untargeting this from 3.7.0. If there's a pull request filed we can retarget this at 3.7.0 or 4.0.0 depending on when the PR is filed.
Add Comment
Puppet / PUP-2573
Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
The [Puppet::Agent::Locker#lock|https://github.com/puppetlabs/puppet/blob/3.5.1/lib/puppet/agent/locker.rb] method documentation says {quote}Return true/false depending on whether we get the lock.{quote} But that's not actually what happens. Instead it returns whatever the yielded block returns. As a result, there's no way to know if the lock was successf...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Kylo Ginsberg Fix Version/s: 4.0.0 Fix Version/s: future Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Joshua Cooper created an issue Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Issue Type: Bug Assignee: Kylo Ginsberg Components: Types and Providers Created: 14/May/14 1:03 PM Fix Versions: 3.7.0 Priority: Normal Reporter: Joshua Cooper The Puppet::Agent::Locker#lock method documentation says Return true/false depending on whether we get the lock. But that's not actually what happens. Instead it returns whatever the yielded block returns. As a result, there's no way to know if the lock was successfully acquired: def lock if lockfile.lock begin yield ensure lockfile.unlock end end end
Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not
Title: Message Title Joshua Cooper updated an issue Puppet / PUP-2573 Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not Change By: Joshua Cooper Reporter: JoshuaCooper ErikDaln Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
