Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Kurt Wall updated an issue Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Release tickets do not need to be testrailed. Change By: Kurt Wall QA Contact: KurtWall QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Rob Reynolds assigned an issue to Rob Reynolds Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Change By: Rob Reynolds Assignee: RobReynolds Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Rob Reynolds assigned an issue to Rob Reynolds Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Change By: Rob Reynolds Assignee: RobReynolds Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Change By: Josh Cooper Assignee: JoshCooper Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Josh Cooper commented on an issue Re: Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Merged in ea94dfa44b and 99680f25b Add Comment Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer As of the merge for PUP-2657, we've noticed some intermittent test failures (in both CI and locally) in semi-random locations. The merge commit is as follows: https://github.com/puppetlabs/puppet/commit/d38153bd712167e2777bdd4c63d37e2e8d1cdb39 The commit itself has been reviewed and it doesn't seem to have issues itself, but it's likely it's trigge... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Rob Reynolds commented on an issue Re: Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Ha, looks like I was pointed to an incorrect commit. Add Comment Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer As of the merge for PUP-2657, we've noticed some intermittent test failures (in both CI and locally) in semi-random locations. The merge commit is as follows: https://github.com/puppetlabs/puppet/commit/d38153bd712167e2777bdd4c63d37e2e8d1cdb39 The commit itself has been reviewed and it doesn't seem to have issues itself, but it's likely it's trigge... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Josh Cooper commented on an issue Re: Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer I had a few minor comments in the PR, but otherwise looked good. Add Comment Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer As of the merge for PUP-2657, we've noticed some intermittent test failures (in both CI and locally) in semi-random locations. The merge commit is as follows: https://github.com/puppetlabs/puppet/commit/d38153bd712167e2777bdd4c63d37e2e8d1cdb39 The commit itself has been reviewed and it doesn't seem to have issues itself, but it's likely it's trigge... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Rob Reynolds commented on an issue Re: Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Merged into master at b5267d1 Add Comment Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer As of the merge for PUP-2657, we've noticed some intermittent test failures (in both CI and locally) in semi-random locations. The merge commit is as follows: https://github.com/puppetlabs/puppet/commit/d38153bd712167e2777bdd4c63d37e2e8d1cdb39 The commit itself has been reviewed and it doesn't seem to have issues itself, but it's likely it's trigge... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Change By: Kylo Ginsberg Sprint: Week2014-6-4to2014-6-11,Week2014-6-11to2014-6-18 ,Week2014-6-18to2014-6-25 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Rob Reynolds commented on an issue Re: Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer I really restricted the memory on both a 32-bit box and a x64 box to try to get memory pressure issues to arise. So far it's just really slowed down the test time, but no memory failures yet. Will update once they are done Add Comment Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer As of the merge for PUP-2657, we've noticed some intermittent test failures (in both CI and locally) in semi-random locations. The merge commit is as follows: https://github.com/puppetlabs/puppet/commit/d38153bd712167e2777bdd4c63d37e2e8d1cdb39 The commit itself has been reviewed and it doesn't seem to have issues itself, but it's likely it's trigge... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Ethan Brown assigned an issue to Rob Reynolds Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Change By: Ethan Brown Assignee: RobReynolds Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Ethan Brown commented on an issue Re: Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer All PR comments addressed. Switched to block form across the board, and added cleanup to our FFI methods that return pointers that must be freed. In new methods accepting blocks, always assume one is given (i.e. don't bother complicating the code by using block_given? to force callers to use block and free memory) In cases where there are yields, and unmanaged memory is only available inside the yield, methods have been updated to return nil (needed especially in cases where the method would otherwise return the result of CloseHandle for instance). Found a number of subtle bugs around values returned from inside blocks. Tried to enforce proper memory usage semantics, and capturing values inside blocks using closures. In recent tests under memory pressue, I no longer get failures in IsValidAcl ... actually receive NoMemoryError, which I believe is an improvement. 23) Puppet::Type::Package Puppet::Type::Package Puppet::Type::Package when it should be absent should uninstall if it is latest Failure/Error: Unable to find matching line from backtrace NoMemoryError: failed to allocate memory # ./lib/puppet/defaults.rb:1611:in `block in module:Puppet' # ./lib/puppet/settings.rb:333:in `block in call_hooks_deferred_to_application_initialization' # ./lib/puppet/settings.rb:331:in `each' # ./lib/puppet/settings.rb:331:in `call_hooks_deferred_to_application_initialization' # ./lib/puppet/settings.rb:324:in `initialize_app_defaults' # ./lib/puppet/test/test_helper.rb:212:in `initialize_settings_before_each' # ./lib/puppet/test/test_helper.rb:121:in `before_each_test' Add Comment Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Ethan Brown assigned an issue to Ethan Brown Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Change By: Ethan Brown Assignee: EthanBrown Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Josh Cooper updated an issue Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Change By: Josh Cooper Assignee: JoshCooper EthanBrown Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Eric Sorenson updated an issue Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Change By: Eric Sorenson Sprint: Week2014-6-4to2014-6-11 ,Week2014-6-11to2014-6-18 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Ethan Brown commented on an issue Re: Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Let's merge what's here so far.. it's good to go. Then revisit once security is wrapped. In my local tests, the memory pressure issues seem to be less prevalent. It would be nice to push these changes through CI / acceptance to see what happens. Add Comment Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer As of the merge for PUP-2657, we've noticed some intermittent test failures (in both CI and locally) in semi-random locations. The merge commit is as follows: https://github.com/puppetlabs/puppet/commit/d38153bd712167e2777bdd4c63d37e2e8d1cdb39 The commit itself has been reviewed and it doesn't seem to have issues itself, but it's likely it's trigge... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Change By: Josh Cooper Assignee: JoshCooper Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Ethan Brown created an issue Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Issue Type: Task Assignee: Unassigned Created: 06/Jun/14 3:21 PM Priority: Major Reporter: Ethan Brown As of the merge for PUP-2657 , we've noticed some intermittent test failures (in both CI and locally) in semi-random locations. The merge commit is as follows: https://github.com/puppetlabs/puppet/commit/d38153bd712167e2777bdd4c63d37e2e8d1cdb39 The commit itself has been reviewed and it doesn't seem to have issues itself, but it's likely it's triggered FFI memory pressure that might have been building up to this point. Locally, failures include rspec ./spec/unit/util/storage_spec.rb:178 # Puppet::Util::Storage when storing to the state file should create the state file if it does not exist rspec ./spec/unit/util/storage_spec.rb:196 # Puppet::Util::Storage when storing to the state file should load() the same information that it store()s rspec ./spec/unit/util/yaml_spec.rb:16 # Puppet::Util::Yaml writes data formatted as YAML to disk rspec ./spec/unit/util_spec.rb:438 # Puppet::Util#replace_file should copy 0555 permissions from the target file by default rspec ./spec/unit/util_spec.rb:438 # Puppet::Util#replace_file should copy 0660 permissions from the target file by default rspec ./spec/unit/util_spec.rb:438 # Puppet::Util#replace_file should copy 0770 permissions from the target file by default rspec ./spec/unit/util_spec.rb:465 # Puppet::Util#replace_file should use the default permissions if the source file doesn't exist rspec ./spec/unit/util_spec.rb:503 # Puppet::Util#replace_file should support string
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Rob Reynolds commented on an issue Re: Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer I like the idea of block form... be more explicit. Add Comment Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer As of the merge for PUP-2657, we've noticed some intermittent test failures (in both CI and locally) in semi-random locations. The merge commit is as follows: https://github.com/puppetlabs/puppet/commit/d38153bd712167e2777bdd4c63d37e2e8d1cdb39 The commit itself has been reviewed and it doesn't seem to have issues itself, but it's likely it's trigge... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Ethan Brown updated an issue Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Change By: Ethan Brown Sprint: Week2014-6-4to2014-6-11 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2738) Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer
Title: Message Title Ethan Brown assigned an issue to Ethan Brown Puppet / PUP-2738 Investigate FFI Memory Pressure / Deterministically Release FFI MemoryPointer Change By: Ethan Brown Assignee: EthanBrown Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
