Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5743 Puppet 3.8.5 breaks compatibility with rspec-puppet Change By: Kylo Ginsberg Fix Version/s: PUP 3.8.6 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Kylo Ginsberg commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet I'd like to close this ticket since the description might still be relevant to someone in the future, although it was resolved with an rspec-puppet release. The ideas for followup are great though - maybe subject matter for another ticket? Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title David Schmitt commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet speaking with my rspec-puppet hat on, I'm fine with the solution as is. Ruby's default-shared model means that handing out datastructures to foreign code is dangerous, and we all got cut for it. rspec-puppet doesn't do this anymore. For safety within puppet's code against post-factum modification of the facts from outside (or even during a compile run, from a function) freezing the data sounds like a good idea, but I'd rather not put my foot deeper in my mouth there. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Henrik Lindberg commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet More info. The reason it broke rspec_puppet is because the information that is given to the node in a hash is used as is. Later when the node changes the value, this also affected information that rspec_puppet thought it owned. David Schmitt made a new PR where the keys are cloned before being used and this fixed the problem, as the first time, when the key is added, Puppet has not yet modified the values. This is a classic case of: "why shared mutual state is a bad idea". The reverse side of this bug is that it may be possible to modify the data the node thinks it owns by first giving it hashes and then changing them. This is probably done in set_node_parameters (and similar). The node should really make sure it owns the data. It should probably deep-freeze the hash as well as it hands it out when asked for. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Henrik Lindberg commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Our options: keep it the way it is, you have to give node parameters in a hash that you then do not change (puppet never does, it constructs the hash from facts etc. and then forgets it. Change the symbol back to String to ensure that when node possibly mutates a shared state that it at least mutates it to a type that was expected earlier. protect node and users of node and make node copy/freeze its input. (This is expensive though, possibly also a lot of work, and rspec_puppet is an atypical use case) Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Krzysztof Suszyński commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Yea. This should be reverted in Puppet first, I think. Provide a new API, rather then changing the current implementation. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title David Schmitt commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet PR is up at https://github.com/rodjek/rspec-puppet/pull/359 I plan to release that ASAP as 2.3.1 to mitigate the issue in the short term. I'm still running through a few validations with only this patch applied to make sure it doesn't break anything else. After firefighting we can start thinking about a proper solution, the code in the PR doesn't make me happy. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Krzysztof Suszyński commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Yup. I can imagine this error was not intentional by Puppetlabs team and that releasing puppet is kind a big deal. I think that we need a better tests compliance suites for Puppet. There were many errors before in depending test harness (rpsec-puppet, beaker). I think this deserves better test suites. And better API for test tools i think. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title David Schmitt commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet I just released rspec-puppet 2.3.1 with a preliminary fix to work around this. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title David Schmitt commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Krzysztof Suszyński do you have any other use-cases beside rspec-puppet who are hit by this issue? releasing a new version of puppet is quite expensive, and the hotfix in rspec-puppet basically locks puppet to this behaviour going forward, until we can haz a better API for this. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Krzysztof Suszyński commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet I wanted to confirm that by using the latest version of `rspec-puppet` problem does not occur for my code. I've just tested it with our code. Thanks David Schmitt Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title David Schmitt commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Yeah, it's a hairy part of the code. Thanks for validation, Krzysztof Suszyński. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Krzysztof Suszyński commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Couldn't you just add some logic to public environment setter? Public setter can accept values in string, and set it in other parts as it is required. Ideally mostly in the same form ex.: Symbol. In that way you will not change the public interface and in the meanwhile changing internal implementation to your needs or liking. Is something stopping you from doing that? It should be rather straight forward to do this, isn't? Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Henrik Lindberg commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Now... changing Puppet back to the way it was before; environment being of String type in a Node will be an interesting excersice as it would again change what needs to be done in rspec-puppet. Our options are: Change puppet back to using strings, and enforce that the attribute is a string. Change rspec-puppet in sync with the puppet release. Keep it as a symbol (it is symbol in parts of the code, and string in other parts), but enforce (and document) that it is a Node.environment (name) is a Symbol. I am leaning towards keeping it as a Symbol. What do you think? Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Henrik Lindberg commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Go look at what is there? The environment is set in phases, and there is lots of old code that makes assumptions about in which order things occur. When we changed the behavior we added such a synchronization of two of the ways a node gets the "environment", via the name of an environment, or the actual environment (an instance that knows stuff about the environment, among other things the name of the environment (a Symbol)). At the end it boils down to, what is the return type of the method that returns the name of the environment for the node. It cannot both return String and Symbol at the same time. That is the problem, not protecting a ruby instance variable with setter/getter (and in this case multiple values, that in different times of the Node's lifecycle is a name or a real environment). Now, parts of the code uses symbol, others use string. There are modules and tools and what not in the eco system around Puppet. So, one type, what should it be? What it was earlier (String), what it became (Symbol)? Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title David Schmitt commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet bisecting rspec-puppet against puppet 3.8.5 points at https://github.com/rodjek/rspec-puppet/commit/c3c0e60de07884448de9cfb86a462dd77c562dfb "Prevent Puppet 3's _timestamp fact from invalidating cache" as the culprit on this side Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title David Schmitt commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet poking around in the code, it turns out that rspec-puppet puts the environment name into the facts_hash at https://github.com/rodjek/rspec-puppet/commit/c3c0e60de07884448de9cfb86a462dd77c562dfb#diff-135e8dde499655a68c6a3cba85ebcf3eR107 as a string. changing that to a symbol clears up the test errors. PR and more validation incoming. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Henrik Lindberg commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet David Schmitt That sounds like a workable solution. We were thinking that we would patch the cache to see if it got a Hash with an environment key being a symbol and changing it to a String. That is a much uglier hack. Also, the change to symbol is unintentional. Puppet is split-brain on use of Symbol vs. String for environment, in some parts, the environment is a symbol, in others a String. A good fix would be for rspec-puppet to not care one way or the other. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5743 Puppet 3.8.5 breaks compatibility with rspec-puppet Change By: Kylo Ginsberg Affects Version/s: PUP 4.3.2 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Kylo Ginsberg commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet I added Puppet 4.3.2 as an affected version. Note that 4.3.2 is not yet released, but it is tagged. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title
Gareth Rushgrove commented on PUP-5743
Re: Puppet 3.8.5 breaks compatibility with rspec-puppet
Posting the upstream bug so everything is in one place:
I hit an issue this morning with the Docker module in Travis where a single test (which had previously passed) failed, but only under the newly released Puppet 3.8.5 (released January 21st). This was also reported independently by another contributor garethr/garethr-docker#396.
Running the test on it's own see's it pass. Testing with previously passing code fails. Testing with rspec-puppet master and with 2.3 also fails. As suggested by @DavidS I tried 2.2 and this allowed the test to pass.
After much spelunking I was able to get a small test case which reliably recreates the failure.
require 'spec_helper'
describe 'docker::run', :type => :define do
let(:title) { 'sample' }
context 'passing the required params' do
let(:facts) { {:osfamily => 'Archlinux'} }
let(:params) { {'command' => 'command', 'image' => 'base'} }
initscript = '/etc/systemd/system/docker-sample.service'
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Kylo Ginsberg commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Popped this back open while re run down the rspec-puppet fix and what in puppet triggered this. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Krzysztof Suszyński created an issue Puppet / PUP-5743 Puppet 3.8.5 breaks compatibility with rspec-puppet Issue Type: Bug Affects Versions: PUP 3.8.5 Assignee: Unassigned Components: Breaking Change Created: 2016/01/22 5:06 AM Environment: Running rspec tests Fix Versions: PUP 3.8.6 Labels: regression Priority: Normal Reporter: Krzysztof Suszyński
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Henrik Lindberg commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Closing this as it is a rspec_puppet problem. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Daniele Sluijters commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Considering some PL employees have committer/release access to rspec-puppet, could someone at least fix it? Because the whole module testing ecosystem is broken now. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Gareth Rushgrove commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Just to connect all the things. I hit this this morning working on the docker module. Another test case at https://github.com/rodjek/rspec-puppet/issues/353 which demonstrates triggering the issue by making more than 16 identical tests. First 16 pass. All the rest fail My fix was to pin to rspec-puppet 2.2.0 which didn't exhibit this behaviour. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title
Krzysztof Suszyński updated an issue
Puppet / PUP-5743
Puppet 3.8.5 breaks compatibility with rspec-puppet
Change By:
Krzysztof Suszyński
After release of Puppet 3.8.5 some rspec tests fail. I was able to pinpoint the point where it breaks.It seams to be connected with using shared_examples and setting parameters for class. Like this:{code:ruby}shared_examples 'working class' do it { expect(subject).to compile } it { expect(subject).to contain_class 'repo::mvn_releases' }enddescribe 'repo::mvn_releases', :type => :class do let(:facts) do{ :path => '/bin:/sbin:/usr/bin:/usr/sbin' } end context 'with default arguments' doit_behaves_like 'working class' # this one works fine end context 'with ["pl.gov.coi .srp : admintool sample ::jar"] arguments' dolet(:params) do { :coordinates => ['pl.gov.coi:sample::jar'] }endit_behaves_like 'working class' # this one fails endend{code}The errors seams to be in line: https://github.com/rodjek/rspec-puppet/blob/master/lib/rspec-puppet/matchers/create_generic.rb#L82 `catalogue.call` returns nil in those case.Some output:{code}behaves like working class should compile into a catalogue without dependency cycles (FAILED - 10)place: /home/ksuszynski/.rvm/gems/ruby-2.1.6/gems/rspec-puppet-2.3.0/lib/rspec-puppet/matchers/create_generic.rb:83catalogue: #@catalogue.class: NilClass@referenced_type: "Class"@title: "repo::mvn_releases"{code}Switching back to Puppet 3.8.4 fixes this issue.
Add Comment
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Gareth Rushgrove commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet I've put up a PR that appears to resolve the problem: https://github.com/rodjek/rspec-puppet/pull/354/files I've not had chance to write a test or to widely test this but it resolves the issue for the Docker module test suite and has some level of understanding of the problem. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Henrik Lindberg commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet With a bit more detective work. The recently introduced cache in rspec_puppet does the wrong thing when it evicts entries from its cache. (It ends up removing the entries that should be kept as opposed to those that should be evicted. https://github.com/rodjek/rspec-puppet/blob/8a90608341077197323c6e35c042f7d1699a3cae/lib/rspec-puppet/cache.rb#L26 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title
David Schmitt commented on PUP-5743
Re: Puppet 3.8.5 breaks compatibility with rspec-puppet
This is also hitting all the module's pipelines on travisci. For example:
https://travis-ci.org/puppetlabs/puppetlabs-apache/jobs/104097526#L2070
1) apache on a Debian OS should not contain File[authn_file.conf]
Failure/Error: it { is_expected.not_to contain_file("#{modname}.conf") }
NoMethodError:
undefined method `resource' for nil:NilClass
# ./vendor/bundle/ruby/2.1.0/gems/rspec-puppet-2.3.0/lib/rspec-puppet/matchers/create_generic.rb:83:in `matches?'
# ./spec/classes/apache_spec.rb:82:in `block (4 levels) in '
Add Comment
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Henrik Lindberg commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet After a quick look at code. The error is because the Matcher ends up with a catalog that is nil. A stacktrace of where that catalog comes from is helpful, but may not be enough as it is needed to see where the catalog is set to nil. Unfortunately the rspec code is written to directly access @catalog instead of using methods which makes it harder to debug and find where it is set to nil. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Gareth Rushgrove commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Other observations: I think the note about shared_examples is a red-herring. I'm not using them anywhere in the docker test suite and still see the issues I've run the test using rspec 3.4.0 (latest release) and rspec 3.1.0 (last release to support Ruby 1.8.7). The behaviour (ie. failure only on rspec-pupet 2.3.0 and Puppet 3.8.5) occurs on both The same test suites pass on rspec-puppet 2.3.0 on the 4+ series and on 3.8.4 and below, it's just the combination of rspec-puppet 2.3.0 AND Puppet 3.8.5 that triggers the issue The number 16 seems key to finding the cause, see the max cache size: https://github.com/rodjek/rspec-puppet/blob/8a90608341077197323c6e35c042f7d1699a3cae/lib/rspec-puppet/cache.rb#L4. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Gareth Rushgrove commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Quick suggestion by Henrik Lindberg, changing the magic number in https://github.com/rodjek/rspec-puppet/blob/8a90608341077197323c6e35c042f7d1699a3cae/lib/rspec-puppet/cache.rb#L4 to 5 instead of 16 results in n-5 test failures rather than n-16. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5743) Puppet 3.8.5 breaks compatibility with rspec-puppet
Title: Message Title Kylo Ginsberg commented on PUP-5743 Re: Puppet 3.8.5 breaks compatibility with rspec-puppet Henrik Lindberg and I have tentatively concluded this should be fixed in puppet. There may be something we could do in rspec-puppet but I'm not sure yet (and it would probably be a hack). Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
