Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Maggie Dreyer commented on PUP-6800 Re: Better error messaging around invalid class names This seems related to PUP-6815, I think these are both referring to the same need for a docs update. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Maggie Dreyer updated an issue Puppet / PUP-6800 Better error messaging around invalid class names Change By: Maggie Dreyer Labels: triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Maggie Dreyer assigned an issue to Jorie Tappa Puppet / PUP-6800 Better error messaging around invalid class names Change By: Maggie Dreyer Assignee: Erik Hansen Jorie Tappa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Nick Walker commented on PUP-6800 Re: Better error messaging around invalid class names Henrik Lindberg Puppet does one lookup of a name against the file system using a downcase of the name. So any file with upper case letters will simply not work (unless the file system is case independent like on OSx). This is what I thought was happening but then I realized that using a class declaration instead of the include function could find an upper case file name. I think the behavior when using a class declaration is the expected behavior and I'm not sure why it'd differ from using include. If we can't make the different ways to include classes all work with uppercase then I'd say we should just through an error and actually abide by the regex that the docs currently says. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Henrik Lindberg commented on PUP-6800 Re: Better error messaging around invalid class names Erik Hansen The name requirement for classes in the documentation is stricter than in the specification and the implementation - so, yes - the documentation should be updated. Documentation should also state that all autoloaded files must be in lower case. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Henrik Lindberg commented on PUP-6800 Re: Better error messaging around invalid class names Puppet does one lookup of a name against the file system using a downcase of the name. So any file with upper case letters will simply not work (unless the file system is case independent like on OSx). The only search being made is that puppet starts with the most specific name, and then removes name/name-space from the right of the name until all wider name spaces have been loaded - thus subnames of say foo::bar::fee can be defined in foo/bar.pp if there is no foo/bar/fee.pp. What puppet cannot do is to warn/error on a missing file based on case as a far more exhaustive search would need to be made. Always use lower case file names. References to classes should be case independent. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Nick Walker updated an issue Puppet / PUP-6800 Better error messaging around invalid class names Change By: Nick Walker Affects Version/s: PUP 4.7.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Nick Walker commented on PUP-6800 Re: Better error messaging around invalid class names So, I think we have a bug around how the puppet master searches for the file on disk that holds a class. Allow me to demonstrate with some examples. I see three factors: 1. The name of the .pp file we put the class in 2. The name of the class 3. The name of the class when we try to include it Lower case, everything works [root@master201640-centos modules]# pwd /etc/puppetlabs/code/environments/production/modules [root@master201640-centos modules]# tree . └── role └── manifests └── appserver └── windows_2012r2.pp 3 directories, 1
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Erik Hansen commented on PUP-6800 Re: Better error messaging around invalid class names Henrik Lindberg The documentation says that class names must match the regex: \A[a-z][a-z0-9_]*\Z Or, for multiple namespaces: \A([a-z][a-z0-9_])?(::[a-z][a-z0-9_])*\Z Do we need to change this so that uppercase characters are included? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Henrik Lindberg commented on PUP-6800 Re: Better error messaging around invalid class names The example looks more like a bug since class references are supposedly case independent. The fact that it worked a second time seems to indicate that this has nothing to do with the class name per se. I can imagine though that first vs. second time could lead to a different path through the logic and that there may be something wrong on the path used the first time - say using create_resources vs. something else - conditional logic written differently etc. IIRC, there has also been bugs related to case independent references that are now fixed - so, puppet version used matters here. Can you supply a simple self contained reproducer? Note that 'role::appserver::windows_2012R2' does not break the naming convention - it is ok to have underscores, digits and upper case letters as long as those are not the first in a name segment. This means that the issue here is not about "better errors when naming convention is broken", but something else. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Erik Hansen commented on PUP-6800 Re: Better error messaging around invalid class names What I observed was that a Windows agent was unable to pick up a class role::appserver::windows_2012R2 until the second time that the agent ran the catalog. Here is an example of the info in puppetserver.log: 2016-09-16 14:47:58,964 ERROR [qtp1760965953-81] [puppetserver] Puppet Could not find class role::appserver::windows_2012R2 for puppetagent.example.comt on node puppetagent.example.com There wasn't really anything that identified the invalid class name, but when the class was renamed to role::appserver::windows_2012r2, I no longer saw the issue. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Henrik Lindberg commented on PUP-6800 Re: Better error messaging around invalid class names Erik Hansen Suspect you have been bitten by a specific case. There is really not much to go in in your description that make this actionable. Can you give examples? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Henrik Lindberg assigned an issue to Erik Hansen Puppet / PUP-6800 Better error messaging around invalid class names Change By: Henrik Lindberg Assignee: Erik Hansen Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title William Hopper updated an issue Puppet / PUP-6800 Better error messaging around invalid class names Change By: William Hopper Team: Puppet Developer Support Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6800) Better error messaging around invalid class names
Title: Message Title Erik Hansen created an issue Puppet / PUP-6800 Better error messaging around invalid class names Issue Type: Improvement Assignee: Unassigned Created: 2016/10/06 3:10 PM Priority: Normal Reporter: Erik Hansen The language guide is specific about what allowed class names are: https://docs.puppet.com/puppet/latest/reference/lang_reserved.html#classes-and-defined-resource-types However, if someone were unaware of the character limitation, it can cause issues that are difficult to track down, such as classes not loading or only being available to certain agents. It would be an improvement if puppet server or the console service (or both) would issue clear warnings about class names that do not follow the standard. Add Comment
