Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-07-11 Thread Kenn Hussey (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kenn Hussey commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 Jorie Tappa did this make it through CI yet?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-07-10 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 merged to puppet#5.5.x in https://github.com/puppetlabs/puppet/commit/23848f32d733c65418bad38f39d612a0968915c1  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-07-09 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 merged to puppet#master in https://github.com/puppetlabs/puppet/commit/ee7cf4d28077be7d1bdbbe934ea012d41d33deff  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-06-27 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 After digging into this more, it looks like we have to preserve the existing implementation and do a docs only deprecation. The problem is that the absolute_path? method serves multiple purposes and it's hard to tell which from within the method. Sometimes it's used on the agent (in a type/provider) to validate that a parameter/property is an absolute path. This is common in puppet, and it would be better for custom types/provider to just use ruby to do this, e.g. Pathname.new(path).absolute?. Functions also use the method to validate paths. For example, stdlib has a deprecated function is_absolute_path, which calls the 3x version of the is_absolute_path function, which calls puppet's absolute_path? method. Since the compiler doesn't know whether it's compiling for a windows or unix node, the function verifies that it's an absolute path for either windows or unix, but it doesn't know exactly which. This can lead to false positives as /foo is absolute on unix, but not windows. With the introduction of puppet data types, it's better to do match values against the specific path data type:  
 
 
 
 
 'C:\foo' =~ Stdlib::Windowspath  
 
 
 '/foo' =~ Stdlib::Unixpath
  
 
 
 
  See https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/types/unixpath.pp and https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/types/windowspath.pp. There is also https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/types/absolutepath.pp for the generic "is it unix or windows path" case.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 
 

Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-06-27 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7407  
 
 
  Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Component/s: 
 DOCS  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-06-25 Thread Jorie Tappa (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jorie Tappa updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7407  
 
 
  Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
Change By: 
 Jorie Tappa  
 
 
Release Notes Summary: 
 Puppet has long used its own version of verifying absolute paths across platforms, but now uses ruby's built-in methods to accomplish this. Use of `Puppet::Util.absolute_path?(path)` is now deprecated in favor of `Pathname.new(path.to_s).absolute?`  
 
 
Release Notes: 
 Bug Fix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-06-20 Thread Kenn Hussey (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kenn Hussey updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7407  
 
 
  Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
Change By: 
 Kenn Hussey  
 
 
Fix Version/s: 
 PUP 5.5.z  
 
 
Fix Version/s: 
 PUP 5.5.3  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-06-06 Thread Jorie Tappa (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jorie Tappa updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7407  
 
 
  Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
Change By: 
 Jorie Tappa  
 
 
Acceptance Criteria: 
 Using Puppet::Util.absolute_path? issues a deprecation warning , only when strict mode is enabled .  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-06-06 Thread Jorie Tappa (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jorie Tappa updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7407  
 
 
  Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
Change By: 
 Jorie Tappa  
 
 
Fix Version/s: 
 PUP 5.y  
 
 
Fix Version/s: 
 PUP 5.5.z  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-06-05 Thread Jorie Tappa (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jorie Tappa updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7407  
 
 
  Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
Change By: 
 Jorie Tappa  
 
 
Sprint: 
 Agent 2017-04-19, Platform Core  Hopper  KANBAN  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-06-04 Thread Jorie Tappa (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jorie Tappa assigned an issue to Jorie Tappa  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7407  
 
 
  Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
Change By: 
 Jorie Tappa  
 
 
Assignee: 
 Jorie Tappa  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-05-29 Thread Craig Gomes (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Craig Gomes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7407  
 
 
  Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
Change By: 
 Craig Gomes  
 
 
Team: 
 Platform Core Coremunity  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-05-18 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 Sounds good, plus add a `@deprecated` to the method in documentation.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-05-18 Thread Eric Sorenson (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Eric Sorenson commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 It looked like the best idea was to reimplement it behind the scenes so it's not using its own implementation but the public method signature doesn't change  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-05-18 Thread Kris Bosland (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kris Bosland commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 Eric Sorenson, should we deprecate this method, or just reimplement it behind the scenes?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-04-13 Thread Craig Gomes (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Craig Gomes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7407  
 
 
  Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
Change By: 
 Craig Gomes  
 
 
Sprint: 
 Agent 2017-04-19 , Platform Core Hopper  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-03-27 Thread Eric Sorenson (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Eric Sorenson commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 E - yes, only one version of each module which was latest as of the time i updated this corpus, maybe ~6 months ago  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-03-27 Thread Ethan Brown (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ethan Brown commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 Thanks for the search results - spot check shows the impact isn't too bad. Looks like you also filtered for "latest" versions of modules only?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-03-26 Thread Eric Sorenson (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Eric Sorenson commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 No, I specifically excluded the vendored puppet implementations, the paths show only types and providers inside of modules. But I totally agree - I'm less concerned with keeping the implementation intact than keeping the method signature intact, which is what it looked like this ticket was doing.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-03-26 Thread Ethan Brown (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ethan Brown commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 Eric Sorenson at the very least I think it would be useful to have the Puppet method shadow / defer to the internal Ruby method instead of implementing the code itself. I'm less concerned about the timeline around deprecation and more concerned with replacing the Puppet implementation with a correct one. Without any data to back it up, my gut says that external consumers are likely consuming the Puppet API correctly, and there probably isn't a ton of value in disrupting content authors. FWIW - given I've run similar searches before, I also suspect your search is still returning a number of modules that have chosen to vendor Puppet itself, which falsely inflates the real module count (even with the gem and vendor dirs ignored). The greater concern is the internal Puppet consumers are relying on accidental behavior, and I suspect there are a number of internal defects hiding or errantly passing for the wrong reasons.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-03-26 Thread Eric Sorenson (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Eric Sorenson commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 What does it hurt to leave this? I ask because unlike many of the deprecations in this epic, this one affects a large number of types and providers in the wild. A search through the forge corpus turned up:   
 
 
 
 
 ag --ignore spec --ignore stdlib --ignore vendor --ignore gem 'absolute_path\?' *  -l | wc -l  
 
 
 53
  
 
 
 
   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more 

Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-03-26 Thread Patrick Carlisle (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Patrick Carlisle commented on  PUP-7407  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
 Is this on the table for Puppet 6?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2018-03-15 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7407  
 
 
  Add deprecation warning to Puppet::Util.absolute_path?   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sub-team: 
 Coremunity  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-07-19 Thread Geoff Nichols (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Geoff Nichols updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Change By:
 
 Geoff Nichols 
 
 
 

Sprint:
 
 Agent  Grooming, Agent  2017-04-19 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-07-06 Thread Ethan Brown (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ethan Brown updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Change By:
 
 Ethan Brown 
 
 
 

Sprint:
 
 Agent  Grooming, Agent  2017-04-19 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-05-15 Thread Branan Riley (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Branan Riley updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Change By:
 
 Branan Riley 
 
 
 

Labels:
 
 triaged 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-05-15 Thread Branan Riley (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Branan Riley updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Change By:
 
 Branan Riley 
 
 
 

Story Points:
 
 1 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-05-15 Thread Branan Riley (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Branan Riley updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Change By:
 
 Branan Riley 
 
 
 

Fix Version/s:
 
 PUP 4.10.z 
 
 
 

Fix Version/s:
 
 PUP 5.y 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-04-19 Thread Geoff Nichols (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Geoff Nichols updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Change By:
 
 Geoff Nichols 
 
 
 

Sprint:
 
 Agent 2017-04-19 , Agent 2017-05-03 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-04-19 Thread Geoff Nichols (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Geoff Nichols updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Change By:
 
 Geoff Nichols 
 
 
 

Sprint:
 
 Agent 2017-04-19 , Agent 2017-05-03 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-04-05 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper commented on  PUP-7407 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 
 
Puppet::Util is mixed into providers (and other places), and changing module providers is hard, so I think we'll only want to emit deprecation warnings when strict mode is enabled. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-04-05 Thread Kurt Wall (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kurt Wall updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Change By:
 
 Kurt Wall 
 
 
 

QA Risk Assessment:
 
 Needs Assessment No Action 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-04-05 Thread Kurt Wall (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kurt Wall updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Change By:
 
 Kurt Wall 
 
 
 

QA Risk Assessment Reason:
 
 Deprecation not risk-assessed 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-04-05 Thread Geoff Nichols (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Geoff Nichols updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Change By:
 
 Geoff Nichols 
 
 
 

Sprint:
 
 Agent  Ready for Engineering  2017-04-19 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-03-29 Thread Geoff Nichols (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Geoff Nichols updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Change By:
 
 Geoff Nichols 
 
 
 

Sprint:
 
 Agent  Grooming  Ready for Engineering 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-03-29 Thread Geoff Nichols (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Geoff Nichols updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Change By:
 
 Geoff Nichols 
 
 
 

Story Points:
 
 1 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

2017-03-29 Thread Maggie Dreyer (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Maggie Dreyer created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7407 
 
 
 
  Add deprecation warning to Puppet::Util.absolute_path?  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Task 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2017/03/29 10:51 AM 
 
 
 

Fix Versions:
 

 PUP 4.10.z 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Maggie Dreyer 
 
 
 
 
 
 
 
 
 
 
We plan to remove Puppet::Util.absolute_path? in favor of Ruby's built-in Pathname.new().absolute_path? in Puppet 5. We need to deprecate it before that can be done. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment